Re: [PATCH] ide: Cap LBA28 capacity announcement to 2^28-1

2021-10-20 Thread Kevin Wolf
Am 06.10.2021 um 01:57 hat Samuel Thibault geschrieben: > Ping? > > Samuel Thibault, le mar. 24 août 2021 12:43:44 +0200, a ecrit: > > The LBA28 capacity (at offsets 60/61 of identification) is supposed to > > express the maximum size supported by LBA28 commands. If the device is > > larger than t

Re: [PATCH 04/15] pcie: Add callback preceding SR-IOV VFs update

2021-10-20 Thread Lukasz Maniak
On Fri, Oct 15, 2021 at 01:30:32PM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 15, 2021 at 06:24:14PM +0200, Lukasz Maniak wrote: > > On Wed, Oct 13, 2021 at 05:10:35AM -0400, Michael S. Tsirkin wrote: > > > On Tue, Oct 12, 2021 at 06:06:46PM +0200, Lukasz Maniak wrote: > > > > On Tue, Oct 12, 2

Re: [PATCH 10/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime

2021-10-20 Thread Klaus Jensen
On Oct 7 18:24, Lukasz Maniak wrote: > From: Łukasz Gieryk > > The Nvme device defines two properties: max_ioqpairs, msix_qsize. Having > them as constants is problematic for SR-IOV support. > > The SR-IOV feature introduces virtual resources (queues, interrupts) > that can be assigned to PF an

Re: [PATCH 05/15] hw/nvme: Add support for SR-IOV

2021-10-20 Thread Klaus Jensen
On Oct 7 18:23, Lukasz Maniak wrote: > This patch implements initial support for Single Root I/O Virtualization > on an NVMe device. > > Essentially, it allows to define the maximum number of virtual functions > supported by the NVMe controller via sriov_max_vfs parameter. > > Passing a non-zero

Re: [PATCH 10/15] hw/nvme: Make max_ioqpairs and msix_qsize configurable in runtime

2021-10-20 Thread Klaus Jensen
On Oct 7 18:24, Lukasz Maniak wrote: > +static void nvme_update_msixcap_ts(PCIDevice *pci_dev, uint32_t table_size) > +{ > +uint8_t *config; > + > +assert(pci_dev->msix_cap); Not all platforms support msix, so an assert() is not right. signature.asc Description: PGP signature