Re: [PATCH V2] block/rbd: implement bdrv_co_block_status

2021-08-23 Thread Peter Lieven
Am 22.08.21 um 23:02 schrieb Ilya Dryomov: On Tue, Aug 10, 2021 at 3:41 PM Peter Lieven wrote: the qemu rbd driver currently lacks support for bdrv_co_block_status. This results mainly in incorrect progress during block operations (e.g. qemu-img convert with an rbd image as source). This patch

Re: [PATCH v7 07/33] block/block-copy: introduce block_copy_set_copy_opts()

2021-08-23 Thread Vladimir Sementsov-Ogievskiy
10.08.2021 17:55, Hanna Reitz wrote: On 04.08.21 11:37, Vladimir Sementsov-Ogievskiy wrote: We'll need a possibility to set compress and use_copy_range options after initialization of the state. So make corresponding part of block_copy_state_new() separate and public. Signed-off-by: Vladimir Se

[PATCH] hw/nvme: fix validation of ASQ and ACQ

2021-08-23 Thread Klaus Jensen
From: Klaus Jensen Address 0x0 is a valid address. Fix the admin submission and completion queue address validation to not error out on this. Signed-off-by: Klaus Jensen --- hw/nvme/ctrl.c | 8 hw/nvme/trace-events | 2 -- 2 files changed, 10 deletions(-) diff --git a/hw/nvme/c

Re: [PATCH 3/3] qcow2: handle_dependencies(): relax conflict detection

2021-08-23 Thread Vladimir Sementsov-Ogievskiy
20.08.2021 16:21, Hanna Reitz wrote: On 24.07.21 15:38, Vladimir Sementsov-Ogievskiy wrote: There is no conflict and no dependency if we have parallel writes to different subclusters of one cluster when cluster itself is already allocated. So, relax extra dependency. Measure performance: First,

Re: [PATCH v6 1/6] qmp: add QMP command x-debug-query-virtio

2021-08-23 Thread Markus Armbruster
Back from my summer break, please excuse the delay. Jonah Palmer writes: > On 8/7/21 8:35 AM, Markus Armbruster wrote: >> QAPI schema review only. >> >> Jonah Palmer writes: >> >>> From: Laurent Vivier >>> >>> This new command lists all the instances of VirtIODevice with >>> their path and vir

hw/nvme: fix verification of select field in namespace attachment

2021-08-23 Thread Naveen
Fix is added to check for reserved value in select field for namespace attachment Signed-off-by: Naveen Nagar Signed-off-by: Klaus Jensen cc: Minwoo Im --- hw/nvme/ctrl.c | 13 + include/block/nvme.h | 5 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v7 17/33] block/copy-before-write: bdrv_cbw_append(): drop unused compress arg

2021-08-23 Thread Vladimir Sementsov-Ogievskiy
10.08.2021 18:17, Hanna Reitz wrote: On 04.08.21 11:37, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy ---   block/copy-before-write.h | 1 -   block/backup.c    | 2 +-   block/copy-before-write.c | 7 +++   3 files changed, 4 insertions(+), 6 deletion

Re: [PATCH v7 25/33] iotests.py: VM: add own __enter__ method

2021-08-23 Thread Vladimir Sementsov-Ogievskiy
04.08.2021 19:27, John Snow wrote: On Wed, Aug 4, 2021 at 5:39 AM Vladimir Sementsov-Ogievskiy mailto:vsement...@virtuozzo.com>> wrote: In superclass __enter__ method is defined with return value type hint 'QEMUMachine'. So, mypy thinks that return value of VM.__enter__ is QEMUMachi

Re: [PATCH v7 07/33] block/block-copy: introduce block_copy_set_copy_opts()

2021-08-23 Thread Vladimir Sementsov-Ogievskiy
23.08.2021 15:05, Vladimir Sementsov-Ogievskiy wrote: 10.08.2021 17:55, Hanna Reitz wrote: On 04.08.21 11:37, Vladimir Sementsov-Ogievskiy wrote: We'll need a possibility to set compress and use_copy_range options after initialization of the state. So make corresponding part of block_copy_state

Re: [PATCH] hw/nvme: fix validation of ASQ and ACQ

2021-08-23 Thread Keith Busch
On Mon, Aug 23, 2021 at 02:20:18PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Address 0x0 is a valid address. Fix the admin submission and completion > queue address validation to not error out on this. Indeed, there are environments that can use that address. It's a host error if the c

Re: [PATCH] hw/nvme: fix validation of ASQ and ACQ

2021-08-23 Thread Klaus Jensen
On Aug 23 19:47, Keith Busch wrote: > On Mon, Aug 23, 2021 at 02:20:18PM +0200, Klaus Jensen wrote: > > From: Klaus Jensen > > > > Address 0x0 is a valid address. Fix the admin submission and completion > > queue address validation to not error out on this. > > Indeed, there are environments tha

Re: hw/nvme: fix verification of select field in namespace attachment

2021-08-23 Thread Klaus Jensen
On Aug 23 16:33, Naveen wrote: > Fix is added to check for reserved value in select field for > namespace attachment > > Signed-off-by: Naveen Nagar > Signed-off-by: Klaus Jensen > cc: Minwoo Im > Looks like your MUA didnt pick up on the CC: tag, so: +CC Minwoo signature.asc Description: