On Thu 13 Dec 2018 06:51:54 PM CET, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
>
> $ spatch --sp-file scripts/coccinelle/qobject.cocci \
> --macro-file scripts/cocci-macro-file.h \
> --dir block --in-place
>
> Signed-off-by: Markus Armbruster
Review
14.12.2018 2:28, Paolo Bonzini wrote:
> On 11/12/18 17:43, Vladimir Sementsov-Ogievskiy wrote:
>> +ThreadPool *pool = aio_get_thread_pool(bdrv_get_aio_context(bs));
>> +
>> +while (s->nb_threads >= QCOW2_MAX_THREADS) {
>> +qemu_co_queue_wait(&s->thread_task_queue, NULL);
>> +}
>
On Wed, 12 Dec 2018 at 11:24, Daniel P. Berrangé wrote:
>
> The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
> Merge remote-tracking branch
> 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11
> 19:18:58 +)
>
> are available in the Git
ping
I suppose this one can go in now.
On Wed 14 Nov 2018 03:58:57 PM CET, Alberto Garcia wrote:
> Refcount table entries have a field to store the offset of the
> refcount block. The rest of the bits of the entry are currently
> reserved.
>
> The offset is always taken from the entry using REFT_
ping
On Thu 22 Nov 2018 04:00:25 PM CET, Alberto Garcia wrote:
> Hi,
>
> a couple of minor fixes for the mirror block job. I don't think these
> bugs can be reproduced at the moment so this shouldn't be 3.1
> material.
>
> Berto
>
> Alberto Garcia (2):
> mirror: Release the dirty bitmap if mirro
On Wed, 12 Dec 2018 at 13:27, Kevin Wolf wrote:
>
> The following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
> Merge remote-tracking branch
> 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11
> 19:18:58 +)
>
> are available in the Git reposito
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be
On Thu, 13 Dec 2018 23:37:37 +0100
Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exem
The following changes since commit d8d5fefd8657d4f7b380b3a1533340434b5b9def:
Merge remote-tracking branch
'remotes/berrange/tags/qcrypto-next-pull-request' into staging (2018-12-13
18:45:18 +)
are available in the Git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
fo
>>> Indeed, performance traces are important for issues like this.
>>See strace of both FC27 and FC29 attached
>Looks like you traced only the main thread. All the I/O is done in other
>threads.
>These flags would be useful:
>
> strace -o log -f -T -tt
New straces attached with mentioned flag
On Fri, 30 Nov 2018 at 15:20, Peter Maydell wrote:
>
> This patchset removes the load_image() function, which we noted
> in a comment as being deprecated in 2008 but were still using
> in a handful of places. All the use cases are bugs of some
> kind or another, either straightforward "no length c
On 14/12/18 11:22, Daniel P. Berrangé wrote:
>> crypto/aes.c
>> crypto/desrfb.c
>
> I'd rather like this to be cleaned to finish the job for
> crypto/.
Ok, will do.
Paolo
On 13.12.2018 15:20, Kevin Wolf wrote:
> Am 13.12.2018 um 12:07 hat Denis Plotnikov geschrieben:
>> On 12.12.2018 15:24, Kevin Wolf wrote:
>>> Am 11.12.2018 um 17:55 hat Denis Plotnikov geschrieben:
> Why involve the AioContext at all? This could all be kept at the
> BlockBackend level wi
I want to make it consistent but I'm note sure I understand all aspects
of current state and legacy clients we need to support.
The initial idea was to have single function blk_lookup(char* name) and
search in all namespaces internally as they are guaranteed to have no
intersection. This will
Am 14.12.2018 um 11:59 hat De Backer, Fred (Nokia - BE/Antwerp) geschrieben:
> >>> Indeed, performance traces are important for issues like this.
> >>See strace of both FC27 and FC29 attached
>
> >Looks like you traced only the main thread. All the I/O is done in other
> >threads.
> >These flags
>Of course, we should also think about the other problem you mentioned, related
>to copying a smaller image to a larger block device. Does this require zeroing
>the parts after the image or should we leave them alone?
>
>I'd tend to say that since you're passing the whole block device as a target
On Fri, Dec 14, 2018 at 12:52:34PM +, De Backer, Fred (Nokia - BE/Antwerp)
wrote:
> >Of course, we should also think about the other problem you mentioned,
> >related to copying a smaller image to a larger block device. Does this
> >require zeroing the parts after the image or should we leav
On Fri, Dec 14, 2018 at 01:26:59PM +0100, Kevin Wolf wrote:
> Am 14.12.2018 um 11:59 hat De Backer, Fred (Nokia - BE/Antwerp) geschrieben:
> > >>> Indeed, performance traces are important for issues like this.
> > >>See strace of both FC27 and FC29 attached
> >
> > >Looks like you traced only the
On Thu, 13 Dec 2018 at 22:38, Paolo Bonzini wrote:
>
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exempted
Hi all!
These series are derived from "[PATCH v3 0/8] qcow2 check improvements"
(https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02284.html)
Some patches are new, some patches are not included and are postponed to
part II.
So, here:
01,03 - unchanged
02: handle broken iotest
04-05: new
Reduce number of structures ignored in overlap check: when checking
active table ignore active tables, when checking inactive table ignore
inactive ones.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Max Reitz
---
block/qcow2-refcount.c | 16 +---
1 file changed, 9 insert
Do not count a cluster which is fixed to be ZERO as allocated.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index e76085d9aa..8da0e91dd
No reasons for not reporting found corruptions as corruptions in case
of some internal errors, especially in case of just failed to fix l2
entry (and in this case, missed corruptions may influence comparing
logic, when we calculate difference between corruptions fields of two
results)
Signed-off-b
qcow2_inc_refcounts_imrt() (through realloc_refcount_array()) can eat
an unpredictable amount of memory on corrupted table entries, which are
referencing regions far beyond the end of file.
Prevent this, by skipping such regions from further processing.
Interesting that iotest 138 checks exactly
Increase corruptions_fixed only after successful fix.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
block/qcow2-refcount.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 1c63ac244a..b717fdecc6 100644
--- a/block
Paolo Bonzini writes:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be exempted from the check.
> Outside th
> -Original Message-
[snip]
> > +
> > +blockdev->auto_iothread = iothread;
> > +
> > +object_property_set_bool(OBJECT(dev), true, "realized",
> &local_err);
> > +if (local_err) {
> > +error_propagate_prepend(errp, local_err,
> > +"initiali
Nir Soffer writes:
> On Fri, Dec 7, 2018 at 3:19 PM Milan Zamazal wrote:
>
>> Hi, I've seen a CI failure on qemu-io tests in ovirt-4.2 branch:
>> http://jenkins.ovirt.org/job/vdsm_standard-check-patch/602/
>
>
> We have several issues:
Thank you Nir for looking.
> *00:12:02.358* def verify
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be
On Thu, Dec 13, 2018 at 11:37:37PM +0100, Paolo Bonzini wrote:
> Most files that have TABs only contain a handful of them. Change
> them to spaces so that we don't confuse people.
>
> disas, standard-headers, linux-headers and libdecnumber are imported
> from other projects and probably should be
> -Original Message-
> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf
> Of Paul Durrant
> Sent: 14 December 2018 14:50
> To: 'Kevin Wolf'
> Cc: xen-de...@lists.xenproject.org; Stefano Stabellini
> ; qemu-de...@nongnu.org; qemu-block@nongnu.org;
> Max Reitz
> Sub
03.12.2018 13:14, Anton Nefedov wrote:
> If COW areas of the newly allocated clusters are zeroes on the backing image,
> efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole
> cluster instead of writing explicit zero buffers later in perform_cow().
>
> iotest 060:
> write
On 12/13/18 4:37 PM, Paolo Bonzini wrote:
Most files that have TABs only contain a handful of them. Change
them to spaces so that we don't confuse people.
disas, standard-headers, linux-headers and libdecnumber are imported
from other projects and probably should be exempted from the check.
Out
On Fri, Dec 07, 2018 at 09:53:06AM +0800, wangjian wrote:
> Memset vhost_dev to zero in the vhost_dev_cleanup function.
> This causes dev.vqs to be NULL, so that
> vqs does not free up space when calling the g_free function.
> This will result in a memory leak. But you can't release vqs
> directly
On 12/13/18 8:09 AM, Vladimir Sementsov-Ogievskiy wrote:
> 13.12.2018 4:50, John Snow wrote:
>> If iotests have lines exceeding >998 characters long, git doesn't
>> want to send it plaintext to the list. We can solve this by allowing
>> the iotests to use pretty printed QMP output that we can ma
Touch up a few last things and remove the x- prefix.
V3:
- Reworked qmp_log to pretty-print the outgoing command, too [Vladimir]
- Modified test to log only bitmap information [Vladimir]
- Test disable/enable transaction toggle [Eric]
Note that the filter I added is now unused, but I think we
Instead of using os.environ[], use .get with a default of empty string
to match the setup in check to allow us to import the iotests module
(for debugging, say) without needing a crafted environment just to
import the module.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir
Presently, we abort transactions in the same order they were processed in.
Bitmap commands, though, attempt to restore backup data structures on abort.
To that end, though, they need to be aborted in reverse chronological order.
Replace the QSIMPLEQ data structure with a QTAILQ one, so we can iter
Especially outside of transactions, it is helpful to provide
all-or-nothing semantics for bitmap merges. This facilitates
the coalescing of multiple bitmaps into a single target for
the "checkpoint" interpretation when assembling bitmaps that
represent arbitrary points in time from component bitmap
If iotests have lines exceeding >998 characters long, git doesn't
want to send it plaintext to the list. We can solve this by allowing
the iotests to use pretty printed QMP output that we can match against
instead.
As a bonus, it's much nicer for human eyes, too.
Note that this changes the sort o
The 'x' prefix was added because I was uncertain of the direction we'd
take for the libvirt API. With the general approach solidified, I feel
comfortable committing to this API for 4.0.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
blockdev.c
New interface, new smoke test.
---
tests/qemu-iotests/236 | 124 +++
tests/qemu-iotests/236.out | 200 +
tests/qemu-iotests/group | 1 +
3 files changed, 325 insertions(+)
create mode 100755 tests/qemu-iotests/236
create mode 100644
To mimic the common filter of the same name, but for the python tests.
Signed-off-by: John Snow
Reviewed-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/iotests.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-
43 matches
Mail list logo
