Re: [Qemu-block] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

On Fri, Nov 16, 2018 at 5:26 PM Kevin Wolf wrote: > Am 15.11.2018 um 23:27 hat Nir Soffer geschrieben: > > On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer wrote: > > > > > On Wed, Nov 7, 2018 at 7:55 PM Nir Soffer wrote: > > > > > >> On Wed, Nov 7, 2018 at 7:27 PM Kevin Wolf wrote: > > >> > > >>> A

Re: [Qemu-block] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

On Sat, Nov 17, 2018 at 10:59:26PM +0200, Nir Soffer wrote: > On Fri, Nov 16, 2018 at 5:26 PM Kevin Wolf wrote: > > > Am 15.11.2018 um 23:27 hat Nir Soffer geschrieben: > > > On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer wrote: > > > > > > > On Wed, Nov 7, 2018 at 7:55 PM Nir Soffer wrote: > > > >

Re: [Qemu-block] [Qemu-devel] [PATCH 6/6] tests: exercise NBD server in TLS mode

On 11/16/18 11:20 AM, Eric Blake wrote: On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: Add tests that validate it is possible to connect to an NBD server running TLS mode. Also test mis-matched TLS vs non-TLS connections correctly fail. --- +== check TLS client to plain server fails == +optio

Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode

On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: Add tests that validate it is possible to connect to an NBD server running TLS mode. Also test mis-matched TLS vs non-TLS connections correctly fail. --- Missing your Signed-off-by. Can you please supply that, so I can include this in my pull requ

Re: [Qemu-block] [PATCH 6/6] tests: exercise NBD server in TLS mode

On 11/17/18 2:49 PM, Eric Blake wrote: On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: Add tests that validate it is possible to connect to an NBD server running TLS mode. Also test mis-matched TLS vs non-TLS connections correctly fail. --- Missing your Signed-off-by. Can you please supply that

[Qemu-block] [PATCH 1.5/6] nbd/server: Ignore write errors when replying to NBD_OPT_ABORT

Commit 37ec36f6 intentionally ignores errors when trying to reply to an NBD_OPT_ABORT request for plaintext clients, but did not make the same change for a TLS server. Since NBD_OPT_ABORT is documented as being a potential for an EPIPE when the client hangs up without waiting for our reply, we don

[Qemu-block] [PATCH 7/6] iotests: Also test I/O over NBD TLS

Enhance test 233 to also perform I/O beyond the initial handshake. Signed-off-by: Eric Blake --- Depends on my tweak to 2/6 to suppress an EIO error message on a failed read after NBD_CMD_DISC. tests/qemu-iotests/233 | 12 +++- tests/qemu-iotests/233.out | 10 ++ 2 files ch

Re: [Qemu-block] [PATCH 2/6 for-3.1] nbd: stop waiting for a NBD response with NBD_CMD_DISC

On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: When sending a NBD_CMD_DISC message there is no reply expected, however, the nbd_read_eof() coroutine is still waiting for a reply. In a plain NBD connection this doesn't matter as it will just get an EOF, however, on a TLS connection it will get an

Re: [Qemu-block] [PATCH 0/6] Misc fixes to NBD

On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: This does two minor fixes to the NBD code and adds significant coverage of the NBD TLS support to detect future problems. The first two patches should be for 3.1. The tests can wait till 4.0 if desired. Daniel P. Berrangé (6): nbd: fix whitespa

Re: [Qemu-block] [PATCH 3/6] tests: pull qemu-nbd iotest helpers into common.nbd file

On 11/16/18 9:53 AM, Daniel P. Berrangé wrote: The helpers for starting/stopping qemu-nbd in 058 will be useful in other test cases, so move them into a common.nbd file. Signed-off-by: Daniel P. Berrangé --- +function nbd_server_start_unix_socket() +{ +nbd_server_stop +$QEMU_NBD -v -

Re: [Qemu-block] Change in qemu 2.12 causes qemu-img convert to NBD to write more data

On Sat, Nov 17, 2018 at 11:13 PM Richard W.M. Jones wrote: > On Sat, Nov 17, 2018 at 10:59:26PM +0200, Nir Soffer wrote: > > On Fri, Nov 16, 2018 at 5:26 PM Kevin Wolf wrote: > > > > > Am 15.11.2018 um 23:27 hat Nir Soffer geschrieben: > > > > On Sun, Nov 11, 2018 at 6:11 PM Nir Soffer > wrote: