Re: [Qemu-block] [Qemu-devel] [PATCH 1/1 V2] Add vhost-pci-blk driver

2018-11-09 Thread Kevin Wolf
Am 09.11.2018 um 02:48 hat Dongli Zhang geschrieben: > > > On 11/09/2018 12:47 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 08, 2018 at 10:09:00PM +0800, Dongli Zhang wrote: > >> It looks the kernel space vhost-blk can only process raw image. > >> > >> How about to verify that only raw image is

Re: [Qemu-block] [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Paul Durrant
> -Original Message- > From: Paul Durrant > Sent: 08 November 2018 16:44 > To: Paul Durrant ; 'Kevin Wolf' > > Cc: Stefano Stabellini ; qemu-block@nongnu.org; > Tim Smith ; qemu-de...@nongnu.org; 'Markus > Armbruster' ; Anthony Perard > ; xen-de...@lists.xenproject.org; Max Reitz > > Subj

Re: [Qemu-block] [Qemu-devel] xen_disk qdevification

2018-11-09 Thread Kevin Wolf
Am 09.11.2018 um 11:27 hat Paul Durrant geschrieben: > > -Original Message- > > From: Paul Durrant > > Sent: 08 November 2018 16:44 > > To: Paul Durrant ; 'Kevin Wolf' > > > > Cc: Stefano Stabellini ; qemu-block@nongnu.org; > > Tim Smith ; qemu-de...@nongnu.org; 'Markus > > Armbruster' ; A

Re: [Qemu-block] [PATCH 6/7] qcow2: aio support for compressed cluster read

2018-11-09 Thread Alberto Garcia
On Tue 06 Nov 2018 05:24:36 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> Is there any reason why some parts of the QEMU code use qemu_blockalign >> and others qemu_try_blockalign() ? From what I can see it seems to be up >> to whoever wrote it... > > As I understand, the good reason to use _try_

Re: [Qemu-block] [Qemu-devel] [PATCH] tests: Fix Python 3 detection on older GNU make versions

2018-11-09 Thread Max Reitz
On 08.11.18 13:43, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Hi Markus, >> >> >> Le jeu. 8 nov. 2018 09:46, Markus Armbruster a écrit : >> >>> Cleber Rosa writes: >>> On 11/7/18 1:05 AM, Markus Armbruster wrote: > [...] > PEP 394 recommends software distributions i

Re: [Qemu-block] [Qemu-devel] [PATCH] bitmap: Update count after a merge

2018-11-09 Thread Eric Blake
On 9/27/18 12:23 PM, John Snow wrote: On 09/26/2018 11:11 PM, Eric Blake wrote: We need an accurate count of the number of bits set in a bitmap after a merge. In particular, since the merge operation short-circuits a merge from an empty source, if you have bitmaps A, B, and C where B started e

[Qemu-block] [RFC PATCH 0/2] Acceptance tests for qemu-img

2018-11-09 Thread Cleber Rosa
The initial goal of this RFC is to get feedback on tests not specific to the QEMU main binary, but specific to other components such as qemu-img. For this experiment, a small issue with the zero and negative number of I/O operations given to the bench command was chosen. Cleber Rosa (2): Accept

[Qemu-block] [RFC PATCH 2/2] qemu-img: consider a zero number of I/O requests an invalid count

2018-11-09 Thread Cleber Rosa
It's debatable whether it makes sense to consider the bench command successful when no I/O requests will be performed. This changes the behavior to consider a zero count of I/O requests an invalid value. While at it, avoid using signed types for number of I/O requests. The image file used, is a s

[Qemu-block] [RFC PATCH 1/2] Acceptance Tests: add QemuImgTest base class

2018-11-09 Thread Cleber Rosa
Testing other utilities such as qemu-img do not require the same infrastructure that testing QEMU itself does. Let's add a base class that just sets the suitable qemu-img binary to be used during test. Signed-off-by: Cleber Rosa --- tests/acceptance/avocado_qemu/__init__.py | 20 +++

Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/11] block: Deal with filters

2018-11-09 Thread Eric Blake
On 8/9/18 5:31 PM, Max Reitz wrote: Note 1: This series depends on v10 of my “block: Fix some filename generation issues” series. Based-on: <20180809213528.14738-1-mre...@redhat.com> Note 2: This is technically the first part of my active mirror followup. But just very technically. I noticed t

Re: [Qemu-block] [Qemu-devel] [PATCH v2 02/11] blockdev: Check @replaces in blockdev_mirror_common

2018-11-09 Thread Eric Blake
On 8/9/18 5:31 PM, Max Reitz wrote: There is no reason why the constraints we put on @replaces should be limited to drive-mirror. Therefore, move the sanity checks from qmp_drive_mirror() to blockdev_mirror_common() so they apply to blockdev-mirror as well. Signed-off-by: Max Reitz --- block

Re: [Qemu-block] [Qemu-devel] [PATCH] bitmap: Update count after a merge

2018-11-09 Thread John Snow
On 11/09/2018 12:57 PM, Eric Blake wrote: > On 9/27/18 12:23 PM, John Snow wrote: >> >> >> On 09/26/2018 11:11 PM, Eric Blake wrote: >>> We need an accurate count of the number of bits set in a bitmap >>> after a merge. In particular, since the merge operation short-circuits >>> a merge from an