Re: [Qemu-block] [Qemu-devel] [PATCH v4 11/11] hw/m68k: define Macintosh Quadra 800

2018-10-23 Thread Philippe Mathieu-Daudé
Hi Laurent, Mark, On 18/10/18 20:28, Mark Cave-Ayland wrote: From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- MAINTAINERS | 19 ++ default-configs/m68k-softmmu.mak | 14 ++ hw/intc/Makefile.ob

Re: [Qemu-block] [Qemu-devel] [PATCH v4 11/11] hw/m68k: define Macintosh Quadra 800

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- [...] > diff --git a/hw/m68k/Makefile.objs b/hw/m68k/Makefile.objs > index d1f089c08a..18ebf1937a 100644 > --- a/hw/

Re: [Qemu-block] [Qemu-devel] [PATCH v4 04/11] hw/m68k: add macfb video card

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- > arch_init.c | 4 + > hw/display/Makefile.objs| 1 + > hw/display/macfb-template.h | 158 +

Re: [Qemu-block] [Qemu-devel] [PATCH v4 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > This is broken as the linux driver seems broken too... So is this required for the initial version, or does Linux also boot without this device in the emulated machine? In the first case, please mention it in the cover lette

Re: [Qemu-block] [Qemu-devel] [PATCH v4 01/11] hw/m68k: add via support

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- [...] > diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c > new file mode 100644 > index 00..084974a24d > -

Re: [Qemu-block] [Qemu-devel] [PATCH v4 02/11] hw/m68k: implement ADB bus support for via

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- > hw/input/adb.c| 2 + > hw/misc/mac_via.c | 166 > +

Re: [Qemu-block] [Qemu-devel] [PATCH v4 07/11] hw/m68k: add Nubus support

2018-10-23 Thread Thomas Huth
On 2018-10-18 19:28, Mark Cave-Ayland wrote: > From: Laurent Vivier > > Co-developed-by: Mark Cave-Ayland > Signed-off-by: Mark Cave-Ayland > Signed-off-by: Laurent Vivier > --- [...] > +static void nubus_register_format_block(NubusDevice *dev) > +{ > +char fblock_name[27]; > + > +spri

Re: [Qemu-block] [PATCH] qemu-iotests: convert `pwd` and $(pwd) to $PWD

2018-10-23 Thread Eric Blake
On 10/22/18 2:48 PM, Mao Zhongyi wrote: The subject line says "what", but the commit body should say "why". My suggestion: POSIX requires $PWD to be reliable, and we expect all shells used by qemu scripts to be relatively close to POSIX. Thus, it is smarter to avoid forking the pwd executa