Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] qemu-iotests: Modern shellscripting(use $() instead of ``)

2018-10-18 Thread maozy
Hi, Eric On 10/18/18 11:28 AM, Eric Blake wrote: On 10/17/18 10:17 PM, Mao Zhongyi wrote: Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. `pwd` and `basename $0` are in 231 files under directory tests/qemu-iotests, so r

[Qemu-block] [PATCH 2/2] iotest: Test x-blockdev-change on a Quorum

2018-10-18 Thread Alberto Garcia
This patch tests that you can add and remove drives from a Quorum using the x-blockdev-change command. Signed-off-by: Alberto Garcia --- tests/qemu-iotests/081 | 86 ++ tests/qemu-iotests/081.out | 54 + 2 files changed,

[Qemu-block] [PATCH 1/2] quorum: Forbid adding children in blkverify mode

2018-10-18 Thread Alberto Garcia
The blkverify mode of Quorum only works when the number of children is exactly two, so any attempt to add a new one must return an error. quorum_del_child() on the other hand doesn't need any additional check because decreasing the number of children would make it go under the vote threshold. Sig

[Qemu-block] [PATCH 0/2] Forbid adding children to a Quorum in blkverify mode

2018-10-18 Thread Alberto Garcia
Hi, as pointed out by Kevin, the Quorum driver should not allow adding new children when running in blkverify mode. This series fixes that and also adds a couple of basic iotests for the x-blockdev-change QMP command. Berto Alberto Garcia (2): quorum: Forbid adding children in blkverify mode

Re: [Qemu-block] [PATCH v2 2/4] Introduce attributes to qemu timer subsystem

2018-10-18 Thread Stefan Hajnoczi
On Wed, Oct 17, 2018 at 01:24:28PM +0200, Paolo Bonzini wrote: > On 17/10/2018 12:57, Artem Pisarenko wrote: > >> Further down in this patch the notation is QEMU_TIMER_ATTR_, which I > >> think is clearer because QEMU_TIMER_ATTR(id) looks like a (non-existent) > >> macro.  Please use the QEMU_TIMER

[Qemu-block] [PATCH v3 2/4] Introduce attributes to qemu timer subsystem

2018-10-18 Thread Artem Pisarenko
Attributes are simple flags, associated with individual timers for their whole lifetime. They intended to be used to mark individual timers for special handling by various qemu features which have integration into qemu-timer. New/init functions family in timer interface updated and refactored (ne

qemu-block@nongnu.org

2018-10-18 Thread Fernando Casas Schössow
Hi Stefan, I hope this email finds you well and I apologize in advance for resurrecting this thread. I'm currently running on qemu 2.12.1 and I'm still having this issue every few days but now I managed to get a core dump generated (without including the guest memory). Would you take a look at

qemu-block@nongnu.org

2018-10-18 Thread Kevin Wolf
Hi Fernando, Am 18.10.2018 um 14:25 hat Fernando Casas Schössow geschrieben: > I hope this email finds you well and I apologize in advance for resurrecting > this thread. > I'm currently running on qemu 2.12.1 and I'm still having this issue every > few days but now I managed to get a core dump

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] qemu-iotests: Modern shellscripting(use $() instead of ``)

2018-10-18 Thread Eric Blake
[adding Jeff] On 10/18/18 2:14 AM, maozy wrote: Hi, Eric On 10/18/18 11:28 AM, Eric Blake wrote: On 10/17/18 10:17 PM, Mao Zhongyi wrote: Various shell files contain a mix between obsolete `` and modern $(); It would be nice to convert to using $() everywhere. `pwd` and `basename $0` are in

Re: [Qemu-block] [PATCH 2/2] iotest: Test x-blockdev-change on a Quorum

2018-10-18 Thread Kevin Wolf
Am 18.10.2018 um 10:59 hat Alberto Garcia geschrieben: > This patch tests that you can add and remove drives from a Quorum > using the x-blockdev-change command. > > Signed-off-by: Alberto Garcia > --- a/tests/qemu-iotests/081 > +++ b/tests/qemu-iotests/081 > @@ -198,6 +198,92 @@ quorum="$quorum

Re: [Qemu-block] [PATCH v3 3/9] block: Require auto-read-only for existing fallbacks

2018-10-18 Thread Kevin Wolf
Am 17.10.2018 um 20:53 hat Eric Blake geschrieben: > On 10/17/18 11:41 AM, Kevin Wolf wrote: > > Some block drivers have traditionally changed their node to read-only > > mode without asking the user. This behaviour has been marked deprecated > > since 2.11, expecting users to provide an explicit r

qemu-block@nongnu.org

2018-10-18 Thread Fernando Casas Schössow
Hi Kevin, Not at the moment. This is a production system and pretty much up to date but can't upgrade to 3.0 yet. If the dump can be of any use, I can upload it somewhere for analysis. BR, Fernando On jue, oct 18, 2018 at 2:38 PM, Kevin Wolf wrote: Hi Fernando, Am 18.10.2018 um 14:25 hat Fern

[Qemu-block] [PATCH] blockdev: report error on block latency histogram set error

2018-10-18 Thread zhenwei pi
Function block_latency_histogram_set may return error, but qapi ignore this. This can be reproduced easily by qmp command: virsh qemu-monitor-command INSTANCE '{"execute":"x-block-latency-histogram-set", "arguments":{"device":"drive-virtio-disk1","boundaries":[10,200,40]}}' In fact this command do

Re: [Qemu-block] [PATCH v3 2/4] Introduce attributes to qemu timer subsystem

2018-10-18 Thread Stefan Hajnoczi
On Thu, Oct 18, 2018 at 05:04:29PM +0600, Artem Pisarenko wrote: > Attributes are simple flags, associated with individual timers for their > whole lifetime. > They intended to be used to mark individual timers for special handling by > various qemu features which have integration into qemu-timer

[Qemu-block] [PATCH v4 01/11] hw/m68k: add via support

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/misc/Makefile.objs | 1 + hw/misc/mac_via.c | 668 ++ include/hw/misc/mac_via.h | 106 3 files changed

[Qemu-block] [PATCH v4 03/11] escc: introduce a selector for the register bit

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier On Sparc and PowerMac, the bit 0 of the address selects the register type (control or data) and bit 1 selects the channel (B or A). On m68k Macintosh, the bit 0 selects the channel and bit 1 the register type. This patch introduces a new parameter (bit_swap) to the device i

[Qemu-block] [PATCH v4 02/11] hw/m68k: implement ADB bus support for via

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/input/adb.c| 2 + hw/misc/mac_via.c | 166 ++ include/hw/misc/mac_via.h | 7 ++ 3 files changed, 175

[Qemu-block] [PATCH v4 06/11] ESP: add pseudo-DMA as used by Macintosh

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/scsi/esp.c | 292 +- include/hw/scsi/esp.h | 7 ++ 2 files changed, 270 insertions(+), 29 deletions(-) diff --

[Qemu-block] [PATCH v4 07/11] hw/m68k: add Nubus support

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/Makefile.objs| 1 + hw/nubus/Makefile.objs | 4 + hw/nubus/mac-nubus-bridge.c | 45 hw/nubus/nubus-bridge.c

[Qemu-block] [PATCH v4 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-18 Thread Mark Cave-Ayland
(MCA: I've reposting this on behalf of Laurent as I've been working on the feedback from v3 over the past months and therefore am better placed to update the changelog. If all goes well, it would be good to get this merged in time for 3.1 soft freeze) I'm rebasing some of these patches for seven y

[Qemu-block] [PATCH v4 04/11] hw/m68k: add macfb video card

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- arch_init.c | 4 + hw/display/Makefile.objs| 1 + hw/display/macfb-template.h | 158 +++ hw/display/macfb.c | 252 +

[Qemu-block] [PATCH v4 08/11] hw/m68k: add Nubus support for macfb video card

2018-10-18 Thread Mark Cave-Ayland
Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/display/macfb.c | 56 ++ 1 file changed, 56 insertions(+) diff --git a/hw/display/macfb.c b/hw/display/macfb.c index 54472c1cbb..7bbcac102c

[Qemu-block] [PATCH v4 11/11] hw/m68k: define Macintosh Quadra 800

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- MAINTAINERS | 19 ++ default-configs/m68k-softmmu.mak | 14 ++ hw/intc/Makefile.objs| 1 + hw/intc/q800_irq.c | 73 +

[Qemu-block] [PATCH v4 09/11] hw/m68k: add a dummy SWIM floppy controller

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/block/Makefile.objs | 1 + hw/block/swim.c | 415 include/hw/block/swim.h | 76 + 3 files changed, 4

[Qemu-block] [PATCH v4 05/11] hw/m68k: Apple Sound Chip (ASC) emulation

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier This is broken as the linux driver seems broken too... Co-developed-by: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Signed-off-by: Laurent Vivier --- hw/audio/Makefile.objs | 1 + hw/audio/asc.c | 446 + incl

[Qemu-block] [PATCH v4 10/11] dp8393x: manage big endian bus

2018-10-18 Thread Mark Cave-Ayland
From: Laurent Vivier This is needed by Quadra 800, this card can run on little-endian or big-endian bus. Signed-off-by: Laurent Vivier Tested-by: Hervé Poussineau --- hw/net/dp8393x.c | 88 1 file changed, 57 insertions(+), 31 deletions

Re: [Qemu-block] [PATCH v4 00/11] hw/m68k: add Apple Machintosh Quadra 800 machine

2018-10-18 Thread Laurent Vivier
Le 18/10/2018 à 20:28, Mark Cave-Ayland a écrit : > (MCA: I've reposting this on behalf of Laurent as I've been working on the > feedback from v3 over the past months and therefore am better placed to > update the changelog. If all goes well, it would be good to get this merged > in time for 3.1 so

[Qemu-block] [PATCH] iotests: update qemu-iotests/082.out after 9cbef9d68ee

2018-10-18 Thread Liang Yan
qemu-img help output is changed after commit 9cbef9d68ee, this is a update for iotests. Signed-off-by: Liang Yan --- tests/qemu-iotests/082.out | 956 ++--- 1 file changed, 478 insertions(+), 478 deletions(-) diff --git a/tests/qemu-iotests/082.out b/tests/qemu-i

Re: [Qemu-block] [PATCH] iotests: update qemu-iotests/082.out after 9cbef9d68ee

2018-10-18 Thread Eric Blake
On 10/18/18 3:22 PM, Liang Yan wrote: qemu-img help output is changed after commit 9cbef9d68ee, this is a update for iotests. Signed-off-by: Liang Yan --- tests/qemu-iotests/082.out | 956 ++--- 1 file changed, 478 insertions(+), 478 deletions(-) Thanks, but

Re: [Qemu-block] [PATCH] iotests: update qemu-iotests/082.out after 9cbef9d68ee

2018-10-18 Thread Liang Yan
On 10/18/18 4:46 PM, Eric Blake wrote: > On 10/18/18 3:22 PM, Liang Yan wrote: >> qemu-img help output is changed after commit 9cbef9d68ee, this is a >> update for iotests. >> >> Signed-off-by: Liang Yan >> --- >>   tests/qemu-iotests/082.out | 956 ++--- >>   1 f