Re: [Qemu-block] [PULL 00/23] Block layer patches

2018-10-02 Thread Peter Maydell
On 1 October 2018 at 18:18, Kevin Wolf wrote: > The following changes since commit 07f426c35eddd79388a23d11cb278600d7e3831d: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180926' into > staging (2018-09-28 18:56:09 +0100) > > are available in the git repository at: > > git://r

Re: [Qemu-block] [PATCH] qcow2: Fix cache-clean-interval documentation

2018-10-02 Thread Leonid Bloch
On 10/1/18 7:59 PM, Kevin Wolf wrote: > Am 01.10.2018 um 16:35 hat Eric Blake geschrieben: >> On 9/29/18 4:54 AM, Leonid Bloch wrote: >>> Fixing cache-clean-interval documentation following the recent change to >>> a default of 600 seconds on supported plarforms (only Linux currently). >>> >>> Sign

[Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Vladimir Sementsov-Ogievskiy
Support modern way of device selecting. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 6 -- blockdev.c | 8 +--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index ac3b48ee54..4efd60d8ab 1006

[Qemu-block] [PATCH 2/2] qapi: drop x- from x-block-latency-histogram-set

2018-10-02 Thread Vladimir Sementsov-Ogievskiy
Libvirt part is ready, let's drop x- prefix. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 4 ++-- blockdev.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index 4efd60d8ab..e9c0079933 100644

[Qemu-block] [PATCH 0/2] improve block-latency-histogram-set

2018-10-02 Thread Vladimir Sementsov-Ogievskiy
Support QOM path for block-latency-histogram-set and drop x- prefix. Libvirt discussion: https://www.redhat.com/archives/libvir-list/2018-September/msg00011.html Vladimir Sementsov-Ogievskiy (2): qapi: support device id for x-block-latency-histogram-set qapi: drop x- from x-block-latency-hist

Re: [Qemu-block] [PATCH v3 1/3] qapi: add x-debug-query-block-graph

2018-10-02 Thread Vladimir Sementsov-Ogievskiy
28.09.2018 19:31, Max Reitz wrote: On 23.08.18 17:46, Vladimir Sementsov-Ogievskiy wrote: Add a new command, returning block nodes (and their users) graph. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 91 +++ include/block/block.h

Re: [Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Eric Blake
On 10/2/18 9:30 AM, Vladimir Sementsov-Ogievskiy wrote: -# @device: device name to set latency histogram for. +# @device: device name to set latency histogram for (better use @id). +# +# @id: The name or QOM path of the guest device. As long as we are renaming the command, there's no need to k

Re: [Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2018 17:22, Eric Blake wrote: On 10/2/18 6:33 AM, Vladimir Sementsov-Ogievskiy wrote: Support modern way of device selecting. Signed-off-by: Vladimir Sementsov-Ogievskiy ---   qapi/block-core.json | 6 --   blockdev.c   | 8 +---   2 files changed, 9 insertions(+), 5 deleti

Re: [Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Nikolay Shirokovskiy
On 02.10.2018 17:22, Eric Blake wrote: > On 10/2/18 6:33 AM, Vladimir Sementsov-Ogievskiy wrote: >> Support modern way of device selecting. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >>   qapi/block-core.json | 6 -- >>   blockdev.c   | 8 +--- >>   2 files changed, 9

Re: [Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Eric Blake
On 10/2/18 6:33 AM, Vladimir Sementsov-Ogievskiy wrote: Support modern way of device selecting. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 6 -- blockdev.c | 8 +--- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/qapi/block-core.

Re: [Qemu-block] [PATCH 2/2] qapi: drop x- from x-block-latency-histogram-set

2018-10-02 Thread Eric Blake
On 10/2/18 6:33 AM, Vladimir Sementsov-Ogievskiy wrote: Libvirt part is ready, let's drop x- prefix. A link to the libvirt list archives would be useful. Signed-off-by: Vladimir Sementsov-Ogievskiy --- qapi/block-core.json | 4 ++-- blockdev.c | 2 +- 2 files changed, 3 insert

Re: [Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Vladimir Sementsov-Ogievskiy
02.10.2018 17:35, Eric Blake wrote: > On 10/2/18 9:30 AM, Vladimir Sementsov-Ogievskiy wrote: > -# @device: device name to set latency histogram for. +# @device: device name to set latency histogram for (better use @id). +# +# @id: The name or QOM path of the guest device. >>> >

Re: [Qemu-block] [PATCH 1/2] qapi: support device id for x-block-latency-histogram-set

2018-10-02 Thread Eric Blake
On 10/2/18 9:58 AM, Vladimir Sementsov-Ogievskiy wrote: -# @device: device name to set latency histogram for. +# @device: device name to set latency histogram for (better use @id). +# +# @id: The name or QOM path of the guest device. Hm. It all looks a bit weird. I've just duplicated block_

Re: [Qemu-block] [PATCH] tests: Disable test-bdrv-drain and test-replication

2018-10-02 Thread John Snow
On 10/01/2018 09:20 AM, Peter Maydell wrote: > The test-bdrv-drain and test-replication tests have > intermittent errors which make my build testing process > fail way too often. Disable them both for the moment. > > Signed-off-by: Peter Maydell > --- > I'm having trouble making forward progre

Re: [Qemu-block] [PATCH v3 00/18] fleecing-hook driver for backup

2018-10-02 Thread Eric Blake
On 10/1/18 5:29 AM, Vladimir Sementsov-Ogievskiy wrote: v2 was "[RFC v2] new, node-graph-based fleecing and backup" Hi all! These series introduce fleecing-hook driver. It's a filter-node, which do copy-before-write operation. Mirror uses filter-node for handling guest writes, let's move to fil

Re: [Qemu-block] [Qemu-devel] [PATCH v2] qemu-img.c: add help for each command

2018-10-02 Thread Eric Blake
On 9/15/18 11:10 AM, John Arbuckle wrote: Add the ability for the user to display help for a certain command. Example: qemu-img create --help What is printed is all the options available to this command and an example. Signed-off-by: John Arbuckle --- v2 changes: Removed block of string compar

Re: [Qemu-block] [Qemu-devel] [PATCH v3] qemu-img.c: add help for each command

2018-10-02 Thread Eric Blake
On 9/25/18 10:39 AM, John Arbuckle wrote: Add the ability for the user to display help for a certain command. Example: qemu-img create --help What is printed is all the options available to this command and an example. Signed-off-by: John Arbuckle --- v3 changes: Fixed a bug that caused qemu-i

[Qemu-block] [PATCH v4 5/6] block/backup: prohibit backup from using in use bitmaps

2018-10-02 Thread John Snow
If the bitmap is frozen, we shouldn't touch it. Signed-off-by: John Snow --- blockdev.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.c index d0febfca79..098d4c337f 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3512,10 +3512,10 @@ static Bl

Re: [Qemu-block] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions

2018-10-02 Thread John Snow
On 10/02/2018 07:02 PM, John Snow wrote: > based on: jsnow/bitmaps staging branch > > This series builds on a previous standalone patch and adjusts > the permission for all (or most) of the QMP bitmap commands. > > V4: > - Replace "in-use" with "in use" > - Replace "user_modifiable" version

[Qemu-block] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked status checker

2018-10-02 Thread John Snow
Instead of both frozen and qmp_locked checks, wrap it into one check. frozen implies the bitmap is split in two (for backup), and shouldn't be modified. qmp_locked implies it's being used by another operation, like being exported over NBD. In both cases it means we shouldn't allow the user to modif

[Qemu-block] [PATCH v4 6/6] nbd: forbid use of frozen bitmaps

2018-10-02 Thread John Snow
Whether it's "locked" or "frozen", it's in use and should not be allowed for the purposes of this operation. Signed-off-by: John Snow --- nbd/server.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index c3dd402b45..940b7aa0cd 100644 --- a/nbd

[Qemu-block] [PATCH v4 3/6] block/dirty-bitmaps: allow clear on disabled bitmaps

2018-10-02 Thread John Snow
Similarly to merge, it's OK to allow clear operations on disabled bitmaps, as this condition only means that they are not recording new writes. We are free to clear it if the user requests it. Signed-off-by: John Snow --- block/dirty-bitmap.c | 1 - blockdev.c | 8 2 files cha

[Qemu-block] [PATCH v4 4/6] block/dirty-bitmaps: prohibit enable/disable on locked/frozen bitmaps

2018-10-02 Thread John Snow
We're not being consistent about this. If it's in use by an operation, the user should not be able to change the behavior of that bitmap. Signed-off-by: John Snow --- blockdev.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/blockdev.c b/blockdev.

[Qemu-block] [PATCH v4 2/6] block/dirty-bitmaps: fix merge permissions

2018-10-02 Thread John Snow
In prior commits that made merge transactionable, we removed the assertion that merge cannot operate on disabled bitmaps. In addition, we want to make sure that we are prohibiting merges to "locked" bitmaps. Use the new user_locked function to check. Reported-by: Eric Blake Signed-off-by: John S

[Qemu-block] [PATCH v4 0/6] dirty-bitmaps: fix QMP command permissions

2018-10-02 Thread John Snow
based on: jsnow/bitmaps staging branch This series builds on a previous standalone patch and adjusts the permission for all (or most) of the QMP bitmap commands. V4: - Replace "in-use" with "in use" - Replace "user_modifiable" version with "user_locked" - Remove more usages of frozen-and-or-lo

[Qemu-block] [PATCH v2] bitmap: Update count after a merge

2018-10-02 Thread John Snow
From: Eric Blake We need an accurate count of the number of bits set in a bitmap after a merge. In particular, since the merge operation short-circuits a merge from an empty source, if you have bitmaps A, B, and C where B started empty, then merge C into B, and B into A, an inaccurate count meant