Re: libnfs 6.0.0 breaks qemu compilation

2025-01-23 Thread Daniel P . Berrangé
Is anyone planning to pick this up and turn it into a formal patch for QEMU ? We're hitting this breakage again in Fedora with libnfs6 and its also hit homebrew and probably other distros too. On Sun, Dec 15, 2024 at 12:52:47PM +1000, ronnie sahlberg wrote: > Maybe something like this: > --- > d

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-18 Thread Daniel P . Berrangé
On Mon, Dec 16, 2024 at 12:13:26PM +0100, Xavier Bachelot wrote: > Le 2024-12-16 11:43, Daniel P. Berrangé a écrit : > > On Sat, Dec 14, 2024 at 01:40:45PM +0100, Paolo Bonzini wrote: > > > Il ven 13 dic 2024, 20:19 Richard W.M. Jones ha > > > scritto: > > > > > > > On Fri, Dec 13, 2024 at 07:37:

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-16 Thread Xavier Bachelot
Le 2024-12-16 11:43, Daniel P. Berrangé a écrit : On Sat, Dec 14, 2024 at 01:40:45PM +0100, Paolo Bonzini wrote: Il ven 13 dic 2024, 20:19 Richard W.M. Jones ha scritto: > On Fri, Dec 13, 2024 at 07:37:10PM +0100, Paolo Bonzini wrote: > > Yeah, and I don't think it should be merged, unless li

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-16 Thread Daniel P . Berrangé
On Sat, Dec 14, 2024 at 01:40:45PM +0100, Paolo Bonzini wrote: > Il ven 13 dic 2024, 20:19 Richard W.M. Jones ha scritto: > > > On Fri, Dec 13, 2024 at 07:37:10PM +0100, Paolo Bonzini wrote: > > > Yeah, and I don't think it should be merged, unless libnfs support is > > dropped > > > from the QEM

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-15 Thread Paolo Bonzini
Il dom 15 dic 2024, 03:53 ronnie sahlberg ha scritto: > Maybe something like this: > --- > diff --git a/block/nfs.c b/block/nfs.c > index 0500f60c08..f768ee0c4b 100644 > --- a/block/nfs.c > +++ b/block/nfs.c > @@ -268,11 +268,18 @@ static int coroutine_fn > nfs_co_preadv(BlockDriverState *bs, int

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-14 Thread Stefan Hajnoczi
On Fri, 13 Dec 2024 at 11:04, Paolo Bonzini wrote: > > On 12/13/24 16:51, Richard W.M. Jones wrote: > > The libnfs asynch API has changed type signature in this new version. > > This change breaks qemu and it wasn't immediately obvious to me how to > > fix it. In particular the new API requires a

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-14 Thread Paolo Bonzini
Il ven 13 dic 2024, 20:19 Richard W.M. Jones ha scritto: > On Fri, Dec 13, 2024 at 07:37:10PM +0100, Paolo Bonzini wrote: > > Yeah, and I don't think it should be merged, unless libnfs support is > dropped > > from the QEMU build in rawhide. > > Sure if there's no easy fix on the horizon, we can

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Richard W.M. Jones
On Fri, Dec 13, 2024 at 07:37:10PM +0100, Paolo Bonzini wrote: > Yeah, and I don't think it should be merged, unless libnfs support is dropped > from the QEMU build in rawhide. Sure if there's no easy fix on the horizon, we can remove libnfs support temporarily. The upgrade path won't be smooth b

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Paolo Bonzini
Il ven 13 dic 2024, 17:06 Richard W.M. Jones ha scritto: > On Fri, Dec 13, 2024 at 05:03:55PM +0100, Paolo Bonzini wrote: > > On 12/13/24 16:51, Richard W.M. Jones wrote: > > >The libnfs asynch API has changed type signature in this new version. > > >This change breaks qemu and it wasn't immediat

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Richard W.M. Jones
On Fri, Dec 13, 2024 at 05:03:55PM +0100, Paolo Bonzini wrote: > On 12/13/24 16:51, Richard W.M. Jones wrote: > >The libnfs asynch API has changed type signature in this new version. > >This change breaks qemu and it wasn't immediately obvious to me how to > >fix it. In particular the new API requ

Re: libnfs 6.0.0 breaks qemu compilation

2024-12-13 Thread Paolo Bonzini
On 12/13/24 16:51, Richard W.M. Jones wrote: The libnfs asynch API has changed type signature in this new version. This change breaks qemu and it wasn't immediately obvious to me how to fix it. In particular the new API requires a buffer to be passed, but it's unclear what that would be. Old si

libnfs 6.0.0 breaks qemu compilation (was: Re: libnfs soname bump)

2024-12-13 Thread Richard W.M. Jones
The libnfs asynch API has changed type signature in this new version. This change breaks qemu and it wasn't immediately obvious to me how to fix it. In particular the new API requires a buffer to be passed, but it's unclear what that would be. Old signature: EXTERN int nfs_pread_async(struct nfs