Re: [PATCH] block vvfat.c fix leak when failure occurs

2021-11-23 Thread Hanna Reitz
On 19.11.21 12:25, Daniella Lee wrote: Based on your suggestions. I made a new patch which contians: 1.format detection 2.replace calloc with g_malloc0 in enable_write_target function 3.use g_free without null pointer detection in vvfat_open function 4.delete line "ret = 0", use return ret direct

Re: [PATCH] block/vvfat.c fix leak when failure occurs

2021-11-18 Thread Hanna Reitz
On 18.11.21 10:33, Daniella Lee wrote: Thanks for your reply and your suggestion is useful. This is my first submission, and I will pay attention to these issues in the future. There are many other places you mentioned need to be modified, do I need to resubmit the patch, or you want to modify

Re: [PATCH] block/vvfat.c fix leak when failure occurs

2021-11-18 Thread Hanna Reitz
On 16.11.21 13:57, Daniella Lee wrote: Function vvfat_open called function enable_write_target and init_directories, and these functions malloc new memory for BDRVVVFATState::qcow_filename, BDRVVVFATState::used_clusters, and BDRVVVFATState::cluster_buff. When the specified folder does not exist