Re: [RFC PATCH v2 15/25] include/block/snapshot: global state API + assertions

2021-10-07 Thread Stefan Hajnoczi
On Tue, Oct 05, 2021 at 10:32:05AM -0400, Emanuele Giuseppe Esposito wrote: > Snapshots run also under the BQL lock, so they all are > in the global state API. The aiocontext lock that they hold > is currently an overkill and in future could be removed. > > Signed-off-by: Emanuele Giuseppe Esposit

Re: [RFC PATCH v2 15/25] include/block/snapshot: global state API + assertions

2021-10-07 Thread Paolo Bonzini
On 05/10/21 16:32, Emanuele Giuseppe Esposito wrote: Snapshots run also under the BQL lock, so they all are in the global state API. The aiocontext lock that they hold is currently an overkill and in future could be removed. Signed-off-by: Emanuele Giuseppe Esposito --- block/snapshot.c

[RFC PATCH v2 15/25] include/block/snapshot: global state API + assertions

2021-10-05 Thread Emanuele Giuseppe Esposito
Snapshots run also under the BQL lock, so they all are in the global state API. The aiocontext lock that they hold is currently an overkill and in future could be removed. Signed-off-by: Emanuele Giuseppe Esposito --- block/snapshot.c | 28 include/block/snap