Re: [Qemu-block] [PATCH] throttle: fix a qemu crash problem when calling blk_delete

2017-10-21 Thread sochin.jiang
Thanks for replying. Indeed, the problem comes from the caller. I guest some code should be reconsidered in blk_remove_bs and blk_delete, especially with throttling. Secondly, when handling drive_del in hmp_drive_del, throttle_timers_detach_aio_context() is called first time in blk_remove_bs

Re: [Qemu-block] [PATCH] throttle: fix a qemu crash problem when calling blk_delete

2017-10-20 Thread Alberto Garcia
On Sun 24 Nov 2013 04:55:52 AM CET, sochin.jiang wrote: ^^^ I guess the date in your computer is wrong :-) > commit 7ca7f0 moves the throttling related part of the BDS life cycle > management to BlockBackend, adds call to > throttle_timers_detach_aio_context in blk_remove_bs. commi

[Qemu-block] [PATCH] throttle: fix a qemu crash problem when calling blk_delete

2017-10-19 Thread sochin.jiang
From: "sochin.jiang" commit 7ca7f0 moves the throttling related part of the BDS life cycle management to BlockBackend, adds call to throttle_timers_detach_aio_context in blk_remove_bs. commit 1606e remove a block device from its throttle group in blk_delete by calling blk_io_limits_disable, thi