Re: [PATCH v4 05/12] job: @force parameter for job_cancel_sync()

2021-09-15 Thread Vladimir Sementsov-Ogievskiy
14.09.2021 20:20, Hanna Reitz wrote: On 08.09.21 18:33, Vladimir Sementsov-Ogievskiy wrote: 07.09.2021 15:42, Hanna Reitz wrote: Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency o

Re: [PATCH v4 05/12] job: @force parameter for job_cancel_sync()

2021-09-14 Thread Hanna Reitz
On 08.09.21 18:33, Vladimir Sementsov-Ogievskiy wrote: 07.09.2021 15:42, Hanna Reitz wrote: Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to

Re: [PATCH v4 05/12] job: @force parameter for job_cancel_sync()

2021-09-08 Thread Vladimir Sementsov-Ogievskiy
07.09.2021 15:42, Hanna Reitz wrote: Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to terminate as soon as possible, so they should pass force

Re: [PATCH v4 05/12] job: @force parameter for job_cancel_sync()

2021-09-08 Thread Eric Blake
On Tue, Sep 07, 2021 at 02:42:38PM +0200, Hanna Reitz wrote: > Callers should be able to specify whether they want job_cancel_sync() to > force-cancel the job or not. > > In fact, almost all invocations do not care about consistency of the > result and just want the job to terminate as soon as pos

[PATCH v4 05/12] job: @force parameter for job_cancel_sync()

2021-09-07 Thread Hanna Reitz
Callers should be able to specify whether they want job_cancel_sync() to force-cancel the job or not. In fact, almost all invocations do not care about consistency of the result and just want the job to terminate as soon as possible, so they should pass force=true. The replication block driver is