Re: [PATCH 03/11] rust: Add some block layer bindings

2025-02-13 Thread Paolo Bonzini
On Wed, Feb 12, 2025 at 8:52 PM Kevin Wolf wrote: > I assume that sooner or later we'll have a reason to include it anyway, > so that might honestly be the best option. Sounds good. > Do you want to post it as a proper patch? It seems to depend on your > errno patch, but that shouldn't be a prob

Re: [PATCH 03/11] rust: Add some block layer bindings

2025-02-12 Thread Kevin Wolf
Am 12.02.2025 um 18:16 hat Paolo Bonzini geschrieben: > On 2/12/25 16:13, Kevin Wolf wrote: > > Or if you have to define the constants anyway - you currently do this > > only for Windows, but for into_negative_errno() you might need it on > > Linux, too - and it wouldn't be a problem for the consta

Re: [PATCH 03/11] rust: Add some block layer bindings

2025-02-12 Thread Paolo Bonzini
On 2/12/25 16:13, Kevin Wolf wrote: Or if you have to define the constants anyway - you currently do this only for Windows, but for into_negative_errno() you might need it on Linux, too - and it wouldn't be a problem for the constants to be signed (that they are unsigned is the main reason why it

Re: [PATCH 03/11] rust: Add some block layer bindings

2025-02-12 Thread Kevin Wolf
Am 12.02.2025 um 14:47 hat Paolo Bonzini geschrieben: > On Wed, Feb 12, 2025 at 2:13 PM Kevin Wolf wrote: > > Yes, we definitely need some proper bindings there. I'm already tired of > > writing things like this: > > > > return -(bindings::EINVAL as std::os::raw::c_int) > > > > Or even: > > >

Re: [PATCH 03/11] rust: Add some block layer bindings

2025-02-12 Thread Paolo Bonzini
On Wed, Feb 12, 2025 at 2:13 PM Kevin Wolf wrote: > Yes, we definitely need some proper bindings there. I'm already tired of > writing things like this: > > return -(bindings::EINVAL as std::os::raw::c_int) > > Or even: > > return e > .raw_os_error() > .unwrap_or(-(bindings

Re: [PATCH 03/11] rust: Add some block layer bindings

2025-02-12 Thread Kevin Wolf
Am 12.02.2025 um 10:29 hat Paolo Bonzini geschrieben: > On 2/11/25 22:43, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > rust/wrapper.h| 4 > > meson.build | 1 + > > rust/qemu-api/src/zeroable.rs | 5 +++-- > > 3 files changed, 8 insertions

Re: [PATCH 03/11] rust: Add some block layer bindings

2025-02-12 Thread Paolo Bonzini
On 2/11/25 22:43, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- rust/wrapper.h| 4 meson.build | 1 + rust/qemu-api/src/zeroable.rs | 5 +++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/rust/wrapper.h b/rust/wrapper.h index 41be87

[PATCH 03/11] rust: Add some block layer bindings

2025-02-11 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- rust/wrapper.h| 4 meson.build | 1 + rust/qemu-api/src/zeroable.rs | 5 +++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/rust/wrapper.h b/rust/wrapper.h index 41be87adcf..c3e1e6f9cf 100644 --- a/rust/wrapper