Re: [RFC 2/4] spdm: add spdm storage transport virtual header

2025-02-02 Thread Wilfred Mallawa
On Tue, 2025-01-28 at 09:03 +0100, Klaus Jensen wrote: > On Jan 15 02:16, Wilfred Mallawa wrote: > > On Fri, 2025-01-10 at 10:04 +0100, Klaus Jensen wrote: > > > On Jan  7 15:29, Wilfred Mallawa via wrote: > > > > This header contains the transport encoding fo

[RFC v2 3/3] hw/nvme: connect SPDM over NVMe Security Send/Recv

2025-01-15 Thread Wilfred Mallawa via
respectively. SPDM over the NVMe Security Send/Recv commands are defined in the DMTF DSP0286. Signed-off-by: Wilfred Mallawa --- docs/specs/spdm.rst | 10 -- hw/nvme/ctrl.c | 62 ++--- include/hw/pci/pci_device.h | 1 + 3 files changed, 60

[RFC v2 2/3] hw/nvme: add NVMe Admin Security SPDM support

2025-01-15 Thread Wilfred Mallawa via
Adds the NVMe Admin Security Send/Receive command support with support for DMTFs SPDM. The transport binding for SPDM is defined in the DMTF DSP0286. Signed-off-by: Wilfred Mallawa --- hw/nvme/ctrl.c | 203 ++- hw/nvme/nvme.h | 5 ++ include

[RFC v2 0/3] Add SPDM over Storage transport support for NVMe

2025-01-15 Thread Wilfred Mallawa via
ecification-wip Changes V1 -> V2: - Split out the SPDM Socket API patch for separate send/recv functions - Addressed comments from Klaus Jensen - Dropped unnecessary allocation length check - Dropped unnecessary alloc_len alignment check - Fixed up `nvme_security_receive: dw10` SPSP bi

[RFC v2 1/3] spdm: add spdm storage transport virtual header

2025-01-15 Thread Wilfred Mallawa via
This header contains the transport encoding for an SPDM message that uses the SPDM over Storage transport as defined by the DMTF DSP0286. Signed-off-by: Wilfred Mallawa --- include/system/spdm-socket.h | 12 1 file changed, 12 insertions(+) diff --git a/include/system/spdm

Re: [RFC 3/4] hw/nvme: add NVMe Admin Security SPDM support

2025-01-15 Thread Wilfred Mallawa
On Fri, 2025-01-10 at 11:03 +0100, Klaus Jensen wrote: > On Jan  7 15:29, Wilfred Mallawa via wrote: > > Adds the NVMe Admin Security Send/Receive command support with > > support > > for DMTFs SPDM. The transport binding for SPDM is defined in the > > DMTF DSP0286. >

Re: [RFC 1/4] spdm-socket: add seperate send/recv functions

2025-01-15 Thread Wilfred Mallawa
On Wed, 2025-01-15 at 12:28 +1000, Alistair Francis wrote: > On Wed, Jan 8, 2025 at 12:04 AM Wilfred Mallawa via > wrote: > > > > This is to support uni-directional transports such as SPDM > > over Storage. As specified by the DMTF DSP0286. > > >

Re: [RFC 2/4] spdm: add spdm storage transport virtual header

2025-01-14 Thread Wilfred Mallawa
On Fri, 2025-01-10 at 10:04 +0100, Klaus Jensen wrote: > On Jan  7 15:29, Wilfred Mallawa via wrote: > > This header contains the transport encoding for an SPDM message > > that > > uses the SPDM over Storage transport as defined by the DMTF > > DSP0286. > > &

[RFC 2/4] spdm: add spdm storage transport virtual header

2025-01-06 Thread Wilfred Mallawa via
This header contains the transport encoding for an SPDM message that uses the SPDM over Storage transport as defined by the DMTF DSP0286. Signed-off-by: Wilfred Mallawa --- include/system/spdm-socket.h | 12 1 file changed, 12 insertions(+) diff --git a/include/system/spdm

[RFC 4/4] hw/nvme: connect SPDM over NVMe Security Send/Recv

2025-01-06 Thread Wilfred Mallawa via
respectively. SPDM over the NVMe Security Send/Recv commands are defined in the DMTF DSP0286. Signed-off-by: Wilfred Mallawa --- docs/specs/spdm.rst | 10 -- hw/nvme/ctrl.c | 62 ++--- include/hw/pci/pci_device.h | 1 + 3 files changed, 60

[RFC 3/4] hw/nvme: add NVMe Admin Security SPDM support

2025-01-06 Thread Wilfred Mallawa via
Adds the NVMe Admin Security Send/Receive command support with support for DMTFs SPDM. The transport binding for SPDM is defined in the DMTF DSP0286. Signed-off-by: Wilfred Mallawa --- hw/nvme/ctrl.c | 207 ++- hw/nvme/nvme.h | 5 ++ include

[RFC 1/4] spdm-socket: add seperate send/recv functions

2025-01-06 Thread Wilfred Mallawa via
This is to support uni-directional transports such as SPDM over Storage. As specified by the DMTF DSP0286. Signed-off-by: Wilfred Mallawa --- backends/spdm-socket.c | 25 + include/system/spdm-socket.h | 35 +++ 2 files changed, 60

[RFC 0/4] Add SPDM over Storage transport support for NVMe

2025-01-06 Thread Wilfred Mallawa via
ecification-wip Wilfred Mallawa (4): spdm-socket: add seperate send/recv functions spdm: add spdm storage transport virtual header hw/nvme: add NVMe Admin Security SPDM support hw/nvme: connect SPDM over NVMe Security Send/Recv backends/spdm-socket.c | 25 docs/specs/spdm.rst

Re: [PATCH v7 3/3] hw/nvme: Add SPDM over DOE support

2024-06-13 Thread Wilfred Mallawa
On Fri, 2024-06-14 at 11:28 +1000, Alistair Francis wrote: > From: Wilfred Mallawa > > Setup Data Object Exchance (DOE) as an extended capability for the > NVME small typo here 🤓️ [s/Setup Data Object Exchance/Setup Data Object Exchange] Wilfred > controller and connect SPDM to

Re: [PATCH v7 1/3] hw/pci: Add all Data Object Types defined in PCIe r6.0

2024-06-13 Thread Wilfred Mallawa
Reviewed-by: Wilfred Mallawa On Fri, 2024-06-14 at 11:28 +1000, Alistair Francis wrote: > Add all of the defined protocols/features from the PCIe-SIG r6.0 > "Table 6-32 PCI-SIG defined Data Object Types (Vendor ID = 0001h)" > table. > > Signed-off-by: Alistair Francis

Re: [PATCH] include/blcok: fixup typos

2023-03-13 Thread Wilfred Mallawa
On Mon, 2023-03-13 at 10:01 +, Peter Maydell wrote: > On Mon, 13 Mar 2023 at 00:26, Wilfred Mallawa > wrote: > > > > From: Wilfred Mallawa > > > > Fixup a few minor typos > > Typo in patch subject line: should be 'block' :-) Ha! already sent

[PATCH v2] include/block: fixup typos

2023-03-12 Thread Wilfred Mallawa
From: Wilfred Mallawa Fixup a few minor typos Signed-off-by: Wilfred Mallawa --- v2: - Fixup typo in commit msg. include/block/aio-wait.h | 2 +- include/block/block_int-common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/aio-wait.h b

[PATCH] include/blcok: fixup typos

2023-03-12 Thread Wilfred Mallawa
From: Wilfred Mallawa Fixup a few minor typos Signed-off-by: Wilfred Mallawa --- include/block/aio-wait.h | 2 +- include/block/block_int-common.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/block/aio-wait.h b/include/block/aio-wait.h index

Re: [PATCH v2 6/6] monitor: convert monitor_cleanup() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-12 Thread Wilfred Mallawa
- >  monitor/monitor.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Wilfred Mallawa > > diff --git a/monitor/monitor.c b/monitor/monitor.c > index 8dc96f6af9..602535696c 100644 > --- a/monitor/monitor.c > +++ b/monitor/monitor.c > @@ -666,7 +666,7 @@ vo

Re: [PATCH v2 5/6] hmp: convert handle_hmp_command() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-12 Thread Wilfred Mallawa
nitor/hmp.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Wilfred Mallawa > > diff --git a/monitor/hmp.c b/monitor/hmp.c > index fee410362f..5cab56d355 100644 > --- a/monitor/hmp.c > +++ b/monitor/hmp.c > @@ -1167,7 +1167,7 @@ void handle_

Re: [PATCH v2 4/6] block: convert bdrv_drain_all_begin() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-12 Thread Wilfred Mallawa
e Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > --- >  block/io.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Wilfred Mallawa > > diff --git a/block/io.c b/block/io.c > index 8

Re: [PATCH v2 3/6] block: convert bdrv_graph_wrlock() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-12 Thread Wilfred Mallawa
) can be substituted. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > --- >  block/graph-lock.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Wilfred Mallawa >

Re: [PATCH v2 2/6] block: convert blk_exp_close_all_type() to AIO_WAIT_WHILE_UNLOCKED()

2023-03-12 Thread Wilfred Mallawa
xt_release() is never called anyway. > > Reviewed-by: Philippe Mathieu-Daudé > Tested-by: Philippe Mathieu-Daudé > Reviewed-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > --- >  block/export/export.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) Reviewed

Re: [PATCH v2 1/6] block: don't acquire AioContext lock in bdrv_drain_all()

2023-03-12 Thread Wilfred Mallawa
> entirely. > > Reviewed-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > --- >  block/block-backend.c | 8 +--- >  1 file changed, 1 insertion(+), 7 deletions(-) Reviewed-by: Wilfred Mallawa > > diff --git a/block/block-backend.c b/block/block-backend.c >

Re: [PATCH 0/3] python: testing fixes

2022-12-04 Thread Wilfred Mallawa
ke8 config >   iotests/check: Fix typing for sys.exit() value >   python: add 3.11 to supported list > >  python/setup.cfg | 6 -- >  tests/qemu-iotests/check | 2 +- >  2 files changed, 5 insertions(+), 3 deletions(-) > > -- > 2.38.1 > I see you've left Westeros! xD Reviewed-by: Wilfred Mallawa > >