On Wed, Mar 19, 2025 at 17:28:06 +0100, Peter Krempa wrote:
> New python doesn't like '\l' escapes from the 'dot' language.
>
> While at it improve usability of the script by employing proper argument
> parsing.
>
> v2:
> - use mutually e
1)
> +''''''''''''''''''''''''''''''''''
> +
> +Use ``job-complete`` instead. The only difference is that ``job-complete``
> +always reports GenericError on failure when ``block-job-complete`` reports
> +DeviceNotActive when block-job is not found.
> +
> +``block-job-dismiss`` (since 10.1)
> +'''''''''''''''''''''''''''''''''
> +
> +Use ``job-dismiss`` instead.
> +
> +``block-job-finalize`` (since 10.1)
> +''''''''''''''''''''''''''''''''''
> +
> +Use ``job-finalize`` instead.
> +
Libvirt uses only the following two with 'block-job-' prefix:
src/qemu/qemu_monitor_json.c:if (!(cmd =
qemuMonitorJSONMakeCommand("block-job-cancel",
src/qemu/qemu_monitor_json.c:if (!(cmd =
qemuMonitorJSONMakeCommand("block-job-set-speed",
thus on behalf of libvirt:
ACKed-by: Peter Krempa
From: Peter Krempa
An error from virsh spews also backtrace:
$ ./scripts/render_block_graph.py --vm doesnotexist
error: failed to get domain 'doesnotexist'
Traceback (most recent call last):
File "/home/pipo/git/qemu.git/./scripts/render_block_graph.py&
New python doesn't like '\l' escapes from the 'dot' language.
While at it improve usability of the script by employing proper argument
parsing.
v2:
- use mutually exclusive group instead of hardcoding it (Pavel)
Peter Krempa (3):
scripts: render_block_graph: Fi
From: Peter Krempa
Trying to run 'render_block_graph' produces following warnings on
machine with python 3.12:
$ ./scripts/render_block_graph.py cd-throttle ble.png
./scripts/render_block_graph.py:57: SyntaxWarning: invalid escape sequence '\l'
'
From: Peter Krempa
As no argument parsing is employed the script is hard to use and when
running without arguments it blurbs:
$ ./scripts/render_block_graph.py
Traceback (most recent call last):
File "/home/pipo/git/qemu.git/./scripts/render_block_graph.py", line 135, in
From: Peter Krempa
As no argument parsing is employed the script is hard to use and when
running without arguments it blurbs:
$ ./scripts/render_block_graph.py
Traceback (most recent call last):
File "/home/pipo/git/qemu.git/./scripts/render_block_graph.py", line 135, in
From: Peter Krempa
An error from virsh spews also backtrace:
$ ./scripts/render_block_graph.py --vm doesnotexist
error: failed to get domain 'doesnotexist'
Traceback (most recent call last):
File "/home/pipo/git/qemu.git/./scripts/render_block_graph.py&
From: Peter Krempa
Trying to run 'render_block_graph' produces following warnings on
machine with python 3.12:
$ ./scripts/render_block_graph.py cd-throttle ble.png
./scripts/render_block_graph.py:57: SyntaxWarning: invalid escape sequence '\l'
'
New python doesn't like '\l' escapes from the 'dot' language.
While at it improve usability of the script by employing proper argument
parsing.
Peter Krempa (3):
scripts: render_block_graph: Fix invalid escape sequence warning with
python 3.12
scripts: rend
On Mon, Mar 10, 2025 at 15:33:02 +0100, Kevin Wolf wrote:
> Am 13.02.2025 um 19:00 hat Stefan Hajnoczi geschrieben:
> > Allow virtio-scsi virtqueues to be assigned to different IOThreads. This
> > makes it possible to take advantage of host multi-queue block layer
> > scalability by assigning virtq
odified my libvirt patches to take only the command queues into
account same as with virtio-blk.
After learning how 'fio' works I was able to set multiple iothreads on
fire based on the mapping.
Tested-by: Peter Krempa
312698
> 4 346744
... so I'll trust you here, but at least configuration wise this seems
to work.
As discussed on the libvirt patchset it might be a good idea to
docuement that the ctrl and event queues need to be mapped as well if
you'll be dealing with docs.
Tested-by: Peter Krempa
On Mon, Jan 27, 2025 at 10:53:16 +, Daniel P. Berrangé wrote:
> On Mon, Jan 27, 2025 at 11:29:24AM +0100, Peter Krempa wrote:
> > Commit 7452162adec25c10 introduced 'qom-path' argument to BLOCK_IO_ERROR
> > event but when the event is instantiated in 'send_qmp_er
nto reporting the QOM path as the device alias and vice
versa which in turn breaks libvirt, which expects the device alias being
either a valid alias or empty (which would make libvirt do the lookup by
node-name instead).
Fixes: 7452162adec25c1003d5bf0079aca52913a80e0c
Signed-off-by: Peter Krempa
---
On Tue, Sep 24, 2024 at 15:24:51 +0200, Thomas Huth wrote:
> According to https://marc.info/?l=fedora-devel-list&m=171934833215726
> the GlusterFS development effectively ended. Thus mark it as deprecated
> in QEMU, so we can remove it in a future release if the project does
> not gain momentum aga
On Mon, Mar 11, 2024 at 18:51:18 +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 11.03.24 00:07, Peter Krempa wrote:
> > On Thu, Mar 07, 2024 at 22:42:56 +0300, Vladimir Sementsov-Ogievskiy wrote:
[...]
> > Libvirt can adapt to any option that will give us the above seman
On Thu, Mar 07, 2024 at 22:42:56 +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 04.03.24 14:09, Peter Krempa wrote:
> > On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
> > > Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > > On 03.
On Mon, Mar 04, 2024 at 11:48:54 +0100, Kevin Wolf wrote:
> Am 28.02.2024 um 19:07 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > On 03.11.23 18:56, Markus Armbruster wrote:
> > > Kevin Wolf writes:
[...]
> > > Is the job abstraction a failure?
> > >
> > > We have
> > >
> > > block-job
On Tue, Dec 05, 2023 at 18:14:40 +0100, Peter Krempa wrote:
> Please see patches for rationale.
>
> Libvirt patches using this new flag will be posted soon-ish (after
> cleanup).
>
> v3:
> - changed name of flag to 'backing-mask-protocol' (Eric)
> - de
On Tue, Dec 05, 2023 at 18:14:40 +0100, Peter Krempa wrote:
> Please see patches for rationale.
>
> Libvirt patches using this new flag will be posted soon-ish (after
> cleanup).
https://lists.libvirt.org/archives/list/de...@lists.libvirt.org/message/GCCZP5ANYTPVXCIEYGSM5NWYCGDL23V6/
stay compatible with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block.c| 37 +-
blo
stay compatible with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/monitor/block-hmp-cmds.c | 2 +-
block/stream.c
gument order in 'hmp_block_stream'
- changed version in docs to 9.0 as getting this into RC 3 probably
isn't realistic
Peter Krempa (2):
block: commit: Allow users to request only format driver names in
backing file format
block: stream: Allow users to request only format driver na
On Thu, Nov 30, 2023 at 13:24:18 -0600, Eric Blake wrote:
> On Thu, Nov 30, 2023 at 05:06:03PM +0100, Peter Krempa wrote:
> > Introduce a new flag 'backing_file_format_no_protocol' for the
> > block-commit QMP command which instructs the internals to use 'raw'
&g
hat
the images stay compatible with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block.c| 37 ++
hat
the images stay compatible with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
Reviewed-by: Vladimir Sementsov-Ogievskiy
---
block/monitor/block-hmp-cmds.c | 2 +-
blo
Please see patches for rationale.
Libvirt patches using this new flag will be posted soon-ish (after
cleanup).
v2:
- fixed mistaken argument order in 'hmp_block_stream'
- changed version in docs to 9.0 as getting this into RC 3 probably
isn't realistic
Peter Krempa (2):
On Tue, Nov 28, 2023 at 20:10:10 +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 24.11.23 17:52, Peter Krempa wrote:
> > Introduce a new flag 'backing_file_format_no_protocol' for the
> > block-commit QMP command which instructs the internals to use 'raw'
> &g
hat
the images stay compatible with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
---
block.c| 37 +-
block/commit.c
hat
the images stay compatible with older libvirt versions which didn't
expect that a protocol driver name can appear in the backing file format
field.
Signed-off-by: Peter Krempa
---
block/monitor/block-hmp-cmds.c | 2 +-
block/stream.c | 10 +-
blo
Please see patches for rationale.
Libvirt patches using this new flag will be posted soon-ish (after
cleanup).
Peter Krempa (2):
block: commit: Allow users to request only format driver names in
backing file format
block: stream: Allow users to request only format driver names in
On Mon, Jan 23, 2023 at 15:01:37 +0100, Markus Armbruster wrote:
> Peter Krempa writes:
>
> > After recent header file inclusion rework the build fails when the blkio
> > module is enabled:
> >
> > ../block/blkio.c: In function ‘blkio_detach_aio_context’:
>
));
| ^~~~
| |
| int
Fix it by including 'block/block-io.h' which contains the required
declarations.
Fixes: e2c1c34f139f49ef909bb4322607fb8b39002312
Signed-off-by: Peter Krempa
---
block/blkio.c | 2
On Wed, Jul 27, 2022 at 21:33:40 +0200, Kevin Wolf wrote:
> Am 08.07.2022 um 06:17 hat Stefan Hajnoczi geschrieben:
> > libblkio (https://gitlab.com/libblkio/libblkio/) is a library for
> > high-performance disk I/O. It currently supports io_uring and
> > virtio-blk-vhost-vdpa with additional drive
ies. Fix some bugs there as a side effect.
> - Remove an unnecessary use of ERRP_GUARD()
> - Replaced error handling patch for qdev_set_id() with Damien's
> - Drop the deprecation patch until libvirt uses the new JSON syntax
Series:
Tested-by: Peter Krempa
On Fri, Sep 24, 2021 at 11:04:25 +0200, Kevin Wolf wrote:
> Directly call qdev_device_add_from_qdict() for QMP device_add instead of
> first going through QemuOpts and converting back to QDict.
>
> Note that this changes the behaviour of device_add, though in ways that
> should be considered bug f
On Wed, Aug 04, 2021 at 12:34:31 +0200, Kevin Wolf wrote:
> We could in theory keep allowing redundant completion requests when the
> completion mode doesn't conflict, but I don't see the point of that.
I don't see either. Especially since ...
> Unless libvirt can actually issue multiple comple
Hi,
recently I've got a report that an upgrade of libvirt (and qemu) caused
a guest-visible change in the SCSI disk identification when a very long
serial number is used.
I've traced it back to the point where libvirt started to use the
'device_id=' property of the SCSI disk to pass in the alias
sertions(+), 3593 deletions(-)
> delete mode 100644 block/sheepdog.c
Libvirt will need to adjust one test case (lock it to qemu-6.0 test
data), but other than that, this change is okay with us.
ACKed-by: Peter Krempa
On Fri, Apr 30, 2021 at 09:42:05 +0200, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > On Thu, Apr 29, 2021 at 04:52:21PM +0100, Stefan Hajnoczi wrote:
> >> The scsi=on|off property was deprecated in QEMU 5.0 and can be removed
> >> completely at this point.
> >>
> >> Drop the scsi=on|
through the code
again to see whether we do the correct thing if it's no longer
available.
>
> Cc: Markus Armbruster
> Cc: Christoph Hellwig
> Cc: Peter Krempa
> Cc: Dr. David Alan Gilbert
> Signed-off-by: Stefan Hajnoczi
> ---
> docs/specs/tpm.rst |
mply enabling O_DIRECT and linux_aio
> unconditionally for drive_backup target. But actually this just shows
> that using drive-backup in blockdev era is a bad idea. So let's motivate
> everyone (including Virtuozzo of course) to move to new interfaces and
> avoid problems with all that outdated option inheritance.
libvirt never used 'drive-backup' thus
Reviewed-by: Peter Krempa
On Thu, Apr 01, 2021 at 15:02:35 -0400, John Snow wrote:
> Hi; downstream we've run into an issue where VMs under heavy load with many
> simultaneously concurrent block jobs running might occasionally flicker into
> the STANDBY state, during which time they will be unable to receive JOB
> COMPLETE
On Fri, Mar 12, 2021 at 09:46:54 +0100, Paolo Bonzini wrote:
> On 12/03/21 09:14, Markus Armbruster wrote:
> > Paolo Bonzini writes:
> >
> > > On 11/03/21 15:08, Markus Armbruster wrote:
> > > > > I would rather keep the OptsVisitor here. Do the same check for JSON
> > > > > syntax that you have
On Thu, Mar 11, 2021 at 12:41:42 +0100, Kevin Wolf wrote:
> Am 11.03.2021 um 12:24 hat Peter Krempa geschrieben:
> > On Thu, Mar 11, 2021 at 09:37:11 +0100, Kevin Wolf wrote:
> > > Am 11.03.2021 um 08:47 hat Peter Krempa geschrieben:
> > > > On Wed, Mar 10, 2021 at 18
On Thu, Mar 11, 2021 at 09:37:11 +0100, Kevin Wolf wrote:
> Am 11.03.2021 um 08:47 hat Peter Krempa geschrieben:
> > On Wed, Mar 10, 2021 at 18:30:44 +0100, Kevin Wolf wrote:
> > > Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben:
> > > > On 10/0
On Wed, Mar 10, 2021 at 18:30:44 +0100, Kevin Wolf wrote:
> Am 10.03.2021 um 15:31 hat Paolo Bonzini geschrieben:
> > On 10/03/21 15:22, Peter Krempa wrote:
[...]
> The keyval parser would create a list if multiple values are given for
> the same key. Some care needs to be taken
On Wed, Mar 10, 2021 at 15:31:57 +0100, Paolo Bonzini wrote:
> On 10/03/21 15:22, Peter Krempa wrote:
> > I've stumbled upon a regression with this patchset applied:
> >
> > error: internal error: process exited while connecting to monitor:
> > qemu-system-x86_64:
On Mon, Mar 08, 2021 at 17:54:10 +0100, Kevin Wolf wrote:
> This series adds a QAPI type for the properties of all user creatable
> QOM types and finally makes the --object command line option (in all
> binaries) and the object-add monitor commands (in QMP and HMP) use the
> new ObjectOptions union
On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
> >> >> Drop the
On Mon, Mar 01, 2021 at 12:07:26 +0100, Kevin Wolf wrote:
> Am 25.02.2021 um 18:02 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > 24.02.2021 15:33, Kevin Wolf wrote:
> > > Am 09.02.2021 um 09:03 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > > 08.02.2021 21:44, Alberto Garcia wrote:
> > > >
libvir-list/2021-February/msg01212.html
Libvirt's test pass after it without any change, so on behalf of libvirt
ACKed-by: Peter Krempa
On Fri, Feb 12, 2021 at 12:38:10 -0600, Eric Blake wrote:
> On 2/12/21 11:34 AM, Peter Krempa wrote:
>
> Long subject line; if it's okay with you, I'd prefer to use:
>
> migration: dirty-bitmap: Use struct for alias map inner members
>
> > Currently the alias m
Verify that the modification of the bitmap persistence over migration
which is controlled via BitmapMigrationBitmapAliasTransform works
properly.
Based on TestCrossAliasMigration
Signed-off-by: Peter Krempa
---
tests/qemu-iotests/300 | 91 ++
tests/qemu
See 2/2 for explanation.
Peter Krempa (3):
migration: dirty-bitmap: Convert alias map inner members to
BitmapMigrationBitmapAlias
migration: dirty-bitmap: Allow control of bitmap persistence
qemu-iotests: 300: Add test case for modifying persistence of bitmap
migration/block-dirty
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so pass a copy of the whole
BitmapMigrationBitmapAlias QAPI struct into the map.
Signed-off-by: Peter K
nto a squashed image) but currently it would need to create another set
of persistent bitmaps and merge them.
This patch adds a 'transform' property to the alias map which allows to
override the persistence of migrated bitmaps both on the source and
destination sides.
Signed-off-b
On Wed, Feb 10, 2021 at 18:26:57 +0100, Kevin Wolf wrote:
> Am 08.02.2021 um 19:44 hat Alberto Garcia geschrieben:
> > Hi,
> >
> > this series allows changing bs->file using x-blockdev-reopen. Read
> > here for more details:
> >
> >https://lists.gnu.org/archive/html/qemu-block/2021-01/msg0043
nto a squashed image) but currently it would need to create another set
of persistent bitmaps and merge them.
This patch adds a 'transform' property to the alias map which allows to
override the persistance of migrated bitmaps both on the source and
destination sides.
Signed-off-by: Peter
See 2/2 for explanation.
Peter Krempa (2):
migration: dirty-bitmap: Convert alias map inner members to a struct
migration: dirty-bitmap: Allow control of bitmap persistance
migration/block-dirty-bitmap.c | 73 +-
qapi/migration.json| 20
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so convert the members to a
struct.
Signed-off-by: Peter Krempa
Reviewed-by: Eric Blake
Reviewed-by: Vla
On Wed, Feb 03, 2021 at 14:27:49 +0100, Peter Krempa wrote:
> On Wed, Feb 03, 2021 at 16:23:21 +0300, Vladimir Sementsov-Ogievskiy wrote:
> > 03.02.2021 16:00, Peter Krempa wrote:
> > > Bitmap's source persistence is transported over the migration stream and
> > >
On Wed, Feb 03, 2021 at 16:23:21 +0300, Vladimir Sementsov-Ogievskiy wrote:
> 03.02.2021 16:00, Peter Krempa wrote:
> > Bitmap's source persistence is transported over the migration stream and
> > the destination mirrors it. In some cases the destination might want to
> >
nto a squashed image) but currently it would need to create another set
of persistent bitmaps and merge them.
This adds 'dest-persistent' optional property to
'BitmapMigrationBitmapAlias' which when present overrides the bitmap
presence state from the source.
Signed-off-by: Pet
Currently the alias mapping hash stores just strings of the target
objects internally. In further patches we'll be adding another member
which will need to be stored in the map so convert the members to a
struct.
Signed-off-by: Peter Krempa
---
migration/block-dirty-bitmap.c
See 2/2 for explanation.
Please let me know if I need to add any tests for this.
Peter Krempa (2):
migration: dirty-bitmap: Convert alias map inner members to a struct
migration: dirty-bitmap: Allow control of bitmap persistence on
destination
migration/block-dirty-bitmap.c | 67
On Thu, Jan 07, 2021 at 16:32:59 -0500, Masayoshi Mizuma wrote:
> On Thu, Jan 07, 2021 at 09:05:42AM +0100, Peter Krempa wrote:
> > On Tue, Jan 05, 2021 at 15:12:55 +0100, Peter Krempa wrote:
> > > On Mon, Jan 04, 2021 at 15:30:19 -0500, Masayoshi Mizuma wrote:
> > > &
On Tue, Jan 05, 2021 at 15:12:55 +0100, Peter Krempa wrote:
> On Mon, Jan 04, 2021 at 15:30:19 -0500, Masayoshi Mizuma wrote:
> > On Sat, Dec 19, 2020 at 11:30:39PM -0500, Masayoshi Mizuma wrote:
[...]
> {"execute":"cont"}
>
> So that is a no-go. Some
On Mon, Jan 04, 2021 at 15:30:19 -0500, Masayoshi Mizuma wrote:
> On Sat, Dec 19, 2020 at 11:30:39PM -0500, Masayoshi Mizuma wrote:
[...]
> I think following qemu command line options and QMP commands work for sharing
> the qcow2 disks. The following uses disk hotplug instead of snapshot overlay.
On Thu, Dec 10, 2020 at 17:26:52 +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
Hi,
>
> I have an idea, that not storing backing filename in qcow2 image at all may
> be a good thing. I'll give some reasons and want to know what do you think
> about it.
>
> 1. Libvirt has to manage and k
On Mon, Nov 30, 2020 at 13:25:20 +0100, Kevin Wolf wrote:
> This series adds a QAPI type for the properties of all user creatable
> QOM types and finally makes QMP object-add use the new ObjectOptions
> union so that QAPI introspection can be used for user creatable objects.
FYI, here's a libvirt
---
> blockdev-nbd.c | 6 +-
> nbd/server.c | 19 --
> qemu-nbd.c | 18 -
> 5 files changed, 58 insertions(+), 29 deletions(-)
Reviewed-by: Peter Krempa
On Fri, Oct 23, 2020 at 13:36:46 -0500, Eric Blake wrote:
> Since 'nbd-server-add' is deprecated, and 'block-export-add' is new to
> 5.2, we can still tweak the interface. Allowing 'bitmaps':['str'] is
> nicer than 'bitmap':'str'. This wires up the qapi and qemu-nbd
> changes to permit passing mu
This is a libvirt question, so asking it on the qemu-block might not get
you an answer that quick, ... or ever if I didn't notice your other
question also addressed incorrectly.
[adding libvirt-us...@redhat.com to cc]
On Tue, Sep 01, 2020 at 10:57:34 -0400, Yoonho Park wrote:
> I am trying to per
is great. Does anyone know the patch set that addressed this bug?
qemu patch:
commit facda5443f5a8676fb635b82ac1046ac6b6a67ce
Author: Peter Krempa
Date: Mon Jan 20 09:50:49 2020 +0100
qapi: Allow getting flat output from 'query-named-block-nodes'
When a management application manages node nam
On Tue, Sep 22, 2020 at 18:42:52 +0100, Daniel Berrange wrote:
> On Tue, Sep 22, 2020 at 01:09:06PM -0400, Neal Gompa wrote:
> > On Tue, Sep 22, 2020 at 12:16 PM Daniel P. Berrangé
> > wrote:
> > >
> > > 2 years back I proposed dropping the sheepdog mailing list from the
> > > MAINTAINERS file,
On Thu, Sep 17, 2020 at 09:30:44 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Here is the implementation of transient option for qcow2 and raw format
> disk. This gets available directive in domain xml file
> like as:
>
>
>
>
>
>
>
>
> When
On Thu, Sep 17, 2020 at 09:30:43 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Update validation of transient disk option. The option for qemu is supported
> with under condistions.
>
> - qemu has blockdev feature
> - the type is file and the format is qcow2 and raw
> - writable d
virDomainDiskDefPtr disk = vm->def->disks[i];
> +
> +if (disk->transient) {
> +virReportError(VIR_ERR_OPERATION_INVALID, "%s",
> + _("migration with transient disk is not
> supported"));
transient disk '%s' is not supported
and use disk->dst as '%s'
> +return false;
> +}
> +}
Reviewed-by: Peter Krempa
On Fri, Sep 18, 2020 at 14:53:53 +0200, Peter Krempa wrote:
> On Thu, Sep 17, 2020 at 09:30:40 -0400, Masayoshi Mizuma wrote:
> > From: Masayoshi Mizuma
> >
> > Signed-off-by: Masayoshi Mizuma
> > ---
> > src/qemu/qemu_domain.c | 7 +++
> > 1 file ch
age
could actually describe the reasons.
Reviewed-by: Peter Krempa
On Thu, Sep 17, 2020 at 09:30:40 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Signed-off-by: Masayoshi Mizuma
> ---
> src/qemu/qemu_domain.c | 7 +++
> 1 file changed, 7 insertions(+)
Reviewed-by: Peter Krempa
On Fri, Aug 28, 2020 at 10:08:36 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Block disk hotplug when transient disk option is enabled so far.
>
> Signed-off-by: Masayoshi Mizuma
> ---
> src/qemu/qemu_hotplug.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/
On Fri, Aug 28, 2020 at 10:08:35 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Block migration when transient disk option is enabled because migration
> requires some blockjobs.
>
> Signed-off-by: Masayoshi Mizuma
> ---
> src/qemu/qemu_migration.c | 22 ++
> 1
On Fri, Aug 28, 2020 at 10:08:34 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Block blockjobs when transient disk option is enabled so far.
>
> Signed-off-by: Masayoshi Mizuma
> ---
> src/qemu/qemu_domain.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/qem
On Fri, Aug 28, 2020 at 10:08:33 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Signed-off-by: Masayoshi Mizuma
> ---
> src/qemu/qemu_validate.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c
>
On Fri, Aug 28, 2020 at 10:08:30 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Get available even if snapdisk argument is NULL at
> qemuSnapshotDiskPrepareOne()
> so that the caller can setup dd->src.
>
> Signed-off-by: Masayoshi Mizuma
> ---
> src/qemu/qemu_snapshot.c | 5 +++--
On Fri, Aug 28, 2020 at 10:08:31 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Here is the implementation of transient option for qcow2 and raw format
> disk. This gets available directive in domain xml file
> like as:
>
>
>
>
>
>
>
>
> When
On Wed, Aug 26, 2020 at 15:30:03 +0200, Peter Krempa wrote:
> On Wed, Aug 26, 2020 at 15:18:32 +0200, Kevin Wolf wrote:
> > Am 26.08.2020 um 02:46 hat Yoonho Park geschrieben:
> > > Another issue I hit is that I cannot set or change the cluster size of
> > > overlays. I
On Wed, Aug 26, 2020 at 15:18:32 +0200, Kevin Wolf wrote:
> Am 26.08.2020 um 02:46 hat Yoonho Park geschrieben:
> > Another issue I hit is that I cannot set or change the cluster size of
> > overlays. Is this possible with "virsh snapshot-create-as"?
>
> That's a libvirt question. Peter, can you h
On Thu, Aug 20, 2020 at 09:41:14 -0500, Eric Blake wrote:
> On 8/20/20 6:05 AM, Kevin Wolf wrote:
>
> > As long as we can keep the compatibility code local to qmp_nbd_*(), I
> > don't think it's too bad. In particular because it's already written.
> >
> > Instead of adjusting libvirt to changes i
On Sun, Jul 19, 2020 at 22:56:50 -0400, Masayoshi Mizuma wrote:
> On Sat, Jul 18, 2020 at 08:06:00AM +0200, Peter Krempa wrote:
> > On Thu, Jul 16, 2020 at 20:55:29 -0400, Masayoshi Mizuma wrote:
> > > Thank you for your review.
> > >
> > > On Tue, Jul 07,
inactive_all(), but bdrv_invalidate_cache_all() attempts to reload
> them (which fails, because they are still present in memory).
>
I've tested it with same commands as I've used before and now the 'cont'
succeeds and also the bitmaps after the cont call are loaded and active
at least according to 'query-named-block-nodes'
Tested-by: Peter Krempa
On Thu, Jul 16, 2020 at 20:55:29 -0400, Masayoshi Mizuma wrote:
> Thank you for your review.
>
> On Tue, Jul 07, 2020 at 06:36:23AM -0500, Eric Blake wrote:
> > On 7/7/20 2:12 AM, Peter Krempa wrote:
> >
> > > You can install a qcow2 overlay on top of a raw file t
On Tue, Jul 07, 2020 at 06:36:23 -0500, Eric Blake wrote:
> On 7/7/20 2:12 AM, Peter Krempa wrote:
> >
> > 1) the virDomainBlockCopy operation flattens the backing chain into the
> > top level only. This means that must be stripped or the
> > operation rejected, as oth
On Tue, Jul 07, 2020 at 12:33:31 +0200, Kevin Wolf wrote:
> Am 07.07.2020 um 08:38 hat Peter Krempa geschrieben:
> > On Mon, Jul 06, 2020 at 18:15:55 +0200, Kevin Wolf wrote:
> > > Am 03.07.2020 um 18:02 hat Daniel P. Berrangé geschrieben:
[...]
> > IMO we really wan
On Mon, Jul 06, 2020 at 14:20:25 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Add a unit test for transient option for qcow2 file.
>
> Signed-off-by: Masayoshi Mizuma
> ---
> tests/qemublocktest.c | 10 ++
> .../xml2json/qcow2-transient-srco
On Mon, Jul 06, 2020 at 14:20:23 -0400, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> Here is the implementation of transient option for qcow2 file.
> This gets available directive in domain xml file
> like as:
>
>
>
>
>
>
>
>
> The internal procedu
On Mon, Jul 06, 2020 at 18:15:55 +0200, Kevin Wolf wrote:
> Am 03.07.2020 um 18:02 hat Daniel P. Berrangé geschrieben:
> > On Fri, Jul 03, 2020 at 04:49:33PM +0100, Dr. David Alan Gilbert wrote:
> > > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > > On Thu, Jul 02, 2020 at 01:12:52PM -05
1 - 100 of 241 matches
Mail list logo
