Re: [PATCH] block: support locking on change medium

2024-09-09 Thread Joelle van Dyne
On Mon, Sep 9, 2024 at 2:56 AM Kevin Wolf wrote: > > Am 09.09.2024 um 03:58 hat Joelle van Dyne geschrieben: > > New optional argument for 'blockdev-change-medium' QAPI command to allow > > the caller to specify if they wish to enable file locking. > > > &g

Re: [PATCH] block: support locking on change medium

2024-09-09 Thread Joelle van Dyne
On Mon, Sep 9, 2024 at 12:36 AM Akihiko Odaki wrote: > > On 2024/09/09 10:58, Joelle van Dyne wrote: > > New optional argument for 'blockdev-change-medium' QAPI command to allow > > the caller to specify if they wish to enable file locking. > >

[PATCH] block: support locking on change medium

2024-09-08 Thread Joelle van Dyne
New optional argument for 'blockdev-change-medium' QAPI command to allow the caller to specify if they wish to enable file locking. Signed-off-by: Joelle van Dyne --- qapi/block.json| 23 ++- block/monitor/block-hmp-cmds.c | 2 +- block/qap

Re: [PATCH v3 2/4] block: check for sys/disk.h

2021-03-31 Thread Joelle van Dyne
On Mon, Mar 15, 2021 at 11:03 AM Joelle van Dyne wrote: > > Some BSD platforms do not have this header. > > Reviewed-by: Peter Maydell > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Joelle van Dyne Please bear with me as I am still new to this, but what happens to

Re: [PATCH v3 1/4] block: feature detection for host block support

2021-03-22 Thread Joelle van Dyne
On Mon, Mar 15, 2021 at 11:03 AM Joelle van Dyne wrote: > > On Darwin (iOS), there are no system level APIs for directly accessing > host block devices. We detect this at configure time. > > Signed-off-by: Joelle van Dyne Hi all, this is the last patch in this set that has to be

[PATCH] nvme: expose 'bootindex' property

2021-03-22 Thread Joelle van Dyne
The check for `n->namespace.blkconf.blk` always fails because this is in the initialization function. Signed-off-by: Joelle van Dyne --- hw/block/nvme.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 6842b01ab5..42605fc

[PATCH v3 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use

2021-03-15 Thread Joelle van Dyne
iOS hosts do not have these defined so we fallback to the default behaviour. Co-authored-by: Warner Losh Reviewed-by: Peter Maydell Signed-off-by: Joelle van Dyne --- block/file-posix.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/block/file

[PATCH v3 1/4] block: feature detection for host block support

2021-03-15 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH v3 2/4] block: check for sys/disk.h

2021-03-15 Thread Joelle van Dyne
Some BSD platforms do not have this header. Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Joelle van Dyne --- meson.build | 1 + block.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 59c7c56366

Re: [PATCH] coroutine: add libucontext as external library

2021-03-10 Thread Joelle van Dyne
Good point, I only ran the PC BIOS but it did time out of 56 tests. -j On Wed, Mar 10, 2021 at 1:30 AM Daniel P. Berrangé wrote: > > On Tue, Mar 09, 2021 at 01:21:29PM -0800, Joelle van Dyne wrote: > > On Tue, Mar 9, 2021 at 10:24 AM Joelle van Dyne wrote: > > > > >

Re: [PATCH] coroutine: add libucontext as external library

2021-03-09 Thread Joelle van Dyne
On Tue, Mar 9, 2021 at 10:24 AM Joelle van Dyne wrote: > > On Tue, Mar 9, 2021 at 7:38 AM Stefan Hajnoczi wrote: > > > > On Mon, Mar 08, 2021 at 07:26:36PM -0800, Joelle van Dyne wrote: > > > iOS does not support ucontext natively for aarch64 and the sigaltstack is &

Re: [PATCH] coroutine: add libucontext as external library

2021-03-09 Thread Joelle van Dyne
On Tue, Mar 9, 2021 at 7:38 AM Stefan Hajnoczi wrote: > > On Mon, Mar 08, 2021 at 07:26:36PM -0800, Joelle van Dyne wrote: > > iOS does not support ucontext natively for aarch64 and the sigaltstack is > > also unsupported (even worse, it fails silently, see: > > https

[PATCH v2 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use

2021-03-08 Thread Joelle van Dyne
iOS hosts do not have these defined so we fallback to the default behaviour. Co-authored-by: Warner Losh Signed-off-by: Joelle van Dyne --- block/file-posix.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index

[PATCH v2 2/4] block: check for sys/disk.h

2021-03-08 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build | 1 + block.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 0e53876f69..ba0db9fa1f 100644 --- a/meson.build +++ b/meson.build @@ -1153,6

[PATCH v2 1/4] block: feature detection for host block support

2021-03-08 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH 3/4] block: detect DKIOCGETBLOCKCOUNT/SIZE before use

2021-03-07 Thread Joelle van Dyne
iOS hosts do not have these defined so we fallback to the default behaviour. Co-authored-by: Warner Losh Signed-off-by: Joelle van Dyne --- block/file-posix.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index

[PATCH 2/4] block: check for sys/disk.h

2021-03-07 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build | 1 + block.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 0e53876f69..ba0db9fa1f 100644 --- a/meson.build +++ b/meson.build @@ -1153,6

[PATCH 1/4] block: feature detection for host block support

2021-03-07 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

Re: [PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Joelle van Dyne
of platform defines. So I added the HAS_SYS_DISK_H flag. -j On Mon, Jan 25, 2021 at 8:35 PM Warner Losh wrote: > > > > On Mon, Jan 25, 2021 at 6:33 PM Joelle van Dyne wrote: >> >> Some BSD platforms do not have this header. >> >> Signed-off-by: Joelle van Dyn

[PATCH v9 09/11] block: check availablity for preadv/pwritev on mac

2021-01-25 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

[PATCH v9 01/11] block: feature detection for host block support

2021-01-25 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH v9 03/11] configure: check for sys/disk.h

2021-01-25 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build| 1 + block.c| 2 +- block/file-posix.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 27110075df..6818d97df5 100644 --- a

Re: [PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-23 Thread Joelle van Dyne
Sorry to rephrase this, we would like a single binary to work on both macOS 10.15 and macOS 11 as well as on both iOS 13 and iOS 14 while ALSO supporting preadv/pwritev when running on the newer OS. -j On Sat, Jan 23, 2021 at 12:00 PM Joelle van Dyne wrote: > > The problem here is that we

Re: [PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-23 Thread Joelle van Dyne
21 at 05:03, Joelle van Dyne wrote: > > > > macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure > > will succeed with CONFIG_PREADV even when targeting a lower OS version. > > We therefore need to check at run time if we can actually use these APIs. &g

[PATCH v8 09/11] block: check availablity for preadv/pwritev on mac

2021-01-22 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

[PATCH v8 03/11] configure: check for sys/disk.h

2021-01-22 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- meson.build| 1 + block.c| 2 +- block/file-posix.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 27110075df..6818d97df5 100644 --- a

[PATCH v8 01/11] block: feature detection for host block support

2021-01-22 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- meson.build | 6 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33 ++--- 3

[PATCH v7 03/11] configure: check for sys/disk.h

2021-01-22 Thread Joelle van Dyne
Some BSD platforms do not have this header. Signed-off-by: Joelle van Dyne --- configure | 9 + block.c| 2 +- block/file-posix.c | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 32be5d225d..951de427bb 100755 --- a

[PATCH v7 01/11] block: feature detection for host block support

2021-01-22 Thread Joelle van Dyne
On Darwin (iOS), there are no system level APIs for directly accessing host block devices. We detect this at configure time. Signed-off-by: Joelle van Dyne --- configure| 13 + meson.build | 2 +- qapi/block-core.json | 10 +++--- block/file-posix.c | 33

[PATCH v7 09/11] block: check availablity for preadv/pwritev on mac

2021-01-22 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

Re: [PATCH v6 3/7] qemu: add support for iOS host

2021-01-12 Thread Joelle van Dyne
On Tue, Jan 12, 2021 at 7:03 AM Peter Maydell wrote: > > On Tue, 5 Jan 2021 at 02:25, Joelle van Dyne wrote: > > > > This introduces support for building for iOS hosts. When the correct Xcode > > toolchain is used, iOS host will be detected automatically. > > >

[PATCH v6 7/7] block: check availablity for preadv/pwritev on mac

2021-01-04 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 33

[PATCH v6 3/7] qemu: add support for iOS host

2021-01-04 Thread Joelle van Dyne
bsrv, errp) < 0) { goto error; @@ -785,7 +785,7 @@ void hmp_hostfwd_add(Monitor *mon, const QDict *qdict) } -#ifndef _WIN32 +#if !defined(_WIN32) && !defined(CONFIG_IOS) /* automatic user mode samba server configuration */ static void slirp_smb_cleanup(SlirpState *s) @@ -900,

[PATCH v6 1/7] configure: option to disable host block devices

2021-01-04 Thread Joelle van Dyne
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure| 4 meson.build | 1 + qapi/block-core.json | 10 +++--- block/file-posix.c | 10 +- 4

[PATCH v5 3/7] qemu: add support for iOS host

2020-11-08 Thread Joelle van Dyne
bsrv, errp) < 0) { goto error; @@ -785,7 +785,7 @@ void hmp_hostfwd_add(Monitor *mon, const QDict *qdict) } -#ifndef _WIN32 +#if !defined(_WIN32) && !defined(CONFIG_IOS) /* automatic user mode samba server configuration */ static void slirp_smb_cleanup(SlirpState *s) @@ -900,

[PATCH v5 7/7] block: check availablity for preadv/pwritev on mac

2020-11-08 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12 1

[PATCH v5 1/7] configure: option to disable host block devices

2020-11-08 Thread Joelle van Dyne
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure| 4 meson.build | 1 + qapi/block-core.json | 10 +++--- block/file-posix.c | 10 +- 4

[PATCH v4 7/7] block: check availablity for preadv/pwritev on mac

2020-11-07 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12 1

[PATCH v4 3/7] qemu: add support for iOS host

2020-11-07 Thread Joelle van Dyne
bsrv, errp) < 0) { goto error; @@ -785,7 +785,7 @@ void hmp_hostfwd_add(Monitor *mon, const QDict *qdict) } -#ifndef _WIN32 +#if !defined(_WIN32) && !defined(CONFIG_IOS) /* automatic user mode samba server configuration */ static void slirp_smb_cleanup(SlirpState *s) @@ -900,

[PATCH v4 1/7] configure: option to disable host block devices

2020-11-07 Thread Joelle van Dyne
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure| 4 meson.build | 1 + qapi/block-core.json | 4 +++- block/file-posix.c | 8 +++- 4 files changed

[PATCH v3 7/7] block: check availablity for preadv/pwritev on mac

2020-10-27 Thread Joelle van Dyne
macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12 1

[PATCH v3 3/7] qemu: add support for iOS host

2020-10-27 Thread Joelle van Dyne
() instead of GCC builtin for iOS tests: disable tests on iOS which uses system() Signed-off-by: Joelle van Dyne --- configure | 43 +- meson.build| 2 +- tcg/aarch64/tcg-target.h | 7 ++ block.c

[PATCH v3 1/7] configure: option to disable host block devices

2020-10-27 Thread Joelle van Dyne
Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure | 4 meson.build| 1 + block/file-posix.c | 8 +++- 3 files changed, 12 insertions(+), 1 deletion

[PATCH RESEND v2 9/9] block: check availablity for preadv/pwritev on mac

2020-10-18 Thread Joelle van Dyne
From: osy macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12

[PATCH RESEND v2 3/9] qemu: add support for iOS host

2020-10-18 Thread Joelle van Dyne
sys_icache_invalidate() instead of GCC builtin for iOS tests: disable tests on iOS which uses system() Signed-off-by: Joelle van Dyne --- configure | 43 ++- meson.build | 2 +- tcg/aarch64/tcg-target.h | 10 + block.c

[PATCH RESEND v2 1/9] configure: option to disable host block devices

2020-10-18 Thread Joelle van Dyne
From: osy Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure | 4 meson.build| 1 + block/file-posix.c | 8 +++- 3 files changed, 12 insertions(+), 1

[PATCH v2 9/9] block: check availablity for preadv/pwritev on mac

2020-10-18 Thread Joelle van Dyne
From: osy macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12

[PATCH v2 3/9] qemu: add support for iOS host

2020-10-18 Thread Joelle van Dyne
sys_icache_invalidate() instead of GCC builtin for iOS tests: disable tests on iOS which uses system() Signed-off-by: Joelle van Dyne --- configure | 43 ++- meson.build | 2 +- tcg/aarch64/tcg-target.h | 10 + block.c

[PATCH v2 1/9] configure: option to disable host block devices

2020-10-18 Thread Joelle van Dyne
From: osy Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- configure | 4 meson.build| 1 + block/file-posix.c | 8 +++- 3 files changed, 12 insertions(+), 1

[PATCH 10/10] block: check availablity for preadv/pwritev on mac

2020-10-12 Thread Joelle van Dyne
From: osy macOS 11/iOS 14 added preadv/pwritev APIs. Due to weak linking, configure will succeed with CONFIG_PREADV even when targeting a lower OS version. We therefore need to check at run time if we can actually use these APIs. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 12

[PATCH 03/10] qemu: add support for iOS host

2020-10-12 Thread Joelle van Dyne
sys_icache_invalidate() instead of GCC builtin for iOS tests: disable tests on iOS which uses system() Signed-off-by: Joelle van Dyne --- block.c | 2 +- block/file-posix.c| 30 --- configure | 43

[PATCH 01/10] configure: option to disable host block devices

2020-10-12 Thread Joelle van Dyne
From: osy Some hosts (iOS) have a sandboxed filesystem and do not provide low-level APIs for interfacing with host block devices. Signed-off-by: Joelle van Dyne --- block/file-posix.c | 8 +++- configure | 4 meson.build| 1 + 3 files changed, 12 insertions(+), 1