On 9/10/24 7:15 PM, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
Reviewed-by: Daniel Henrique Barboza
hw/ppc/spapr_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c
index cb05874..38ac1cb7866
\
+g_assert_not_reached();
\
} \
\
if (unlikely((exp < 0) || (exp > max_exp))) { \
Otherwise,
Reviewed-by: Daniel Henrique Barboza
diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
index b0a0676beba..b167b37e0ab 100
On 9/10/24 7:16 PM, Pierrick Bouvier wrote:
Signed-off-by: Pierrick Bouvier
---
Reviewed-by: Daniel Henrique Barboza
target/riscv/monitor.c | 1 -
target/riscv/insn_trans/trans_rvv.c.inc | 2 --
2 files changed, 3 deletions(-)
diff --git a/target/riscv/monitor.c b
a boolean indicating error.
Remove this value to avoid confusion.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Daniel Henrique Barboza
hw/ppc/spapr_rtas_ddw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/spapr_rtas_ddw.c b/hw/ppc/spapr_rtas_ddw.c
index 7ba11382b
On 1/4/23 19:04, Philippe Mathieu-Daudé wrote:
Nothing here requires access to PFlashCFI01 internal fields:
use the inherited generic DeviceState.
Signed-off-by: Philippe Mathieu-Daudé
---
Reviewed-by: Daniel Henrique Barboza
hw/riscv/virt.c | 9 +
include/hw/riscv
On 11/3/22 23:31, BALATON Zoltan wrote:
On Thu, 3 Nov 2022, Daniel Henrique Barboza wrote:
On 11/3/22 09:51, BALATON Zoltan wrote:
On Wed, 2 Nov 2022, Daniel Henrique Barboza wrote:
On 11/1/22 19:29, Philippe Mathieu-Daudé wrote:
This is a respin of Bernhard's v4 with Freescale
On 11/3/22 09:51, BALATON Zoltan wrote:
On Wed, 2 Nov 2022, Daniel Henrique Barboza wrote:
On 11/1/22 19:29, Philippe Mathieu-Daudé wrote:
This is a respin of Bernhard's v4 with Freescale eSDHC implemented
as an 'UNIMP' region. See v4 cover here:
https://lore.kernel
On 11/1/22 19:29, Philippe Mathieu-Daudé wrote:
This is a respin of Bernhard's v4 with Freescale eSDHC implemented
as an 'UNIMP' region. See v4 cover here:
https://lore.kernel.org/qemu-devel/20221018210146.193159-1-shen...@gmail.com/
Since v5:
- Rebased (ppc-next merged)
- Properly handle big
On 10/28/22 19:42, Philippe Mathieu-Daudé wrote:
On 28/10/22 17:09, Daniel Henrique Barboza wrote:
Bernhard,
The 32 builds aren't fancying this patch. The issue is down there:
On 10/18/22 18:01, Bernhard Beschow wrote:
Allows e500 boards to have their root file system reside on
Bernhard,
The 32 builds aren't fancying this patch. The issue is down there:
On 10/18/22 18:01, Bernhard Beschow wrote:
Allows e500 boards to have their root file system reside on flash using
only builtin devices located in the eLBC memory region.
Note that the flash memory area is only create
On 10/27/22 05:21, Bernhard Beschow wrote:
Am 16. September 2022 14:36:05 UTC schrieb "Philippe Mathieu-Daudé"
:
On 12/9/22 21:50, Bernhard Beschow wrote:
Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow :
Testing done:
* `qemu-system-ppc -machine pegasos2 -rtc base=localtime
On 10/26/22 16:51, B wrote:
Am 26. Oktober 2022 17:18:14 UTC schrieb Daniel Henrique Barboza
:
Hi,
Since this is being sent to qemu-ppc and has to do with e500 I decided to
take a look. I acked the e500 related patches, 5 and 7. Patch 6 LGTM as well
but I'd rather not ack it it
Hi,
Since this is being sent to qemu-ppc and has to do with e500 I decided to
take a look. I acked the e500 related patches, 5 and 7. Patch 6 LGTM as well
but I'd rather not ack it it's SD specific code.
I'll send a PowerPC pull request this week. I can grab this series via the ppc
tree if someo
On 10/18/22 18:01, Bernhard Beschow wrote:
Adds missing functionality to e500plat machine which increases the
chance of given "real" firmware images to access SD cards.
Signed-off-by: Bernhard Beschow
---
Reviewed-by: Daniel Henrique Barboza
docs/system/ppc/ppce50
given file. The idea is to
put users into control.
Signed-off-by: Bernhard Beschow
---
Reviewed-by: Daniel Henrique Barboza
docs/system/ppc/ppce500.rst | 16
hw/ppc/Kconfig | 1 +
hw/ppc/e500.c | 79 +
3 files
On 10/9/22 00:30, Bin Meng wrote:
On Sun, Oct 9, 2022 at 12:11 AM Bernhard Beschow wrote:
Am 4. Oktober 2022 12:43:35 UTC schrieb Daniel Henrique Barboza
:
Hey,
On 10/3/22 18:27, Philippe Mathieu-Daudé wrote:
Hi Daniel,
On 3/10/22 22:31, Bernhard Beschow wrote:
Cover letter
Hey,
On 10/3/22 18:27, Philippe Mathieu-Daudé wrote:
Hi Daniel,
On 3/10/22 22:31, Bernhard Beschow wrote:
Cover letter:
~
This series adds support for -pflash and direct SD card access to the
PPC e500 boards. The idea is to increase compatibility with "real" firmware
images where
On 9/19/22 20:17, Bernhard Beschow wrote:
Signed-off-by: Bernhard Beschow
---
Reviewed-by: Daniel Henrique Barboza
And I've queued it in gitlab.com/danielhb/qemu/tree/ppc-next since it's not
tied with the rest of the series. Thanks,
Daniel
include/hw/ppc/spapr.h | 5 +++-
On 9/8/22 05:34, Bernhard Beschow wrote:
Am 1. September 2022 11:41:14 UTC schrieb Bernhard Beschow :
v5:
* Add patch "Inline vt82c686b_southbridge_init() and remove it" (Zoltan)
* Use machine parameter when creating rtc-time alias (Zoltan)
Testing done: Same as in v3.
v4:
* Fix in c
Signed-off-by: Bernhard Beschow
---
Acked-by: Daniel Henrique Barboza
hw/isa/vt82c686.c | 2 --
hw/mips/fuloong2e.c | 4
hw/ppc/pegasos2.c | 4
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index 48cd4d0036..3f9bd0c04d 10
On 9/1/22 08:41, Bernhard Beschow wrote:
The AC97 function's wakeup status is wired to the PM function and both
the AC97 and MC97 interrupt routing is determined by the ISA function.
Signed-off-by: Bernhard Beschow
---
Acked-by: Daniel Henrique Barboza
hw/isa/vt82c686.c
On 9/1/22 08:41, Bernhard Beschow wrote:
The PM controller has activity bits which monitor activity of other
built-in devices in the host device.
Signed-off-by: Bernhard Beschow
---
Acked-by: Daniel Henrique Barboza
hw/isa/vt82c686.c | 13 +
hw/mips/fuloong2e.c
On 9/1/22 08:41, Bernhard Beschow wrote:
Suggested-by: BALATON Zoltan
Signed-off-by: Bernhard Beschow
---
Acked-by: Daniel Henrique Barboza
hw/mips/fuloong2e.c| 4 ++--
hw/ppc/pegasos2.c | 4 ++--
hw/usb/vt82c686-uhci-pci.c | 4 ++--
include/hw/isa/vt82c686.h | 1
On 9/1/22 08:41, Bernhard Beschow wrote:
The USB functions can be enabled/disabled through the ISA function. Also
its interrupt routing can be influenced there.
Signed-off-by: Bernhard Beschow
---
Acked-by: Daniel Henrique Barboza
hw/isa/vt82c686.c | 12
hw/mips
Henrique Barboza
configs/devices/mips64el-softmmu/default.mak | 1 -
hw/isa/Kconfig | 1 +
hw/isa/vt82c686.c| 17 +
hw/mips/fuloong2e.c | 8
hw/ppc/Kconfig
On 9/1/22 08:41, Bernhard Beschow wrote:
Establishes consistency with other (VIA) devices.
Signed-off-by: Bernhard Beschow
---
Acked-by: Daniel Henrique Barboza
hw/ide/via.c | 2 +-
hw/mips/fuloong2e.c | 2 +-
hw/ppc/pegasos2.c | 2 +-
include/hw/isa
On 6/14/22 07:40, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert"
Inspired by Julia Lawall's fixing of Linux
kernel comments, I looked at qemu, although I did it manually.
Signed-off-by: Dr. David Alan Gilbert
---
Reviewed-by: Daniel Henrique Barbo
by initializing the QDict variable with NULL.
Signed-off-by: Murilo Opsfelder Araujo
Cc: Kevin Wolf
Cc: Hanna Reitz
Cc: Markus Armbruster
---
Reviewed-by: Daniel Henrique Barboza
qobject/block-qdict.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qobject/block
Ping
On 1/30/20 6:39 PM, Daniel Henrique Barboza wrote:
The version 8 of this patch series got buried and it's now
conflicting with master. Rebase and re-sending it.
Also, I contemplated the idea of moving/copying the password
verification in qcrypto_block_luks_create() all the way back t
7;bdrv_co_delete_file' will be already in co_routine context, thus there
is no need to add all the machinery to check for qemu_in_coroutine() and
create a separated co_routine to do the job.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Daniel Henrique Barbo
.
All that said, I believe that this patch series presents a sane
solution with the code we have ATM.
changes in this version:
- rebase with current master at 204aa60b37
- previous version:
https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg01551.html
Daniel Henrique Barboza (4):
elete_file' interface to block
drivers and add it to the 'file' driver in file-posix.c. The
implementation is given by 'raw_co_delete_file'.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Daniel Henrique Barboza
---
block/file-posix.c| 23
.
* in our case, block_crypto_co_create_generic calls qcrypto_block_create,
which calls qcrypto_block_luks_create, and this function fails when
calling qcrypto_secret_lookup_as_utf8.
Reported-by: Srikanth Aithal
Suggested-by: Kevin Wolf
Signed-off-by: Daniel Henrique Barboza
---
block/crypt
This patch adds a new test file to exercise the case where
qemu-img fails to complete for the LUKS format when a non-UTF8
secret is used.
Signed-off-by: Daniel Henrique Barboza
---
tests/qemu-iotests/282 | 67 ++
tests/qemu-iotests/282.out | 11
'out4' can be replaced by 'return 2'.
CC: Kevin Wolf
CC: Max Reitz
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
qemu-img.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 6233b8ca56..fc7b08e7
'out' can be replaced by 'return ret' and 'return -ECANCELED'.
CC: John Snow
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/backup.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/block/backup.c b/b
Both the 'fail' label and 'ret' variable can be removed from the
function. Instead, call 'return -EINVAL' in the error conditions.
CC: Stefan Hajnoczi
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/dmg.c | 10 ++
1 file changed
The 'fail' label can be replaced by 'return ret' or by
a 'return' with the error code that was being set right
before the 'goto' call.
CC: Stefan Weil
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/vdi.c | 40 +---
'exit' label of vhdx_region_check() and vhdx_update_header()
can be replaced by 'return' statements.
CC: Jeff Cody
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/vhdx.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --
'error' can be replaced by 'return -1' directly.
CC: Kevin Wolf
CC: Max Reitz
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
crypto/block-luks.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/crypto/block-luks.c b/crypt
'exit' label from vmdk_open_desc_file() can be replaced by
'return' calls with the appropriate value. Same thing with
the 'out' label from vmdk_co_create().
CC: Fam Zheng
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique B
'exit' label in find_allocation() can be replaced by a
'return -ENOTSUP' call.
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/gluster.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/gluster.c b/block/gluste
Removing some 'exit' labels used in some functions that are
unneeded, changing them for the adequate 'return' value
for the context.
CC: Jeff Cody
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/vhdx-log.c | 86 ++--
'out' is just a 'return' call.
CC: Kevin Wolf
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/vxhs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/vxhs.c b/block/vxhs.c
index d79fc97df6..e3db367918 100644
--- a/bloc
'fail' label can be replaced by 'return ret' on error and
'return 0' in the end of the function.
CC: Kevin Wolf
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/vpc.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
di
The 'out' labels for check_host_key_knownhosts() and authenticate()
functions can be removed and, instead, call 'return' with the
appropriate return value. The 'ret' integer from both functions
could also be removed.
CC: Richard W.M. Jones
CC: qemu-block@nongnu.org
'fail' label can be replaced by 'return ret' and 'return -ENOMEM'
calls.
CC: Kevin Wolf
CC: Max Reitz
CC: qemu-block@nongnu.org
Signed-off-by: Daniel Henrique Barboza
---
block/qcow2-refcount.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --
'out' label from cdrom_probe_device() can be removed, and its
only instance replaced by 'return prio'.
In raw_co_create(), 'out' can be replaced by 'return -errno' in
the error condition it is being called.
CC: Kevin Wolf
CC: qemu-block@nongnu.or
Hi John,
On 5/13/19 4:47 PM, John Snow wrote:
It looks like this one has gone un-noticed for a little while.
On 3/26/19 5:17 PM, Daniel Henrique Barboza wrote:
Adding to Block Drivers the capability of being able to clean up
its created files can be useful in certain situations. For the
LUKS
Ping
On 3/26/19 6:17 PM, Daniel Henrique Barboza wrote:
In this new interation, the following changes were made from
the previous version [1]:
- moved the 'generic' code from block.c to file-posix.c
- moved the file delete call from qemu_img to the error path
of block_crypto_co_create
LUKS in a later patch.
Foreseeing this future use, let's put it in block.c and make it
public.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Daniel Henrique Barboza
---
block.c | 11 +++
block/file-posix.c| 28
include/block/
d function
bdrv_delete_co_entry is used to call the bdrv_co_delete_file
co-routine of the driver, if the driver implements it.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Daniel Henrique Barboza
---
block.c | 71 +++
include/block/block.h | 2 +
el/2019-03/msg06444.html
Daniel Henrique Barboza (3):
block: introducing 'bdrv_co_delete_file' interface
block.c: adding bdrv_delete_file
crypto.c: cleanup created file when block_crypto_co_create_opts_luks
fails
block.c | 82 ++
.
Reported-by: Srikanth Aithal
Suggested-by: Kevin Wolf
Signed-off-by: Daniel Henrique Barboza
---
block/crypto.c | 31 +++
1 file changed, 31 insertions(+)
diff --git a/block/crypto.c b/block/crypto.c
index 3af46b805f..7c1b80616c 100644
--- a/block/crypto.c
+++ b/blo
On 3/25/19 9:10 AM, Kevin Wolf wrote:
Am 22.03.2019 um 18:52 hat Daniel Henrique Barboza geschrieben:
Adding to Block Drivers the capability of being able to clean up
its created files can be useful in certain situations. For the
LUKS driver, for instance, a failure in one of its
On 3/22/19 4:02 PM, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20190322175241.5954-1-danielhb...@gmail.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can pro
that deals with local files, but I thought it would be overkill -
at least for this second spin.
[1] https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05899.html
Daniel Henrique Barboza (3):
block: introducing 'bdrv_co_delete_file' interface
block.c: adding bdrv_delete_fi
aniel P. Berrangé
Signed-off-by: Daniel Henrique Barboza
---
block.c | 45 +++
block/crypto.c| 2 ++
include/block/block.h | 3 +++
include/block/block_int.h | 6 ++
4 files changed, 56 insertions(+)
diff --git
is created if needed, a specialized function
bdrv_delete_co_entry is used to call the bdrv_co_delete_file
co-routine of the driver, if the driver implements it.
Suggested-by: Daniel P. Berrangé
Signed-off-by: Daniel Henrique Barboza
---
@Daniel: I put the 'Suggested-by' tag here awar
hal
Suggested-by: Daniel P. Berrangé
Signed-off-by: Daniel Henrique Barboza
---
qemu-img.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/qemu-img.c b/qemu-img.c
index 5fac840742..03b139b4ac 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -422,11 +4
On 3/20/19 6:52 AM, Daniel P. Berrangé wrote:
On Tue, Mar 19, 2019 at 07:03:30PM -0300, Daniel Henrique Barboza wrote:
When using a non-UTF8 secret to create a volume using qemu-img, the
following error happens:
$ qemu-img create -f luks --object
secret,id=vol_1_encrypt0,file
in our case, block_crypto_co_create_generic calls qcrypto_block_create,
which calls qcrypto_block_luks_create, and this function fails when
calling qcrypto_secret_lookup_as_utf8.
Reported-by: Srikanth Aithal
Signed-off-by: Daniel Henrique Barboza
---
block/crypto.c | 9 +
1 file chang
On 05/24/2018 11:04 AM, Stefan Hajnoczi wrote:
On Tue, May 15, 2018 at 06:25:46PM -0300, Daniel Henrique Barboza wrote:
This means that the test executed a write at LBA 0x94fa and, after
confirming that the write was completed, issue 2 reads in the same LBA to
assert the written contents and
On 05/16/2018 06:35 PM, Daniel Henrique Barboza wrote:
On 05/16/2018 04:47 AM, Paolo Bonzini wrote:
On 15/05/2018 23:25, Daniel Henrique Barboza wrote:
This is the current status of this investigation. I decided to start a
discussion here, see if someone can point me something that I
On 05/16/2018 06:47 AM, Dr. David Alan Gilbert wrote:
* Daniel Henrique Barboza (danie...@linux.ibm.com) wrote:
Hi,
I've been working in the last two months in a miscompare issue that happens
when using a raid device and a SATA as scsi-hd (emulated SCSI) with
cache=none and io=threads d
On 05/16/2018 04:47 AM, Paolo Bonzini wrote:
On 15/05/2018 23:25, Daniel Henrique Barboza wrote:
This is the current status of this investigation. I decided to start a
discussion here, see if someone can point me something that I overlooked
or got it wrong, before I started changing the POSIX
Hi,
I've been working in the last two months in a miscompare issue that
happens when using a raid device and a SATA as scsi-hd (emulated SCSI)
with cache=none and io=threads during a hardware stress test. I'll
summarize it here as best as I can without creating a great wall of text
- Red Hat
67 matches
Mail list logo
