Re: [PATCH 1/2] rust: Add antoher variant for impl_vmstate_struct! macro

2025-08-01 Thread Paolo Bonzini
Il ven 1 ago 2025, 17:00 Martin Kletzander ha scritto: > From: Martin Kletzander > > In some cases (e.g. in vmstate_tests.rs) the second argument to > impl_vmstate_struct! is actually an existing struct which is then > copied (since VMStateDescription implements Copy) when saved into the > stati

Re: [PATCH 2/2] tests/qemu-iotests: Indent expected error messages

2025-08-01 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Aug 01, 2025 at 04:59:50PM +0200, Martin Kletzander wrote: >> From: Martin Kletzander >> >> When running all tests the expected "killed" messages are indented >> differently than the actual ones, by three more spaces. Change it so >> that the messages match

[QEMU/FUSE] Discussion on Proper Termination and Async Cancellation in fuse-over-io_uring

2025-08-01 Thread Brian Song
Hi Bernd, We are currently working on implementing termination support for fuse-over-io_uring in QEMU, and right now we are focusing on how to clean up in-flight SQEs properly. Our main question is about how well the kernel supports robust cancellation for these fuse-over-io_uring SQEs. Does

Re: [PATCH 2/2] tests/qemu-iotests: Indent expected error messages

2025-08-01 Thread Daniel P . Berrangé
On Fri, Aug 01, 2025 at 04:59:50PM +0200, Martin Kletzander wrote: > From: Martin Kletzander > > When running all tests the expected "killed" messages are indented > differently than the actual ones, by three more spaces. Change it so > that the messages match and tests pass. This would break t

[PATCH 1/2] rust: Add antoher variant for impl_vmstate_struct! macro

2025-08-01 Thread Martin Kletzander
From: Martin Kletzander In some cases (e.g. in vmstate_tests.rs) the second argument to impl_vmstate_struct! is actually an existing struct which is then copied (since VMStateDescription implements Copy) when saved into the static VMSD using .get(). That is not a problem because it is part of th

[PATCH 0/2] Few fixes I found when building QEMU with Rust

2025-08-01 Thread Martin Kletzander
I'm fairly sure the first one is alright, but I must admit I have no idea why is the second patch needed on my system. For both patches, please take them with a grain of salt and feel free to prove me wrong with anything. This used to be a bigger series until I rebased on top of Paolo's rust-next

[PATCH 2/2] tests/qemu-iotests: Indent expected error messages

2025-08-01 Thread Martin Kletzander
From: Martin Kletzander When running all tests the expected "killed" messages are indented differently than the actual ones, by three more spaces. Change it so that the messages match and tests pass. Signed-off-by: Martin Kletzander --- tests/qemu-iotests/039.out | 10 +- tests/qemu-i

[PATCH] hw/nvme: cap MDTS value for internal limitation

2025-08-01 Thread Keith Busch
From: Keith Busch The emulated device had let the user set whatever max transfers size they wanted, including no limit. However the device does have an internal limit of 1024 segments. NVMe doesn't report max segments, though. This is implicitly inferred based on the MDTS and MPSMIN values. IOV_

[PATCH trivial] tests/qemu-iotests/tests/mirror-sparse: skip if O_DIRECT is not supported

2025-08-01 Thread Michael Tokarev
This test uses cache.direct=true, but does not check if O_DIRECT is supported by the underlying filesystem, and fails, for example, on a tmpfs (which is rather common on various auto-builders, in CI, etc). Fix this by using _require_o_direct. This example shows where our testing framework is sign

Re: [PATCH v3 10/11] tests: Add iotest mirror-sparse for recent patches

2025-08-01 Thread Michael Tokarev
On 25.04.2025 03:52, Eric Blake wrote: Prove that blockdev-mirror can now result in sparse raw destination files, regardless of whether the source is raw or qcow2. By making this a separate test, it was possible to test effects of individual patches for the various pieces that all have to work t