Re: QEMU Community Call Agenda Items (July 9th, 2024)

2024-07-08 Thread Markus Armbruster
Cc: Block layer core maintainers Philippe Mathieu-Daudé writes: > On 8/7/24 16:58, Alex Bennée wrote: >> Hi, >> The KVM/QEMU community call is at: >>https://meet.jit.si/kvmcallmeeting >>@ >>9/7/2024 14:00 UTC >> Are there any agenda items for the sync-up? > > - I don't remember who m

[PATCH v8 06/10] block/nvme: add reservation command protocol constants

2024-07-08 Thread Changqi Lu
Add constants for the NVMe persistent command protocol. The constants include the reservation command opcode and reservation type values defined in section 7 of the NVMe 2.0 specification. Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- include/block/nvme.h

[PATCH v8 10/10] block/iscsi: add persistent reservation in/out driver

2024-07-08 Thread Changqi Lu
Add persistent reservation in/out operations for iscsi driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: z

[PATCH v8 04/10] scsi/util: add helper functions for persistent reservation types conversion

2024-07-08 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the persistent reservation types used in the SCSI protocol and those used in the block layer. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: Stefan Hajnoczi --- include/scsi/utils.h | 8 +

[PATCH v8 09/10] hw/nvme: add reservation protocal command

2024-07-08 Thread Changqi Lu
Add reservation acquire, reservation register, reservation release and reservation report commands in the nvme device layer. By introducing these commands, this enables the nvme device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservati

[PATCH v8 05/10] hw/scsi: add persistent reservation in/out api for scsi device

2024-07-08 Thread Changqi Lu
Add persistent reservation in/out operations in the SCSI device layer. By introducing the persistent reservation in/out api, this enables the SCSI device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservation keys, initiating and releasin

[PATCH v8 08/10] hw/nvme: enable ONCS and rescap function

2024-07-08 Thread Changqi Lu
This commit enables ONCS to support the reservation function at the controller level. Also enables rescap function in the namespace by detecting the supported reservation function in the backend driver. Reviewed-by: Klaus Jensen Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/c

[PATCH v8 07/10] hw/nvme: add helper functions for converting reservation types

2024-07-08 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the reservation types used in the NVME protocol and those used in the block layer. Reviewed-by: Klaus Jensen Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/nvme.h |

[PATCH v8 00/10] Support persistent reservation operations

2024-07-08 Thread Changqi Lu
Sorry, due to network problems, the patch I sent earlier was incomplete. Stefan, the issue you mentioned has been fixed. Almost all patches have been reviewed, thank you very much to Stefan and Klaus. v7->v8: - Fix num_keys may be less than 0 at scsi_pr_read_keys_complete(). - Fix buf memory le

[PATCH v8 03/10] scsi/constant: add persistent reservation in/out protocol constants

2024-07-08 Thread Changqi Lu
Add constants for the persistent reservation in/out protocol in the scsi/constant module. The constants include the persistent reservation command, type, and scope values defined in sections 6.13 and 6.14 of the SCSI Primary Commands-4 (SPC-4) specification. Signed-off-by: Changqi Lu Signed-off-b

[PATCH v8 02/10] block/raw: add persistent reservation in/out driver

2024-07-08 Thread Changqi Lu
Add persistent reservation in/out operations for raw driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: zhe

[PATCH v8 01/10] block: add persistent reservation in/out api

2024-07-08 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

Re: [PATCH v2 09/15] memory: Do not create circular reference with subregion

2024-07-08 Thread Peter Xu
On Mon, Jul 08, 2024 at 10:06:44AM +0200, Philippe Mathieu-Daudé wrote: > On 6/7/24 13:59, Akihiko Odaki wrote: > > On 2024/07/03 2:44, Peter Xu wrote: > > > On Thu, Jun 27, 2024 at 10:37:52PM +0900, Akihiko Odaki wrote: > > > > A memory region does not use their own reference counters, but instead

Re: [PATCH] hw/nvme: Add support for setting the MQES for the NVMe emulation

2024-07-08 Thread Berg, John
On Wed, 2024-05-01 at 14:35 +0200, Klaus Jensen wrote: > On May  1 12:27, Berg, John wrote: > > On Thu, 2024-04-04 at 15:01 +0200, Klaus Jensen wrote: > > > On Apr  4 13:04, John Berg wrote: > > > > From: John Berg > > > > > > > > The MQES field in the CAP register describes the Maximum Queue > >

Re: [PATCH v2 06/15] ppc/vof: Fix unaligned FDT property access

2024-07-08 Thread Peter Maydell
On Mon, 8 Jul 2024 at 08:49, Nicholas Piggin wrote: > > On Sun Jul 7, 2024 at 9:46 AM AEST, David Gibson wrote: > > On Sat, Jul 06, 2024 at 11:37:08AM +0100, Peter Maydell wrote: > > > On Fri, 5 Jul 2024 at 06:13, David Gibson > > > wrote: > > > > Huh.. well I'm getting different impressions of

Re: [PATCH v8 00/10] Support persistent reservation operations

2024-07-08 Thread 卢长奇
Hi, I am sorry. There may be a problem with the mailbox server, and all emails cannot be send out. Please ignore the above emails. From: "Changqi Lu" Date: Mon, Jul 8, 2024, 21:01 Subject: [PATCH v8 00/10] Support persistent reservation operations To: , Cc: , , , < f...@euphon.net>, , , < p...@d

[PATCH v8 00/10] Support persistent reservation operations

2024-07-08 Thread Changqi Lu
Stefan, the issue you mentioned has been fixed. Almost all patches have been reviewed, thank you very much to Stefan and Klaus. v7->v8: - Fix num_keys may be less than 0 at scsi_pr_read_keys_complete(). - Fix buf memory leak at iscsi driver. v6->v7: - Add buferlen size check at SCSI layer. - Ad

[PATCH v8 01/10] block: add persistent reservation in/out api

2024-07-08 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

[PATCH v8 02/10] block/raw: add persistent reservation in/out driver

2024-07-08 Thread Changqi Lu
Add persistent reservation in/out operations for raw driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: zhe

[PATCH v8 03/10] scsi/constant: add persistent reservation in/out protocol constants

2024-07-08 Thread Changqi Lu
Add constants for the persistent reservation in/out protocol in the scsi/constant module. The constants include the persistent reservation command, type, and scope values defined in sections 6.13 and 6.14 of the SCSI Primary Commands-4 (SPC-4) specification. Signed-off-by: Changqi Lu Signed-off-b

[PATCH v8 04/10] scsi/util: add helper functions for persistent reservation types conversion

2024-07-08 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the persistent reservation types used in the SCSI protocol and those used in the block layer. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: Stefan Hajnoczi --- include/scsi/utils.h | 8 +

[PATCH v8 00/10] Support persistent reservation operations

2024-07-08 Thread Changqi Lu
Stefan, the issue you mentioned has been fixed. Almost all patches have been reviewed, thank you very much to Stefan and Klaus. v7->v8: - Fix num_keys may be less than 0 at scsi_pr_read_keys_complete(). - Fix buf memory leak at iscsi driver. v6->v7: - Add buferlen size check at SCSI layer. - Ad

[PATCH v8 01/10] block: add persistent reservation in/out api

2024-07-08 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

Re: [PULL 0/1] ufs queue

2024-07-08 Thread Jeuk Kim
://github.com/philmd/qemu into staging (2024-07-07 10:34:52 -0700) are available in the Git repository at: https://gitlab.com/jeuk20.kim/qemu.git tags/pull-ufs-20240708 for you to fetch changes up to 6db492596dd9204e8fe341b2396472271cf15023: hw/ufs: Fix mcq register range determination log

Re: [PATCH v7 00/10] Support persistent reservation operations

2024-07-08 Thread Stefan Hajnoczi
On Fri, Jul 05, 2024 at 06:56:04PM +0800, Changqi Lu wrote: > Hi, > > Patch v7 has been modified. > Thanks again to Stefan for reviewing the code. > > v6->v7: > - Add buferlen size check at SCSI layer. > - Add pr_cap calculation in bdrv_merge_limits() function at block layer, > so the ugly bs->

Re: [PATCH v7 06/10] block/nvme: add reservation command protocol constants

2024-07-08 Thread Stefan Hajnoczi
On Fri, Jul 05, 2024 at 06:56:10PM +0800, Changqi Lu wrote: > Add constants for the NVMe persistent command protocol. > The constants include the reservation command opcode and > reservation type values defined in section 7 of the NVMe > 2.0 specification. > > Signed-off-by: Changqi Lu > Signed-o

Re: [PATCH v7 10/10] block/iscsi: add persistent reservation in/out driver

2024-07-08 Thread Stefan Hajnoczi
On Fri, Jul 05, 2024 at 06:56:14PM +0800, Changqi Lu wrote: > Add persistent reservation in/out operations for iscsi driver. > The following methods are implemented: bdrv_co_pr_read_keys, > bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, > bdrv_co_pr_release, bdrv_co_pr_clear

Re: [PATCH v2 09/15] memory: Do not create circular reference with subregion

2024-07-08 Thread Akihiko Odaki
On 2024/07/08 17:06, Philippe Mathieu-Daudé wrote: On 6/7/24 13:59, Akihiko Odaki wrote: On 2024/07/03 2:44, Peter Xu wrote: On Thu, Jun 27, 2024 at 10:37:52PM +0900, Akihiko Odaki wrote: A memory region does not use their own reference counters, but instead piggybacks on another QOM object, "

Re: [PATCH v7 07/10] hw/nvme: add helper functions for converting reservation types

2024-07-08 Thread Klaus Jensen
On Jul 5 18:56, Changqi Lu wrote: > This commit introduces two helper functions > that facilitate the conversion between the > reservation types used in the NVME protocol > and those used in the block layer. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Changqi Lu > Signed-off-by: zhenwei p

Re: [PATCH v7 08/10] hw/nvme: enable ONCS and rescap function

2024-07-08 Thread Klaus Jensen
On Jul 5 18:56, Changqi Lu wrote: > This commit enables ONCS to support the reservation > function at the controller level. Also enables rescap > function in the namespace by detecting the supported reservation > function in the backend driver. > > Signed-off-by: Changqi Lu > Signed-off-by: zhen

Re: [PATCH v7 08/10] hw/nvme: enable ONCS and rescap function

2024-07-08 Thread Stefan Hajnoczi
On Fri, Jul 05, 2024 at 06:56:12PM +0800, Changqi Lu wrote: > This commit enables ONCS to support the reservation > function at the controller level. Also enables rescap > function in the namespace by detecting the supported reservation > function in the backend driver. > > Signed-off-by: Changqi

Re: [PATCH v7 05/10] hw/scsi: add persistent reservation in/out api for scsi device

2024-07-08 Thread Stefan Hajnoczi
On Fri, Jul 05, 2024 at 06:56:09PM +0800, Changqi Lu wrote: > Add persistent reservation in/out operations in the > SCSI device layer. By introducing the persistent > reservation in/out api, this enables the SCSI device > to perform reservation-related tasks, including querying > keys, querying res

Re: [PATCH v2 09/15] memory: Do not create circular reference with subregion

2024-07-08 Thread Philippe Mathieu-Daudé
On 6/7/24 13:59, Akihiko Odaki wrote: On 2024/07/03 2:44, Peter Xu wrote: On Thu, Jun 27, 2024 at 10:37:52PM +0900, Akihiko Odaki wrote: A memory region does not use their own reference counters, but instead piggybacks on another QOM object, "owner" (unless the owner is not the memory region it

Re: [PATCH 3/4] hw/pci: Convert rom_bar into OnOffAuto

2024-07-08 Thread Daniel P . Berrangé
On Sat, Jul 06, 2024 at 06:29:23PM +0900, Akihiko Odaki wrote: > rom_bar is tristate but was defined as uint32_t so convert it into > OnOffAuto to clarify that. For compatibility, a uint32 value set via > QOM will be converted into OnOffAuto. > > Signed-off-by: Akihiko Odaki > --- > docs/igd-ass

Re: [PATCH v2 06/15] ppc/vof: Fix unaligned FDT property access

2024-07-08 Thread Nicholas Piggin
On Sun Jul 7, 2024 at 9:46 AM AEST, David Gibson wrote: > On Sat, Jul 06, 2024 at 11:37:08AM +0100, Peter Maydell wrote: > > On Fri, 5 Jul 2024 at 06:13, David Gibson > > wrote: > > > > > > On Fri, Jul 05, 2024 at 02:40:19PM +1000, Nicholas Piggin wrote: > > > > On Fri Jul 5, 2024 at 11:41 AM AES

Re: [PATCH v3 9/9] tests/qtest: Delete previous boot file

2024-07-08 Thread Thomas Huth
On 08/07/2024 08.55, Akihiko Odaki wrote: A test run may create boot files several times. Delete the previous boot file before creating a new one. Signed-off-by: Akihiko Odaki Reviewed-by: Michael S. Tsirkin --- tests/qtest/migration-test.c | 18 +++--- 1 file changed, 11 insert

Re: [PATCH v2 00/11] qcow2: make subclusters discardable

2024-07-08 Thread Andrey Drobyshev
On 6/24/24 10:43 AM, Andrey Drobyshev wrote: > On 6/17/24 9:39 AM, Andrey Drobyshev wrote: >> On 6/10/24 11:53 AM, Andrey Drobyshev wrote: >>> On 6/3/24 12:19 PM, Andrey Drobyshev wrote: On 5/13/24 9:31 AM, Andrey Drobyshev wrote: > v1: https://lists.nongnu.org/archive/html/qemu-devel/2023