On Sep 16 18:30, Klaus Jensen wrote:
> On Sep 16 14:41, Kevin Wolf wrote:
> > Am 14.09.2021 um 22:37 hat Klaus Jensen geschrieben:
> > > From: Klaus Jensen
> > >
> > > Hi,
> > >
> > > This is an attempt at adressing a bunch of issues that have presented
> > > themselves since we added subsystem
(But continue to support the old ones for now, too.)
There are very few cases of any user of QEMUMachine or a subclass
thereof relying on a QMP Exception type. If you'd like to check for
yourself, you want to grep for all of the derivatives of QMPError,
excluding 'AQMPError' and its derivatives. T
This is a wrapper around the async QMPClient that mimics the old,
synchronous QEMUMonitorProtocol class. It is designed to be
interchangeable with the old implementation.
It does not, however, attempt to mimic Exception compatibility.
Signed-off-by: John Snow
---
python/qemu/aqmp/legacy.py | 13
This allows 'Greeting' to be subclass of 'Message'. We need the adapter
classes to avoid some typing problems that occur if we try to put too
much into the 'Model' class itself; the exact details of why are left as
an exercise to the reader.
Why bother? This makes 'Greeting' ⊆ 'Message', which is
If we spy on the QMP commands instead, we don't need callers to remember
to pass it. Seems like a fair trade-off.
The one slightly weird bit is overloading this instance variable for
wait(), where we use it to mean "don't issue the qmp 'quit'
command". This means that wait() will "fail" if the QEM
To use the AQMP backend, Machine just needs to be a little more diligent
about what happens when closing a QMP connection. The operation is no
longer a freebie in the async world.
Because async QMP continues to check for messages asynchronously, it's
almost certainly likely that the loop will have
On Thu, Sep 16, 2021 at 12:10 AM John Snow wrote:
> GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/371611883
> Based-On: <20210915175318.853225-1-hre...@redhat.com>
> "[PULL 00/32] Block patches"
>
> Since iotests ar
The scary message interferes with the iotests output. Coincidentally, if
iotests works by removing this, then it's good evidence that we don't
really need to scare people away from using it.
Signed-off-by: John Snow
---
python/qemu/aqmp/__init__.py | 14 --
1 file changed, 14 deletio
Swap out the synchronous QEMUMonitorProtocol from qemu.qmp with the sync
wrapper from qemu.aqmp instead.
Add an escape hatch in the form of the environment variable
QEMU_PYTHON_LEGACY_QMP which allows you to cajole QEMUMachine into using
the old interface, proving that both implementations work co
Disable the aqmp logger, which likes to (at the moment) print out
intermediate warnings and errors that cause session termination; disable
them so they don't interfere with the job output.
Leave any "CRITICAL" warnings enabled though, those are ones that we
should never see, no matter what.
Signe
It turns out you can do this directly from Python ... and because of
this, you don't need to worry about setting the inheritability of the
fds or spawning another process.
Doing this is helpful because it allows QEMUMonitorProtocol to keep its
file descriptor and socket object as private implement
It's not used anymore, now.
Signed-off-by: John Snow
---
tests/qemu-iotests/socket_scm_helper.c | 136 -
python/qemu/machine/machine.py | 3 -
python/qemu/machine/qtest.py | 2 -
tests/Makefile.include | 1 -
tests/meson.build
All callers in the tree *already* clear the events after a call to
get_events(). Do it automatically instead and update callsites to remove
the manual clear call.
These semantics are quite a bit easier to emulate with async QMP, and
nobody appears to be abusing some emergent properties of what hap
The single space is indeed required to successfully transmit the file
descriptor to QEMU.
Signed-off-by: John Snow
---
python/qemu/aqmp/qmp_client.py | 17 +
1 file changed, 17 insertions(+)
diff --git a/python/qemu/aqmp/qmp_client.py b/python/qemu/aqmp/qmp_client.py
index d2ad7
Synchronous clients may want to know if they're about to block waiting
for an event or not. A method such as this is necessary to implement a
compatible interface for the old QEMUMonitorProtocol using the new async
internals.
Signed-off-by: John Snow
---
python/qemu/aqmp/events.py | 6 ++
1
Expose the greeting as a read-only property of QMPClient so it can be
retrieved at-will.
Signed-off-by: John Snow
---
python/qemu/aqmp/qmp_client.py | 5 +
1 file changed, 5 insertions(+)
diff --git a/python/qemu/aqmp/qmp_client.py b/python/qemu/aqmp/qmp_client.py
index 82e9dab124..d2ad7459
Based-on: <20210916220716.1353698-1-js...@redhat.com>
Based-on: <20210915162955.333025-1-js...@redhat.com>
[PULL 0/2] Python patches
[PATCH v4 00/27] python: introduce Asynchronous QMP package
Hiya,
This series continues where the first AQMP series left off and adds a
synchron
This serves two purposes:
(1) It is now possible to discern whether or not clear() removed any
event(s) from the queue with absolute certainty, and
(2) It is now very easy to get a List of all pending events in one
chunk, which is useful for the sync bridge.
Signed-off-by: John Snow
---
python
I think either -global or -global-state.
Paolo
Il gio 16 set 2021, 16:03 Emanuele Giuseppe Esposito
ha scritto:
>
>
> On 15/09/2021 16:43, Stefan Hajnoczi wrote:
> > On Wed, Sep 15, 2021 at 02:11:41PM +0200, Paolo Bonzini wrote:
> >> On 13/09/21 15:10, Stefan Hajnoczi wrote:
> >>> On Wed, Sep
On Sep 16 09:06, Keith Busch wrote:
> On Tue, Sep 14, 2021 at 10:37:26PM +0200, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > Move ZNS related helpers and types into zoned.h. Use a common prefix
> > (nvme_zoned or nvme_ns_zoned) for zns related functions.
>
> Just a nitpicks on the naming,
On Sep 16 14:41, Kevin Wolf wrote:
> Am 14.09.2021 um 22:37 hat Klaus Jensen geschrieben:
> > From: Klaus Jensen
> >
> > Hi,
> >
> > This is an attempt at adressing a bunch of issues that have presented
> > themselves since we added subsystem support. It's been brewing for a
> > while now.
> >
On Tue, Sep 14, 2021 at 10:37:26PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Move ZNS related helpers and types into zoned.h. Use a common prefix
> (nvme_zoned or nvme_ns_zoned) for zns related functions.
Just a nitpicks on the naming, you can feel free to ignore.
Since we're within N
On 9/16/21 4:27 PM, John Snow wrote:
> On Thu, Sep 16, 2021 at 12:27 AM Philippe Mathieu-Daudé
> mailto:phi...@redhat.com>> wrote:
>
> On 9/16/21 6:09 AM, John Snow wrote:
> > We need to import things from the qemu namespace; importing the
> > namespace alone doesn't bring the submodul
On Thu, Sep 16, 2021 at 9:30 AM Alex Bennée wrote:
>
> John Snow writes:
>
> > A few new annoyances. Of note is the new warning for an unspecified
> > encoding when opening a text file, which actually does indicate a
> > potentially real problem; see
> > https://www.python.org/dev/peps/pep-0597/
On Thu, Sep 16, 2021 at 12:27 AM Philippe Mathieu-Daudé
wrote:
> On 9/16/21 6:09 AM, John Snow wrote:
> > We need to import things from the qemu namespace; importing the
> > namespace alone doesn't bring the submodules with it -- unless someone
> > else (like iotests.py) imports them too.
> >
> >
On 15/09/2021 16:43, Stefan Hajnoczi wrote:
On Wed, Sep 15, 2021 at 02:11:41PM +0200, Paolo Bonzini wrote:
On 13/09/21 15:10, Stefan Hajnoczi wrote:
On Wed, Sep 08, 2021 at 09:10:17AM -0400, Emanuele Giuseppe Esposito wrote:
Currently, block layer APIs like block-backend.h contain a mix of
John Snow writes:
> A few new annoyances. Of note is the new warning for an unspecified
> encoding when opening a text file, which actually does indicate a
> potentially real problem; see
> https://www.python.org/dev/peps/pep-0597/#motivation
>
> Use LC_CTYPE to determine an encoding to use for
16.09.2021 13:48, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
We'll need this for realizing qdev_find_child() in the next commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
softmmu/qdev-monitor.c | 48 +-
1 file changed, 33 in
Am 14.09.2021 um 22:37 hat Klaus Jensen geschrieben:
> From: Klaus Jensen
>
> Hi,
>
> This is an attempt at adressing a bunch of issues that have presented
> themselves since we added subsystem support. It's been brewing for a
> while now.
>
> Fundamentally, I've come to the conclusion that mod
Am 09.07.21 um 12:21 schrieb Kevin Wolf:
Am 08.07.2021 um 20:23 hat Peter Lieven geschrieben:
Am 08.07.2021 um 14:18 schrieb Kevin Wolf :
Am 07.07.2021 um 20:13 hat Peter Lieven geschrieben:
Am 06.07.2021 um 17:25 schrieb Kevin Wolf :
Am 06.07.2021 um 16:55 hat Peter Lieven geschrieben:
I wil
the qemu rbd driver currently lacks support for bdrv_co_block_status.
This results mainly in incorrect progress during block operations (e.g.
qemu-img convert with an rbd image as source).
This patch utilizes the rbd_diff_iterate2 call from librbd to detect
allocated and unallocated (all zero area
Vladimir Sementsov-Ogievskiy writes:
> We'll need this for realizing qdev_find_child() in the next commit.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> softmmu/qdev-monitor.c | 48 +-
> 1 file changed, 33 insertions(+), 15 deletions(-)
>
> diff
16.09.2021 11:34, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add a class that will unify block parents for blockdev-replace
functionality we are going to add.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/block-parent.h | 32 +
block/bloc
On Wed, 15 Sept 2021 at 18:53, Hanna Reitz wrote:
>
> The following changes since commit 0b6206b9c6825619cd721085fe082d7a0abc9af4:
>
> Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210914-4'
> into staging (2021-09-15 13:27:49 +0100)
>
> are available in the Git repository at
Vladimir Sementsov-Ogievskiy writes:
> Add a class that will unify block parents for blockdev-replace
> functionality we are going to add.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> include/block/block-parent.h | 32 +
> block/block-parent.c | 66 +++
Am 15.09.2021 um 23:36 hat Philippe Mathieu-Daudé geschrieben:
> ping & Cc'ing qemu-trivial@ (reviewed twice) ...
>
> On 8/16/21 8:04 PM, Philippe Mathieu-Daudé wrote:
> > When configuring QEMU with --disable-fuse, the qemu-storage-daemon
> > still reports FUSE command line options in its help:
>
36 matches
Mail list logo
