Re: [PATCH resend] block/replication.c: Properly attach children

04.07.2021 13:58, Lukas Straub wrote: The replication driver needs access to the children block-nodes of it's child so it can issue bdrv_make_empty to manage the replication. However, it does this by directly copying the BdrvChilds, which is wrong. Fix this by properly attaching the block-nodes

Re: [PATCH v2 3/3] qapi: deprecate drive-backup

09.06.2021 13:49, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: 08.06.2021 14:12, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: [...] TODO: We also need to deprecate drive-backup transaction action.. But union members in QAPI doesn't support 'deprecated' fe

[PATCH] vhost-user: Fix backends without multiqueue support

dev->max_queues was never initialised for backends that don't support VHOST_USER_PROTOCOL_F_MQ, so it would use 0 as the maximum number of queues to check against and consequently fail for any such backend. Set it to 1 if the backend doesn't have multiqueue support. Fixes: c90bd505a3e8210c23d69fe

Re: [PATCH 8/9] tests/acceptance: Remove now unused pow2ceil()

On Wed, Jun 23, 2021 at 3:10 PM Philippe Mathieu-Daudé wrote: > > We don't use pow2ceil() anymore, remove it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 12 > 1 file changed, 12 deletions(-) > Reviewed-by: Willian Rampazzo

Re: [RFC PATCH 6/9] tests/acceptance: Use image_expand() in test_arm_orangepi_bionic_20_08

On Wed, Jun 23, 2021 at 3:09 PM Philippe Mathieu-Daudé wrote: > > U-Boot expects the SD card size to be at least 2GiB, so > expand the SD card image to this size before using it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > TODO: U-Boot reference? > --- > tests/acceptance/boot_linux_console

Re: [PATCH 5/9] tests/acceptance: Use image_expand() in test_arm_orangepi_uboot_netbsd9

On Wed, Jun 23, 2021 at 3:08 PM Philippe Mathieu-Daudé wrote: > > The NetBSD OrangePi image must be at least 2GiB, not less. > Expand the SD card image to this size before using it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 9 +++-- > 1 file c

Re: [PATCH 4/9] tests/acceptance: Extract image_expand() helper

On Wed, Jun 23, 2021 at 3:06 PM Philippe Mathieu-Daudé wrote: > > To be able to expand an image to a non-power-of-2 value, > extract image_expand() from image_pow2ceil_expand(). > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/acceptance/boot_linux_console.py | 14 +- > 1 file

Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

On Wed, Jun 23, 2021 at 3:03 PM Philippe Mathieu-Daudé wrote: > > Avocado allows us to select set of tests using tags. > When wanting to run all tests using a NetBSD guest OS, > it is convenient to have them tagged, add the 'os:netbsd' > tag. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tes

Re: [ovirt-users] Re: Any way to terminate stuck export task

On Mon, Jul 5, 2021 at 3:36 PM Gianluca Cecchi wrote: > > On Mon, Jul 5, 2021 at 2:13 PM Nir Soffer wrote: >> >> >> > >> > vdsm 14342 3270 0 11:17 ?00:00:03 /usr/bin/qemu-img convert >> > -p -t none -T none -f raw >> > /rhev/data-center/mnt/blockSD/679c0725-75fb-4af7-bff1-7c447c5d

Re: [ovirt-users] Re: Any way to terminate stuck export task

On Mon, Jul 5, 2021 at 4:06 PM Strahil Nikolov wrote: > > >Disks on the export domain are never used by a running VM so there is > no reason to > preallocate them. The system should always use sparse disks when > copying to export > domain. > > >When importing disks from export domain, the system

[PATCH v5 3/3] block/io: Merge discard request alignments

Signed-off-by: Akihiko Odaki --- block/io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/io.c b/block/io.c index 323854d0633..db19ae2bd9c 100644 --- a/block/io.c +++ b/block/io.c @@ -125,6 +125,8 @@ void bdrv_parent_drained_begin_single(BdrvChild *c, bool poll) static void bdrv

[PATCH v5 2/3] block: Add backend_defaults property

backend_defaults property allow users to control if default block properties should be decided with backend information. If it is off, any backend information will be discarded, which is suitable if you plan to perform live migration to a different disk backend. If it is on, a block device may ut

[PATCH v5 1/3] block/file-posix: Optimize for macOS

This commit introduces "punch hole" operation and optimizes transfer block size for macOS. Thanks to Konstantin Nazarov for detailed analysis of a flaw in an old version of this change: https://gist.github.com/akihikodaki/87df4149e7ca87f18dc56807ec5a1bc5#gistcomment-3654667 Signed-off-by: Akihiko

Re: [ovirt-users] Re: Any way to terminate stuck export task

On Mon, Jul 5, 2021 at 2:13 PM Nir Soffer wrote: > > > > > vdsm 14342 3270 0 11:17 ?00:00:03 /usr/bin/qemu-img > convert -p -t none -T none -f raw > /rhev/data-center/mnt/blockSD/679c0725-75fb-4af7-bff1-7c447c5d789c/images/530b3e7f-4ce4-4051-9cac-1112f5f9e8b5/d2a89b5e-7d62-4695-96d8

Re: [ovirt-users] Re: Any way to terminate stuck export task

On Mon, Jul 5, 2021 at 12:50 PM Gianluca Cecchi wrote: > > On Sun, Jul 4, 2021 at 1:01 PM Nir Soffer wrote: >> >> On Sun, Jul 4, 2021 at 11:30 AM Strahil Nikolov >> wrote: >> > >> > Isn't it better to strace it before killing qemu-img . >> >> It may be too late, but it may help to understand wh

Re: [ovirt-users] Re: Any way to terminate stuck export task

On Mon, Jul 5, 2021 at 11:56 AM Strahil Nikolov wrote: > That NFS looks like it is not properly configured -> nobody:nobody is not > suposed to be seen. > > Change the ownership from nfs side to 36:36. Also, you can define > (all_squash,anonuid=36,anongid=36) as export options. > > > Best Regards

Re: [RFC] block/mirror: fix file-system went to read-only after block-mirror

24.06.2021 15:06, Jinhua Cao wrote: 1) Configure the VM disk as prdm. ... ... Mount the disk in guest and keep the disk writing data continuously during block-mirror, the file-system went to read-only after block-mirror. 2) This commit 6cdbceb12cf[mirror: Add filter-no

Re: [PATCH 06/14] iotest 302: use img_info_log() helper

05.07.2021 12:15, Vladimir Sementsov-Ogievskiy wrote: Instead of qemu_img_log("info", ..) use generic helper img_info_log(). img_info_log() has smarter logic. For example it use filter_img_info() to filter output, which in turns filter a compression type. So it will help us in future when we imp

Re: [PATCH 0/2] util/async: print leaked BH name when AioContext finalizes

On Wed, Apr 14, 2021 at 09:02:45PM +0100, Stefan Hajnoczi wrote: > Eric Ernst and I debugged a BH leak and it was more involved than it should > be. > The problem is that BHs don't have a human-readable identifier, so low-level > debugging techniques and inferences about the code are required to f

Re: [v5 1/3] block/file-posix: Optimize for macOS

On Fri, Apr 02, 2021 at 09:02:54AM -0700, Akihiko Odaki wrote: > This commit introduces "punch hole" operation and optimizes transfer > block size for macOS. > > Thanks to Konstantin Nazarov for detailed analysis of a flaw in an > old version of this change: > https://gist.github.com/akihikodaki/8

Re: [ovirt-users] Re: Any way to terminate stuck export task

That NFS looks like it is not properly configured -> nobody:nobody is not suposed to be seen. Change the ownership from nfs side to 36:36. Also, you can define (all_squash,anonuid=36,anongid=36) as export options. Best Regards,Strahil Nikolov On Mon, Jul 5, 2021 at 12:52, Gianluca Cecchi

Re: [PATCH] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller

On 6/23/21 8:59 PM, Joanne Koong wrote: > The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus > capability > was added in v2. > > In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul << > 28)) > where 28 represents the BUS64BIT SDHC_CAPAB field. > > Signe

Re: [PATCH 0/3] hw/sd: Check for valid address range in SEND_WRITE_PROT (CMD30)

On 7/2/21 5:58 PM, Philippe Mathieu-Daudé wrote: > Trivial fix for https://gitlab.com/qemu-project/qemu/-/issues/450 > > Missing review: patch #3 > > Philippe Mathieu-Daudé (3): > hw/sd: When card is in wrong state, log which state it is > hw/sd: Extract address_in_range() helper, log invalid

Re: [ovirt-users] Re: Any way to terminate stuck export task

On Sun, Jul 4, 2021 at 1:01 PM Nir Soffer wrote: > On Sun, Jul 4, 2021 at 11:30 AM Strahil Nikolov > wrote: > > > > Isn't it better to strace it before killing qemu-img . > > It may be too late, but it may help to understand why this qemu-img > run got stuck. > > Hi, thanks for your answers and

[PATCH 09/14] iotests/common.rc: introduce _qcow2_dump_header helper

We'll use it in tests instead of explicit qcow2.py. Then we are going to add some filtering in _qcow2_dump_header. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/common.rc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/qemu-iotests/common.rc b/tests/qem

[PATCH 11/14] iotests: bash tests: filter compression type

We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type), so implement specific option for it. Signed-off-by: Vladimir Sementsov-

[PATCH 07/14] qcow2: simple case support for downgrading of qcow2 images with zstd

If image doesn't have any compressed cluster we can easily switch to zlib compression, which may allow to downgrade the image. That's mostly needed to support IMGOPTS='compression_type=zstd' in some iotests which do qcow2 downgrade. While being here also fix checkpatch complain against '#' in pri

[PATCH 06/14] iotest 302: use img_info_log() helper

Instead of qemu_img_log("info", ..) use generic helper img_info_log(). img_info_log() has smarter logic. For example it use filter_img_info() to filter output, which in turns filter a compression type. So it will help us in future when we implement a possibility to use zstd compression by default

[PATCH 12/14] iotests 60: more accurate set dirty bit in qcow2 header

Don't touch other incompatible bits, like compression-type. This makes the test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/060 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/060 b/tests/qem

[PATCH 08/14] iotests/common.rc: _make_test_img(): smarter compressiont_type handling

Like it is done in iotests.py in qemu_img_create_prepare_args(), let's not follow compression_type=zstd of IMGOPTS if test creates image in old format. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/common.rc | 8 1 file changed, 8 insertions(+) diff --git a/tests/q

[PATCH 03/14] iotest 303: explicit compression type

The test prints qcow2 header fields which depends on chosen compression type. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/303 | 25 -

[PATCH 10/14] iotests: massive use _qcow2_dump_header

We are going to add filtering in _qcow2_dump_header and want all tests use it. The patch is generated by commands: cd tests/qemu-iotests sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_header\1/' ??? tests/* (the difficulty is to avoid converting dump-header-exts) Si

[PATCH 05/14] iotests.py: filter compression type out

We want iotests pass with both the default zlib compression and with IMGOPTS='compression_type=zstd'. Actually the only test that is interested in real compression type in test output is 287 (test for qcow2 compression type) and it's in bash. So for now we can safely filter out compression type in

[PATCH 14/14] iotest 214: explicit compression type

The test-case "Corrupted size field in compressed cluster descriptor" heavily depends on zlib compression type. So, make it explicit. This way test passes with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/214 | 2 +- 1 file changed, 1 insert

[PATCH 02/14] iotests.py: qemu_img*("create"): support IMGOPTS='compression_type=zstd'

Adding support of IMGOPTS (like in bash tests) allows user to pass a lot of different options. Still, some may require additional logic. Now we want compression_type option, so add some smart logic around it: ignore compression_type=zstd in IMGOPTS, if test want qcow2 in compatibility mode. As wel

[PATCH 13/14] iotest 39: use _qcow2_dump_header

_qcow2_dump_header has filter for compression type, so this change makes test pass with IMGOPTS='compression_type=zstd'. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/039 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/039 b/tests/qemu-

[PATCH 01/14] iotests.py: img_info_log(): rename imgopts argument

We are going to support IMGOPTS environment variable like in bash tests. Corresponding global variable in iotests.py should be called imgopts. So to not interfere with function argument, rename it in advance. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/210| 8 -

[PATCH 00/14] iotests: support zstd

Hi all! These series makes all test pass with IMGOPTS='compression_type=zstd' Also, python iotests start to support IMGOPTS (they didn't before). Also, tests works if enable compression type zstd by default. There is no such config option currently, probably it will appear in future or we'll

[PATCH 04/14] iotest 065: explicit compression type

The test checks different options. It of course fails if set IMGOPTS='compression_type=zstd'. So, let's be explicit in what compression type we want and independent of IMGOPTS. Test both existing compression types. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/065 | 14 +

Re: [PATCH 3/9] tests/acceptance: Tag NetBSD tests as 'os:netbsd'

Hi Niek, On 7/4/21 2:35 PM, Niek Linnenbank wrote: > for test_arm_orangepi_uboot_netbsd9: > > Reviewed-by: Niek Linnenbank > Thanks for the review. Does your R-b tag applies for this single patch or all patches related to test_arm_orangepi_uboot_netbsd9 in this

Re: [PATCH v2] docs: document file-posix locking protocol

On 7/5/21 10:55 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.07.2021 17:50, Nir Soffer wrote: >> On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy >> wrote: >>> >>> Let's document how we use file locks in file-posix driver, to allow >>> external programs to "communicate" in this way with

Re: [PATCH resend] nbd: register yank function earlier

04.07.2021 13:56, Lukas Straub wrote: Although unlikely, qemu might hang in nbd_send_request(). Allow recovery in this case by registering the yank function before calling it. Signed-off-by: Lukas Straub Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH] nbd: register yank function earlier

04.07.2021 01:07, Lukas Straub wrote: Although unlikely, qemu might hang in nbd_send_request(). Allow recovery in this case by registering the yank function before calling it. Signed-off-by: Lukas Straub Reviewed-by: Vladimir Sementsov-Ogievskiy -- Best regards, Vladimir

Re: [PATCH] hw/sd: sdhci: Enable 64-bit system bus capability in the default SD/MMC host controller

On Thu, Jun 24, 2021 at 3:01 AM Joanne Koong wrote: > > The default SD/MMC host controller uses SD spec v2.00. 64-bit system bus > capability > was added in v2. > > In this change, we arrive at 0x157834b4 by computing (0x057834b4 | (1ul << > 28)) > where 28 represents the BUS64BIT SDHC_CAPAB fie

Re: [PATCH v2] docs: document file-posix locking protocol

03.07.2021 17:50, Nir Soffer wrote: On Sat, Jul 3, 2021 at 4:51 PM Vladimir Sementsov-Ogievskiy wrote: Let's document how we use file locks in file-posix driver, to allow external programs to "communicate" in this way with Qemu. This makes the locking implementation public, so qemu can never

Re: [PATCH 3/3] hw/sd: Check for valid address range in SEND_WRITE_PROT (CMD30)

On Fri, Jul 2, 2021 at 11:59 PM Philippe Mathieu-Daudé wrote: > > OSS-Fuzz found sending illegal addresses when querying the write > protection bits triggers an assertion: > > qemu-fuzz-i386: hw/sd/sd.c:824: uint32_t sd_wpbits(SDState *, uint64_t): > Assertion `wpnum < sd->wpgrps_size' failed.

[PATCH v8 15/16] qemu-iotests: add option to show qemu binary logs on stdout

Using the flag -p, allow the qemu binary to print to stdout. Also create the common function _close_qemu_log_file() to avoid accessing machine.py private fields directly and have duplicate code. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- python/qemu

[PATCH v8 16/16] docs/devel/testing: add -p option to the debug section of QEMU iotests

Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 719accdb1e..e5311cb167 100644 --- a/docs/devel/testing.rst +++ b/docs/devel

[PATCH v8 14/16] docs/devel/testing: add -valgrind option to the debug section of QEMU iotests

Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Max Reitz Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 8b24e6fb47..719accdb1e 100644 --- a/docs/devel/te

[PATCH v8 11/16] qemu-iotests: extend QMP socket timeout when using valgrind

As with gdbserver, valgrind delays the test execution, so the default QMP socket timeout and the generic class Timeout in iotests.py timeouts too soon. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +++--- 1 file change

[PATCH v8 10/16] qemu-iotests: extend the check script to prepare supporting valgrind for python tests

Currently, the check script only parses the option and sets the VALGRIND_QEMU environmental variable to "y". Add another local python variable that prepares the command line, identical to the one provided in the test scripts. Because the python script does not know in advance the valgrind PID to a

[PATCH v8 07/16] qemu_iotests: insert gdbserver command line as wrapper for qemu binary

Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index e176a84620..e7e3d92d3e 100644 --- a/test

[PATCH v8 13/16] qemu-iotests: insert valgrind command line as wrapper for qemu binary

If -gdb and -valgrind are both defined, return an error. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iote

[PATCH v8 05/16] qemu-iotests: add option to attach gdbserver

Define -gdb flag and GDB_OPTIONS environment variable to python tests to attach a gdbserver to each qemu instance. This patch only adds and parses this flag, it does not yet add the implementation for it. if -gdb is not provided but $GDB_OPTIONS is set, ignore the environment variable. Signed-off

[PATCH v8 04/16] docs/devel/testing: add debug section to the QEMU iotests chapter

Introduce the "Debugging a test case" section, in preparation to the additional flags that will be added in the next patches. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v8 08/16] qemu-iotests: add gdbserver option to script tests too

Remove read timer in test script when GDB_OPTIONS are set, so that the bash tests won't timeout while running gdb. The only limitation here is that running a script with gdbserver will make the test output mismatch with the expected results, making the test fail. Signed-off-by: Emanuele Giuseppe

[PATCH v8 12/16] qemu-iotests: allow valgrind to read/delete the generated log file

When using -valgrind on the script tests, it generates a log file in $TEST_DIR that is either read (if valgrind finds problems) or otherwise deleted. Provide the same exact behavior when using -valgrind on the python tests. Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov

[PATCH v8 09/16] docs/devel/testing: add -gdb option to the debugging section of QEMU iotests

Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy --- docs/devel/testing.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 9d6a8f8636..8b24e6fb47 100644 --- a/docs/devel/testing.rst +++ b/d

[PATCH v8 03/16] python: qemu: pass the wrapper field from QEMUQtestmachine to QEMUMachine

Signed-off-by: Emanuele Giuseppe Esposito Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz Acked-by: John Snow --- python/qemu/machine/qtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/python/qemu/machine/qtest.py b/python/q