On 23/09/2014 4:25 AM, Chris Angelico wrote:
On Tue, Sep 23, 2014 at 4:24 AM, Chris Kaynor wrote:
But the thing that requires the comment is the "2", not the "print" or the
"cells". And that comes to a more common issue: any number other than 0 or 1
in code most likely needs a comment (that com
Original Message -
> From: "Chris Angelico"
> Cc: python-list@python.org
> Sent: Monday, 22 September, 2014 6:04:43 PM
> Subject: Re: Love to get some feedback on my first python app!!!
>
> On Tue, Sep 23, 2014 at 1:52 AM, Jean-Michel Pichavant
> wrote:
On Tue, Sep 23, 2014 at 4:24 AM, Chris Kaynor wrote:
> On Mon, Sep 22, 2014 at 8:52 AM, Jean-Michel Pichavant
> wrote:
>>
>> Anyway it's seems we agree anyway because your example perfectly
>> illustrate what I was trying to demonstrate:
>> print(cells[2]) is very easy to understand, most of peop
On Mon, Sep 22, 2014 at 8:52 AM, Jean-Michel Pichavant <
jeanmic...@sequans.com> wrote:
> Anyway it's seems we agree anyway because your example perfectly
> illustrate what I was trying to demonstrate:
> print(cells[2]) is very easy to understand, most of people would say 'no
> need of any comment
On 22/09/2014 14:17, Nicholas Cannon wrote:
Ok I'm confused. Do I need to do better comments? I know the text is not that
great but that is my next obstacle I am going to tackle. I mostly need to know
where I am going wrong such as what is expectable readable code and what is not
and how to fi
On 22/09/2014 13:00, vek.m1...@gmail.com wrote:
https://github.com/Veek/Python/blob/master/IRC/Hexchat/fake_ctcp.py
that's not too bad as far as readability is concerned and it's bereft of all
comments {:p
Definitely googlegroups rides again.
--
My fellow Pythonistas, ask not what our langua
On Tue, Sep 23, 2014 at 2:17 AM, Mark Lawrence wrote:
> And ignore Chris at your peril, he knows a fair bit about Python. Sure he
> gets things wrong, but the only person who never gets things wrong is the
> person who never does anything.
Thanks :)
I don't mind being wrong, or being told I'm w
On 22/09/2014 14:48, C Smith wrote:
I wouldn't take it personally, just defend your position. I think that
is what he is looking for. We are all adults here (maybe?). You guys
should be able to work it out. A tangential skill to programming is
being able to give and take criticism well, even if y
On 22/09/2014 14:35, vek.m1...@gmail.com wrote:
@Chris, Hi, I don't like your style of posting - please kill file me.
@Everybody else - I don't like Chris and his style of posting (overuse of the
'troll' word and perceived aggression). I shall be ignoring him for a year
(barring an emergency).
On Tue, Sep 23, 2014 at 2:10 AM, Mark Lawrence wrote:
> Google groups rides again?
Yeah. And now someone from Google Groups has killfiled me. So it's up
to you to request/recommend alternatives, s/he won't see me saying so.
ChrisA
--
https://mail.python.org/mailman/listinfo/python-list
On 22/09/2014 12:47, vek.m1...@gmail.com wrote:
1. It's feedback not a mathematical proof.
What is?
2. I hope the OP tries what I suggested - it's all entirely optional.
Which is?
@OP
I have no idea what that program does because it's well commented. You aren't
using variable and functi
On Tue, Sep 23, 2014 at 1:52 AM, Jean-Michel Pichavant
wrote:
> The code I posted had many bugs but one could not be fixed without the
> comment. Or at least there's an obvious discrepancy between the comment and
> the code that should catch the reader's attention.
>
The obvious discrepancy, sa
- Original Message -
> From: "Chris Angelico"
> Cc: python-list@python.org
> Sent: Monday, 22 September, 2014 4:50:15 PM
> Subject: Re: Love to get some feedback on my first python app!!!
>
> On Tue, Sep 23, 2014 at 12:32 AM, Jean-Michel Pichavan
On Mon, 22 Sep 2014 16:32:27 +0200, Jean-Michel Pichavant wrote:
> - Original Message -
>> From: "Chris Angelico"
>> Cc: python-list@python.org Sent: Saturday, 20 September, 2014 4:58:44
>> PM Subject: Re: Love to get some feedback on my first python app
@CSmith
Hi, I'm sorry, I wish I could acquiesce but I think it's better for me to stay
clear. There's criticism, and there's name calling ('dim' 'troll').
Reiterating what I said earlier, if the OP wants clarification he can ask for
it.
--
https://mail.python.org/mailman/listinfo/python-list
On Tue, Sep 23, 2014 at 12:32 AM, Jean-Michel Pichavant
wrote:
> For instance:
>
> cells = ['a', 'b' 'c']
> # print the first cell
> print cell[1]
>
> A bug that is easily spotted thanks to the comment. It's all about
> implementation versus intentions. Also note that comment should be written
>
On Mon, Sep 22, 2014 at 10:32 AM, Jean-Michel Pichavant
wrote:
> - Original Message -
>> From: "Chris Angelico"
>> Cc: python-list@python.org
>> Sent: Saturday, 20 September, 2014 4:58:44 PM
>> Subject: Re: Love to get some feedback on my first pyt
- Original Message -
> From: "Chris Angelico"
> Cc: python-list@python.org
> Sent: Saturday, 20 September, 2014 4:58:44 PM
> Subject: Re: Love to get some feedback on my first python app!!!
[snip]
>
> #search API
> rawData =
>
> urlli
On Mon, Sep 22, 2014 at 11:48 PM, C Smith wrote:
> I wouldn't take it personally, just defend your position. I think that
> is what he is looking for. We are all adults here (maybe?). You guys
> should be able to work it out. A tangential skill to programming is
> being able to give and take criti
I wouldn't take it personally, just defend your position. I think that
is what he is looking for. We are all adults here (maybe?). You guys
should be able to work it out. A tangential skill to programming is
being able to give and take criticism well, even if you think it
crosses the line.
On Mon,
@Chris, Hi, I don't like your style of posting - please kill file me.
@Everybody else - I don't like Chris and his style of posting (overuse of the
'troll' word and perceived aggression). I shall be ignoring him for a year
(barring an emergency). Good communication demands that I announce this.
On Mon, Sep 22, 2014 at 11:17 PM, Nicholas Cannon
wrote:
> Ok I'm confused. Do I need to do better comments? I know the text is not that
> great but that is my next obstacle I am going to tackle. I mostly need to
> know where I am going wrong such as what is expectable readable code and what
>
On Mon, Sep 22, 2014 at 11:02 PM, Larry Martell wrote:
> On Mon, Sep 22, 2014 at 8:23 AM, Chris Angelico wrote:
>> So, comments would definitely help. In some cases, would help a lot.
>
> This is me:
>
> http://xkcd.com/1421/
Also me. I have apologized to my future selves on a number of
occasion
Also I have just been coding for about and hour and a half and added a lot more
code to it but it is not fully finished yet so it is not on github yet.
--
https://mail.python.org/mailman/listinfo/python-list
Ok I'm confused. Do I need to do better comments? I know the text is not that
great but that is my next obstacle I am going to tackle. I mostly need to know
where I am going wrong such as what is expectable readable code and what is not
and how to fix this. This is good feedback thanks to all of
On Mon, Sep 22, 2014 at 8:23 AM, Chris Angelico wrote:
> So, comments would definitely help. In some cases, would help a lot.
This is me:
http://xkcd.com/1421/
--
https://mail.python.org/mailman/listinfo/python-list
On Mon, Sep 22, 2014 at 10:00 PM, wrote:
> https://github.com/Veek/Python/blob/master/IRC/Hexchat/fake_ctcp.py
> that's not too bad as far as readability is concerned and it's bereft of all
> comments {:p
Sure, I can work out what it's doing without comments. Doesn't mean
comments are bad, thou
On Mon, Sep 22, 2014 at 9:47 PM, wrote:
> 1. It's feedback not a mathematical proof.
> 2. I hope the OP tries what I suggested - it's all entirely optional.
Doesn't change the fact that you need to justify your recommendations,
at least when they're not obvious. You're suggesting a number of
thi
https://github.com/Veek/Python/blob/master/IRC/Hexchat/fake_ctcp.py
that's not too bad as far as readability is concerned and it's bereft of all
comments {:p
--
https://mail.python.org/mailman/listinfo/python-list
1. It's feedback not a mathematical proof.
2. I hope the OP tries what I suggested - it's all entirely optional.
@OP
I have no idea what that program does because it's well commented. You aren't
using variable and function names to good effect and are resorting to excessive
comments.
Additional
On Mon, Sep 22, 2014 at 7:00 PM, wrote:
> One thing I noticed with that code was the size of your function, and
> excessive comments. It reminds me of my bubble_sort.c program in
> school/college - everything plonked into 'main'.
>
> Try writing it like this:
I'd like to see justifications for
One thing I noticed with that code was the size of your function, and excessive
comments. It reminds me of my bubble_sort.c program in school/college -
everything plonked into 'main'.
Try writing it like this:
1. #!/usr/bin/python or #!/usr/bin/env python
The leading #! is read by the kernel w
On Saturday, September 20, 2014 9:17:27 PM UTC+8, Nicholas Cannon wrote:
> I have created my first python program and I have learnt a lot about python
> from this group and wanted some feedback. I am still improving it and trying
> to tackle some performance and GUI stuff so keep that in mind. I
I have just committed a new main.py file on github. I added alot more comments
and slimmed down the getinfo() function.
--
https://mail.python.org/mailman/listinfo/python-list
On Sun, Sep 21, 2014 at 11:33 AM, Nicholas Cannon
wrote:
> Yeah this is exactly what I was looking for I know the comments are horrible
> and I had no idea about the camelCase stuff. Should I use
> '''
> Use this commenting on my functions or not. I think they are called
> docStrings or somethin
On Saturday, September 20, 2014 9:17:27 PM UTC+8, Nicholas Cannon wrote:
> I have created my first python program and I have learnt a lot about python
> from this group and wanted some feedback. I am still improving it and trying
> to tackle some performance and GUI stuff so keep that in mind. I
On 20/09/2014 15:58, Chris Angelico wrote:
On Sat, Sep 20, 2014 at 11:16 PM, Nicholas Cannon
wrote:
You may
also notice that the camelCase variable names you're using are in
stark contrast to the rest of the language. It's normal to use
lower_case_with_underscores instead.
That may be the PEP
On Sat, Sep 20, 2014 at 11:16 PM, Nicholas Cannon
wrote:
> I have created my first python program and I have learnt a lot about python
> from this group and wanted some feedback. I am still improving it and trying
> to tackle some performance and GUI stuff so keep that in mind. I don't think
>
I have created my first python program and I have learnt a lot about python
from this group and wanted some feedback. I am still improving it and trying to
tackle some performance and GUI stuff so keep that in mind. I don't think it is
the best program but is a good product of 3 months of python
39 matches
Mail list logo
