Changes by Xiang Zhang :
--
nosy: +pitrou, tim.peters
___
Python tracker
<http://bugs.python.org/issue29376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
This seems an regression from #18808, so nosy Tim and Antoine. Since
_DummyThread is always alive and daemonic, I think the solution could be
overriding is_alive in _DummyThread and always returning True.
--
keywords: +patch
nosy: +xiang.zhang
stage
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
versions: -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list m
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue29405>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I could reproduce this using Audric's command. And yes, debug build doesn't
suffer from this crash. Nosy Victor.
DEBUG:root:Called with: ['/tmp/minimal_crash.py', '-d', 'sqlite:///crash.db',
'-v']
Xiang Zhang added the comment:
Sounds reasonable. IIUC if the sample data gets 11 lines the total could be 20.
I also think the second min is redundant. Would you mind review my patch Milt?
--
keywords: +patch
stage: -> patch review
type: behavior -> enhancement
versions: +Pyth
Changes by Xiang Zhang :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue29405>
___
___
Python-bugs-list mailing list
Un
Xiang Zhang added the comment:
After reading the code I could see the possibility. A weakref object gets two
linkedlist pointers which are not initialized by new_weakref (actually they are
initialized by insert_head or insert_after). But the weakref object is possible
to be destroyed in [1
Changes by Xiang Zhang :
--
nosy: +fdrake
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Hmm, what's your test program? Would you mind show it?
--
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Pytho
Xiang Zhang added the comment:
But your weakref_crash.c doesn't look correct to me. Your test.object type
doesn't support weak references at all. How could you use GET_WEAKREFS_LISTPTR
then? See https://docs.python.org/3/extending/newtypes.html#weakr
Xiang Zhang added the comment:
Saida, I changed your test program to use set instead of self created type (see
attachment). I tested it under Py2.7 and it seems no crash happens.
python test.py 1 1
2.7.10 (default, Oct 14 2015, 16:09:02)
[GCC 5.2.1 20151010]
0x101010101010101
0x1010101010101
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue29453>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
David, actually I have the same thoughts as Jim. Ordered ordinary dicts is not
a feature but ordered **kwargs is in 3.6. They seems not the same thing.
--
___
Python tracker
<http://bugs.python.org/issue29
Changes by Xiang Zhang :
--
assignee: docs@python -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29453>
___
___
Python-bugs-list mai
Changes by Xiang Zhang :
--
nosy: +davin
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue29454>
___
___
Python-bugs-list mailing list
Un
Xiang Zhang added the comment:
Thanks Milt. I committed with my change not because it's better, but I want to
make the change small so others won't get unfamiliar with the new code. :-)
--
resolution: -> fixed
stage: commit review -> resolved
status
Xiang Zhang added the comment:
I am fine with any version (both are simple and not the hardest part to
understand in the logic). :-) I have no opinion on which is better.
--
___
Python tracker
<http://bugs.python.org/issue29
Xiang Zhang added the comment:
How about the third character's range? The code seems assuming it's
[11a7..11c3] while the spec is [11a8..11c2]?
>>> unicodedata.normalize("NFC", "\u1100\u1175\u11a7")
'기'
while
Xiang Zhang added the comment:
I doubt the info belongs to datetime module documentation. When you encounter
locale related problems maybe it's better for you to refer locale module
documentation, and it mentions this behaviour
https://docs.python.org/3/library/locale.html#background-de
Changes by Xiang Zhang :
--
nosy: +haypo, mark.dickinson, rhettinger
___
Python tracker
<http://bugs.python.org/issue29458>
___
___
Python-bugs-list mailin
Changes by Xiang Zhang :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29466>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
> if (was_shared && (cached = CACHED_KEYS(tp)) != NULL && cached !=
> ((PyDictObject *)dict)->ma_keys)
+1 on this and I think the deletion should also use
if ((cached = CACHED_KEYS(tp) ！= NULL)
--
_
Xiang Zhang added the comment:
I left one review about the comment on Rietvied last patch. :-)
--
___
Python tracker
<http://bugs.python.org/issue29438>
___
___
Xiang Zhang added the comment:
3.6 LGTM. 3.7 is technically right to me. But it looks to me AC shouldn't call
path_cleanup in .c.h. It always do nothing.
--
___
Python tracker
<http://bugs.python.org/is
Xiang Zhang added the comment:
> If PyObject_New(ScandirIterator, &ScandirIteratorType) fails the path should
> be cleaned up by Argument Clinic.
Ohh yes. My stupid. Then both LGTM.
--
stage: patch review -> commit review
___
Python t
Xiang Zhang added the comment:
I am using 16.10 but I can't reproduce the failures. Sachin can you reliably
reproduce the failures? And one thing interesting is that all the failed test
cases need the network source to be enabled but your command doesn't do that,
it's better
Xiang Zhang added the comment:
The documentation[1] explicitly states using % to do string format could be
error-prone and recommends using str.format(). So +1 on no change in
maintenance branches.
[1]
https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
Xiang Zhang added the comment:
Or even not fix it in develop branch.
--
___
Python tracker
<http://bugs.python.org/issue29568>
___
___
Python-bugs-list mailin
Changes by Xiang Zhang :
--
pull_requests: +89
___
Python tracker
<http://bugs.python.org/issue28806>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Ping.
--
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +90
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Yaowei Zhang :
--
components: Library (Lib)
nosy: Yaowei Zhang
priority: normal
severity: normal
status: open
title: 2D list with Bugs when defined by using Multiplication
versions: Python 3.5
___
Python tracker
<http://bugs.python.
New submission from Yaowei Zhang:
#If we define a list by:
nums = [[0]*3]*3
#nums = [[0,0,0],[0,0,0],[0,0,0]]
nums[0][1] = 1
print(mums)
# the result is
[[0,1,0],[0,1,0],[0,1,0]]
#I think it is because all the line use the same list variable, but it suppose
#not.
--
components: +Build
Changes by Anthony Zhang :
--
pull_requests: +127
___
Python tracker
<http://bugs.python.org/issue29110>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +gpolo, serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue29559>
___
___
Python-bugs-list mailing list
Unsub
Xiang Zhang added the comment:
New changeset d0e8212ed70445cc3d48b0d4ae7c9cb480004010 by GitHub in branch
'master':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128)
https://github.com/python/cpython/commit/d0e8212ed70445cc3d48b0d4ae7c9c
Changes by Xiang Zhang :
--
pull_requests: +152
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +153
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +154
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +ned.deily, ronaldoussoren
___
Python tracker
<http://bugs.python.org/issue29562>
___
___
Python-bugs-list mailing list
Unsub
Xiang Zhang added the comment:
New changeset 7131a73f9655cfd325c798385905326f57b94640 by GitHub in branch
'2.7':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128) (#187)
https://github.com/python/cpyt
Xiang Zhang added the comment:
New changeset 7c95a94c3ab41e4296e94335d66b2400ad16f052 by GitHub in branch
'3.5':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128) (#188)
https://github.com/python/cpyt
Xiang Zhang added the comment:
New changeset 9a4577a4bb23888fed2cf192cf1a4c95ce5c26f8 by GitHub in branch
'3.6':
bpo-29347: Fix possibly dereferencing undefined pointers when creating weakref
objects (#128) (#186)
https://github.com/python/cpyt
Xiang Zhang added the comment:
Although no feedback from Saida, but IMHO the problem is solved so I close it
now.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +155
___
Python tracker
<http://bugs.python.org/issue27660>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I opened a PR on GitHub for this issue. Hope Raymond you could review it some
time.
--
versions: +Python 3.7 -Python 3.6
___
Python tracker
<http://bugs.python.org/issue27
Xiang Zhang added the comment:
Hi Dima, can you stably reproduce the failures? Or try with the latest 3.6 code?
--
nosy: +xiang.zhang
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issu
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue29595>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +larry
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue29596>
___
___
Python-bugs-list mailing list
Un
Changes by Xiang Zhang :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue29602>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Thanks for your time Raymond. :-) I applied your suggestions in the PR.
--
___
Python tracker
<http://bugs.python.org/issue27
Xiang Zhang added the comment:
Sorry, I have the commit bit and know what to do with a commit. So I assign it
to myself and wait someone approve the PR on GitHub.
--
assignee: Mariatta -> xiang.zhang
stage: patch review -> commit review
___
Xiang Zhang added the comment:
Thanks for your confirmation Saida! :-)
--
___
Python tracker
<http://bugs.python.org/issue29347>
___
___
Python-bugs-list mailin
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xiang Zhang added the comment:
New changeset 4cee049f5b6864066b8315e9b54de955e5487dfc by GitHub in branch
'master':
bpo-27660: remove unnecessary overflow checks in list_resize (GH-189)
https://github.com/python/cpython/commit/4cee049f5b6864066b8315e9b54de9
Changes by Xiang Zhang :
--
pull_requests: +194
___
Python tracker
<http://bugs.python.org/issue7769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Hmm, it seems not Python's fault. I can't reproduce the failure either. So I am
going to close this issue.
--
resolution: -> works for me
stage: test needed -> resolved
status: open -> closed
___
Py
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue28624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I agree with Berker and Jim here. I think the current doc is clear enough so
mark this as rejected. :-(
--
nosy: +xiang.zhang
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
_
Changes by Xiang Zhang :
--
pull_requests: +197
___
Python tracker
<http://bugs.python.org/issue29376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
versions: -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue29619>
___
___
Python-bugs-list m
Changes by Xiang Zhang :
--
nosy: +paul.j3
___
Python tracker
<http://bugs.python.org/issue29553>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Lisa, could you make a PR? It could let more developers see your patch.
--
nosy: +xiang.zhang
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issu
Xiang Zhang added the comment:
Yes. This is the case for builtin types which usually get their own __new__
methods. See #5996.
--
dependencies: +abstract class instantiable when subclassing dict
nosy: +xiang.zhang
versions: +Python 3.5, Python 3.7
Xiang Zhang added the comment:
I concur the current message is misleading.
OSError makes the string "file1 -> file2". This also affects other methods
calling `path_error2()` such as os.link().
--
nosy: +xiang.zhang
versions: +Python 3.
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue29652>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +290
___
Python tracker
<http://bugs.python.org/issue29376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +289
___
Python tracker
<http://bugs.python.org/issue29376>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +291
___
Python tracker
<http://bugs.python.org/issue29661>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
assignee: -> xiang.zhang
nosy: +xiang.zhang
stage: -> patch review
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/i
Changes by Xiang Zhang :
--
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/issue29662>
___
___
Python-bugs-list mailing list
Unsub
Changes by Xiang Zhang :
--
assignee: xiang.zhang
components: Documentation
nosy: xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Fix wrong indentation of timeit.Timer's documenation
___
Python tracker
Changes by Xiang Zhang :
--
pull_requests: +292
___
Python tracker
<http://bugs.python.org/issue29662>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
pull_requests: +293
___
Python tracker
<http://bugs.python.org/issue29662>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xiang Zhang added the comment:
Of course that is okay. I didn't do what you propose since I thought it's
somewhat superfluous, what is returned is mentioned below. I choose 'calculate'
when I see 'Automatically determine how many times to call timeit
Changes by Xiang Zhang :
--
pull_requests: +302
___
Python tracker
<http://bugs.python.org/issue29661>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Thanks Raymond!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Xiang Zhang added the comment:
Thanks Raymond. I would like to keep the example style another issue, not this
one. :-) And I hope someone is willing to review the PR.
--
assignee: -> xiang.zhang
stage: needs patch -> patch review
versions: +Python 3.7 -Pyth
Xiang Zhang added the comment:
Thanks everyone involved!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
New submission from Xiang Zhang:
Recently when I run the test suite test_cprofile always produces some verbose
info but won't fail. This is not the case before. I am not sure this is a bug
or not. git bisect tells me
https://github.com/python/cpython/c
Changes by Xiang Zhang :
--
pull_requests: +310
___
Python tracker
<http://bugs.python.org/issue28598>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +311
___
Python tracker
<http://bugs.python.org/issue26867>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 2.7
___
Python tracker
<http://bugs.python.or
Changes by Xiang Zhang :
--
pull_requests: +343
___
Python tracker
<http://bugs.python.org/issue28728>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue27137>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I think subclassing builtin types and making it abstract is rare. And when
there is a need, we can mimic this in application level (this may also apply to
types having custom __new__):
In [2]: class CustomDict(dict, metaclass=abc.ABCMeta):
...: def
Changes by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<http://bugs.python.org/issue27164>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
This seems related with the difference between zlib format and raw format. When
you do raw inflate, you have to inflateSetDictionary before any inflate. You
cannot rely on the first inflate to return Z_NEED_DICT and then do
inflateSetDictionary.
Although I have
Xiang Zhang added the comment:
I think my conclusion in last message is right. A similar bug in CPAN can be
found in https://rt.cpan.org/Public/Bug/Display.html?id=36046. And I can find
in zlib's changelog inflateSetDictionary starts to support raw inflate from
1.2.2.1.
Patch attache
Xiang Zhang added the comment:
Forget to add test. Upload a new one with test included.
--
Added file: http://bugs.python.org/file43085/issue27164_with_test.patch
___
Python tracker
<http://bugs.python.org/issue27
Xiang Zhang added the comment:
Yes. It's compression object not compress.
I find more. The overflow checking is introduced to solve problem in issue8650.
It seems the explicit overflow checking is introduced to keep compatibility
with py2 (py2 raises the overflowerror in pyargparse
Xiang Zhang added the comment:
Thanks for your review, Martin. :) I have replied with after thinking and try.
Yes, this is more like a feature request. But for the end user, this behaviour
is quite like a bug.
> If we were to add full support of inflateSetDictionary() for raw deflate
>
Changes by Xiang Zhang :
--
nosy: +steven.daprano
___
Python tracker
<http://bugs.python.org/issue27181>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I'd like to help but it'll need some time. And I'd like to start after
issue27164 is solved. zdict now also checks for 4GB limit.
--
___
Python tracker
<http://bugs.pyt
Xiang Zhang added the comment:
Serhiy, actually the patch(issue26915_s2.patch) I uploaded early has tried to
make Sequence.index and Sequence.count consistent. Maybe the issue stage is not
right.
--
___
Python tracker
<http://bugs.python.
Xiang Zhang added the comment:
Thanks for review Serhiy and nice thoughts. I make the class inherited directly
from Sequence. So if the methods in Sequence are OK, the test class is OK.
--
Added file: http://bugs.python.org/file43189/issue26915_v3.patch
901 - 1000 of 1760 matches
Mail list logo
