[issue18489] IDLE Unit test for SearchEngine.py

2013-07-17 Thread Phil Webster
New submission from Phil Webster: This test uses the mock text widget to search forwards and backwards, with and without wrapping. It also tests for empty matches with the 'ok' flag set in search_text(). The patch relies on the mock text tag_add function implemented

[issue18226] IDLE Unit test for FormatParagrah.py

2013-07-19 Thread Phil Webster
Phil Webster added the comment: I added and rewrote tests to use the Text widget (when necessary). The only changes made to FormatParagraph are documentation/comment formatting and the if __main__ function. I will work on the comment header behavior separately and can post the patch in this

[issue18504] IDLE:Improvements- Improving Mock_Text

2013-07-22 Thread Phil Webster
Changes by Phil Webster : -- nosy: +philwebster ___ Python tracker <http://bugs.python.org/issue18504> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18489] IDLE Unit test for SearchEngine.py

2013-07-24 Thread Phil Webster
Phil Webster added the comment: Added tests for the rest of the SearchEngine module. I used the mock tkMessageBox for testing the error display, but used the tkinter Text widget for other tests because mark_set and tag_add/remove haven't been added to the mock yet. -- Added

[issue18226] IDLE Unit test for FormatParagrah.py

2013-07-24 Thread Phil Webster
Phil Webster added the comment: This patch moves the comment_header code to reformat_comment, adds tests for reformat_comment, and implements the fix that Todd mentioned in #18429. In addition, I changed the get_comment_header and get_indent regular expressions to only look for spaces and

[issue18565] Test for closing delegating generator with cleared frame (Issue17669)

2013-07-26 Thread Phil Connell
New submission from Phil Connell: This is a testcase for issue17669 - it passes against the latest default (and hits the same segfault under 3.3.0). I came up with this while tracking down a thorny generator finalisation crash that turned out to be a variant on 17669. The root cause was

[issue18565] Test for closing delegating generator with cleared frame (Issue17669)

2013-07-27 Thread Phil Connell
Phil Connell added the comment: Good suggestion, updated patch attached. -- Added file: http://bugs.python.org/file31055/gen_close_with_cleared_frame.diff ___ Python tracker <http://bugs.python.org/issue18

[issue17669] Segfault caused by weird combination of imports and yield from

2013-07-29 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue17669> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-07-29 Thread Phil Webster
New submission from Phil Webster: This is a basic set of tests for SearchDialogBase. It mainly consists of gui code, so I was not completely sure of how/what to test. Before venturing any further, I thought I would make sure I'm heading in the right direction. -- components:

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-07-29 Thread Phil Webster
Changes by Phil Webster : -- keywords: +patch Added file: http://bugs.python.org/file31082/test_searchdialogbase.patch ___ Python tracker <http://bugs.python.org/issue18

[issue18583] Idle: enhance FormatParagraph

2013-07-29 Thread Phil Webster
Changes by Phil Webster : -- nosy: +philwebster ___ Python tracker <http://bugs.python.org/issue18583> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

2013-08-03 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue18566> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18594] C accelerator for collections.Counter is slow

2013-08-03 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue18594> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18583] Idle: enhance FormatParagraph

2013-08-09 Thread Phil Webster
Phil Webster added the comment: In the case of no selection would it make sense to only format if the cursor is in a string/comment? If not in a string or comment, the single line that the cursor is in could be formatted with a line ending backslash or not at all. Otherwise Format Paragraph

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-10 Thread Phil Webster
Phil Webster added the comment: As suggested by Ezio, I factored out the button tests to a common method. -- Added file: http://bugs.python.org/file31220/test_searchdialogbase2.patch ___ Python tracker <http://bugs.python.org/issue18

[issue18583] Idle: enhance FormatParagraph

2013-08-12 Thread Phil Webster
Phil Webster added the comment: I've attached a patch that attempts to address the issues above. For the tests, I made some changes because the cursor doesn't end in exactly the same spot with line endings. Here's a quick summary of the changes: 1. Removed format_paragraph and

[issue18766] IDLE: Autocomplete in editor doesn't work for un-imported modules

2013-08-16 Thread Phil Webster
New submission from Phil Webster: If you open a new editor window in IDLE, some modules will autocomplete (re, os, other common modules used by IDLE) and others will not (textwrap, datetime, ...). The current solution is to run your module or type the imports into the shell window to get

[issue18409] IDLE Improvements: Unit test for AutoComplete.py

2013-08-26 Thread Phil Webster
Phil Webster added the comment: I've attached my work so far in order to get feedback before I head too far in the wrong direction. I'm not sure if my addition of mock events and AutoCompleteWindow is the right way to go and I'm open to any guidance. -- keywords: +p

[issue1565525] tracebacks eat up memory by holding references to locals and globals when they are not wanted

2013-08-29 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue1565525> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18592] IDLE: Unit test for SearchDialogBase.py

2013-08-31 Thread Phil Webster
Phil Webster added the comment: Added tests for labels, a mock function for widget creation, a back option for radiobuttontests, and the docstring fixes that Terry mentioned. -- Added file: http://bugs.python.org/file31542/18592_test_searchdialog2.diff

[issue18910] IDLE: Unit test for textView.py

2013-09-02 Thread Phil Webster
New submission from Phil Webster: Started writing the tests for textView.py. -- components: IDLE files: test_textview.patch keywords: patch messages: 196820 nosy: JayKrish, Todd.Rovito, philwebster, terry.reedy priority: normal severity: normal status: open title: IDLE: Unit test for

[issue11804] expat parser not xml 1.1 (breaks xmlrpclib)

2012-05-22 Thread Phil Daintree
Phil Daintree added the comment: Another example - the following xml returned and displayed from verbose mode: 0001 001 002 100 121213 123456 291 321654 580 ABS ACTIVE AIRCON ALIEJA AMP ASSETS BAKE BRACE BYC CARRO CARTON CO COMPS CULOIL DECOR DVD E FOOD HDD INF LAB LINER LL MCNBI MEDS

[issue11804] expat parser not xml 1.1 (breaks xmlrpclib)

2012-05-22 Thread Phil Daintree
Phil Daintree added the comment: The xml parses happily at http://www.w3schools.com/xml/xml_validator.asp -- ___ Python tracker <http://bugs.python.org/issue11

[issue5767] xmlrpclib expat

2012-05-24 Thread Phil Daintree
Changes by Phil Daintree : -- title: xmlrpclib loads invalid documents -> xmlrpclib expat versions: +Python 2.7 -Python 2.5, Python 2.6 ___ Python tracker <http://bugs.python.org/iss

[issue11804] expat parser not xml 1.1 (breaks xmlrpclib)

2012-05-24 Thread Phil Daintree
Phil Daintree added the comment: The field in question contains the utf-8 text: PEÇAS -- ___ Python tracker <http://bugs.python.org/issue11804> ___ ___ Python-bug

[issue11804] expat parser not xml 1.1 (breaks xmlrpclib)

2012-05-27 Thread Phil Daintree
Phil Daintree added the comment: Well maybe this should be a different bug as it is clearly not xml 1.1 related as the linue in the xml gives away :-) To repeat the bug ... using the webERP demo data #!/usr/bin/env python import xmlrpclib x_server = xmlrpclib.Server('

[issue11804] expat parser not xml 1.1 (breaks xmlrpclib)

2012-05-27 Thread Phil Daintree
Phil Daintree added the comment: or for less data... #!/usr/bin/env python import xmlrpclib x_server = xmlrpclib.Server('http://www.weberp.org/weberp/api/api_xml-rpc.php',verbose=True) #Get the stock items defined in the webERP installation

[issue7757] sys.path is incorrect when prefix is ""

2014-04-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue7757> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19533] Unloading docstrings from memory if -OO is given

2014-04-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue19533> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17277] incorrect line numbers in backtrace after removing a trace function

2014-04-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue17277> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12154] PyDoc Partial Functions

2014-04-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue12154> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13598] string.Formatter doesn't support empty curly braces "{}"

2012-10-31 Thread Phil Elson
Changes by Phil Elson : -- nosy: +pelson ___ Python tracker <http://bugs.python.org/issue13598> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13598] string.Formatter doesn't support empty curly braces "{}"

2012-10-31 Thread Phil Elson
Phil Elson added the comment: The current patch fails to catch the fact that auto vs manual numbering has been used in following corner case: from string import Formatter print(Formatter().format("{0:{}}", 'foo', 5)) To fix this, without adding state to the formatter

[issue13598] string.Formatter doesn't support empty curly braces "{}"

2012-10-31 Thread Phil Elson
Phil Elson added the comment: Ramchandra's fix looks fairly good, although there is at least one remaining issue (see my last comment). I have attached a patch which addresses (and tests) this. I'd be happy to pick this up if there are any remaining issues that need to be

[issue16382] Better warnings exception for bad category

2012-11-01 Thread Phil Elson
New submission from Phil Elson: When passing an invalid Warning subclasses to the warnings.warn function, a bare issubclass exception is raised: >>> import warnings >>> warnings.warn('hello world', 'not a valid warning type') Traceback (most recent call l

[issue16449] RotatingFileHandler rollover doesn't work on QNX shmem filesystems

2012-11-10 Thread Phil Connell
New submission from Phil Connell: logging.handlers.RotatingFileHandler.doRollover fails on QNX /dev/shmem filesystems (seen on a 6.4.0-based system). QNX RAM filesystems don't support rename() (see http://www.qnx.com/developers/docs/6.4.0/neutrino/sys_arch/fsys.html#DEVSHMEM - it

[issue16449] RotatingFileHandler rollover doesn't work on QNX shmem filesystems

2012-11-10 Thread Phil Connell
Changes by Phil Connell : -- type: -> behavior ___ Python tracker <http://bugs.python.org/issue16449> ___ ___ Python-bugs-list mailing list Unsubscri

[issue16449] RotatingFileHandler rollover doesn't work on QNX shmem filesystems

2012-11-11 Thread Phil Connell
Phil Connell added the comment: I'm not convinced that it matters whether the rename or move is atomic. Can anyone come up with a quick concrete example? I see two scenarios: 1. The process crashes during a copy in shutils.move(). In this case, some logs will be duplicated across the

[issue16449] RotatingFileHandler rollover doesn't work on QNX shmem filesystems

2012-11-11 Thread Phil Connell
Phil Connell added the comment: Serhiy, there are also calls to os.rename in RotatingFileHandler.doRollover -- ___ Python tracker <http://bugs.python.org/issue16

[issue16449] RotatingFileHandler rollover doesn't work on QNX shmem filesystems

2012-11-11 Thread Phil Connell
Phil Connell added the comment: I've updated the type to enhancement (it seems like a grey area to me - it's a behavioural fix for a niche use case). I suggested a patch rather than simply subclassing RotatingFileHandler since: - The subclass would just have a copy of RotatingFil

[issue16382] Better warnings exception for bad category

2012-11-20 Thread Phil Elson
Changes by Phil Elson : Added file: http://bugs.python.org/file28053/pelson_warnings_fix_2.diff ___ Python tracker <http://bugs.python.org/issue16382> ___ ___ Python-bug

[issue16382] Better warnings exception for bad category

2012-11-22 Thread Phil Elson
Changes by Phil Elson : Added file: http://bugs.python.org/file28072/pelson_warnings_fix_3.diff ___ Python tracker <http://bugs.python.org/issue16382> ___ ___ Python-bug

[issue16195] Difficult or impossible to figure out how garbage collector and weak references should interact for user-defined extension types

2013-10-04 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue16195> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14157] time.strptime without a year fails on Feb 29

2013-10-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue14157> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16596] Skip stack unwinding when "next", "until" and "return" pdb commands executed in generator context

2013-11-16 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue16596> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

2013-11-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue18864> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13907] test_pprint relies on set/dictionary repr() ordering

2013-11-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue13907> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16596] Skip stack unwinding when "next", "until" and "return" pdb commands executed in generator context

2013-11-23 Thread Phil Connell
Phil Connell added the comment: It looks like call_exc_trace is leaking refs to Py_None. I believe the attached patch fixes the issue (it certainly fixes Antoine's failing invokation :) -- Added file: http://bugs.python.org/file32794/issue16596_leak

[issue16596] Skip stack unwinding when "next", "until" and "return" pdb commands executed in generator context

2013-11-23 Thread Phil Connell
Phil Connell added the comment: Full run of the test suite was clean, so the fix is ready to go. -- ___ Python tracker <http://bugs.python.org/issue16596> ___ ___

[issue18036] "How do I create a .pyc file?" FAQ entry is out of date

2013-11-23 Thread Phil Connell
Phil Connell added the comment: I've had a stab at creating a patch for this. As well as mentioning __pycache__, I've tweaked some wording to reflect the fact that .pyc files are regenerated if the source file's length changes (as per issue13645). -- A

[issue13344] closed sockets don't raise EBADF anymore

2013-11-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue13344> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19291] Add docs for asyncio package (Tulip, PEP 3156)

2013-11-23 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue19291> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16669] Docstrings for namedtuple

2013-12-05 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue16669> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9232] Allow trailing comma in any function argument list.

2014-07-09 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue9232> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21999] shlex: bug in posix more handling of empty strings

2014-07-18 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue21999> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1152248] Add support for reading records with arbitrary separators to the standard IO stack

2014-07-26 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue1152248> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20217] Build failure in posixmodule.c with SCHED_SPORADIC available

2014-01-10 Thread Phil Connell
Phil Connell added the comment: Where I actually mean changeset 71704:89e92e684b37 -- ___ Python tracker <http://bugs.python.org/issue20217> ___ ___ Python-bug

[issue20217] Build failure in posixmodule.c with SCHED_SPORADIC available

2014-01-10 Thread Phil Connell
New submission from Phil Connell: Typo in revision 71704 that causes build failures on systems with SCHED_SPORADIC available. See attached patch. (Can reproduce by #defining SCHED_SPORADIC just above where it's used in posixmodule.c) -- components: Extension Modules

[issue2292] Missing *-unpacking generalizations

2014-02-07 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue2292> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5639] Support TLS SNI extension in ssl module

2009-08-31 Thread Phil Pennock
Phil Pennock added the comment: (Sorry for dropping this, lost available time) I see your point. OTOH, use of SNI needs to be something that can be disabled and people need to be able to connect to host A while supplying host B, not necessarily using IP addresses for the specificity. Use

[issue5639] Support TLS SNI extension in ssl module

2009-09-04 Thread Phil Pennock
Phil Pennock added the comment: wrapssl(server_hostname=True/False/String) looks good to me. Your arguments for enabling by default are compelling, for P3k. -- ___ Python tracker <http://bugs.python.org/issue5

[issue1337876] Inconsistent use of buffer interface in string and unicode

2009-03-24 Thread Phil Thompson
Phil Thompson added the comment: Yes I can update the patch, but it might be a while before I get the time. -- ___ Python tracker <http://bugs.python.org/issue1337

[issue5639] Support TLS SNI extension in ssl module

2009-03-31 Thread Phil Pennock
New submission from Phil Pennock : With TLS it is possible to have the client use an extension (defined in RFC 4366, and RFC 3546 before that) to indicate to the server which hostname it believes it is talking to. The server can then choose TLS certificates accordingly. This makes virtual

[issue5639] Support TLS SNI extension in ssl module

2009-04-01 Thread Phil Pennock
Phil Pennock added the comment: Note: this previous work is client-side only, as noted in the body of the report. I'll look into what's needed for clean server-side support too. -- ___ Python tracker <http://bugs.python.

[issue27146] posixmodule.c needs stdio.h

2016-05-28 Thread Phil Thompson
New submission from Phil Thompson: posixmodule.c needs to #include to get the declaration of ctermid(). On most platforms this happens as a side effect of including other .h files but does not on Android. -- components: Library (Lib) messages: 266561 nosy: philthompson10 priority

[issue27306] Grammatical Error in Documentation - Tarfile page

2016-06-13 Thread Phil Jeffes
New submission from Phil Jeffes: On the tarfile page (https://docs.python.org/3.5/library/tarfile.html) there is a line which reads: mode is either 'r' to read from an existing archive, 'a' to append data to an existing file, 'w' to create a new file overwri

[issue13598] string.Formatter doesn't support empty curly braces "{}"

2013-03-04 Thread Phil Elson
Phil Elson added the comment: > I didn't see a test case relating to the example in his comment, namely > > f.format("{0:{}}", 'foo', 5) > > Did I miss it? The example should fail, which it wouldn't have done with the patch previously propose

[issue16382] Better warnings exception for bad category

2013-03-04 Thread Phil Elson
Phil Elson added the comment: Ok. I think I've done all of the actions from the reviews. I'm not sure if I should remove the old patches or not? Thanks, -- Added file: http://bugs.python.org/file29304/pelson_warnings_fix_4.diff ___ Pyth

[issue17351] Fixed python3 descriptor documentation example + removal of explicit "object" inheritance in docs

2013-03-04 Thread Phil Elson
New submission from Phil Elson: The example at http://docs.python.org/3.4/howto/descriptor.html#properties does not run due to the old style "raise AttributeError, message" form. This patch fixes the problem, and also goes through the docs to remove explicit sub-classing from &qu

[issue17577] Add lookahead/peek wrapper to itertools

2013-03-29 Thread Phil Connell
New submission from Phil Connell: A recipe often requested on the likes of stackoverflow and activestate is a way to look 'ahead' in an iterator, without altering the values returned for subsequent next() calls. Last time this came up on python-ideas, it got a reasonable recepti

[issue17577] Add lookahead/peek wrapper to itertools

2013-03-31 Thread Phil Connell
Phil Connell added the comment: I like the suggested API: "iterator with indexing" is a good articulation of the request. -- ___ Python tracker <http://bugs.python.o

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2013-04-03 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue14905> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2013-04-03 Thread Phil Connell
Phil Connell added the comment: The problem appears to be more general. zipimport fails for deeper hierarchies, even with directory entries. With the supplied patch (zipimport-issue14905-2.patch) I see the following: $ unzip -l foo.zip Archive: foo.zip Length DateTimeName

[issue17630] Create a pure Python zipfile importer

2013-04-03 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue17630> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-04 Thread Phil Connell
New submission from Phil Connell: Only one level of namespace package nesting is handled correctly: $ unzip -l foo.zip Archive: foo.zip Length DateTimeName - -- - 0 2013-04-03 17:28 a/b/c/foo.py 0 2013-04-03 17:34 a/ 0

[issue14905] zipimport.c needs to support namespace packages when no 'directory' entry exists

2013-04-04 Thread Phil Connell
Phil Connell added the comment: I've raised issue17633 to track the issue in my last message. -- ___ Python tracker <http://bugs.python.org/issue14905> ___ ___

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-04 Thread Phil Connell
Changes by Phil Connell : -- nosy: +isoschiz ___ Python tracker <http://bugs.python.org/issue17633> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17636] Modify IMPORT_FROM to fallback on sys.modules

2013-04-04 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue17636> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-06 Thread Phil Connell
Changes by Phil Connell : Removed file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker <http://bugs.python.org/issue17633> ___ ___ Python-bug

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-06 Thread Phil Connell
Changes by Phil Connell : Added file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker <http://bugs.python.org/issue17633> ___ ___ Python-bugs-list m

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-06 Thread Phil Connell
Phil Connell added the comment: Here's a test that fails without the patch and succeeds with the patch. -- Added file: http://bugs.python.org/file29696/test.diff ___ Python tracker <http://bugs.python.org/is

[issue12820] Tests for Lib/xml/dom/minicompat.py

2013-04-06 Thread Phil Connell
Phil Connell added the comment: I happened to spot this issue languishing, and the markups looked pretty straightforward, so I just went ahead and did them. Updated patch attached. -- nosy: +pconnell Added file: http://bugs.python.org/file29698/minicompat_tests_markedup.diff

[issue9341] allow argparse subcommands to be grouped

2013-04-13 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue9341> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Changes by Phil Connell : Removed file: http://bugs.python.org/file29679/zipimport_ns.diff ___ Python tracker <http://bugs.python.org/issue17633> ___ ___ Python-bug

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Changes by Phil Connell : Removed file: http://bugs.python.org/file29696/test.diff ___ Python tracker <http://bugs.python.org/issue17633> ___ ___ Python-bugs-list mailin

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Phil Connell added the comment: The attached patch is ready for review. -- Added file: http://bugs.python.org/file29925/issue17633.diff ___ Python tracker <http://bugs.python.org/issue17

[issue15852] typos in curses argument error messages

2013-04-18 Thread Phil Connell
Phil Connell added the comment: The patch looks correct and complete, and still patches and passes the tests. So, as far as I can see, this can be committed. -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue15

[issue16355] inspect.getcomments() does not work in the interactive shell

2013-04-18 Thread Phil Connell
Phil Connell added the comment: Here's a patch that updates getcomments to match the behaviour of getsource, raising OSError if the source file can't be found and TypeError when passed a built-in. Since this is a backwards-incompatible change, presumably it can only be applied to

[issue17633] zipimport's handling of namespace packages is incorrect

2013-04-18 Thread Phil Connell
Phil Connell added the comment: Updated patch with markups suggested by Serhiy. -- Added file: http://bugs.python.org/file29927/issue17633-2.diff ___ Python tracker <http://bugs.python.org/issue17

[issue17123] Add OCSP support to ssl module

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue17123> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15992] Strict aliasing violations in Objects/unicodeobject.c

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue15992> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12489] email.errors.HeaderParseError if base64url is used

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue12489> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16394] Reducing tee() memory footprint

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue16394> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11549] Build-out an AST optimizer, moving some functionality out of the peephole optimizer

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue11549> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11698] Improve repr for structseq objects to show named, but unindexed fields

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue11698> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17306] Improve the way abstract base classes are shown in help()

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue17306> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16863] Python 2 error in Argparse tutorial

2013-04-19 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue16863> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17804] streaming struct unpacking

2013-04-20 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pconnell ___ Python tracker <http://bugs.python.org/issue17804> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17807] Generator cleanup without tp_del

2013-04-21 Thread Phil Connell
Changes by Phil Connell : -- nosy: +isoschiz, pconnell -pitrou ___ Python tracker <http://bugs.python.org/issue17807> ___ ___ Python-bugs-list mailing list Unsub

[issue17807] Generator cleanup without tp_del

2013-04-21 Thread Phil Connell
Changes by Phil Connell : -- nosy: +pitrou ___ Python tracker <http://bugs.python.org/issue17807> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    1   2   3   >