[issue28756] robotfileparser always uses default Python user-agent

2016-11-20 Thread John Nagle
John Nagle added the comment: Suggest adding a user_agent optional parameter, as shown here: def __init__(self, url='', user_agent=None): urllib.robotparser.RobotFileParser.__init__(self, url) # init parent self.user_agent = user_agent# save

[issue28756] robotfileparser always uses default Python user-agent

2016-11-20 Thread John Nagle
John Nagle added the comment: (That's from a subclass I wrote. As a change to RobotFileParser, __init__ should start like this.) def __init__(self, url='', user_agent=None): self.user_agent = user_agent#

[issue11933] newer() function in dep_util.py mixes up new vs. old files due stat.st_mtime vs stat

2011-06-09 Thread John S. Gruber
John S. Gruber added the comment: The patch worked--it eliminated the redundant copy caused by this issue. Thank you very much, Éric. On Fri, Jun 3, 2011 at 12:39 PM, Éric Araujo wrote: > > Éric Araujo added the comment: > > Can you tes

[issue1660009] continuing problem with httplib multiple set-cookie headers

2010-09-21 Thread John J Lee
John J Lee added the comment: What I said in 2007 re commas could be well out of date (might well have been so even then, in fact). Somebody should check what browsers do now... -- ___ Python tracker <http://bugs.python.org/issue1660

[issue2193] Cookie Colon Name Bug

2010-09-21 Thread John J Lee
John J Lee added the comment: Looks like a bug. Here's the trac bug that this caused -- trac fixed their bug by working around this bug in a really ugly way: http://trac.edgewall.org/ticket/2256 It would be nice to notify the trac developers if/when this is fixed. This bug is probabl

[issue2193] Cookie Colon Name Bug

2010-10-19 Thread John J Lee
John J Lee added the comment: dstanek> Would it be better to file bugs against buggy implementations instead of changing Python's implementation to be more lenient? No. Another app running on the same domain that knows nothing about RFC 2109 (and why should it?) shouldn'

[issue1520831] urrlib2 max_redirections=0 disables redirects

2010-11-13 Thread John J Lee
John J Lee added the comment: Why not? -- ___ Python tracker <http://bugs.python.org/issue1520831> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1520831] urrlib2 max_redirections=0 disables redirects

2010-11-15 Thread John J Lee
John J Lee added the comment: That's silly. A justification of the need for a new feature isn't needed, because this is already-implemented feature that simply does the wrong thing at the edge case. It's not high priority,

[issue11933] newer() function in dep_util.py mixes up new vs. old files due stat.st_mtime vs stat[ST_MTIME]

2011-04-26 Thread John S. Gruber
New submission from John S. Gruber : In researching a bug I was surprised that a newly created file was being replaced when being processed a second time (it shouldn't have been processed a second time). I tracked the surprise to diff Lib/distutils/dep_util.py @ 57642:9211a5d7d0b4 wh

[issue11933] newer() function in dep_util.py mixes up new vs. old files due stat.st_mtime vs stat[ST_MTIME]

2011-04-27 Thread John S. Gruber
John S. Gruber added the comment: Thanks for considering my report so quickly. Attached is a simple test to reproduce the bug, as you suggested. Please note that I am not suggesting the code base use stat.st_mtime. Running the attached with ext4, which keeps sub-second file timestamps

[issue11933] newer() function in dep_util.py mixes up new vs. old files due stat.st_mtime vs stat[ST_MTIME]

2011-04-27 Thread John S. Gruber
John S. Gruber added the comment: The original bug report is at: https://bugs.launchpad.net/ubuntu/+source/python-distutils-extra/+bug/770566 As you can see it had to do with a symbolic link created by distutils-extra before distutils was called upon to copy anything. Since this was done

[issue11933] newer() function in dep_util.py mixes up new vs. old files due stat.st_mtime vs stat[ST_MTIME]

2011-04-27 Thread John S. Gruber
John S. Gruber added the comment: I can understand what you are saying about side effects. I was trying to suggest that the move to stat.st_mtime in dep_util.py in the hg commit I mentioned be reverted back to use stat[ST_MTIME], thereby matching the other python releases and the old

[issue11933] newer() function in dep_util.py mixes up new vs. old files due stat.st_mtime vs stat[ST_MTIME]

2011-04-27 Thread John S. Gruber
John S. Gruber added the comment: As I thought about it, I suppose I should demonstrate the problem with stat.st_mtime. Here's an example and its output on an ext4 file system: gruber@gruber-Satellite-L355D:~$ ./mtime.py (1303933305.5525582, 1303933305.5525582) (1303933305.5

[issue11993] Is it desired to distinguish new files from old with sub-second resolution?

2011-05-03 Thread John S. Gruber
New submission from John S. Gruber : This report is meant to prompt discussion, if desired, on the advisability of distinguishing new files from old using subsecond data. (It isn't clear to me that it is important to do this.) Some file systems keep sub-second modification times, bu

[issue11993] Is it desired to distinguish new files from old with sub-second resolution?

2011-05-03 Thread John S. Gruber
John S. Gruber added the comment: Thanks for writing so quickly. This topic arose as part of issue 11933 (similar number). Éric Araujo asked that I bring this up in either mail to the fellowship of the packaging or as a separate bug report, so I chose to file this. Please see msg 134634

[issue11933] newer() function in dep_util.py mixes up new vs. old files due stat.st_mtime vs stat[ST_MTIME]

2011-05-06 Thread John S. Gruber
John S. Gruber added the comment: As Éric suggested I opened issue 11993 a couple of days ago. -- ___ Python tracker <http://bugs.python.org/issue11933> ___ ___

[issue1520831] urrlib2 max_redirections=0 disables redirects

2010-11-20 Thread John J Lee
John J Lee added the comment: Oops, I hadn't noticed that max_redirections isn't part of the API. In that case, I agree that it's not strictly a bug. I'd also agree it's not very important. FWIW: "want[ing] to see all redirects" is not the same thing as p

[issue2193] Cookie Colon Name Bug

2011-01-05 Thread John J Lee
John J Lee added the comment: karl: I'm not clear precisely what it is that you want to draw our attention to. Note this bug is about parsing of Cookie headers by servers, not production of Set-Cookie headers by servers. -- ___ Python tr

[issue2193] Cookie Colon Name Bug

2011-01-05 Thread John J Lee
John J Lee added the comment: Again, I don't think this is relevant, because the bug is about servers parsing Cookie: headers. Note that that string (the value of the Cookie: header) may be generated by a different server than the server that parses it (see the trac example mentioned i

[issue2193] Cookie Colon Name Bug

2011-01-05 Thread John J Lee
John J Lee added the comment: Yes, interoperability is good. Do you have a specific concern about the change that I proposed? If not, and you're instead just trying to ensure conformance, by all means read the draft specification that you pointed out and look for reasons why my sugg

[issue2193] Cookie Colon Name Bug

2011-01-05 Thread John J Lee
John J Lee added the comment: Yes, interoperability is good. Do you have a specific concern about the change that I proposed? If not, and you're instead just trying to ensure conformance, by all means read the draft specification that you pointed out and look for reasons why my sugg

[issue2193] Cookie Colon Name Bug

2011-01-30 Thread John J Lee
John J Lee added the comment: I agree with And Clover that Carsten Klein's comments in #msg127366 are not correct, for the reason that And stated. Also, Carsten repeats again the idea that the trac issue is about the trac server failing to generate appropriate cookies -- but that issu

[issue3012] disutils fails with GNU ld (GNU Binutils) 2.18.50.20080523

2008-05-30 Thread John Arbash Meinel
New submission from John Arbash Meinel <[EMAIL PROTECTED]>: I just upgraded my cygwin installation to the latest versions. Which seems to include GNU ld (GNU Binutils) 2.18.50.20080523 and GNU dllwrap (GNU Binutils) 2.18.50.20080523 It seems that their version notation

[issue3013] disutils fails with GNU ld (GNU Binutils) 2.18.50.20080523

2008-05-30 Thread John Arbash Meinel
New submission from John Arbash Meinel <[EMAIL PROTECTED]>: I just upgraded my cygwin installation to the latest versions. Which seems to include GNU ld (GNU Binutils) 2.18.50.20080523 and GNU dllwrap (GNU Binutils) 2.18.50.20080523 It seems that their version notation

[issue3013] disutils fails with GNU ld (GNU Binutils) 2.18.50.20080523

2008-05-30 Thread John Arbash Meinel
Changes by John Arbash Meinel <[EMAIL PROTECTED]>: -- components: +Distutils ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3013> ___ _

[issue3012] disutils fails with GNU ld (GNU Binutils) 2.18.50.20080523

2008-05-30 Thread John Arbash Meinel
John Arbash Meinel <[EMAIL PROTECTED]> added the comment: can you link the bug that this is a dupe of? I did a search and didn't find anything. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3013] disutils fails with GNU ld (GNU Binutils) 2.18.50.20080523

2008-05-30 Thread John Arbash Meinel
John Arbash Meinel <[EMAIL PROTECTED]> added the comment: Quick patch that changes the regex -- keywords: +patch Added file: http://bugs.python.org/file10481/cygwinccompiler.diff ___ Python tracker <[EMAIL PROTECTED]> <http://

[issue3013] disutils fails with GNU ld (GNU Binutils) 2.18.50.20080523

2008-06-02 Thread John Arbash Meinel
John Arbash Meinel <[EMAIL PROTECTED]> added the comment: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Georg Brandl wrote: | Georg Brandl <[EMAIL PROTECTED]> added the comment: | | Do you need the (\.\d+)* trailer in the regex at all? | | -- | nosy: +georg.brandl Not sure

[issue2275] urllib2 header capitalization

2008-07-10 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: * The patch looks like it will break code that uses .header_items(), which is not acceptable. * The patch to the docs seems to muddy the waters even further (than the current slightly murky state) about whether and why .headers is

[issue2275] urllib2 header capitalization

2008-07-11 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: There already is a test for the breakage, but the patch changes the expected output to match the new return value of .header_items(): -[('Foo-bar', 'baz'), ('Spam-eggs', 'blah')] +[('

[issue2275] urllib2 header capitalization

2008-07-11 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: > > * The patch to the docs seems to muddy the waters even further (than the > > current slightly murky state) about whether and why .headers is to be > > preferred over the methods, or vice-versa. I think .headers should

[issue2275] urllib2 header capitalization

2008-07-11 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Just to quickly note that by "providing case-insensitive lookup" I don't necessarily mean via .headers. But it's you who's providing the patch, so I'll wait for your next suggestion rather than

[issue2275] urllib2 header capitalization

2008-07-22 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: > With respect to point 1), I assume that we all agree upon that headers > should stored in Titled-Format instead of Capitalized-format. I would probably choose to store the headers in Capitalized-form, because that makes implement

[issue2275] urllib2 header capitalization

2008-07-22 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Of course, that "along the lines of" suggestion isn't quite right: None does not have a .title() method. (and, to spell it out, I'm assuming in that suggestion that .headers is the dict of headers with .capitalize()d

[issue2275] urllib2 header capitalization

2008-08-12 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: The CaseInsensitive dict class fails to preserve its invariants (implied invariants, since there are no tests for it). There are also problems with the documentation in the patch. I will submit a modified patch, I hope later thi

[issue2275] urllib2 header capitalization

2008-08-12 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: By the way, this is a feature addition, not a bug fix. The first beta releases for 2.6 and 3.0 came out some time ago, so according to PEP 361, this change should not be committed to trunk until after the 2.6 / 3.0 maintenance branches hav

[issue3577] Interpreter name: python vs. python-3.0

2008-08-17 Thread John J Lee
New submission from John J Lee <[EMAIL PROTECTED]>: The tutorial says: "The Python interpreter is usually installed as /usr/local/bin/python on those machines where it is available" Shouldn't that be "python3" or "python-3.0"? And the same throughou

[issue3577] Interpreter name: python vs. python-3.0

2008-08-17 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: "make install" actually installs as "python3.0" (and not as "python-3.0", nor "python3", nor "python"). ___ Python track

[issue3858] make install tries to install files outside of --prefix

2008-09-13 Thread John J Lee
New submission from John J Lee <[EMAIL PROTECTED]>: ./configure --prefix=DIR && make && make install tries to install files in directories outside of DIR. This happens both with trunk (r66412) and 2.6b3. This is a problem for users of GNU stow, for example. I know that

[issue3858] make install tries to install files outside of --prefix

2008-09-13 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: OK, this was because I had a .pydistutils.cfg file containing the following (ironically, put there following somebody's recipe for installing setuptools packages using stow): [install] install_lib=~/lib/python$py_version_short/si

[issue2190] MozillaCookieJar ignore HttpOnly cookies

2008-10-09 Thread John J Lee
Changes by John J Lee <[EMAIL PROTECTED]>: -- nosy: +jjlee ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2190> ___ ___ Python-bugs

[issue1028088] Cookies without values are silently ignored (by design?)

2008-10-09 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: You haven't said what the specific problem is. Note that the SimpleCookie class really represents a set of cookies, and the Morsel class represents a single cookie. It seems that setting special value-less cookie-attributes like &qu

[issue1028088] Cookies without values are silently ignored (by design?)

2008-10-10 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I was responding to your comment of 2008-10-08 03:08, not to the opening comment. I already responded to the opening comment. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue1028088] Cookies without values are silently ignored (by design?)

2008-10-10 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: The Cookie: header does not have a "secure flag" (The Set-Cookie: header does). I don't strongly object to the issue identified in the original comment being fixed. ___ Python trac

[issue7896] IDLE.app crashes when attempting to open a .py file

2010-02-09 Thread John-Michael Glenn
New submission from John-Michael Glenn : This happens every time I try to open any .py file from anywhere in my computer. I start IDLE.app and go to the menu and open a file then it pauses and crashes. I get a similar event when I try to use the Run Module option from the menu, except it

[issue3646] MacOS X framework install to non-standard directory fails

2010-02-09 Thread John-Michael Glenn
John-Michael Glenn added the comment: I'm using Python 2.6.4 on OSX 10.6 and I first used the mv command to rename the original python.framework. Then I was able to install 2.6 as the new python.framework. These are the commands: rename it: sudo mv /Library/Frameworks/Python.fram

[issue7896] IDLE.app crashes when attempting to open a .py file

2010-02-10 Thread John-Michael Glenn
John-Michael Glenn added the comment: I compiled it myself. "I know there are issues with the system Tk 8.5 on OSX 10.6, although this is a new type of problem and and probably unrelated to the other ones." ...crap, I have 8.5 on 10.6.2 "...start IDLE by running "/Appl

[issue8378] PYTHONSTARTUP broken on Windows

2010-04-12 Thread John Van Praag
New submission from John Van Praag : The PYTHONSTARTUP environment variable does not work--does not import the indicated startup file--when IDLE is started under Windows. I have tested under Windows XP SP2, and under Windows Vista Ultimate 64 bit. The os.environ variable does list the startup

[issue8350] os.mkdir doc comment is incorrect

2010-05-08 Thread John Mark Schofield
John Mark Schofield added the comment: Please don't close this as "invalid." Most (all?) of the functions in the os module have positional-only arguments, which are documented in exactly the same manner as arguments which can be supplied using a keyword. As someone reading th

[issue8350] os.mkdir doc comment is incorrect

2010-05-08 Thread John Mark Schofield
John Mark Schofield added the comment: I'd also suggest changing the title to "Documentation for many functions in os module is incomplete." I didn't because I don't know if that would be considered rude. (I'

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-09 Thread John J Lee
John J Lee added the comment: It looks to me that it's just request_path that's wrong, so no need to add extra arguments to that function. It should discard the query and fragment (still keeping the "parameters" -- using urlparse.urlsplit instead of urlparse.urlparse wou

[issue6588] insert cookies into cookie jar - cookielib.py

2010-05-09 Thread John J Lee
John J Lee added the comment: Jon, If you want to get these changes applied you need to: 1. Split up these three separate issues 2. Most important: explain in full detail exactly how you used cookielib, what you expected it to do, and what it actually did, and then justify why your

[issue5537] LWPCookieJar cannot handle cookies with expirations of 2038 or greater on 32-bit platforms

2010-05-09 Thread John J Lee
John J Lee added the comment: Shouldn't module time be changed to use a cross-platform implementation that uses a 64 bit time_t-like type? Apparently Perl 6 has made the equivalent change. Admittedly there seems to be no sign of that actually happening. -- nosy: +

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-10 Thread John J Lee
John J Lee added the comment: I'll upload a patch when I'm back home (bugs.python.org went down yesterday). Will turn docstring into comment. -- ___ Python tracker <http://bugs.python.

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-10 Thread John J Lee
John J Lee added the comment: Just re-read your comment, Tres. Since when do docstrings determine whether a stdlib function is public? If it's documented in the docs, it's public. If not, it's not. This function isn't, so it's not public. It'

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-10 Thread John J Lee
Changes by John J Lee : Added file: http://bugs.python.org/file17285/issue3704.patch ___ Python tracker <http://bugs.python.org/issue3704> ___ ___ Python-bugs-list mailin

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-10 Thread John J Lee
John J Lee added the comment: Didn't bother changing docstring to comment, since that would be inconsistent with rest of module. -- ___ Python tracker <http://bugs.python.org/i

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-10 Thread John J Lee
John J Lee added the comment: FWIW, the "certain semantics" that request_path "promises" are 1. that it returns the RFC 2965 request-URI (which has never been true -- it returns the path component of the request-URI instead) and 2. that that request-URI is as defined i

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-11 Thread John J Lee
John J Lee added the comment: What specific breakage do you expect resulting from my patch being backported? There is no behaviour change here, except to the minimal extent that all bug fixes involve behaviour change. This seems a clear-cut backport candidate. It's not a surprise to me

[issue735515] urllib / urllib2 should cache 301 redirections

2008-01-20 Thread John J Lee
John J Lee added the comment: In what respect? I just meant that it would be nice (and more compliant with the RFC) if rather than fetching the original URL each time, a map of URLs to 301-redirected URLs was kept. For urllib2, I suppose the map would be a private attribute of

[issue1777134] minidom pretty xml output improvement

2008-02-12 Thread John-Mark Gurney
John-Mark Gurney added the comment: I think this is a good patch. It gives more useful pretty XML output. I would suggest that possibly this routine be moved to xml.dom or xml.dom.utils instead of being part of minidom since it should not be minidom specific. There is one bug in the patch in

[issue841728] urllib and cookie module improvements

2008-02-24 Thread John J Lee
John J Lee added the comment: This should be closed. Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue841728> ___ Python-bugs-list mailing list Unsubs

[issue2289] os.path.normpath over-normalizes

2008-03-14 Thread John Love-Jensen
New submission from John Love-Jensen <[EMAIL PROTECTED]>: I found a bug (or at least a shortcoming) in Python's os.path.normpath routine. It overly normalizes, at least for Unix and Unix-like systems (including Mac), and Windows. Example: x = os.path.join(".", &quo

[issue2450] urllib2.Request constructor has no timeout parameter

2008-03-21 Thread John J Lee
New submission from John J Lee <[EMAIL PROTECTED]>: r55792 added timeout support to urllib2. A timeout parameter was added to urllib2.OpenerDirector.open(), but there is no corresponding Request constructor parameter. timeout is unique in that respect. Instead, OpenerDirector.open(

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-21 Thread John J Lee
New submission from John J Lee <[EMAIL PROTECTED]>: The new timeout support in 2.6 makes use of new function socket.create_connection(). socket.create_connection() provides no way to disable timeouts, other than by relying on socket.getdefaulttimeout() returning None. This is unfor

[issue2452] inaccuracy in httplib timeout documentation

2008-03-21 Thread John J Lee
New submission from John J Lee <[EMAIL PROTECTED]>: The documentation for the new timeout support in 2.6 states that "If the optional timeout parameter is given, connection attempts will timeout after that many seconds". In fact, other non-blocking. The only operation that

[issue2452] inaccuracy in httplib timeout documentation

2008-03-21 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Oops, un-finished sentence in my opening comment ("In fact, other non-blocking.") should have read: In fact, other blocking operations will also time out. __ Tracker <[EMAIL PROTECTED]> &

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-21 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I see this thread: http://www.gossamer-threads.com/lists/python/dev/552292 But I don't see an explanation of this API decision there that I understand. *Because* socket.setdefaulttimeout() is a hack for when nothing else is avail

[issue2450] urllib2.Request constructor has no timeout parameter

2008-03-21 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: This should be solved by introducing a "not set" value other than None. __ Tracker <[EMAIL PROTECTED]> <http://

[issue2450] urllib2.Request constructor has no timeout parameter

2008-03-21 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I don't buy the "API complication" argument. I might accept an argument that the timeout isn't really anything to do with the request, so I won't bother to continue with this bug report. ___

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-27 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Great. I'll try to submit a patch this weekend. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2451> __

[issue2275] urllib2 header capitalization

2008-03-30 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Specifically, these improvements could be made: * the headers actually sent to httplib could be normalized to Standard-Http-Case by urllib2 * the urllib2.Request.headers interface could support case-insensitive key

[issue2275] urllib2 header capitalization

2008-03-30 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: urllib2.Request.headers is, in practice, an undocumented public interface. Did you run the tests? There is room for improvement here, but not in the way you suggest. python[1]$ python2.6 iPython 2.6a1+ (trunk:62045M, Mar 30 2008, 03

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-30 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I've attached a patch. My patch introduces one minor issue: it's an inconvenience when wrapping objects if special default values like socket._GLOBAL_DEFAULT_TIMEOUT are not public. However, I think it's not worth maki

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-30 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Should I also have selected "Python 3.0" from the "Versions" list, BTW? Don't know what the proper process is ATM... __ Tracker <[EMAIL PROTECTED]&

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-03-30 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Me: """ This should be done in such a way as to also fix the lack of documentation of the None special value in the protocol modules documentation (httplib, etc.). I should have fixed that as part of this patch, but ran

[issue2646] Python does not accept unicode keywords

2008-04-16 Thread John (J5) Palmieri
New submission from John (J5) Palmieri <[EMAIL PROTECTED]>: # given this function def a(**kwargs): pass # this works a(**{'b':'c'}) # this throws a format error a(**{u'b':'c'}) I am using a web framework (TurboGears w/ genshi templating) w

[issue2646] Python does not accept unicode keywords

2008-04-16 Thread John (J5) Palmieri
John (J5) Palmieri <[EMAIL PROTECTED]> added the comment: Someone has convinced me that it is not worth bothering the dev team since they will have this fixed in P3k the right way. If it is easy then please fix this, otherwise feel free to close. __ T

[issue2672] speed of set.update([])

2008-04-22 Thread John Arbash Meinel
New submission from John Arbash Meinel <[EMAIL PROTECTED]>: I was performance profiling some of my own code, and I ran into something unexpected. Specifically, set.update(empty_generator_expression) was significantly slower than set.update(empty_list_expression). I double checked my fi

[issue2672] speed of set.update([])

2008-04-22 Thread John Arbash Meinel
Changes by John Arbash Meinel <[EMAIL PROTECTED]>: -- type: -> performance __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2672> __ ___ Python-b

[issue2672] speed of set.update(

2008-04-24 Thread John Arbash Meinel
John Arbash Meinel <[EMAIL PROTECTED]> added the comment: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alexander Belopolsky wrote: > Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: > > This has nothing to do with set.update, the difference is due to th

[issue2672] speed of set.update(

2008-04-24 Thread John Arbash Meinel
John Arbash Meinel <[EMAIL PROTECTED]> added the comment: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Raymond Hettinger wrote: > Raymond Hettinger <[EMAIL PROTECTED]> added the comment: > > John, when y=[], the update method has to create a new list iterator on > ea

[issue2451] No way to disable socket timeouts in httplib, etc.

2008-04-25 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Facundo, are you going to review this? __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2451> __ ___ Python

[issue2007] cookielib lacks FileCookieJar class for Internet Explorer

2008-10-15 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Note that the code on wwwsearch.sf.net only reads cookies, and does not write them. Also, the approach used is fragile to changes to MS's "index.dat" database, which was the reason why that code was not included when cookiel

[issue1570255] redirected cookies

2008-10-15 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Sorry I turned up rather late here (is there a way to subscribe to changes to all bugs whose comments or title contain a given string?) If it works with Firefox and not with cookielib it's almost certainly a bug. However, it's

[issue2190] MozillaCookieJar ignore HttpOnly cookies

2008-10-15 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I think firefox 3 no longer writes cookies.txt (it writes cookies.sqlite instead). Can anybody point out a version of firefox that wrote this HttpOnly information to cookies.txt, so the patch can be

[issue4131] Note that Firefox 3 does not write cookies.txt

2008-10-15 Thread John J Lee
New submission from John J Lee <[EMAIL PROTECTED]>: Just adds a note to the cookielib documentation to point out that Firefox 3 no longer writes cookies.txt, the file format understood by cookielib.MozillaCookieJar (firefox now maintains persistent cookie state in an sqlite da

[issue3704] cookielib doesn't handle URLs with / in parameters

2008-10-15 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Do we have an RFC 3986 URI parser in the stdlib now? It would be better to use that if so, but I don't see one. Failing that, an implementation of the relevant part of that RFC is only about four lines of code, so that would be

[issue3924] cookielib chokes on non-integer cookie version, should ignore it instead

2008-10-15 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: The sensible fix for this is to strip the quotes off, defaulting to version 0 on failure to parse the version cookie-attribute. It's not necessary to retain the original version string. By the way, what you posted warning rather than

[issue2007] cookielib lacks FileCookieJar class for Internet Explorer

2008-10-16 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Forgot to add: if somebody else does the work, I'm happy to agree to the code being used in Python stdlib. Perhaps it would be necessary to get the author of the original Perl code from which this MSIE class is derived to sign a

[issue3647] urlparse - relative url parsing and joins to be RFC3986 compliance

2008-10-16 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: There are a bunch of other candidate implementations of this RFC kicking around, I think. Also, I believe there was agreement on python-dev that a new module should be added rather than changing the behaviour of module urlparse. -

[issue3647] urlparse - relative url parsing and joins to be RFC3986 compliance

2008-10-16 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Here they are: http://bugs.python.org/issue1500504 http://bugs.python.org/issue1462525 http://bugs.python.org/issue1591035 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3647] urlparse - relative url parsing and joins to be RFC3986 compliance

2008-10-16 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Hmm, I see you've already commented on some of those, Senthil. Perhaps you could add a comment to this bug explaining how your patch relates to the others. Should it replace them? (why?) Should one of those patches be applied also

[issue2275] urllib2 header capitalization

2008-10-25 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I have attached a patch that just: * Improves doctests a bit * Changes .get_headers() and .has_header() to be case-insensitive * Documents .get_header() and .header_items(), fixes some incorrectly-documented argument names, and notes th

[issue2275] urllib2 header capitalization

2008-10-25 Thread John J Lee
Changes by John J Lee <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11887/issue2775-problems.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2756] urllib2 add_header fails with existing unredirected_header

2008-10-25 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I agree there is a bug here: clearly the methods on the Request class are inconsistent with AbstractHTTPHandler.do_open() . I think Facundo's patch is good, though it needs a test. The general principle when fixing earlier bugs ha

[issue3924] cookielib chokes on non-integer cookie version, should ignore it instead

2008-10-25 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: Patch with tests attached. The patch is slightly different to my first suggestion: in the patch, invalid version values cause the cookie to be ignored (but double quotes around valid versions are fine). -- keywords: +patch Adde

[issue3924] cookielib chokes on non-integer cookie version, should ignore it instead

2008-10-25 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: The bug is present on trunk and on the py3k branch, so I've selected versions "Python 2.7" and "Python 3.0" This is a straightforward bug, so I selected 2.5.3 and 2.6 also, to indicate this is a candidate for b

[issue2464] urllib2 can't handle http://www.wikispaces.com

2008-12-02 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: This fix was applied in the wrong place. URI path components, and HTTP URI path components in particular, *can* be empty. See RFC 3986. So the comment in the code that was inserted with the fix for this bug that says "possibly ma

[issue3819] urllib2 sends Basic auth across redirects

2008-12-02 Thread John J Lee
John J Lee <[EMAIL PROTECTED]> added the comment: I agree this is a bug. Senthil -- re "1)", the paragraph you refer to (quoted by the OP) is relevant. The fact that it doesn't specifically mention redirection is not relevant. Re "2)": I don't know how dige

<    6   7   8   9   10   11   12   13   >