Change by hai shi :
--
nosy: +paul.j3, rhettinger
___
Python tracker
<https://bugs.python.org/issue42980>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> New C API functions must not return borrowed references, but strong
> references.
Thanks petr, victor for your suggestion. It's more friendly to users.
> Which one should be returned by PyType_GetName()? Is there a warranty that
> it's
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue42955>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Wait. petr mentioned `_PyType_Name` in PR 23903 which use the short name. So I
am not sure which way is better. Lol~
--
___
Python tracker
<https://bugs.python.org/issue42
Change by hai shi :
--
nosy: +paul.j3, rhettinger
___
Python tracker
<https://bugs.python.org/issue42966>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
As the title mentioned. A entire py_curses capi struct would be better than
pointer array.
Related PR: PR 24186
--
assignee: shihai1991
messages: 385532
nosy: shihai1991, vstinner
priority: normal
severity: normal
status: open
title: Port curses capi
Change by hai shi :
--
keywords: +patch
pull_requests: +23125
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24304
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
I have checked all capi instances have been allocated in the heap memory.
So I think this bpo can be closed ;)
Thanks Erlend for your contribution.
Thanks victor, petr for your review&merge.
--
resolution: -> fixed
stage: patch review -> resol
hai shi added the comment:
> If PyCapsule_Import() fails, zoneinfomodule_exec() returns 0 (success) with
> an exception raised.
Why not return -1 directly when PyCapsule_Import() fails?
It looks like more simpler. Do I miss something?
--
nosy: +shih
Change by hai shi :
--
keywords: +patch
pull_requests: +23152
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24333
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> It's already the case. Example
Nice, interesting case.
--
___
Python tracker
<https://bugs.python.org/issue42979>
___
_
hai shi added the comment:
> The _decimal API is also just an array of pointers. Should we change that to
> a struct as well?
+1. IMHO, structure is more directly than pointer array. And there haven't
exposing this pointer array to users(no backward co
hai shi added the comment:
> The _decimal API is also just an array of pointers. Should we change that to
> a struct as well?
Hi, victor. Do you have suggestion about it :)
--
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
I found `type.__name__` has the implementation details in
https://github.com/python/cpython/blob/master/Objects/typeobject.c#L486.
IMHO, keep the consistency in `PyType_GetName()` is OK.
Victor, Petr. Do you think it make senses
Change by hai shi :
--
nosy: +paul.j3
___
Python tracker
<https://bugs.python.org/issue43160>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
>> PyCFunction_NewEx is part of the limited API as well, even though it's
>> undocumented. People can call it.
>
>Wait no, I wrote too soon.
>PyCFunction_NewEx is part of the limited API as well, even though it's
>>undocumente
Change by hai shi :
--
nosy: +paul.j3, rhettinger
___
Python tracker
<https://bugs.python.org/issue43259>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> So it doesn't sound like a good idea to immediately remove these two macros.
MAYBE we can update the annotation in pyfpe.h to address that we will remove
those macros in python 4.0.
The fpe have been removed, so those macros will be removed
Change by hai shi :
--
nosy: +giampaolo.rodola
___
Python tracker
<https://bugs.python.org/issue43285>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Maybe Guido can give you some answers.
Related commit:
https://github.com/python/cpython/commit/f26cda62b68b68c07666f2f21b1f16ded03afa37.
--
nosy: +gvanrossum, shihai1991
___
Python tracker
<https://bugs.python.
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 4.0 -> 5.0
pull_requests: +23424
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24639
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
> It would be great to have a tool to check that all symbols exported on Unix
> are also exported on Windows.
I write a demo in PR 24639(compare the stable_abi.dat to python3dll.c).
And the output result:
```
Some symbols from the limited API on windows are m
hai shi added the comment:
Hi, Chigozirim Chukwu. Thanks for your report.
There have releated comment in: https://bugs.python.org/issue17050#msg315716
--
nosy: +paul.j3, rhettinger, shihai1991
versions: +Python 3.10
___
Python tracker
<ht
Change by hai shi :
--
keywords: +patch
nosy: +shihai1991
nosy_count: 1.0 -> 2.0
pull_requests: +23470
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24688
___
Python tracker
<https://bugs.python.org/i
hai shi added the comment:
> It is not "bad"; it is just more wordy.
Agree. Using sturct will be more easy check the members.
But converting the decimal c api may breaks the compatibility, because some
macros like `PyDec_TypeCheck_INDEX` have been expos
hai shi added the comment:
> True. Is there many external users of this API? I could not find any relevant
> examples using searchcode.com.
Hm, many teams don't open their code, so we get check all user cases by
searchcode web. So I have no any better sugessti
hai shi added the comment:
+1 from me. 3.10.0 final haven't been released, so no one will be affected.
--
nosy: +shihai1991, vstinner
___
Python tracker
<https://bugs.python.org/is
Change by hai shi :
--
pull_requests: +19504
pull_request: https://github.com/python/cpython/pull/20207
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19549
pull_request: https://github.com/python/cpython/pull/20263
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40703>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +19609
pull_request: https://github.com/python/cpython/pull/20344
___
Python tracker
<https://bugs.python.org/issue38
Change by hai shi :
--
pull_requests: +19712
pull_request: https://github.com/python/cpython/pull/20459
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19728
pull_request: https://github.com/python/cpython/pull/20479
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19731
pull_request: https://github.com/python/cpython/pull/20482
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19850
pull_request: https://github.com/python/cpython/pull/20625
___
Python tracker
<https://bugs.python.org/issue40
New submission from hai shi :
petr have write a PR(adding a method: _PyType_GetModuleByDef) to supply pep573
in
https://github.com/encukou/cpython/pull/4/commits/98dd889575cf7d1688495983ba791e14894a0bb8
So I try to use pep573 in functools again in:
https://github.com/shihai1991/cpython/pull
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40521>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +19903
pull_request: https://github.com/python/cpython/pull/20689
___
Python tracker
<https://bugs.python.org/issue40
New submission from hai shi :
redundant if statements in itertools、_functools、_io, so remove it.
--
components: Extension Modules
messages: 370883
nosy: shihai1991
priority: normal
severity: normal
status: open
title: Remove redundant if statements in tp_traverse
versions: Python 3.10
Change by hai shi :
--
keywords: +patch
pull_requests: +19907
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20692
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
Thanks, Inada :)
--
___
Python tracker
<https://bugs.python.org/issue40898>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +19941
pull_request: https://github.com/python/cpython/pull/20732
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19964
pull_request: https://github.com/python/cpython/pull/20765
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19990
pull_request: https://github.com/python/cpython/pull/20794
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +19993
pull_request: https://github.com/python/cpython/pull/20797
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
I propose to start updating tests to use directly support.import_helper and
support.os_helper. Hai: do you want to work on that? Maybe start by focusing on
import_helper (but if you modify a test, check for also symbols imported from
os_helper).
> of course
Change by hai shi :
--
pull_requests: +20019
pull_request: https://github.com/python/cpython/pull/20824
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20042
pull_request: https://github.com/python/cpython/pull/20849
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40925>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from hai shi :
Looks like `classname` in PyErr_NewException() is redundant:
https://github.com/python/cpython/blob/master/Python/errors.c#L1082
--
components: Interpreter Core
messages: 371438
nosy: shihai1991
priority: normal
severity: normal
status: open
title: Remove
Change by hai shi :
--
keywords: +patch
pull_requests: +20043
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/20850
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
Thanks, Dong-hee Na.
--
___
Python tracker
<https://bugs.python.org/issue40966>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
LGTM. It's a lightweight patch :)
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue37910>
___
___
Pytho
Change by hai shi :
--
nosy: +shihai1991
nosy_count: 12.0 -> 13.0
pull_requests: +20067
pull_request: https://github.com/python/cpython/pull/20824
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
Thanks for your report. I am not catch this segfault in my python compiler. I
test your example in:
Python 3.8.3 (v3.8.3:6f8c832)
Python 3.9.0b3 (v3.9.0b3-dirty:b484871)
Python 3.10.0a0 (heads/master-dirty:1c209e3)
--
nosy: +shihai1991
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40993>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> Attached PR skips these jobs on pull requests.
I am not familiar with travis ci. coverage jobs can tell us how many features
need add unit tests. Can we use other CI services to do this job? MAYBE in
checks gate or something other services l
hai shi added the comment:
> Coverage jobs are still run with my changes.
> https://codecov.io/gh/python/cpython is still updated.
Copy that, thanks.
--
___
Python tracker
<https://bugs.python.org/i
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40987>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue36346>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41006>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +20135
pull_request: https://github.com/python/cpython/pull/20957
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41036>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41034>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue1944>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41073>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
Hi, victor. If you have much bpo need to manage, I could take a look in this
week :)
--
___
Python tracker
<https://bugs.python.org/issue41
Change by hai shi :
--
pull_requests: +20253
pull_request: https://github.com/python/cpython/pull/21087
___
Python tracker
<https://bugs.python.org/issue1635
Change by hai shi :
--
pull_requests: +20310
pull_request: https://github.com/python/cpython/pull/21151
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue40799>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue4>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by hai shi :
--
pull_requests: +20325
pull_request: https://github.com/python/cpython/pull/21167
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> Python 2 is EOL, so I think this issue should be closed.
+1, if someone need create a PR, we can reopen it again.
--
___
Python tracker
<https://bugs.python.org/issu
hai shi added the comment:
> My PR of bpo-40799 fix this issue.
Thanks victor for your work, I closed my PR ;)
--
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
nosy: +shihai1991
nosy_count: 5.0 -> 6.0
pull_requests: +20327
pull_request: https://github.com/python/cpython/pull/21169
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +20328
pull_request: https://github.com/python/cpython/pull/21169
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
historical discuss: bpo17162
--
___
Python tracker
<https://bugs.python.org/issue41073>
___
___
Python-bugs-list mailing list
Unsub
hai shi added the comment:
I create a PR in: https://github.com/shihai1991/cpython/pull/13/commits.
Looks like It works.
If we extend PyType_GetSlot() to accept non-heaptype, we need find a way to
judge the max slot of non-heaptype.
--
___
Python
Change by hai shi :
--
pull_requests: +20371
pull_request: https://github.com/python/cpython/pull/21219
___
Python tracker
<https://bugs.python.org/issue40
hai shi added the comment:
> bpo-17162 added PyType_GetSlot(), but static types were not discussed there.
Thanks to correct my info. I paste this bpo just Larry have mentioned the
static type in PyType_GetSlot() :)
--
___
Python tracker
<
Change by hai shi :
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue38980>
___
___
Python-bugs-list mailing list
Unsubscribe:
hai shi added the comment:
> You'll probably need some table like typeslots.inc to record which sub-slots
> struct each slot belongs to.
Looks like it's a good way to solve this probleam, Let me try it ;)
--
___
Python
Change by hai shi :
--
pull_requests: +20466
pull_request: https://github.com/python/cpython/pull/21314
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20467
pull_request: https://github.com/python/cpython/pull/21315
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20470
pull_request: https://github.com/python/cpython/pull/21317
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
keywords: +patch
pull_requests: +20543
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21395
___
Python tracker
<https://bugs.python.org/issu
Change by hai shi :
--
pull_requests: +20561
pull_request: https://github.com/python/cpython/pull/21412
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20596
pull_request: https://github.com/python/cpython/pull/21448
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20597
pull_request: https://github.com/python/cpython/pull/21449
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20598
pull_request: https://github.com/python/cpython/pull/21450
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20599
pull_request: https://github.com/python/cpython/pull/21451
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20600
pull_request: https://github.com/python/cpython/pull/21452
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20746
pull_request: https://github.com/python/cpython/pull/21605
___
Python tracker
<https://bugs.python.org/issue1635
hai shi added the comment:
What's change for the performance benchmark?
--
nosy: +shihai1991
___
Python tracker
<https://bugs.python.org/issue41340>
___
___
hai shi added the comment:
>I haven't checked to see what's documented. I'm sure we'd accept a patch that
>improves the documentation if it's lacking.
+1
--
nosy: +shihai1991
___
Python tracker
<
Change by hai shi :
--
pull_requests: +20870
pull_request: https://github.com/python/cpython/pull/21727
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20895
pull_request: https://github.com/python/cpython/pull/21743
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20908
pull_request: https://github.com/python/cpython/pull/21764
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20917
pull_request: https://github.com/python/cpython/pull/21772
___
Python tracker
<https://bugs.python.org/issue40
Change by hai shi :
--
pull_requests: +20922
pull_request: https://github.com/python/cpython/pull/21771
___
Python tracker
<https://bugs.python.org/issue40
401 - 500 of 700 matches
Mail list logo