[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)

2010-04-18 Thread Brett Cannon
Brett Cannon added the comment: Let's try this again... -- Added file: http://bugs.python.org/file16976/subprocess__del__.diff ___ Python tracker <http://bugs.python.org/i

[issue2090] __import__ with fromlist=

2010-04-18 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the patch, George. I will get it when I can. And this make me even more glad that we removed the file path import from 3.x. -- ___ Python tracker <http://bugs.python.org/issue2

[issue7319] Silence DeprecationWarning by default

2010-04-23 Thread Brett Cannon
Changes by Brett Cannon : -- priority: critical -> release blocker ___ Python tracker <http://bugs.python.org/issue7319> ___ ___ Python-bugs-list mai

[issue7997] http://www.python.org/dev/faq/ doesn't seem to explain how to regenerate "configure"

2010-04-23 Thread Brett Cannon
Changes by Brett Cannon : -- priority: -> normal ___ Python tracker <http://bugs.python.org/issue7997> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8523] shutil.rmtree and os.listdir cannot recover on error conditions

2010-04-25 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> tarek nosy: +tarek ___ Python tracker <http://bugs.python.org/issue8523> ___ ___ Python-bugs-list mailing list Un

[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)

2010-04-25 Thread Brett Cannon
Brett Cannon added the comment: New patch updated to at least r80476. -- Added file: http://bugs.python.org/file17080/subprocess_shutdown.diff ___ Python tracker <http://bugs.python.org/issue5

[issue5099] subprocess.POpen.__del__() AttributeError (os module == None!)

2010-04-25 Thread Brett Cannon
Changes by Brett Cannon : Removed file: http://bugs.python.org/file16976/subprocess__del__.diff ___ Python tracker <http://bugs.python.org/issue5099> ___ ___ Python-bug

[issue7319] Silence DeprecationWarning by default

2010-04-25 Thread Brett Cannon
Brett Cannon added the comment: -Q now works like -3 by causing the DeprecationWarning silencing to be skipped. Committed in r80492. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue7288] Detect improper leading whitespace in C files for Vim

2010-04-25 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> wont fix status: open -> closed ___ Python tracker <http://bugs.python.org/issue7288> ___ ___ Python-bugs-list

[issue7319] Silence DeprecationWarning by default

2010-04-25 Thread Brett Cannon
Brett Cannon added the comment: Making this a 3.2 issue now. -- versions: +Python 3.2 -Python 2.7 ___ Python tracker <http://bugs.python.org/issue7319> ___ ___

[issue7319] Silence DeprecationWarning by default

2010-04-25 Thread Brett Cannon
Brett Cannon added the comment: I'm tired of svn. I swear I made sure I didn't list that file in what was changed. Anyway, it's been reverted in r80496. -- ___ Python tracker <http://bugs.py

[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-04-26 Thread Brett Cannon
Brett Cannon added the comment: Did you run the patch on a Windows machine, Eric? As for Gabriel's comment about not using a __del__ method, it's a general rule of thumb, not something you have to do. __del__ methods exist for those times when you REALLY need them, but otherwise

[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-04-26 Thread Brett Cannon
Brett Cannon added the comment: I was just following the style already set in __del__ for storing a reference to sys (that and I didn't feel like having to explicitly store all of those references in the __init__ or at the class level just above the methods). As for using atexit,

[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-04-26 Thread Brett Cannon
Brett Cannon added the comment: Code reviews are always helpful, Éric. I just wanted since that is what is preventing me from committing. And you are right that I can commit my change now and we can fix it after the fact. -- ___ Python tracker

[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-04-26 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker <http://bugs.python.org/issue5099> ___ ___ Python-bugs-list mailing list Unsubscri

[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-04-26 Thread Brett Cannon
Changes by Brett Cannon : -- priority: normal -> high ___ Python tracker <http://bugs.python.org/issue5099> ___ ___ Python-bugs-list mailing list Unsubscri

[issue2091] file accepts 'rU+' as a mode

2010-05-02 Thread Brett Cannon
Changes by Brett Cannon : -- keywords: +needs review stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue2091> ___ ___ Python-

[issue4180] warnings.simplefilter("always") does not make warnings always show up

2010-05-02 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> exarkun keywords: +needs review ___ Python tracker <http://bugs.python.org/issue4180> ___ ___ Python-bugs-list mai

[issue8627] Unchecked PyErr_WarnPy3k return value in Objects/typeobject.c

2010-05-05 Thread Brett Cannon
Brett Cannon added the comment: I just came across the warning myself (after ignoring all the PyType_INIT() warnings; what to do about those?) and came to the same conclusion: it's a pain to fix. One option is to do a PyErr_Occurred() check at inherit_slots() call sites. Would that mit

[issue8626] TypeError: rsplit() takes no keyword arguments

2010-05-05 Thread Brett Cannon
Changes by Brett Cannon : -- keywords: +easy stage: -> unit test needed ___ Python tracker <http://bugs.python.org/issue8626> ___ ___ Python-bugs-list mai

[issue8662] bytes join cannot join bytes

2010-05-08 Thread Brett Cannon
Brett Cannon added the comment: While the bytes-returning-int semantics might be annoying in this case, but as you point out, Timothy, it's too late to change this. -- nosy: +brett.cannon resolution: -> wont fix status: open -> closed ___

[issue8667] Link to PEP 3147 from importlib docs

2010-05-08 Thread Brett Cannon
New submission from Brett Cannon : In trying to keep importlib's docs THE place to go for links to all relevant import details, a link to PEP 3147 is needed. -- assignee: brett.cannon components: Documentation keywords: easy messages: 105351 nosy: brett.cannon priority: low sev

[issue2090] __import__ with fromlist=

2010-05-08 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: wont fix -> status: closed -> open ___ Python tracker <http://bugs.python.org/issue2090> ___ ___ Python-bugs-list

[issue7397] __import__ docs should reference importlib.import_module

2010-05-08 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: georg.brandl -> brett.cannon ___ Python tracker <http://bugs.python.org/issue7397> ___ ___ Python-bugs-list mai

[issue6526] importlib.import_module affects permissions of .pyc files subsequently created by import

2010-05-08 Thread Brett Cannon
Brett Cannon added the comment: Did this go anywhere, David? Since beta2 just went out now is the time to either revert or enshrine the new behavior. -- ___ Python tracker <http://bugs.python.org/issue6

[issue8672] Error decompressing valid zlib data

2010-05-09 Thread Matthew Brett
New submission from Matthew Brett : I have a valid zlib compressed string, attached here as 'mat.bin' (1.7M), that cause and error on zlib.decompress decompression: >>> import zlib >>> data = open('mat.bin', 'rb').read() >>> out = zlib.d

[issue8678] crashers in rgbimg

2010-05-10 Thread Brett Cannon
New submission from Brett Cannon : Red Hat found some crashers in the rgbimg module along with a proposed patch: https://bugzilla.redhat.com/show_bug.cgi?id=541698 . Since the patch was sent to the PSRT privately before the bugs were announced, it should be fine to take the patch from the

[issue8672] Error decompressing valid zlib data

2010-05-10 Thread Matthew Brett
Matthew Brett added the comment: Hi, > Antoine Pitrou added the comment: > > After a bit of debugging, it seems your data is not actually a complete zlib > stream (*). What did you generate it with? > > (*) in technical terms, the zlib never returns Z_STREAM_END when &g

[issue8672] Error decompressing valid zlib data

2010-05-10 Thread Matthew Brett
Matthew Brett added the comment: >> Thanks for the debugging.  The stream comes from within a matlab 'mat' >> file.  I maintain the scipy matlab file readers; the variables within >> these files are zlib compressed streams. > > So this would be a Matlab is

[issue8678] crashers in rgbimg

2010-05-11 Thread Brett Cannon
Brett Cannon added the comment: Because it's a crasher it could still be patched if someone chose to do the work. -- components: +Extension Modules ___ Python tracker <http://bugs.python.org/i

[issue5099] subprocess.Popen.__del__ causes AttributeError (os module == None)

2010-05-13 Thread Brett Cannon
Brett Cannon added the comment: OK, my patch is committed: 2.6 81158 2.7 81154 3.1 81159 3.2 81155 I didn't apply your test, Gabriel, as it passed without the fixes. Thanks to the work you did on it, though. -- resolution: -> fixed status: open -

[issue1631171] implement warnings module in C

2007-11-29 Thread Brett Cannon
Brett Cannon added the comment: I see two ways of implementing the fetching of a source code line from __loader__.get_source(). One is to do it in Python. We have a function provided that can suppress the second line of output from a warning and just handle it in Python code. That has the

[issue1005] Patches to rename Queue module to queue

2007-12-04 Thread Brett Cannon
Brett Cannon added the comment: Yes, thanks for the patches, Paul! Guido sent out an email today saying that the reorg will probably be the main focus of the next Py3K release after 3.0a2. So hopefully they won't go too stale. And I just realized it might end up being best to roll Queue

[issue1333] merge urllib and urlparse functionality

2007-12-13 Thread Brett Cannon
Brett Cannon added the comment: Yes, the modules should probably all get merged somehow. But discussing it in the web-sig is fine with me and I am happy to look at what the web-sig ends up recommending. __ Tracker <[EMAIL PROTECTED]> <http://bugs.p

[issue1624] Remove output comparison for test_pep277

2007-12-14 Thread Brett Cannon
New submission from Brett Cannon: The output from test_pep277.py seems to be completely worthless in terms of testing. The attached patch removes the output comparison file from Lib/test/output and changes test_pep277.py to not output anything. But since I don't have a Windows box I can&#

[issue1632] email

2007-12-14 Thread Brett Cannon
Brett Cannon added the comment: More detail is needed than this in order to try to fix this. What error message are you getting? What OS? What exact version of Python? Is this a binary distro or a source one? Since all releases are thoroughly tested and never had any import issues with the

[issue1632] email cannot be imported

2007-12-14 Thread Brett Cannon
Changes by Brett Cannon: -- title: email -> email cannot be imported __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1632> __ ___ Python-bugs-li

[issue1633] smtplib

2007-12-14 Thread Brett Cannon
Brett Cannon added the comment: There is no module named SMTP. See the list of modules at http://docs.python.org/modindex.html . -- nosy: +brett.cannon resolution: -> invalid status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://

[issue1632] email cannot be imported

2007-12-16 Thread Brett Cannon
Brett Cannon added the comment: I just noticed that the directory you are executing from is Panda3D. Did you not download Python directly but are using the one from Panda3D? __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/

[issue1648] add new function, sys.gettrace

2007-12-18 Thread Brett Cannon
Changes by Brett Cannon: -- assignee: -> brett.cannon __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1648> __ ___ Python-bugs-list mailing list Uns

[issue1648] add new function, sys.gettrace

2007-12-18 Thread Brett Cannon
Brett Cannon added the comment: On Dec 18, 2007 12:14 PM, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > Guido van Rossum added the comment: > > Why not do the same for its cousin sys.setprofile()? If Titus' code works out I was going to just copy it and tweak i

[issue1659] Tests needing network flag?

2007-12-19 Thread Brett Cannon
Changes by Brett Cannon: -- assignee: -> brett.cannon nosy: +brett.cannon __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1659> __ ___ Python-bugs-li

[issue1695] time.localtime() docstring has a wrong fieldname

2007-12-24 Thread Brett Cannon
Changes by Brett Cannon: -- assignee: -> brett.cannon nosy: +brett.cannon __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1695> __ ___ Python-bugs-li

[issue1695] time.localtime() docstring has a wrong fieldname

2007-12-24 Thread Brett Cannon
Brett Cannon added the comment: Fixed in r59596 and r59597. -- resolution: -> fixed status: open -> closed versions: +Python 2.6 __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue602345] option for not writing .py[co] files

2008-01-05 Thread Brett Cannon
Brett Cannon added the comment: For some reason I don't love the use of "dont", with the missing apostrophe. Just looks ugly to me. But I don't know if "donot" is that much better. And I don't think "PYTHONSKIPWRITINGBYTECODE" is much bette

Re: [issue1816] sys.cmd_flags patch

2008-01-13 Thread Brett Cannon
On Jan 13, 2008 9:45 AM, Christian Heimes <[EMAIL PROTECTED]> wrote: > > Christian Heimes added the comment: > > Guido van Rossum wrote: > > Can't you use a namedtuple? Then printing it would show the names of > > the flags... > > ... and increase the startup costs of Python by loading several > a

[issue1828] Renaming platform path modules

2008-01-14 Thread Brett Cannon
Brett Cannon added the comment: On Jan 14, 2008 5:12 PM, Christian Heimes <[EMAIL PROTECTED]> wrote: > > Christian Heimes added the comment: > > Brett, it sounds like a good idea for the 3.0 stdlib reorg. > Yep, it does. __ Tracker <

[issue1326] "internal" zipimport.zipimporter feature untested

2008-01-15 Thread Brett Cannon
Brett Cannon added the comment: And if you want more ideas for tests, I implemented my own tests for my pure Python implementation of zipimport. They can be found in the sandbox at import_in_py/zipimport_/tests.py . -- nosy: +brett.cannon __ Tracker

[issue1917] init_types() in Parser/asdl_c.py conflicts with init_types() in Modules/_typesmodule.c

2008-01-23 Thread Brett Cannon
Changes by Brett Cannon: -- resolution: -> invalid status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1917> __ ___ Python-bugs

[issue1935] test_descr.py converted to unittest

2008-01-26 Thread Brett Cannon
Brett Cannon added the comment: Just so you know, Amaury, a student did a conversion for GHOP: http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=291 . It was not checked in yet as we are waiting for contributor forms first. But perhaps you can have a look at it and

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Brett Cannon
Brett Cannon added the comment: Have a look at http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 where a GHOP student did a conversion as well. Any chance to come up with a possible merged version that takes the best from your work, Giampaolo and the student&#

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Brett Cannon
Brett Cannon added the comment: On Jan 28, 2008 5:03 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote: > > Giampaolo Rodola' added the comment: > > > Have a look at > http://code.google.com/p/google-highly-open-participation-psf/issues/detail?id=290 > >

[issue1961] possible error with json format for sphinx

2008-01-28 Thread Brett Cannon
New submission from Brett Cannon: I currently can't build the docs (r60374): ... File "/Users/brett/Dev/python/2.x/pristine/Doc/tools/sphinx/search.py", line 70, in load for (k, v) in frozen[2].iteritems()) AttributeError: 'list' object has no attribute 'iter

[issue1960] test_gdbm.py converted to unittest

2008-01-28 Thread Brett Cannon
Brett Cannon added the comment: On Jan 28, 2008 6:20 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote: > > Giampaolo Rodola' added the comment: > > > Well, if you have an opinion, feel free to leave a comment in this > > issue about it. I will most likely be t

[issue1935] test_descr.py converted to unittest

2008-01-29 Thread Brett Cannon
Brett Cannon added the comment: On Jan 29, 2008 12:24 PM, Amaury Forgeot d'Arc <[EMAIL PROTECTED]> wrote: > > Amaury Forgeot d'Arc added the comment: > > Did he misunderstand the last comment in this post of yours? > http://code.google.com/p/google-highly-open-par

[issue1935] test_descr.py converted to unittest

2008-01-29 Thread Brett Cannon
Brett Cannon added the comment: On Jan 29, 2008 3:11 AM, Amaury Forgeot d'Arc <[EMAIL PROTECTED]> wrote: > > Amaury Forgeot d'Arc added the comment: > > On the contrary, Jeff's version is better in many aspects. > I happily withdraw my submission. > >

[issue1982] Feature: extend strftime to accept milliseconds

2008-01-31 Thread Brett Cannon
Changes by Brett Cannon: -- type: -> rfe __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1982> __ ___ Python-bugs-list mailing list Uns

[issue1722344] Thread shutdown exception in Thread.notify()

2008-02-05 Thread Brett Cannon
Brett Cannon added the comment: I think the general idea of the problem has been stated, but I figured I would state the official issue. When Python begins to shutdown it takes each module and sets each variable in the global namespace to None. If a thread has not terminated before the

[issue1722344] Thread shutdown exception in Thread.notify()

2008-02-05 Thread Brett Cannon
Brett Cannon added the comment: Hold on, why is that wrong? What if the threads block forever, preventing shutdown? sys.exit() is not exactly some namby-pamby function but a forced shutdown of the interpreter that should guarantee that the interpreter quits. Changing its semantics now would take

[issue1722344] Thread shutdown exception in Thread.notify()

2008-02-05 Thread Brett Cannon
Brett Cannon added the comment: OK, I will re-open to see if some other core developer wants to take this on, but personally I am passing. -- resolution: wont fix -> status: closed -> open _ Tracker <[EMAIL PROTECTED]> <http://

[issue1722344] Thread shutdown exception in Thread.notify()

2008-02-06 Thread Brett Cannon
Brett Cannon added the comment: > > which means no global namespace access > Does that mean that you cannot use len and range in a Thread? No, it means you have to be careful if you do. Shutting down properly will take care of things. Otherwise you need to save a reference locally (eit

[issue2091] file accepts 'rU+' as a mode

2008-02-12 Thread Brett Cannon
New submission from Brett Cannon: The docs on file's constructor says that the 'U' mode should not work with '+', and yet 'rU+' does not throw an error. -- components: Interpreter Core messages: 62343 nosy: brett.cannon severity: normal status: open

[issue1740] use unittest for test_logging

2008-02-17 Thread Brett Cannon
Brett Cannon added the comment: Yeah, that's my fault. I forgot to search the issue tracker first before committing the GHOP rewrite. I will do a review of this patch and see which version is better. -- assignee: -> brett.cannon nosy: +bret

[issue1960] test_gdbm.py converted to unittest

2008-02-17 Thread Brett Cannon
Changes by Brett Cannon: -- assignee: -> brett.cannon __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1960> __ ___ Python-bugs-list mailing list Uns

[issue1952] test_select.py converted to unittest

2008-02-17 Thread Brett Cannon
Changes by Brett Cannon: -- assignee: -> brett.cannon nosy: +brett.cannon __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1952> __ ___ Python-bugs-li

[issue1864] test_locale doesn't use unittest

2008-02-17 Thread Brett Cannon
Changes by Brett Cannon: -- keywords: +patch __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1864> __ ___ Python-bugs-list mailing list Unsubs

[issue2055] test_fcntl.py converted to unittest

2008-02-17 Thread Brett Cannon
Changes by Brett Cannon: -- assignee: -> brett.cannon nosy: +brett.cannon __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2055> __ ___ Python-bugs-li

[issue2135] Restructure import.c into PEP 302 importer objects

2008-02-22 Thread Brett Cannon
Brett Cannon added the comment: Sorry I have not commented on this sooner; been swamped. First, the error Alexander is seeing is probably caused by a source file that has an encoding other than ASCII (which is fine as the default encoding in Python 3.0 is UTF-8). But chances are the file has an

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Brett Cannon added the comment: Patch that has been brought up-to-date with r60968. No new work, though. Added file: http://bugs.python.org/file9490/c_warnings.diff _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/iss

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file7708/c-warnings.diff _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file7709/_warnings.c _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file8495/_warnings.c _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file8496/c_warnings.diff _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file8557/_warnings.c _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file8565/_warnings.c _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file8772/test_warnings.py _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file8783/warnings.diff _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue1631171] implement warnings module in C

2008-02-22 Thread Brett Cannon
Changes by Brett Cannon: Removed file: http://bugs.python.org/file8858/_warnings.diff _ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1631171> _ ___ Pyth

[issue2135] Restructure import.c into PEP 302 importer objects

2008-02-22 Thread Brett Cannon
Brett Cannon added the comment: On Fri, Feb 22, 2008 at 5:21 PM, Douglas Greiman <[EMAIL PROTECTED]> wrote: > > Douglas Greiman added the comment: > > Brett, > > I wrote my patch thinking that the next step would be to rewrite > DirectoryImporter in Python. If you

[issue1740] use unittest for test_logging

2008-02-24 Thread Brett Cannon
Brett Cannon added the comment: I am attaching a reviewed version of the patch. It had some major PEP 8 violations that I had to clean up. I also moved over to the usage of test.test_support.captured_stdout(). Otherwise it looks good. I am going to wait a little while in hopes someone else can

[issue1740] use unittest for test_logging

2008-02-25 Thread Brett Cannon
Brett Cannon added the comment: On Mon, Feb 25, 2008 at 11:39 AM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou added the comment: > > Out of curiosity, what were the PEP 8 violations? Usually I try to > respect the coding guidelines. There were three t

[issue2196] Fix hasattr's exception problems

2008-02-29 Thread Brett Cannon
Brett Cannon added the comment: On Fri, Feb 29, 2008 at 2:04 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson added the comment: > > After looking more closely, I saw that this is documented at > http://www.python.org/dev/patches/style/. So the

[issue1740] use unittest for test_logging

2008-03-02 Thread Brett Cannon
Brett Cannon added the comment: Committed in r61189 on the trunk. Thanks, Antoine! -- status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.o

[issue1740] use unittest for test_logging

2008-03-02 Thread Brett Cannon
Brett Cannon added the comment: Oh, and thanks Thomas for the port change. I made sure to keep it. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1740> __ ___

[issue2227] time.strptime too strict? should it assume current year?

2008-03-03 Thread Brett Cannon
Brett Cannon added the comment: The documentation already mentions that the default values when information left out is (1900, 1, 1, 0, 0, 0, 0, 1, -1) so the docs are already clear. If you want to generate a patch to make the default year be this year I would be willing to review it and

[issue1631171] implement warnings module in C

2008-03-13 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Add tests for the 'line' argument to formatwarning() and showwarning(). Added file: http://bugs.python.org/file9667/c_warnings.diff _ Tracker <[EMAIL PROTECTED]> <http://bug

[issue1163] Patch to make py3k/Lib/test/test_thread.py use unittest

2008-03-13 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Closing as out of date as a GHOP attempt at this got farther and committed. -- nosy: +brett.cannon resolution: -> out of date status: open -> closed __ Tracker <[EMAIL PR

[issue1952] test_select.py converted to unittest

2008-03-13 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Went with another test_select conversion from GHOP that added more tests. Closing as rejected. -- resolution: -> rejected status: open -> closed __ Tracker <[EMAIL PROTECTED]> <h

[issue1960] test_gdbm.py converted to unittest

2008-03-13 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Committed in revision 61374 (w/ changes so that the key stuff is not order-dependent). Thanks, Giampaolo! -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PR

[issue2055] test_fcntl.py converted to unittest

2008-03-13 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Committed in revision 61375. -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue1659] Tests needing network flag?

2008-03-13 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I think, for the cases that are not special-cased by regrtest, test.test_support.requires() should be used. -- assignee: brett.cannon -> skip.montanaro __ Tracker <[EMAIL PROTE

[issue2291] Catching all exceptions with 'object'

2008-03-15 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Sat, Mar 15, 2008 at 5:30 PM, Neal Norwitz <[EMAIL PROTECTED]> wrote: > > Neal Norwitz <[EMAIL PROTECTED]> added the comment: > > See PEP 352. Currently this is slated for python 2.8. Perhaps the > sc

[issue2291] Catching all exceptions with 'object'

2008-03-16 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Actually, if you go back to 2.4, before BaseException even existed, a try/except with a new-style class in the 'except' clause was also possible. Actual enforcement of what can be in an 'except' clause is a new thing

[issue2311] Update the ACKS file

2008-03-17 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Sun, Mar 16, 2008 at 4:27 PM, Guido van Rossum <[EMAIL PROTECTED]> wrote: > > New submission from Guido van Rossum <[EMAIL PROTECTED]>: > > We should keep the ACKS files up to date. Have all the GHOP contribu

[issue2322] Clean up getargs.c and its formatting possibilities

2008-03-17 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: It was mentioned by Georg on python-3000 that getargs.c needs to be cleaned up and worked on before Python 3.0 goes out the door. -- assignee: georg.brandl components: Interpreter Core messages: 63665 nosy: brett.cannon, georg.

[issue2323] Unify structseq and namedtuple's API

2008-03-17 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: structseq and namedtuple should end up with a uniformed API. -- components: Extension Modules messages: 63667 nosy: brett.cannon priority: immediate severity: normal status: open title: Unify structseq and namedtuple's A

[issue2324] Document that 2.6 pickles of strings turn into pickles of unicode in 3.0

2008-03-17 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: It turns out that unpickling a string from 2.6 leads to a Unicode string in 3.0. That might fail since the encoding was never specified. This should be documented probably in both 2.6 and 3.0. -- assignee: georg.brandl comp

[issue2326] Doc isnumeric and isdecimal for the unicode object

2008-03-17 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Both the isnumeric and isdecimal methods on the unicode object need to be documented. -- assignee: georg.brandl components: Documentation messages: 63672 nosy: brett.cannon, georg.brandl priority: immediate severity: normal

[issue2327] Backport keyword-only arguments to 2.6

2008-03-17 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Keyword-only arguments have not been backported to 2.6 from 3.0. -- components: Interpreter Core keywords: 26backport messages: 63679 nosy: brett.cannon priority: immediate severity: normal status: open title: Backport keywor

[issue2331] Backport parameter annotations

2008-03-17 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Parameter annotations (e.g., ``def fxn(a:int) -> str: pass`` need to be backported. -- components: Interpreter Core keywords: 26backport messages: 63688 nosy: brett.cannon priority: immediate severity: normal status: o

<    5   6   7   8   9   10   11   12   13   14   >