[issue3506] Change buffer/memoryview DeprecationWarning

2008-08-07 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: In r65584 I changed the warning to not mention memoryview(); it just says that buffer() does not exist in 3.0. -- resolution: -> fixed status: open -> closed ___ Python tracker <[

[issue2983] Ttk support for Tkinter

2008-08-08 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I wish I had realized this work was done or else I would have pushed to get this in for 2.6/3.0. Damn. Setting for 2.7/3.1, although if the decision was made it was easier to only have it in 3.1 that would be fine by me. Regardless, s

[issue2548] Undetected error in exception handling

2008-08-13 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Wed, Aug 13, 2008 at 12:49 PM, Daniel Diniz <[EMAIL PROTECTED]> wrote: > > Daniel Diniz <[EMAIL PROTECTED]> added the comment: > > FWIW, rev58032 introduced this: >tstate = PyThreadState_GET(); &

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-16 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: The following leads to a SyntaxError in 3.0: compile(b'# coding: latin-1\nu = "\xC7"\n', '', 'exec') That is not the case in Python 2.6. -- messages: 71251 nosy: brett.cannon severit

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-16 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Looks like Parser/tokenizer.c:check_coding_spec() considered Latin-1 a raw encoding just like UTF-8. Patch is in the works. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-16 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Here is a potential fix. It broke test_imp because it assumed that Latin-1 source files would be encoded at Latin-1 instead of UTF-8 when returned by imp.new_module(). Doesn't seem like a critical change as the file is still prope

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-16 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Attached is a test for test_pep3120 (since that is what most likely introduced the breakage). It's a separate patch since the source file is marked as binary and thus can't be diffed by ``svn diff``. -- components: +

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-16 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- type: -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3574> ___ ___

[issue3583] test_urllibnet.test_bad_address() fails when using OpenDNS

2008-08-17 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: OpenDNS has a "feature" where if you enter an address that doesn't exist, you get a 404 and a Google-looking search page. Problem is that urllib.urlopen() does not raise any exception on a 404. Probably should just chan

[issue3474] Using functools.reduce() does not stop DeprecationWarning when using -3

2008-08-17 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Reviewing the patch at http://codereview.appspot.com/2968 . ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3474] Using functools.reduce() does not stop DeprecationWarning when using -3

2008-08-17 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Reviewed in Rietveld. Only a minor change is suggested. Otherwise I think the patch is ready to be committed, Benjamin. -- assignee: brett.cannon -> benjamin.peterson ___ Python tracke

[issue3583] test_urllibnet.test_bad_address() fails when using OpenDNS

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Mon, Aug 18, 2008 at 3:52 AM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > > Are many people using OpenDNS? Is there a way to detect that OpenDNS is >

[issue2876] Write UserDict fixer for 2to3

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Mon, Aug 18, 2008 at 10:59 AM, Nick Edds <[EMAIL PROTECTED]> wrote: > > Nick Edds <[EMAIL PROTECTED]> added the comment: > > What's the current status of this? I think it is waiting for someone to work o

[issue3592] Patch to add imp.get_codingspec()

2008-08-18 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Attached is a patch to add imp.get_codingspec(); a function that returns the encoding of a source file. The motivation is to remove the import of the re module in linecache to speed up interpreter startup. -- components: L

[issue3592] Patch to add imp.get_codingspec()

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: It should be noted the original patch by Christian had a check for bad tokenizing. Turns out that if you have that in several tests fail, including test_modulefinder. This might mean there is a deeper problem in the

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-08-18 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Turns out that PyTokenizer_FindEncoding() never properly succeeds because the tok_state used by it does not have tok->filename set, which is an error condition in the tokenizer. This error has been masked by the one place the functio

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I have not bothered to check if this exists in 2.6, but I don't see why it would be any different. -- type: -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bu

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Turns out that the NULL return value can signal an error that manifests itself as SyntaxError("encoding problem: with BOM") thanks to the lack of tok->filename being set in Parser/tokenizer.c:fp_setreadl() which is called b

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Can someone double-check this patch for me? I don't have much experience with the parser so I want to make sure I am not doing anything wrong. ___ Python tracker <[EMAIL PROTECTED]> <ht

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: There is a potential dependency on issue3594 as it would change how imp.find_module() acts and thus make test_imp no longer fail in the way it has. -- dependencies: +PyTokenizer_FindEncoding() never su

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-08-18 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Attached is a patch that fixes where the error occurs. By opening the file by either file name or file descriptor, the problem goes away. Once this patch is accepted then PyErr_Occurred() should be added to all uses of PyTokenizer_FindEn

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-19 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Since most UNIX distros don't ship Python's test directory, test.test_support.catch_warning() needs to be moved to the 'warnings' directory so it can be used to suppress warnings in modules outside the 'test

[issue1675334] Draft implementation for PEP 364

2008-08-20 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: At this point we should probably just have PEP 364 rejected since 2to3 handles the renamings so well. -- assignee: brett.cannon -> barry ___ Python tracker <[EMAIL PROTE

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-20 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Just some quick notes on this. The decorator should become: def catchwarning(*, record=False, using=warnings) Name change is to follow the naming convention in 'warnings' (even though I prefer underscores). The 'us

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-20 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Wed, Aug 20, 2008 at 10:29 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > I don't think the using argument should live in warnings; it&#x

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-20 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Wed, Aug 20, 2008 at 2:53 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > On Wed, Aug 20, 2008 at 4:51 PM, Brett Cannon <[EMAIL PROTECTED]&g

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-20 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Wed, Aug 20, 2008 at 3:05 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > Alternatively, you could just have another copy of catch_warning in >

[issue2356] sys.exitfunc should raise a Py3K warning

2008-08-20 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Actually, a fixer probably won't work since that would require the atexit module to be imported. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue2356] sys.exitfunc should raise a Py3K warning

2008-08-21 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Thu, Aug 21, 2008 at 6:43 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > This is going to be very hard to implement without module descriptors.

[issue2876] Write UserDict fixer for 2to3

2008-08-21 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: As I said, it isn't using the import filter, it's whether this should be done through a warning instead because the superclasses have changed. I really should ask on python-dev about this. -- priority: high -&

[issue2350] Warn against importing 'exceptions'

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2357] sys.exc_{type,values,traceback} needs a 2to3 fixer

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: critical -> release blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2876] Write UserDict fixer for 2to3

2008-08-21 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: You know what, Nick, go for the fixer. UserDict.UserDict will need a deprecation warning, but otherwise a fixer for IterableUserDict and DictMixin is fine. And I can handle the deprecation if you want. -- assignee: collin

[issue2356] sys.exitfunc should raise a Py3K warning

2008-08-21 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Thu, Aug 21, 2008 at 11:45 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > On Thu, Aug 21, 2008 at 1:21 PM, Brett Cannon <[EMAIL PROTECTE

[issue3573] IDLE hangs when passing invalid command line args (directory(ies) instead of file(s))

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- keywords: +patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3573> ___ __

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2351> ___ __

[issue2357] sys.exc_{type,values,traceback} needs a 2to3 fixer

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2357> ___ __

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3594> ___ __

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-21 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3574> ___ __

[issue3644] ``make htmlview`` for docs fails on OS X

2008-08-21 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Running ``make htmlview`` on OS X Leopard causes the following:: > make htmlview ~/Dev/python/3.x/scratch/Doc mkdir -p build/html build/doctrees python2.5 tools/sphinx-build.py -b html

[issue3639] segfaults calling warnings.warn() with non-string message

2008-08-21 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: If you search for _PyUnicode_AsString() in Python/_warnings.c you will find several places that assume that the proper measures have been taken to make sure the object is a string. All of those places need to be fixed so that if a string

[issue3644] ``make htmlview`` for docs fails on OS X

2008-08-22 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Fri, Aug 22, 2008 at 6:12 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > This is probably actually a problem with the webbrowser module. Tr

[issue3639] segfaults calling warnings.warn() with non-string message

2008-08-22 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Fri, Aug 22, 2008 at 8:03 AM, Daniel Diniz <[EMAIL PROTECTED]> wrote: > > Daniel Diniz <[EMAIL PROTECTED]> added the comment: > > Brett, > I don't think I know C (and CPython) enough to fix this. I

[issue3639] segfaults calling warnings.warn() with non-string message

2008-08-22 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: The patch doesn't actually bother with a translation as the code causing issue is only there to prevent infinite recursion. So if the object being used is not a string, then there is no need to worry as it is not part of the infinit

[issue3639] segfaults calling warnings.warn() with non-string message

2008-08-22 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: That's why the keyword is set. =) ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3639> ___

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-22 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I think I can clean up the code by shifting WarningMessage over to a subclass of namedtuple and moving WarningsRecorder over to a subclass of list. ___ Python tracker <[EMAIL PROTECTE

[issue3652] Remove DeprecationWarning in _warnings about 'line'

2008-08-22 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: The DeprecationWarning introduced in Python 2.6/3.0 about the 'line' argument for showwarning() can be removed in 2.7/3.1. -- assignee: brett.cannon components: Library (Lib) messages: 71797 nosy: brett.cannon

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-22 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: The patch does a couple of things. It moves test.test_support.catch_warning() to warnings.catch_warnings() and leaves a stub behind. WarningsRecorder becomes a subclass of list to make it easier to work with. The uses of catch_warnings()

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-22 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11227/move_catch_warnings.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-08-22 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: New patch is up with a minor change from Benjamin's review. My explicit comments on the suggestions are on Rietveld. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3651] eval() leaks 1 reference every time

2008-08-23 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Ignoring the question of whether owning the reference is the right thing or not, the patch looks fine, although I don't see a reason for the decrements to not be Py_DECREF since the function calls just won't even happen if the

[issue3642] Objects/obmalloc.c:529: warning: comparison is always false due to limited range of data type

2008-08-23 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: There is no patch here, so undoing the "needs review" flag. -- keywords: -needs review nosy: +brett.cannon ___ Python tracker <[EMAIL PROTECTED]> <http://

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-23 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I reviewed the patch and made some changes (which I uploaded). Mostly changed the punctuation of the warning, made sure that PyErr_WarnPy3k() was used for all cases, and simplified the code for the test. Assigning to Benjamin for him to

[issue2351] Using __(get|set|del)slice__ needs a Py3K warning

2008-08-24 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Sat, Aug 23, 2008 at 6:00 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Those changes are great; thanks for the review! Are you happy en

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-24 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Actually, the tests don't have to change; if issue 3594 gets applied then that change cascades into this issue and negates the need to change the tests themselves. As for treating Latin-1 as a raw encoding, how can that be theoret

[issue3574] compile() cannot decode Latin-1 source encodings

2008-08-24 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: The test_imp stuff has to do with PyTokenizer_FindEncoding(). imp.find_module() only opens the file, passes the file descriptor to PyTokenizer_FindEncoding() and then returns a file object with the found encoding. Problem is that (as

[issue2350] Warn against importing 'exceptions'

2008-08-24 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Sun, Aug 24, 2008 at 2:51 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > I'm not sure how we could implement a warning on import of excepti

[issue2876] Write UserDict fixer for 2to3

2008-08-24 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Sun, Aug 24, 2008 at 3:00 PM, Nick Edds <[EMAIL PROTECTED]> wrote: > > Nick Edds <[EMAIL PROTECTED]> added the comment: > > How soon is this needed by? I probably won't have a chance to do it in > the

[issue3279] import of site.py fails on startup

2008-08-25 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Mon, Aug 25, 2008 at 6:40 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > We could: > > 1. Use _fileio._FileIO directly. > 2. Use os.

[issue3279] import of site.py fails on startup

2008-08-25 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Mon, Aug 25, 2008 at 10:49 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > On Mon, Aug 25, 2008 at 12:48 PM, Brett Cannon <[EMAIL PROTECTED]&g

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-09-01 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- assignee: -> brett.cannon ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3602> ___ __

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-09-01 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Applied in the trunk under r66135. Working on merging in 3.0. -- status: open -> pending ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

2008-09-01 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: r66139 has the 3.0 work. Had to rip out an outdated DeprecationWarning. Also moved over to keyword-only arguments as stated in the 2.6 docs. -- resolution: -> accepted status: pending

[issue3639] segfaults calling warnings.warn() with non-string message

2008-09-01 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Checked in r66140. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3758] "make check" suggest a testing target under GNU coding standards

2008-09-02 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Tue, Sep 2, 2008 at 7:17 AM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > > Benjamin Peterson <[EMAIL PROTECTED]> added the comment: > > Brett, how about "patchcheck"? > Maybe. I will see if any

[issue3758] "make check" suggest a testing target under GNU coding standards

2008-09-03 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Or how about ``make precommit``? -- priority: -> low ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2744] Fix test_cProfile

2008-09-03 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: So is this going to be a 3.1 issue or a 3.0 one? If it's the former then it should not be a release blocker. But if is going to be for 3.0 then the version list is wrong. ___ Python tracker <[E

[issue3768] Move test_py3kwarn over to new catch_warnings API

2008-09-03 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: test_py3kwarn was using the old API presented by catch_warnings. The attached patch fixes it to use the new one. -- components: Library (Lib) files: fix_py3kwarn.diff keywords: needs review, patch, patch messages: 7242

[issue3768] Move test_py3kwarn over to new catch_warnings API

2008-09-03 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Done in r66197 on the trunk with the Py3K block in r66198. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3769] Deprecate bsddb for removal in 3.0

2008-09-03 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: Attached is a patch that deprecates bsddb for removal in 3.0. -- components: Library (Lib) files: deprecate_bsddb.diff keywords: needs review, patch, patch messages: 72431 nosy: brett.cannon priority: release blocker severity:

[issue3769] Deprecate bsddb for removal in 3.0

2008-09-03 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11366/deprecate_bsddb.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3769] Deprecate bsddb for removal in 3.0

2008-09-03 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: New patch to also deprecated dbhash. Added file: http://bugs.python.org/file11367/deprecate_bsddb.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3769] Deprecate bsddb for removal in 3.0

2008-09-03 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Wed, Sep 3, 2008 at 4:41 PM, Raymond Hettinger <[EMAIL PROTECTED]> wrote: > I think this should be deferred to Py3.1. > This decision was not widely discussed and I think it likely that some users > will > be surprise

[issue2322] Clean up getargs.c and its formatting possibilities

2008-09-03 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: This was an issue created at PyCon when I just went through every single thing I could think of. It might not even be that relevant anymore. ___ Python tracker <[EMAIL PROTECTED]> <http://

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-09-03 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Committed in r66209. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3773] Check for errors

2008-09-03 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: The patch adds two lines to call_find_module() to check for errors after calling PyTokenizer_FindEncoding() since it returns NULL as a default value so a call to PyErr_Occurred() is needed. -- components: Interpreter Core

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

2008-09-03 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- title: Check for errors -> Check for errors when using PyTokenizer_FindEncoding() ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

2008-09-03 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: -- priority: release blocker -> deferred blocker ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: If PyMem_MALLOC() returns NULL, shouldn't MemoryError be set? ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Your patch looks fine, Amaury. -- assignee: -> amaury.forgeotdarc ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3776] deprecate bsddb/dbhash in 2.6 for removal in 3.0

2008-09-04 Thread Brett Cannon
New submission from Brett Cannon <[EMAIL PROTECTED]>: This patch deprecates bsddb and dbhash for removal in Python 3.0. -- components: Library (Lib) files: deprecate_bsddb.diff keywords: needs review, patch, patch messages: 72517 nosy: brett.cannon priority: release blocker se

[issue3776] deprecate bsddb/dbhash in 2.6 for removal in 3.0

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Sorry if that impression was given about 2.6 deprecation. The plan was always just for 3.0 removal since removing in 2.6 really would not be enough time to warn users. I have assigned to myself to apply the patch when I have time (som

[issue3758] "make check" suggest a testing target under GNU coding standards

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: OK, I am going to go with ``make patchcheck`` since that is the script's name and the command does nothing but execute the script. I will wait until after rc1 to deal with this. ___ Python trac

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Thu, Sep 4, 2008 at 3:10 PM, Jean-Paul Calderone <[EMAIL PROTECTED]> wrote: > > New submission from Jean-Paul Calderone <[EMAIL PROTECTED]>: > > This example shows the behavior: > >from warnings i

[issue3780] No way to write unit tests for warnings

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: It sounds like you are trying to get around "once"/"default" rules to see all warnings raised. Why can't you use catch_warnings() and do ``simplefilter("always")`` or use "error"? Otherwise you

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I won't be able to get to this until tonight, but assuming no one objects, I will make it be an AttributeError and a release blocker so that the API can be considered stable in rc1. -- priority: -> r

[issue3780] No way to write unit tests for warnings

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Thu, Sep 4, 2008 at 3:48 PM, Glyph Lefkowitz <[EMAIL PROTECTED]> wrote: > > Glyph Lefkowitz <[EMAIL PROTECTED]> added the comment: > > Looks like we just misunderstood the way the warnings filter works, and >

[issue3780] No way to write unit tests for warnings

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: On Thu, Sep 4, 2008 at 4:18 PM, Glyph Lefkowitz <[EMAIL PROTECTED]> wrote: > > Glyph Lefkowitz <[EMAIL PROTECTED]> added the comment: > > The use of the term "filter" is pretty confusing. I would norma

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: There is no specific reason why it would be, although that is an option as well. Part of the problem with None is that it is a legitimate default value for some arguments to showwarning() so it doesn't necessarily reflect that no ex

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

2008-09-04 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: The attached patch has WarningsRecorder raise AttributeError when there is no recorded attribute and yet one tries to access warnings attributes. And just so you know, JP, make sure to use keyword arguments when calling catch_warnings

[issue3769] Deprecate bsddb for removal in 3.0

2008-09-05 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I accidentally filed this twice, and the code review is on the other issue, so setting the superceder and closing (although the patch has not been applied yet). -- resolution: fixed -> duplicate superseder: -> deprecate

[issue3776] deprecate bsddb/dbhash in 2.6 for removal in 3.0

2008-09-05 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: Trunk done with r66232 and blocked on 3.0 with r66233. -- resolution: -> accepted status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3758] "make check" suggest a testing target under GNU coding standards

2008-09-05 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: The attached patch renames the target to patchcheck. -- keywords: +needs review, patch Added file: http://bugs.python.org/file11394/rename_check.diff ___ Python tracker <[EMAIL PROTECTE

[issue3574] compile() cannot decode Latin-1 source encodings

2008-09-05 Thread Brett Cannon
Brett Cannon <[EMAIL PROTECTED]> added the comment: I have attached a new version of the patch with the changes to test_imp removed as issue 3594 fixed the need for the change. I have also directly uploaded test_pep3120.py since it is flagged as binary and thus cannot be diffed by svn.

[issue3574] compile() cannot decode Latin-1 source encodings

2008-09-05 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11130/fix_latin.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3574] compile() cannot decode Latin-1 source encodings

2008-09-05 Thread Brett Cannon
Changes by Brett Cannon <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11399/test_pep3120.py ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

<    3   4   5   6   7   8   9   10   11   12   >