Brett Cannon added the comment:
OK, now that all the modules have been analyzed, let's see what is what.
The modules not playing nicely with others by blindly reseting the trace module:
test_doctest
test_pdb
test_scope
test_sys_settrace
test_zipimport_support (because of test_doctest)
Brett Cannon added the comment:
Here is a patch that fixes test_scope.
--
Added file: http://bugs.python.org/file20508/test_scope.diff
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
Here is a partial patch for test_sys_settrace. It fails on
test_19_no_jump_without_trace_function for some reason I don't understand. It
also doesn't protect against it being CPython-only as that is a function
decorator and basically the whole modul
Brett Cannon added the comment:
You could return -1 for everything. =)
In all seriousness, it could simply be proportional. IMO as long as people
realize if a list takes up less space than a dict then the numbers seem fine to
me.
--
___
Python
Brett Cannon added the comment:
If Sandro is willing to write test for regrtest as part of the move then that
would be a complete net win from the current situation.
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
Thanks for the diagnosis, Kristian. Attached is a patch for test_trace which
fixes its over-zealous setting of the trace function (doesn't address the
failures, though).
--
Added file: http://bugs.python.org/file20516/test_trace
Brett Cannon added the comment:
Here is a patch for test_pdb; the context manager made this dirt-simple to fix.
--
Added file: http://bugs.python.org/file20517/test_gdb.diff
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
Patch for doctest/test_doctest (yes, both files were wiping out the trace
function.
--
Added file: http://bugs.python.org/file20518/test_doctest.diff
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
And with this patch for test_zipimport_support to work thanks to the
test_doctest changes, all of the test suites blasting the trace function
*should* be fixed.
--
Added file: http://bugs.python.org/file20519/test_zipimport_support.diff
Brett Cannon added the comment:
I have a patch that I am testing right now which deals which fixes all the test
suites.
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
OK, here is a single patch (from `hg outgoing --patch`) that fixes all the
tests by introducing the test.support.no_tracing decorator.
--
Added file: http://bugs.python.org/file20523/trace_fxn_protected.diff
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20498/sys_gettrace_monitor.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Pytho
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20508/test_scope.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bugs-list m
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20509/test_sys_settrace.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bug
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20516/test_trace.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bugs-list m
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20517/test_gdb.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bugs-list m
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20518/test_doctest.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bug
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20519/test_zipimport_support.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Pytho
Brett Cannon added the comment:
Did you try a `make distclean` before compiling?
--
nosy: +brett.cannon
title: Build of CVS version 2.7 fails in readline -> Build of 2.7 svn fails in
readline
___
Python tracker
<http://bugs.python.org/issu
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20523/trace_fxn_protected.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bug
Brett Cannon added the comment:
OK, here is an updated patch that fixes the introduced failure in
test_sys_settrace. This should be ready to go for Python 3.3 once the tree
opens up (unless someone reviews it and finds a problem).
--
resolution: -> accepted
stage: -> patch
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20526/unnamed
___
Python tracker
<http://bugs.python.org/issue11013>
___
___
Python-bugs-list mailin
Changes by Brett Cannon :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue11013>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
Patch looks good to me.
--
assignee: -> pitrou
nosy: +brett.cannon
resolution: -> accepted
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
Since the whole Mac directory got gutted in the switch over to Python 3,
macostools is now gone, making this out of date.
--
resolution: -> out of date
status: languishing -> closed
___
Python tracker
Brett Cannon added the comment:
Analyzed by downloading the latest Clang static analyzer from
http://clang-analyzer.llvm.org/ and running ``scan-build ./configure
--with-pydebug; scan-build make -s -j2``. The attached tar.xz (yes I went with
a cutting edge archival format; get pax on UNIX to
Brett Cannon added the comment:
Well, there is no upload because the compressed file is 70 MB. But you can
download the file from
https://docs.google.com/leaf?id=0B7CvitGf6YffMGFlYTg2N2UtMjY3Yi00ZTg1LWI2NWUtNmRiMmEwYzZjMTQ1&sort=name&layout=lis
Brett Cannon added the comment:
Turns out I was using pax wrong. =) Thought it automatically compressed new
files; turns out it doesn't. Using the zx compressor it shrank the 70 MB file
down, so ignore the Google Docs upload and just grab this.
--
Added file: http://bugs.pytho
Brett Cannon added the comment:
Martin actually asked for the file and deserves the thanks.
--
___
Python tracker
<http://bugs.python.org/issue11013>
___
___
Changes by Brett Cannon :
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11013>
___
___
Python-bugs-list
Brett Cannon added the comment:
Attached is a patch against test_gc that shows what I think should be done for
the tests failing because of refcounts. Basically I added a refcount_test
decorator to test.support that skips a decorated test if it is not being run
under CPython and otherwise
Brett Cannon added the comment:
Attached is a patch for test_descr. I suspect the __locals__ failures will all
be the same; simply skip the test when a trace function is set.
And thanks for identifying the cause of the failures, Kristian; helps me make
sure I am not misdiagnosing the problem
Brett Cannon added the comment:
Closing as invalid since gevent seems to be the culprit of the segfault.
--
nosy: +brett.cannon
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
New submission from Brett Cannon :
It seems a little negligent that test.support has no tests. The
test.test_support name is available in py3k and backporting issues to 2.7
shouldn't be a problem (rare chance something does happen it can be handling
manually). There doesn't seem
Brett Cannon added the comment:
I should note that I am not suggesting that test.support suddenly be considered
a module with a stable API that the public can use. Simply that we take the
proper measures to make sure the code in there does what is expected
Brett Cannon added the comment:
Attached is a fixed copy of Kristian's patch; error in test_trace where
self.settrace was being called.
--
Added file: http://bugs.python.org/file20581/issue10990.diff
___
Python tracker
<http://bugs.py
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20561/issue10990.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bugs-list m
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20525/trace_fxn_protected.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bug
Brett Cannon added the comment:
The attached patch has all tests passing when run under coverage.py. Most
places are flat-out skipped since there is no good way around the tests short
of coding up a second set of test values. Plus editing doctests to have
optional values is way too painful
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20581/issue10990.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bugs-list m
Brett Cannon added the comment:
Sorry about that. New patch attached.
--
Added file: http://bugs.python.org/file20620/issue_10990.diff
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
Attached is a simpler fix for test_cgi so it can get in for Python 3.2. You can
reproduce the failure if you run ``./python -W error -m test test_cgi``.
Georg, can I commit?
--
assignee: -> georg.brandl
nosy: +brett.cannon, georg.brandl
Added f
New submission from Brett Cannon :
The tokenize module stores the built-in open() module in a global assignment
statement. Problem is that if you reload the module, that global assignment
picks up the module's own open() that came into existence during the initial
import.
The attached
Changes by Brett Cannon :
--
assignee: georg.brandl -> brett.cannon
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issu
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue10992>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
Once Python 3.3 is open I will apply the cgi fix. Just to double-check, can I
close this issue once the test_cgi patch goes in?
--
assignee: georg.brandl -> brett.cannon
___
Python tracker
<http://bugs.pyth
New submission from Brett Cannon :
There is no reason why the 2to3 script can't be gutted and turned into just a
stub that uses runpy to call lib2to3.__main__. Also has the nice benefit that
one can use ``-m lib2to3`` instead of having to use the 2to3 script.
--
components: Li
Brett Cannon added the comment:
The attached patch adds lib2to3.__main__ and tweaks 2to3.
--
keywords: +patch
Added file: http://bugs.python.org/file20636/2to3_main.diff
___
Python tracker
<http://bugs.python.org/issue11
Brett Cannon added the comment:
I don't find it ideal either, but ``python -m lib2to3`` gives complete control
over which VM is used since it's specified right on the command line. I don't
expect this to become the common way to invoke 2to3, just **a** wa
Changes by Brett Cannon :
--
stage: needs patch -> commit review
___
Python tracker
<http://bugs.python.org/issue11086>
___
___
Python-bugs-list mailing list
Un
Brett Cannon added the comment:
Would needlessly break code for such a minor perk. I mean I doubt very many
people will use this feature if it goes in. It's just rather nice for those who
do want the feature to exist in the first
Brett Cannon added the comment:
pkg_resources is not from Python but setuptools; you probably installed it and
forgot it was there. I would suggest you do your App Engine development using
virtualenv to make sure that you are working in a clean environment.
--
nosy: +brett.cannon
Brett Cannon added the comment:
Importlib puts all of its ABCs in importlib.abc, so at least one package has
already taken this approach.
I for one support the collections.abc idea.
--
nosy: +brett.cannon
___
Python tracker
<h
Brett Cannon added the comment:
Just a comment on those warnings about unused assignments; think about
commenting them out instead of flat-out deleting them. When I ran clang over
Python 2.7 I got some blow-back from deleting some assignments as some found
them to be like documentation. In
Brett Cannon added the comment:
Here is a patch that covers all of the relevant dead assignments that were
detected.
--
keywords: +patch
Added file: http://bugs.python.org/file20660/clang_analyzer.diff
___
Python tracker
<http://bugs.python.
Brett Cannon added the comment:
This was just dead assignments. I have not tackled Idempotent operations, dead
increments, dead initializations, dead nested assignments, possible deref of
NULL, deref of unassigned pointer, division by zero, undefined/garbage results,
or undefined alloc of 0
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20660/clang_analyzer.diff
___
Python tracker
<http://bugs.python.org/issue8914>
___
___
Python-bug
Brett Cannon added the comment:
New patch which covers dead assignments and increments.
--
Added file: http://bugs.python.org/file20663/clang_analyzer.diff
___
Python tracker
<http://bugs.python.org/issue8
Brett Cannon added the comment:
Here is a new patch which includes setting the noreturn attribute on
Py_FatalError() and Py_Exit() in order to make the null pointer deref analysis
results more tractable.
--
Added file: http://bugs.python.org/file20666/analyzer_fixes.diff
Brett Cannon added the comment:
This is a new set of results with the analyzer_fixes.diff file applied using
the latest analyzer.
--
Added file: http://bugs.python.org/file20667/checker_254_2011-02-03.tar.xz
___
Python tracker
<h
Changes by Brett Cannon :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue9189>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
OK, done going through the results. Attached is a patch with all of the fixes
(only one actual bug which I file an issue for separately; everything else is
removing a little bit of dead code here and there).
--
Added file: http://bugs.python.org
New submission from Brett Cannon :
Pretty straight forward change, but could potentially cause a NULL pointer
deref in a rare situation.
diff --git a/Modules/_sqlite/module.c b/Modules/_sqlite/module.c
--- a/Modules/_sqlite/module.c
+++ b/Modules/_sqlite/module.c
@@ -329,7 +329,7
Brett Cannon added the comment:
Yeah, probably some little mention in the docs.
--
___
Python tracker
<http://bugs.python.org/issue11086>
___
___
Python-bug
Brett Cannon added the comment:
Not for 3.2.0, no as it's such a minor "fix". Chance this can go into 3.2.1,
though. Definitely for 3.3.
--
___
Python tracker
<http://bugs.pyt
Brett Cannon added the comment:
py3k: r88337
3.1: 88339
2.7 (blocked): 88338
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
Updated patch that applies cleanly.
--
Added file: http://bugs.python.org/file20718/issue10990.diff
___
Python tracker
<http://bugs.python.org/issue10
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20620/issue_10990.diff
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bugs-list m
Brett Cannon added the comment:
I am using LLVM/Clang 2.8 and test_list passes fine for me as-is. Does it only
fail under 32 or 64-bit conditions? Configure compiles under 32-bits for me
even though I have -arch x86_64 set.
--
nosy: +brett.cannon
Brett Cannon added the comment:
You're right, Terry. It's a judgment call as to what should be simply deleted
compared to commented out.
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
Here is a patch which has added the necessary changes to
test.support.import_module() and placed the necessary changes in the test
suites themselves. I still need to rip out the (un)expected test stuff from
regrtest before I consider the patch complete
Changes by Brett Cannon :
--
title: eliminate use of ImportError implicitly representing TestSkipped ->
eliminate use of ImportError implicitly representing SkipTest
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
So os.name is also supported. But the point is that if a platform wants to be
considered supported then they need to give us a patch to update the tests to
make them acceptable to skip.
As for test_ttk and such, those that have a third-party dependency are
Brett Cannon added the comment:
I should also mention that if the idea of whitelisting failures
doesn't fly, it can always be changed to be a blacklist of failures
(i.e., ditch 'optional' and only use 'required_on'). But I did it this
way to force people to clearly
Brett Cannon added the comment:
Well, ctypes failing because it cannot compile is only when a platform that is
not listed as optional cannot import it. So if some platform does not support
ctypes then it gets added to the list, end of story.
We only support so many platforms as it is. And
Brett Cannon added the comment:
You don't. ctypes failing under LLVM 2.8 should not be a special case of
skipping; ctypes not building on darwin regardless of whether it is gcc or
clang is a failure. If someone uses a compiler we don't support, that's
Brett Cannon added the comment:
One other option is to simply have a whitelist of platforms that test.support
knows of so it only considers it a failure when the platform being run on is
known (regrtest does this already).
--
___
Python tracker
Brett Cannon added the comment:
I should mention this would act as a nice testing doc for exactly which
platforms CPython considers supported.
--
___
Python tracker
<http://bugs.python.org/issue10
Changes by Brett Cannon :
Removed file: http://bugs.python.org/file20725/issue10966.diff
___
Python tracker
<http://bugs.python.org/issue10966>
___
___
Python-bugs-list m
Brett Cannon added the comment:
Here is the completed patch. It adds required_on and 'optional' args to
test.support.import_module() to help delineate if a test should **not** be
skipped simply because a module could not be imported. It also changes various
tests to use the new arg
Changes by Brett Cannon :
--
assignee: brett.cannon ->
___
Python tracker
<http://bugs.python.org/issue7997>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
New patch which makes test_pipes back into an explicit skip if os.name !+ posix
and makes test_sqlite optional on all platforms.
--
Added file: http://bugs.python.org/file20737/issue10966.diff
___
Python tracker
New submission from Brett Cannon :
As reported to the PSRT:
Python's SimpleHTTPServer class is a simple HTTP server, documented as
serving up the content of the pwd and below readonly via GET and HEAD
commands:
$ python -m SimpleHTTPServer
Serving HTTP on 0.0.0.0 port 8000 ...
Howeve
Brett Cannon added the comment:
Can you give a longer backtrace? Since that failure is happening in a system
library we need to know where the segfault first occurs in either PIL, numpy,
or CPython.
And have you tried this in Python 2.7?
--
nosy: +brett.cannon
status: open
Brett Cannon added the comment:
odbc is not a module provided by Python.
--
nosy: +brett.cannon
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
r88467 has it for 3.3.
--
resolution: accepted -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue11277>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
So on my system, that 'while' loop is executed once (put a printf() after the
bug and len adjustments and it was never hit).
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
3.3 in r88494
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
r88496 for 3.3
r88497 for 3.2
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
r88498 for 3.3
r88499 for 3.2
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
Does it matter that _4G < UINT_MAX?
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue11277>
___
___
Brett Cannon <[EMAIL PROTECTED]> added the comment:
First, thanks for doing this, Benjamin!
Second, can the plat-darwin directory go as well?
Third, can you get rid of the --disable--toolbox-glue flag for
configure.in (and any other relevant removals) and Makefile.pre.in
cleanup?
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Do note that HTMLParse is slated to become html.parser in 3.0, so these
patches are out-of-date. They can be used, though, to possibly help all
references to HTMLParser (although 2to3 should handle that).
--
nosy: +brett.
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
dependencies: +Remove cl usage from aifc
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2775>
__
__
New submission from Brett Cannon <[EMAIL PROTECTED]>:
The cl module has been removed from Python 3.0, but the aifc module still
imports it in multiple locations. The module needs to be updated (with
tests hopefully) so as to not use the cl module.
--
components: Library (Lib)
me
New submission from Brett Cannon <[EMAIL PROTECTED]>:
The mimetools module has been deprecated for ages, but it is still used in
multiple places (a quick grep lists ``cgi``, ``httplib``, ``urllib``,
``urllib2``, ``test_cookielib``, ``test_multifile``, ``test_urllib``,
``test_u
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
dependencies: +Remove mimetools usage from the stdlib
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
New submission from Brett Cannon <[EMAIL PROTECTED]>:
The rfc822 module has been deprecated for a while but is still used in the
stdlib (at least in 'cgi' and 'test_urllib2'). All uses need to go before
the module can be removed.
--
components: Library
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
dependencies: +Remove usage of rfc822 from the stdlib
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
401 - 500 of 5934 matches
Mail list logo
