Brett Cannon added the comment:
While directly referencing a module on its own is useless, this is an issue if
the module is used in e.g., an assignment: ``blah = cPickle`` is not changed.
--
nosy: +brett.cannon
stage: -> needs patch
___
Pyt
Brett Cannon added the comment:
r88503 has the patch in 3.3
Didn't both with documenting it since I only expect core devs who are debugging
something with 2to3 will want to use this approach.
--
assignee: -> brett.cannon
resolution: -> fixed
stage: commit review -
Brett Cannon added the comment:
applied in r88506
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
I will look at the patch.
--
assignee: jafo -> brett.cannon
nosy: +brett.cannon
stage: committed/rejected -> patch review
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
The patch didn't even import as-is or past the tests, but I tweaked it so it
did (and made method() just an attribute on the module).
--
resolution: accepted -> fixed
stage: patch review -> committed/rejected
status: ope
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue11277>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11327>
___
___
Python-bugs-
Brett Cannon added the comment:
Thanks for the patch, but the wording was completely changed a little while ago
so the error has been dealt with.
--
nosy: +brett.cannon
resolution: -> out of date
status: open -> closed
___
Python tracker
Brett Cannon added the comment:
Just to give an opinion (which can be ignored), I see no issue with mocking if
done carefully and properly. It should just be kept to a minimum (and typically
be privately exposing certain things that can be overridden
Brett Cannon added the comment:
OK, but acceptance tests do not need to not try to get higher test coverage.
For instance, for testing disable() simply using it and making sure the outcome
is as expected also works.
I can understand wanting to avoid some low-level whitebox testing, but I
Brett Cannon added the comment:
Testing the documented API is definitely wanted, Oliver. Any change in
behaviour needs to be detected to ensure there is not backwards-compatibility
regressions without it being intentional.
--
___
Python tracker
Brett Cannon added the comment:
Can you provide the test's failing report and traceback?
--
nosy: +brett.cannon
status: open -> pending
___
Python tracker
<http://bugs.python.org
Brett Cannon added the comment:
My mistake; missed the attachment.
--
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue11340>
___
___
Py
Brett Cannon added the comment:
Fixed in [9bacb56f08e7]
--
nosy: +brett.cannon
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
Fixed in [aa000dd4287f]. I went with a simpler solution than Ben's, but it did
help figure out what to do.
--
nosy: +brett.cannon
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
Brett Cannon added the comment:
So is this a bogus bug, or a valid bug created with a bogus account?
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue11
New submission from Brett Cannon :
test.test_urllibnet.urlopenNetworkTests.test_getcode() is leaving a socket
open. My guess is that the error condition being triggered is somehow leaving
the socket open but I can't find where.
--
components: Library (Lib)
messages: 131059
Changes by Brett Cannon :
--
assignee: -> brett.cannon
stage: -> needs patch
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/
Brett Cannon added the comment:
At the PyCon 2011 sprint we discussed this issue and Nick, myself, and some
other people agreed that using a keyword-only argument for passing in the
module name is probably a better solution. While it won't be
backwards-compatible (BaseException doe
Changes by Brett Cannon :
--
Removed message: http://bugs.python.org/msg131148
___
Python tracker
<http://bugs.python.org/issue502085>
___
___
Python-bugs-list m
Brett Cannon added the comment:
I'm not crazy about the idea of adding an inspect.isclass() check simply to
clear up this rare error message. It's still decipherable what the problem is
from the issubclass() message.
Closing as "won't fix".
--
resolution:
Brett Cannon added the comment:
This is what I get for trying to clean up site.py years ago. =)
I'm fine with the change as long as there is a very clear Misc/NEWS message
that the semantics on import have changed (and obviously this is not
backported).
--
assignee: -> eri
Brett Cannon added the comment:
Someone having the time to do a patch review.
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issu
Changes by Brett Cannon :
--
assignee: eric.araujo -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue11591>
___
___
Python-bugs-list mai
Changes by Brett Cannon :
--
assignee: -> brett.cannon
components: +Demos and Tools
stage: -> patch review
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
Doc changes seem fine to me.
--
assignee: brett.cannon -> eric.araujo
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
It should have been '-w', not '-W'.
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue11653>
___
_
Brett Cannon added the comment:
I have attached a Python script which does what Antoine's patch does except
which is expected to live in Tools/scripts. The perk of doing this in a Python
script is that Windows users will be able to simply execute the script while
the Makefile can be ma
Brett Cannon added the comment:
The attached patch has both the code to make test skipping more obvious as well
as eliminating the concept of expected skips.
If someone can double-check that what I am doing here is sane and desirable I
would appreciate it.
--
assignee: brett.cannon
Changes by Brett Cannon :
--
assignee: -> haypo
___
Python tracker
<http://bugs.python.org/issue8754>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
I went with a different solution as backwards-compatibility dictates a solution
that is not as complete as one might do with an argument to marshal.
--
resolution: -> wont fix
stage: test needed -> committed/rejected
status: open -&g
Brett Cannon added the comment:
The import failures are because you didn't rebuild (I added a new function to
imp). Re-build and the import issues will go away.
--
___
Python tracker
<http://bugs.python.org/is
Brett Cannon added the comment:
You have a build problem, Skip. On my system and at least all of the stable
buildbots for 3.3 there are no test failures from imp._fix_co_filename().
--
___
Python tracker
<http://bugs.python.org/issue11
Brett Cannon added the comment:
In terms of the symmetrical comment, what exactly do you mean? The semantics
are opposites of each other. Do you not like the name? Or did I screw up and
they truly aren't opposites?
--
___
Python tracker
Brett Cannon added the comment:
I can change it to 'required' and 'optional'.
As for Antoine's comment, do you have another suggestion? I realize it isn't
necessarily easier per se to manage these lists than the 'expected' list, but
what would you
Brett Cannon added the comment:
On Thu, Mar 24, 2011 at 15:22, Antoine Pitrou wrote:
Sure, but do the buildbots pick up on this fact in some visible way?
> Perhaps we can keep required/optional for core things like "posix" or
> "winreg". But failing the test su
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue11664>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue11572>
___
___
Python-bugs-list mai
Brett Cannon added the comment:
I say it's a documentation bug.
--
assignee: -> docs@python
components: +Documentation -Interpreter Core, Library (Lib)
nosy: +brett.cannon, docs@python
stage: -> needs patch
___
Python tra
Brett Cannon added the comment:
It's actually not surprising that imp works this way: it predates packages.
Because the semantics (I assume) have been like this for ages I say we document
the current behavior (it's easy to work around) and simply continue to replace
imp function
Changes by Brett Cannon :
--
assignee: -> tarek
components: +Distutils -Tests
nosy: +eric.araujo, tarek
___
Python tracker
<http://bugs.python.org/issu
Brett Cannon added the comment:
Thanks for the report, but this has been fixed in the code repo.
--
nosy: +brett.cannon
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue11701>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue11863>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
When I did the patch they were coming in reversed, so I reversed the reversal.
Obviously something changed so now the manual reversal is not necessary anymore.
--
___
Python tracker
<http://bugs.python.org/issue4
Brett Cannon added the comment:
On Wed, Nov 17, 2010 at 17:19, Éric Araujo wrote:
>
> Éric Araujo added the comment:
>
> I don’t think there can be a unit test for that, so do we agree on just
> removing the reversed call?
As long as the person removing it verifies it and
Brett Cannon added the comment:
I think everyone knows that importlib is there and might need to be patched.
Plus I run importlib against the entire test suite already on occasion so
changes which has a proper test will eventually get caught.
So just file it against core
Brett Cannon added the comment:
PyErr_Format doesn't need to change, just it's argument. A call to
PyObject_Repr() (w/ proper error checking) should be all that is needed.
And no, I don't make any "you do the Python, I'll do the C" deals because th
Brett Cannon added the comment:
No, it's rather Linux and tool specific to go into ast.py. But adding it to the
Tools/ directory makes sense.
--
___
Python tracker
<http://bugs.python.org/is
Brett Cannon added the comment:
Just ran it without issue after doing an `svn up`.
As for fix vs. not, while fixing indentations and removing trailing whitespace
is nice, it isn't necessary. Both instances should be a rarity (most IDEs will
make sure the situation doesn't occur), s
Brett Cannon added the comment:
I have no issue with moving importlib into Lib/test as long as I can still run
the tests with ``python3 -m test.importlib``. I actually only put the tests in
importlib.tests because that was common practice amongst newer packages in the
stdlib.
And just to
Brett Cannon added the comment:
I'm with Raymond; this is unneeded consistency. I honestly would rather see
what little support there is for a trailing comma to go away, but w/o looking
at the grammar I am willing to bet that would be a pain to get right and not be
worth the e
Brett Cannon added the comment:
So I just looked at the syntax file linked by Antoine and that is definitely
*not* what he meant to link to; probably meant
http://www.vim.org/scripts/script.php?script_id=790 . As for the indentation
file, it's out-of-date and so doesn't sup
Brett Cannon added the comment:
Nothing jumps to my mind.
--
___
Python tracker
<http://bugs.python.org/issue4236>
___
___
Python-bugs-list mailing list
Unsub
Brett Cannon added the comment:
I say ditch it.
--
___
Python tracker
<http://bugs.python.org/issue10710>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
That's a fair assessment. A lot of the bugs that are easy to fix got closed out
a couple of years back. The rest are (I think) considered too difficult and too
marginal to worry about.
--
nosy: +brett.c
Brett Cannon added the comment:
But if you have a local copy of the Vim files from the community what is
preventing you from editing them for new keywords and sending a patch to the
maintainer so that the rest of the community is brought up to speed that much
faster?
I suspect that not many
Brett Cannon added the comment:
This is still failing. I also just confirmed it is also happening for 3.1 and
2.7.
--
versions: +Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/issue10
New submission from Brett Cannon :
r87812 shows that using getopt is not a good thing; having the short and long
versions of an argument separated from each other can lead to bugs. It would be
good to move test.regrtest over to argparse to help prevent that from happening
again
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue10845>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I will be writing a proper task item for this (there's a reason it's a todo
item =), but I will read this before writing it so feel free to leave any
thoughts or ideas for the future task.
--
___
Pyth
Brett Cannon added the comment:
You missed importlib/abc.py which uses the annotations to document the types of
method arguments (and their return values), e.g., what Guido said he might use
the annotations for.
--
nosy: +brett.cannon
___
Python
Brett Cannon added the comment:
You can discuss within the comments whether this issue should be re-opened or
not, but do not take it upon yourself to change the status on your own once a
core developer has already closed an issue as their decision supersedes that of
a regular user
Changes by Brett Cannon :
--
nosy: -brett.cannon
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue7662>
___
___
Python-bugs-list mai
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue10951>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue10923>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
priority: normal -> critical
___
Python tracker
<http://bugs.python.org/issue10845>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
Filed a bug with LLVM/Clang: http://llvm.org/bugs/show_bug.cgi?id=9014
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
Chris Lattner from LLVM says that this has been fixed in their mainline and
that to work around it in LLVM 2.8 one should build with the -no-integrated-as
flag.
--
resolution: -> fixed
status: open ->
New submission from Brett Cannon :
Once the docs are built using Python 3, then the coverage results can be used
by people wanting to contribute as something to do. Should also mention in the
task that some APIs should probably be private:
http://mail.python.org/pipermail/python-dev/2010
Changes by Brett Cannon :
--
dependencies: +Build 3.x documentation using python3.x
___
Python tracker
<http://bugs.python.org/issue10965>
___
___
Python-bug
New submission from Brett Cannon :
test.regrtest considers an ImportError to be a test to skip. It then uses this
info to decide what skipped tests were expected (or not) based on a list kepted
in regrtest.py.
For detecting compiler failures, an ImportError should be a test error or
failure
Brett Cannon added the comment:
Once the proper function in test.support comes about then a dev task to help
move everything over can be created. And then once all needed test modules have
been switched over the ImportError try/except statement in regrtest can be
removed
New submission from Brett Cannon :
test.regrtest is rather old and has not been updated to take advantage of all
the latest features in unittest (e.g., test discovery). It might be a rather
large undertaking with various bits requiring some changes (e.g., getting away
from raising exceptions
Brett Cannon added the comment:
I have verified that if you add -no-integrated-as as a flag (e.g., through
CFLAGS) then ctypes will build.
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
Yes. So for _winreg (if we even have tests) it would be skipped on all OSs
other than Windows, on on Windows it would be a test failure if it didn't work
as it is expected to exist.
--
___
Python tracker
Brett Cannon added the comment:
Yes, I somewhat view this as an index issue. I don't expect a wholesale move
but a more step-by-step move.
--
___
Python tracker
<http://bugs.python.org/is
Brett Cannon added the comment:
That entire portion of the FAQ has been removed as it was redundant compared to
other parts of the devguide.
Closing as out of date.
--
resolution: -> out of date
status: open -> closed
___
Python tracker
Brett Cannon added the comment:
At least the test_trace fix for preventing the complete destruction of any
preset trace should be looked at and possibly applied separately (prevents
coverage.py from covering the entire test suite as well). Should probably add a
test to regrtest to make sure
New submission from Brett Cannon :
If you run test_sys under coverage.py with ``./python.exe -m coverage run
--pylib Lib/test/regrtest.py test_sys`` you get::
Fatal Python error: Cannot recover from stack overflow
Have not taken the time to try to figure out exactly what code is triggering
Brett Cannon added the comment:
Ran the test under verbose mode at Antoine's suggestion; test triggering the
failure is test_recursionlimit_recovery
--
___
Python tracker
<http://bugs.python.org/is
Brett Cannon added the comment:
The comment on the test says its brittle and sensitive to nothing mucking
around with recursion depth, so the test probably need a unittest.skipIf check
for a trace function.
--
___
Python tracker
<h
Brett Cannon added the comment:
I have a patch for this which makes it a CPython-only test along with being
conditional if a trace function is set. Making it a release blocker to see if
Georg will let me commit it.
--
keywords: +patch
nosy: +georg.brandl
priority: normal -> rele
Brett Cannon added the comment:
Georg cleared the commit; just waiting for a test run with coverage.py to
finish before committing.
--
resolution: -> accepted
stage: unit test needed -> commit review
___
Python tracker
<http://bugs.p
Brett Cannon added the comment:
r88153 w/ a review by Georg Brandl
--
resolution: accepted -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Brett Cannon :
The attached patch adds resource monitoring to test.regrtest to detect which
tests are changing the trace function w/o putting back to what it was
previously. The tests listed below are thus all being naughty. This is a
meta-issue to help track which tests
New submission from Brett Cannon :
If you run ``test.regrtest -T`` you will discover that (at least)
test_importlib and test_runpy prevent coverage data from being written out as
'trace' will try to find files which no longer exist. Both test suites create
temp files, import them
New submission from Brett Cannon :
A bunch of tests fail when run under coverage (trend seems to be refcount
tests). This is to act as a meta-issue to keep track of what tests need to be
fixed.
[fail under both coverage.py and regrtest -T]
test_ctypes
test_descr
test_gc
test_metaclass
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue10994>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I've done what I plan to do to Misc and moving Porting was not part of it. I
have no issue if someone else moves it, though.
--
resolution: -> rejected
status: open -> closed
___
Python tra
Changes by Brett Cannon :
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue9893>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
Cinder on IRC found that test_exception's RuntimeError test triggers a
trace_trampoline() line of code which resets the trace function as an exception
gets triggered in the trace function itself.
test_doctest is being messy and setting pdb's trace fu
Brett Cannon added the comment:
test_pdb uses pdb.set_trace() w/o putting the original trace function back.
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
test_scope blindly resets the trace function to None.
--
___
Python tracker
<http://bugs.python.org/issue10990>
___
___
Python-bug
Brett Cannon added the comment:
And here is a revelation: test_sys_settrace clobbers the trace function blindly.
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
test_zipimport_support fails because test_doctest fails; it re-runs the tests
from a zipfile.
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
test_io is causing coverage.py to complain thanks to the TextIOWrapperTests,
and the regrtest check is complaining about SignalsTests. Don't know why
specifically for either.
--
___
Python tracker
Brett Cannon added the comment:
test_runpy fails because of a recursion depth test (test_main_recursion_error).
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
test_richcmp is failing because of a recursion test (test_recursion)
--
___
Python tracker
<http://bugs.python.org/issue10
Brett Cannon added the comment:
For test_io.*SignalsTests, its all the tests calling check_interrupted_write().
For TestIOWrapperTests its test_threads_write() (although only coverage.py is
complaining, not regrtest).
--
___
Python tracker
<h
301 - 400 of 5934 matches
Mail list logo
