Brett Cannon <[EMAIL PROTECTED]> added the comment:
If you start at line 3652 in configure.in you fill find the check for
the %zd format specifier. Any patch to make it more robust would be
appreciated.
--
nosy: +brett.cannon
priority: -> normal
stage: ->
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
keywords: +needs review
stage: -> commit review
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Brett Cannon <[EMAIL PROTECTED]> added the comment:
The patch looks good to me.
--
nosy: +brett.cannon
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
keywords: -needs review
stage: patch review -> commit review
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Brett Cannon <[EMAIL PROTECTED]> added the comment:
r67310 has the fix.
--
resolution: -> accepted
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Brett Cannon <[EMAIL PROTECTED]> added the comment:
I am re-opening this as a deferred blocker with a patch to document that
dbm implementations write out and return bytes, but that strings are
accepted and implicitly converted.
--
priority: release blocker -> deferred block
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Have another patch that fixes all open() calls to specify the file
encoding in dbm.dumb. Also caught one spot in _addkey() where
decode("Latin-1") was not being called.
Added file: http://bugs.python.org/file12085/specify_op
Brett Cannon <[EMAIL PROTECTED]> added the comment:
So the use of pickle is not fair as that doesn't round-trip if you
simply write out a file because py3k pickle doesn't like classic classes
and the new-style classes want copy_reg which is not in existence in
py3k since it
Changes by Brett Cannon <[EMAIL PROTECTED]>:
Added file: http://bugs.python.org/file12098/pickle3read.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Brett Cannon <[EMAIL PROTECTED]>:
Added file: http://bugs.python.org/file12099/mydb2write.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Brett Cannon <[EMAIL PROTECTED]>:
Added file: http://bugs.python.org/file12100/mydb3read.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
resolution: accepted ->
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3799>
___
__
Brett Cannon <[EMAIL PROTECTED]> added the comment:
On Fri, Nov 21, 2008 at 10:32, Skip Montanaro <[EMAIL PROTECTED]> wrote:
>
> Skip Montanaro <[EMAIL PROTECTED]> added the comment:
>
> Brett> In other words I think my solution works and pickle is the
>
Brett Cannon <[EMAIL PROTECTED]> added the comment:
On Fri, Nov 21, 2008 at 11:01, Skip Montanaro <[EMAIL PROTECTED]> wrote:
>
> Skip Montanaro <[EMAIL PROTECTED]> added the comment:
>
> One doc nit: There is still reference to ``gdbm`` and Dbm (or dbm) objects
&
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Issue 3799 already has a patch that specifies the encoding upon opening
the file so this should be fixed by final. Can you test the patch
(specify_open_encoding.diff) and let me know if that solves your
problem, M
New submission from Brett Cannon <[EMAIL PROTECTED]>:
It would be nice if the logging package provided a replacement for
warnings.showwarning() so that all warning redirect to the logging package.
--
components: Library (Lib)
keywords: easy
messages: 76221
nosy: brett.cannon
pr
Brett Cannon <[EMAIL PROTECTED]> added the comment:
On Sun, Nov 23, 2008 at 15:49, STINNER Victor <[EMAIL PROTECTED]> wrote:
>
> STINNER Victor <[EMAIL PROTECTED]> added the comment:
>
> 2.6 and 3.0rc3 are released. It's too late to change the standard
>
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
assignee: brett.cannon ->
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4236>
___
__
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
assignee: -> brett.cannon
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4382>
___
__
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Fixed in r67369.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Brett Cannon <[EMAIL PROTECTED]> added the comment:
specify_open_encoding.diff has been committed in r67369.
I still need a review for doc_dbm_strings.diff, though, which clarifies
the docs, fixes one oversight in dbm.dumb, and extends testing to make
sure strings can be ac
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
components: +Library (Lib)
stage: needs patch -> commit review
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Brett Cannon <[EMAIL PROTECTED]> added the comment:
On Mon, Nov 24, 2008 at 16:25, Skip Montanaro <[EMAIL PROTECTED]> wrote:
>
> Skip Montanaro <[EMAIL PROTECTED]> added the comment:
>
> Brett> I still need a review for doc_dbm_strings.diff, though, which
>
Brett Cannon <[EMAIL PROTECTED]> added the comment:
r67380 has the fix. Thanks for the review, Skip!
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Brett Cannon <[EMAIL PROTECTED]> added the comment:
The reason this occurs is that in order to have a portable and sane
implementation time.strptime() uses the re module to parse dates. The
issue here is that by specifying the same format twice the re module is
complaining that there a
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Amaury's patch for pickle looks fine to me.
--
nosy: +brett.cannon
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Is this an actual bug report or more of a request for help? If it is the
former then a test case is needed in order to help figure out what is
going on. If it is the latter you should ask on
comp.lang.python/pytho
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
nosy: +brett.cannon
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4469>
___
__
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
nosy: +brett.cannon
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4477>
___
__
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Because of all the patch includes a bunch of junk for generated files
(any chance you can make a diff, Thomas, with only the stuff that really
requires review?), I have not done a real review. But a quick look does
show that the comment
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
New submission from Brett Cannon <[EMAIL PROTECTED]>:
If you try to remove something from a list, e.g. ``[].remove(1)``, the
message from ValueError is rather useless: "ValueError: list.remove(x):
x not in list". It should probably list the repr for the argument to
h
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Considering the entire compiler package is not in 3.0 it is not worth
fixing this. Closing as wont fix.
--
nosy: +brett.cannon
resolution: -> wont fix
status: open -> closed
___
Py
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Yes, the simple __import__/sys.modules idiom should be the suggested
idiom until a proper function is provided in the standard library.
--
nosy: +brett.cannon
___
Python tracker <[EMAIL
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Benoit has a good point, so I have opened this issue again so we can get
2.7 even closer to 3.x compatibility.
--
resolution: fixed ->
status: closed -> open
___
Python tracker <[
Brett Cannon <[EMAIL PROTECTED]> added the comment:
On Sun, Dec 7, 2008 at 13:26, Mark Dickinson <[EMAIL PROTECTED]> wrote:
>
> Mark Dickinson <[EMAIL PROTECTED]> added the comment:
>
> About unittest:
>
> unittest.TestLoader has an attribute "sortTestM
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Are you returning the module in your extension's init function? The
import machinery takes the returned module from the init function and
adds it to sys.modules for you.
--
nosy: +b
Changes by Brett Cannon <[EMAIL PROTECTED]>:
--
status: open -> pending
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4612>
___
___
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Because the init function for extension modules are supposed to return
the module now and the import machinery adds the module itself.
--
nosy: +brett.cannon
___
Python tracker <[EMAIL
Brett Cannon <[EMAIL PROTECTED]> added the comment:
Ah, I had not looked at the issue; sorry about the confusion.
PyImport_Create() is doing what it is supposed to be doing and should
not call PyImport_AddModule(). The example is wrong.
Closing this as invalid since the example
Brett Cannon <[EMAIL PROTECTED]> added the comment:
You are probably looking at http://docs.python.org/3.0/ still and that
only updates when a new release happens. To see the in-development docs
look at http://docs.python.org/dev/3.0/ .
And the problem with the docs and its new PyModule_
Brett Cannon <[EMAIL PROTECTED]> added the comment:
The example is broken.
And the example under discussion is
http://docs.python.org/dev/3.0/extending/embedding.html#extending-embedded-python
.
I have changed the title to be more descriptive and assigned to Martin
to find out what the
New submission from Brett Cannon <[EMAIL PROTECTED]>:
PyModule_Create() is not documented (or at least it isn't showing up in
the C API index). Might be other parts of the new module initialization
API that are not documented either.
--
assignee: georg.brandl
components: Do
Brett Cannon <[EMAIL PROTECTED]> added the comment:
On Tue, Dec 9, 2008 at 14:34, Amaury Forgeot d'Arc
<[EMAIL PROTECTED]> wrote:
>
> Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:
>
> When python is embedded in a program, there must be a w
New submission from Brett Cannon <[EMAIL PROTECTED]>:
When compile() is called with a string it is a reasonable assumption
that it has already been decoded. But this is not in fact the case and
leads to errors when trying to use non-ASCII identifiers::
>>> source = "# co
New submission from Brett Cannon <[EMAIL PROTECTED]>:
Passing in bytes to compile() works well for letting the parser handle
the decoding of a file when an encoding is specified, but it doesn't
take care of universal newlines::
>>> source = b'a = 1\r\nb = 2\r\n'
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue4010>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue1673409>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Here is what I have found out so far.
Python/bltinmodule.c:builtin_compile takes in a PyObject and gets the
char * representation of that object and passes it to
Python/pythonrun.c:Py_CompileStringFlags. Unfortunately no other
information is passed along in the
Brett Cannon added the comment:
So explicitly converting to UTF-8 didn't work, or at least as simply as
I had hoped.
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
Do you still need a review for this, Guilherme? If you just need a quick
code check I can see if I can make the time for this, but my tkinter
knowledge is lacking so it won't be very in-depth. Hopefully this is all
isolated enough that even if it is init
Brett Cannon added the comment:
If Fredrik already reviewed it I don't see why you can't commit. If
something goes wrong you can always back the commit out.
As for the testing question, I am not sure I understand what you are
asking. Are you asking if the tests can stay integ
Brett Cannon added the comment:
At the language summit I actually plan on proposing separating out the
Python the language and standard library from CPython. That would make
this patch mostly unneeded as the CPython-specific tests and code would
simply be kept separate from the language code
Brett Cannon added the comment:
I will see when I can get to it (other stuff is taking priority). Not
going to assign to myself quite yet in case someone wants to beat me to
this. I won't lose track since I created the bug and have a saved query
to look at all bugs I
Brett Cannon added the comment:
I will take a look when I can.
--
assignee: -> brett.cannon
___
Python tracker
<http://bugs.python.org/issue4347>
___
___
Py
Brett Cannon added the comment:
The other option is to propose its removal on python-dev, get support,
and then submit patches for the module's deprecation.
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
Yeah, that code has not been tested yet as that is farther down the todo
list. Thanks for the catch!
Fixed in r68761.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Pytho
Brett Cannon added the comment:
On Tue, Jan 20, 2009 at 18:19, Terry J. Reedy wrote:
>
> Terry J. Reedy added the comment:
>
> Like Brett, I think the long term solution is to segregate
> implementation-specific tests into a separate file or subdirectory of
> files. Then
Changes by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<http://bugs.python.org/issue4111>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Amaury, did the buildbots verify this worked and thus this bug can be
closed?
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue3
Brett Cannon added the comment:
Well, if the libraries for Ttk are not included then the tests should
get skipped when the import fails.
A key reason to leaving something out of 'all' is if it takes a REALLY
long time like the zipfile64 tests.
--
nosy: +br
New submission from Brett Cannon :
When you call datetime.datetime.utcnow() you get back a naive datetime
object. But why? You asked for UTC as the timezone based on what method
call you made. And UTC is a very concrete timezone that never changes.
It would be nice to have a concrete UTC tzinfo
Brett Cannon added the comment:
On Wed, Jan 28, 2009 at 18:17, Daniel Diniz wrote:
>
> Daniel Diniz added the comment:
>
> Brett,
> It might be worth to update tzinfo-examples.py to use your concrete UTC
> then:
I will if people are generally okay with the idea of
Brett Cannon added the comment:
On Thu, Jan 29, 2009 at 07:30, Benjamin Peterson wrote:
>
> Benjamin Peterson added the comment:
>
> Actually, I would like to repurpose tp_compare as tp_bytes for the
> __bytes__ method.
Repurposing would be extremely bad as that would mean it
Brett Cannon added the comment:
>> On Thu, Jan 29, 2009 at 07:30, Benjamin Peterson
>> wrote:
>>>
>>> Benjamin Peterson added the comment:
>>>
>>> Actually, I would like to repurpose tp_compare as tp_bytes for the
>>> __bytes__ metho
Brett Cannon added the comment:
The problem is not that ctime should be taken into account, but that the
.pyc file should be read for its timestamp and that should be used.
Otherwise you are still deviating from what Python uses internally to
decide whether bytecode should be regenerated
Brett Cannon added the comment:
And just some more info, Python 2.7/3.1 have gained the importlib
module/package and its import_module function which gives a much saner
API than __import__.
___
Python tracker
<http://bugs.python.org/issue2
Brett Cannon added the comment:
On Mon, Feb 2, 2009 at 12:22, Martin von Gagern wrote:
>
> Martin von Gagern added the comment:
>
> Like this?
Don't have the time right now to do a code review right now, but
hopefully I can get to this soon.
> Should the magic number be
Changes by Brett Cannon :
--
assignee: -> brett.cannon
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue5128>
___
___
Python-bugs-
Brett Cannon added the comment:
On Mon, Feb 2, 2009 at 12:42, Martin von Gagern wrote:
>
> Martin von Gagern added the comment:
>
> Next iteration. With magic number, and now also closing the file again.
> I changed from unpack and number comparison to pack and string
>
Brett Cannon added the comment:
On Mon, Feb 2, 2009 at 13:50, Brett Cannon wrote:
> On Mon, Feb 2, 2009 at 12:42, Martin von Gagern
> wrote:
>>
>> Martin von Gagern added the comment:
>>
>> Next iteration. With magic number, and now also closing the file again
Brett Cannon added the comment:
If you want an easy way to see how bytecode is checked, look at
importlib._bootstrap in Python 3.1:
http://svn.python.org/view/python/branches/py3k/Lib/importlib/_bootstrap.py?view=markup
. Specifically, look at the get_code() method for _PyFileLoader
Changes by Brett Cannon :
--
priority: -> low
stage: -> needs patch
type: -> feature request
___
Python tracker
<http://bugs.python.org/issue5094>
___
Brett Cannon added the comment:
On Tue, Feb 3, 2009 at 03:28, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> The UTC class have to be converted to C.
Yes, the example code is just an example. =)
> Can someone write a patch for
> datetimemodule.c (and th
Changes by Brett Cannon :
--
assignee: -> brett.cannon
stage: needs patch -> test needed
___
Python tracker
<http://bugs.python.org/issue5094>
___
___
Pyth
Brett Cannon added the comment:
So I finally got around to reviewing the patch and while it looks fine,
I ended up with some failing tests: test_compiler test_quopri test_sys
test_transformer.
Do you know what is going on Thomas? This is after repeated make/make
clean calls and using your non
Brett Cannon added the comment:
Patch is really close. Can you use a context manager for the file
management? That way the file is guaranteed to be closed without issue.
___
Python tracker
<http://bugs.python.org/issue5
Brett Cannon added the comment:
On Wed, Feb 4, 2009 at 05:56, Eric Smith wrote:
>
> Eric Smith added the comment:
>
> The doc string for sys includes:
> version_info -- version information as a tuple
>
> I'm not sure changing this to "... as a structseq"
Brett Cannon added the comment:
Here is a patch to remove the DeprecationWarning.
--
keywords: +patch
Added file: http://bugs.python.org/file12967/issue3652.diff
___
Python tracker
<http://bugs.python.org/issue3
Brett Cannon added the comment:
On Sun, Feb 8, 2009 at 09:15, Martin von Gagern wrote:
>
> Martin von Gagern added the comment:
>
> Any progress with the review?
>
I am planning to get to it on Tuesday.
> By the way, what branch are we aiming for?
2.7/3.1. It's a
Brett Cannon added the comment:
On Mon, Feb 9, 2009 at 01:11, Thomas Lee wrote:
>
> Thomas Lee added the comment:
>
> This would appear to be another build quirk: Lib/symbol.py needs to be
> regenerated if Grammar/Grammar changes.
>
> Brett, do you think it would be oka
Brett Cannon added the comment:
It's probably out of date. I will check if it is still failing tonight
or tomorrow probably.
--
assignee: jackjansen -> brett.cannon
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
Committed in 69481 and 69482 for trunk and py3k, respectively. Had to
rewrite the test code but the compileall patch went in fine. Thanks, Martin!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -&g
Changes by Brett Cannon :
--
title: add "reload" function -> add "reload" function to IDLE
___
Python tracker
<http://bugs.python.org/issue1175686>
___
__
Brett Cannon added the comment:
Georg is right and this has been fixed apparently in 3.0, leaving 2.7
and older broken.
There are two possible solutions to this. One is to change
socket._fileobject.fileno() to simply try self._sock.fp.fileno() if
self._sock.fileno() does not exist. The other
Brett Cannon added the comment:
Another option is to change urllib.addinfourl to look for fileno() on an
HTTPResponse object.
___
Python tracker
<http://bugs.python.org/issue1327
Changes by Brett Cannon :
--
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue5094>
___
___
Python-bugs-list mailing list
Un
Changes by Brett Cannon :
--
priority: -> normal
stage: patch review -> needs patch
___
Python tracker
<http://bugs.python.org/issue4347>
___
___
Pyth
Changes by Brett Cannon :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue2775>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brett Cannon :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue616247>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brett Cannon :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue2227>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brett Cannon :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue4011>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brett Cannon :
--
assignee: -> brett.cannon
nosy: +brett.cannon
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue5236>
___
__
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue5239>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue5240>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Closing as I don't think this is Python's fault plus we have changed how
we generate our project files since then.
--
nosy: +brett.cannon
resolution: -> rejected
status: open -> closed
___
Pytho
Changes by Brett Cannon :
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue974635>
___
___
Python-bugs-
Brett Cannon added the comment:
"Practically nothing can be reused - there's no registry, no shebang handling,
and our process launching on Windows is already very complex (and has to remain
that way for compatibility)."
I do process the shebang to restrict searching,
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue47025>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I think it depends on whether we want to say the standard/included/built-in
import mechanisms don't support byte paths, or byte paths are entirely not
supported even for 3rd-party code? I definitely think we should at least do the
former, but I'm h
1201 - 1300 of 5934 matches
Mail list logo
