Brett Cannon added the comment:
On 10/7/07, Gregory P. Smith <[EMAIL PROTECTED]> wrote:
[SNIP]
> Feel free to close this bug in favor of something that just tracks the
> PEP being implemented.
Eh, it can stay open as a reminder to double-check everything is fine
once PEP 3137 go
New submission from Brett Cannon:
PySys_GetObject() is not documented even though it is exposed as part of
the public API.
--
components: Documentation
messages: 56266
nosy: brett.cannon
priority: low
severity: minor
status: open
title: Document PySys_GetObject()
type: behavior
versions
New submission from Brett Cannon:
PySys_GetObject() is not documented even though it is exposed as part of
the public API.
--
components: Documentation
messages: 56267
nosy: brett.cannon
priority: low
severity: minor
status: open
title: Document PySys_GetObject()
type: behavior
versions
Brett Cannon added the comment:
Accidentally clicked the Submit button twice; exact dup of issue1245.
--
resolution: -> duplicate
status: open -> closed
superseder: -> Document PySys_GetObject()
__
Tracker <[EMAIL PROTECTED]>
<http
New submission from Brett Cannon:
For instance, ftplib.FTP reads from sockets using socket.makefile(), but
in text mode. That's bad when the data could be in the format of ASCII
or binary data.
--
components: Library (Lib)
keywords: py3k
messages: 56281
nosy: brett.cannon
pri
Brett Cannon added the comment:
I have uploaded my touched up version of _warnings.c . I also have a
new diff since the old one did not apply cleanly (test_warnings didn't
get patched nor did PCbuild8). It also lacked the changes needed to
Modules/config.c .
It is still not complete, t
Changes by Brett Cannon:
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1631171>
_
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python
Brett Cannon added the comment:
I just tried Neal's version of _warnings.c and it has the same failures,
so they are not my fault. =)
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.or
Brett Cannon added the comment:
I figured out why the tests are all failing; the C code does not call
back into the Python 'warnings' wrapper.
For instance, warn_explicit in the C code does not ever try to use a
user-provided showwarning() function. This causes the tests to fail as
Brett Cannon added the comment:
I went ahead and had Vim do a global search-and-replace on the names and
ditched the typedefs; the patch is uploaded. I have not yet run the
test suite, though, which is why I have not committed it. But if it
passes I will just check it in.
--
assignee
Brett Cannon added the comment:
Applied my patch in r58399. Thanks for noticing the inconsistency, anthon!
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Brett Cannon:
--
status: open -> closed
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue756576>
___
Python-bugs-list mailing li
New submission from Brett Cannon:
If Py3K is executed without importing site, it fails horribly. This is
because site.py sets __builtins__.open, sys.stdout, sys.stderr, and
sys.stdin.
The setting of sys.stderr is especially bad as exception printing
requires sys.stderr, otherwise it reports
Changes by Brett Cannon:
--
keywords: +patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1274>
__
___
Python-bugs-list mailing list
Unsubs
Brett Cannon added the comment:
So the descriptor idea didn't work.
Another idea is to have the C code that relies on attributes on warnings
that are allowed to change have an initial check for warnings, and if
that fails to fall back on C code. That way the module can still be
completely
Brett Cannon added the comment:
No, my work has the exact same problem. Actually, this bug report has
confirmed for me why heapq could not be imported when I accidentally
forced all open text files to use UTF-8. I just have not gotten around
to trying to solve this issue yet. But since
Changes by Brett Cannon:
--
assignee: -> brett.cannon
keywords: +patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1267>
__
___
Python-bugs-li
Brett Cannon added the comment:
Attached is a new version of _warnings.c that checks to see if
'warnings' has been imported, and if so, uses the attributes from that
module for onceregistry and 'filters'. I did it in such a way so that
'warnings' is in no way
Brett Cannon added the comment:
Regression test suite now passes. =) Had to add the support for when
warnings.showwarning() is set and a bug in PyErr_WarnExplicit() where a
NULL value for the module name was not being allowed.
Couple things still left to implement. One is the second output
Brett Cannon added the comment:
Attached is a patch to fix test_compile. Simple fix of turning an empty
string into ``str8('')``.
Added file: http://bugs.python.org/file8573/fix_test_compile.diff
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Brett Cannon added the comment:
The file I just uploaded is unicode-string-eq-false-all-r4.patch with
the codecs.c and structmember.c parts of the patch removed.
--
nosy: +brett.cannon
Added file: http://bugs.python.org/file8572/r4-revised.patch
Brett Cannon added the comment:
runpy is failing because pkgutil is failing because it is giving
compile() part of a source file instead of the entire thing::
Traceback (most recent call last):
File "/Users/drifty/Dev/python/3.x/pristine/Lib/runpy.py", line 97,
in _run_modu
Brett Cannon added the comment:
It looks like the file object returned by imp.find_module() has its read
position WAY too far forward (at least on OS X).
Re-opening.
--
status: closed -> open
__
Tracker <[EMAIL PROTECTED]>
<http://bug
Changes by Brett Cannon:
--
nosy: +brett.cannon
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1303>
__
___
Python-bugs-list mailing list
Unsubs
Changes by Brett Cannon:
--
keywords: +patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1303>
__
___
Python-bugs-list mailing list
Unsubs
Brett Cannon added the comment:
Yeah, I just noticed this as well. is it definitely this change?
On 10/19/07, Guido van Rossum <[EMAIL PROTECTED]> wrote:
>
> Guido van Rossum added the comment:
>
> FWIW, on Mac I get six failures (all these pass on Linux):
>
> te
Brett Cannon added the comment:
Attached a fix for test_format.
It was testing string interpolation on both str8 and str and using a str
for the comparison. Since string interpolation is going away for str8
once it becomes bytes I just removed the testing of str8.
The failures I know of left
Brett Cannon added the comment:
OK, for some reason, when PyTokenizer_FindEncoding() is called and the
resulting file is big enough, it starts off with a seek position
(according to TextIOWrapper.tell()) of 4096. That happens to be exactly
half the size of the buffer used by io.
But I am not
Brett Cannon added the comment:
Nope, didn't do it. I also checked using gdb a few minutes ago and
ftell() was reporting a position of 0 all they way back to
PyObject_MethodCall().
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Brett Cannon added the comment:
58557 as the fix. Yes, it was stupid on OS X's part and I was lucky to
just think of the possible solution.
Basically OS X does not like it when you do stuff with a file pointer
but then poke around with the file descriptor. That means that
Brett Cannon added the comment:
OK, I think I might have a solution, and it is really stupid. I will
run the unit test suite to see if it really fixes everything.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Brett Cannon added the comment:
I checked in your ``< 2`` change and plugged a memory leak since you
were not freeing the struct tok_state. Checked in r58555.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Brett Cannon added the comment:
On 10/19/07, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> Brett Cannon wrote:
> > This suggests that perhaps we should standardize on file pointers or
> > file descriptors in Python to pr
Changes by Brett Cannon:
Removed file: http://bugs.python.org/file8543/unnamed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1263>
__
___
Python-bugs-list
Brett Cannon added the comment:
There is no patch. =)
--
assignee: -> gvanrossum
keywords: +py3k
nosy: +brett.cannon
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Brett Cannon added the comment:
PyTokenizer_FindEncoding() is the culprit. If I comment it out in
Python/import.c:call_find_module(), and thus just use the system
encoding, runpy works again.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Brett Cannon added the comment:
Patch is inlined in a comment.
--
keywords: +patch
nosy: +brett.cannon
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Brett Cannon added the comment:
Thanks, Guido.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1267>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mai
Brett Cannon added the comment:
On 10/20/07, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> Guido van Rossum wrote:
> > You're right that a lot of this could be avoided if we used file
> > descriptors consistently. It
Brett Cannon added the comment:
Attached is a fix for modulefinder.
It is an ugly hack as modulefinder took the numeric opcode numbers from
dis and passed them to chr(). But that doesn't work since that returns
Unicode. So I took those single characters and passed them to str8().
Once
Brett Cannon added the comment:
Attached is a fix for sqlite3.
First issue was that the dictionary that was being used to store
converters was having keys in Python code as Unicode but being compared
against str8 in C.
The second issue was that when an object was serialized using
__conform__
Brett Cannon added the comment:
Attached is a patch to fix test_str.
Basically there were a bunch of redundant tests for making sure that
calling str() on an object called it's __str__ method. str8 no longer
is directly relevant since it is no longer an actual string type.
Added file:
Brett Cannon added the comment:
Guido, what do you want to do about the struct module for the various
string formats (i.e., c, s, p)? Should they return str8 or Unicode?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Brett Cannon added the comment:
Attached is a fix for test_subprocess.
Simply had to change a call to str8() to str().
I am going to run the test suite, but that should leave only test_struct
failing and that can be fixed as soon as Guido makes a call on whether
str8 or str should be used for
Brett Cannon added the comment:
Attached is a fix for test_struct.
All of the string tests now assume str8 is returned when arguments of
bytes, str8 or str are given for the various string formats.
All tests now pass. Re-assigning to myself to check everything in when
it isn't so la
Changes by Brett Cannon:
--
keywords: +py3k
priority: -> immediate
type: rfe -> behavior
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1263>
__
_
Brett Cannon added the comment:
Everything committed in r58596. Thanks for the help, Thomas!
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Brett Cannon added the comment:
The changes to str8 look fine.
Now it's time to find out how badly tests break since Georg's patch was
generated. =)
--
assignee: gvanrossum -> brett.cannon
__
Tracker <[EMAIL PROTECTED]>
<
Brett Cannon added the comment:
Attached is an updated patch. I didn't touch Georg's code short of
tossing in some comments on whether we wanted to sneak around some APIs
for performance or not. Anything I added was to make all but one test pass.
And that one test is test_str. Th
Brett Cannon added the comment:
I will have a look when I can.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1293>
__
___
Python-bugs-list mailing list
Unsubs
Brett Cannon added the comment:
This is not going to go anywhere without someone offering a patch to
implement this. Plus I suspect this has a much greater use in the C API
than in the Python API for datetime.
--
nosy: +brett.cannon
_
Tracker
Brett Cannon added the comment:
On 11/6/07, Guido van Rossum <[EMAIL PROTECTED]> wrote:
>
> Guido van Rossum added the comment:
>
> > Another patch that uses os.path.normpath.
>
> Sorry, I really don't like to be importing os.path in order to be able
> to
Brett Cannon added the comment:
While I am not sure how I feel about searching every entry on sys.path,
I know I don't like the idea of recursing the directory tree. pth files
are meant to only be at the top-level of a directory that packages and
modules are checked for.
--
Brett Cannon added the comment:
For what you meant by recursion, that makes more sense.
But as for whether this is correct or not, read the next paragraph in
the site docs
(http://docs.python.org/dev/library/site.html#module-site). It says "A
path configuration file is a file whose nam
Brett Cannon added the comment:
I have made this a documentation bug as obviously there is some needed
clarification in how .pth files are handled.
If you have any suggested wording, Giambattista, then please feel free
to submit patches against the 2.6 docs (easier to work with since they
are
Brett Cannon added the comment:
And under 2.6 on OS X. I doubt this is a BSD thing but more of a
recursion depth issue.
And I don't think there is anything to fix here. The recursion depth is
a per-thread thing, and this test is blowing the C stack before the
recursion depth is reached
Changes by Brett Cannon:
--
assignee: nnorwitz -> brett.cannon
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1631171>
_
___
Python-bugs-li
Brett Cannon added the comment:
Fixed in r59033 for Python 2.6. Thanks for the help!
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Brett Cannon added the comment:
This version of test_warnings has tests for _warnings.c. It currently
is failing as the second line of output for warnings has not been
implemented yet for _warnings.c.
But all the specified tests in my last comment have now been implemented.
Added file: http
Brett Cannon added the comment:
This report should go to the meta tracker, not here.
And the issue is known: see
http://psf.upfronthosting.co.za/roundup/meta/issue149.
--
nosy: +brett.cannon
resolution: -> invalid
status: open -> closed
__
T
Brett Cannon added the comment:
Fixed in r59059.
--
nosy: +brett.cannon
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Brett Cannon:
--
nosy: +brett.cannon
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1692335>
_
___
Python-bugs-list mailing list
Brett Cannon added the comment:
Implementing warn_explicit() is going to be troublesome with the new
module_globals argument. It requires not only to go through the hassle
of looking for a loader and calling get_source(), but it will most
likely require reworking the traceback function
Brett Cannon added the comment:
There has been talk in the past of cleaning up the sys module by
splitting it up into a package, although I don't know how that would
work for a built-in module, though.
--
nosy: +brett.cannon
__
Tracker <[EMAIL P
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue12958>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
It's probably not a bad thing it's undocumented either since importing by file
path was removed in Python 3, so this is another case where imp.find_module()
differentiates from __import__.
--
___
Pyth
Brett Cannon added the comment:
I don't think this is undocumented as much as it's unexpected behavior. I
really doubt this functionality was on purpose.
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
I'm w/ Ezio on this; imp.find_module() handling modules whose names can't be
used by __import__() is fine.
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.py
Brett Cannon added the comment:
And thanks for doing this, Antoine! One less thing on my never-ending
todo list. =)
On Mon, Oct 17, 2011 at 10:35, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> Should be fixed now. Thanks for the reviews!
>
> -
Brett Cannon added the comment:
Probably need a comment in the Grammar file so people know why an
unused operator is in there.
--
___
Python tracker
<http://bugs.python.org/issue13
Brett Cannon added the comment:
On Fri, Oct 21, 2011 at 11:35, Benjamin Peterson wrote:
>
> Benjamin Peterson added the comment:
>
> Or perhaps we don't need joke backward compatibility? (That's nearly 3 years
> old.)
Then you tell the FLUFL that you want to take h
New submission from Brett Cannon :
Importlib uses the errno module explicitly for properly checking OSError for
EEXIST and IOError for EACCES. Thanks to PEP 3151, however, neither check is
needed since those exceptions correspond to FileExistsError and
PermissionError, respectively.
As long
Brett Cannon added the comment:
Florent inadvertently did this for me in rev 73169.
--
resolution: -> fixed
stage: needs patch ->
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brett Cannon added the comment:
If it is importlib._diagnostics then I'm fine with it, but I definitely don't
want it exposed in a public API.
--
___
Python tracker
<http://bugs.python.o
Brett Cannon added the comment:
This is working as intended. Importers on sys.meta_path should be able to rely
on the assumption that the names they are given are syntactically proper module
names and not just any random string. You could perform a transform from module
name to random string
Changes by Brett Hoerner :
--
nosy: -bretthoerner
___
Python tracker
<http://bugs.python.org/issue4111>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I think the clarification should be enough.
--
___
Python tracker
<http://bugs.python.org/issue13239>
___
___
Python-bugs-list m
Brett Cannon added the comment:
Just so people know, if the profile situation isn't resolved by 3.3 I'm
considering PEP 3108 done.
IOW, if anyone wants to step forward and deal with cProfile/profile, that would
be appreciated. =)
--
Brett Cannon added the comment:
Just some notes on the branch:
The FAILING file contains tests known to fail. There is a comment explaining
the failure and possible fixes. If something makes it here and stays for a
while it probably means upstream changes are needed (eg. test_pydoc needs
Brett Cannon added the comment:
Answers to Eric's questions: yes and yes, but I probably won't bother until I
do a final update to the PEP.
--
___
Python tracker
<http://bugs.python.
Brett Cannon added the comment:
I say go with the deletion for importlib. If the failure is a sign of success,
then just go with it and not worry about the failure. __pycache__ guarantees
that we are not losing out by clobbering some other Python version's pyc
Brett Cannon added the comment:
Fixed by Issue13146.
--
resolution: -> out of date
stage: test needed ->
status: open -> closed
superseder: -> Writing a pyc file is not atomic
___
Python tracker
<http://bugs.pytho
Brett Cannon added the comment:
This fails for me on OS X Snow Leopard using LLVM 3.0.
And I agree with your initial guess, Victor: I don't see how importlib could
possibly be the issue here since it's using load_dynamic() and not loading some
Python sou
New submission from Brett Cannon :
The internal closure functions (eg. wrapper functions used by decorators)
should not use generic names like inner() or wrapper(), but descriptive names
so that they make sense when read in a traceback. IOW, you shouldn't have to
look up the source co
Brett Cannon added the comment:
Seems fine to me, and if Antoine says it's doing the right thing then I'm cool
with the patch.
--
assignee: -> meador.inge
___
Python tracker
<http://bugs.pytho
Brett Cannon added the comment:
Thanks for the patch! I will try to find some time to do a proper review if
someone else doesn't beat me to it (although first glance seems to suggest it
all looks fine).
--
stage: needs patch -> patc
Brett Cannon added the comment:
Patch looks good to me.
--
assignee: -> meador.inge
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/i
Brett Cannon added the comment:
Why change importlib's API and instead add to it? You could add the requisite
path_size() method to get the value, and assume 0 means unsupported (at least
until some future version where a deprecation warning about not requiring file
size comes about).
Brett Cannon added the comment:
I'm not suggesting two stat calls (in the general case); you would call one or
the other depending on the magic number of the pyc file.
Anyway, it would probably be best to have some method that is expected to
return a specific object which embodies al
Brett Cannon added the comment:
On Mon, Jan 9, 2012 at 18:05, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> > I'm not suggesting two stat calls (in the general case); you would
> > call one or the other depending on the magic number of the pyc fi
Brett Cannon added the comment:
LGTM (although I didn't run the unit tests and focused mainly on the
importlib._bootstrap and abc changes). Only two things I would change. One is
possibly deprecating path_mtime() so people don't waste time implementing it
(we actually never need to
Brett Cannon added the comment:
Yeah, it's dead code so go ahead and rip it out.
--
assignee: -> eric.araujo
___
Python tracker
<http://bugs.python.org
Brett Cannon added the comment:
Sure, but I'm not even sure it's worth the hassle of dealing with the merge. If
you want to put in the time then that's fine, but I don't think it's worth it.
--
___
Python tracker
<http:
Brett Cannon added the comment:
sys.version_info and sys._mercurial provide all the info needed for someone
(like me for mnfy) to know if their code will work against the AST nodes used
by the running interpreter. I say drop __version__
Changes by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue12341>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
hgrepos: +34
___
Python tracker
<http://bugs.python.org/issue2377>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brett Cannon :
--
title: Replace import.c with a pure Python implementation -> Replace __import__
w/ importlib.__import__
___
Python tracker
<http://bugs.python.org/iss
Changes by Brett Cannon :
--
assignee: brett.cannon ->
___
Python tracker
<http://bugs.python.org/issue8745>
___
___
Python-bugs-list mailing list
Unsubscri
Brett Cannon added the comment:
This is out of date thanks to the rewrite of the FAQ for Mercurial.
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Brett Cannon :
--
assignee: brett.cannon ->
___
Python tracker
<http://bugs.python.org/issue8912>
___
___
Python-bugs-list mailing list
Unsubscri
101 - 200 of 5934 matches
Mail list logo