[issue31813] python -m ensurepip hangs

2019-05-06 Thread anthony shaw
anthony shaw added the comment: I believe the issue is caused by the issue referenced in the last comment. Closing issue -- nosy: +anthonypjshaw resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracke

[issue5243] Missing dependency in distutils build

2019-05-06 Thread anthony shaw
anthony shaw added the comment: This issue has been open for some time, looking at the install_lib in master, there have been no changes to call 'build_clib' so the issue documented here would still apply. -- nosy: +anthonypjshaw

[issue26303] Shared execution context between doctests in a module

2019-05-06 Thread anthony shaw
anthony shaw added the comment: this issue would be good for pycon sprints -- nosy: +Mariatta, anthonypjshaw ___ Python tracker <https://bugs.python.org/issue26

[issue26303] Shared execution context between doctests in a module

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- assignee: docs@python -> Mariatta ___ Python tracker <https://bugs.python.org/issue26303> ___ ___ Python-bugs-list mailing list Un

[issue28540] math.degrees(sys.float_info.max) should throw an OverflowError exception

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Francisco, I recommend converting the patch into a GitHub pull request to make it easier to code review. Mark, Raymond, please could you re-review this patch. -- nosy: +anthonypjshaw, rhettinger ___ Python tracker

[issue5243] Missing dependency in distutils build

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- nosy: +dstufft, ncoghlan ___ Python tracker <https://bugs.python.org/issue5243> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31603] Please add argument to override stdin/out/err in the input builtin

2019-05-06 Thread anthony shaw
anthony shaw added the comment: The discussion on python-ideas has some unresolved questions. Wren, did you get a definitive answer on this idea? -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue31

[issue34946] inspect.getcallargs is marked as deprecated in documentation, but doesn't issue a DeprecationWarning when used

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch pull_requests: +13040 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34946> ___ ___ Py

[issue34946] inspect.getcallargs is marked as deprecated in documentation, but doesn't issue a DeprecationWarning when used

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Submitted PR to add the deprecation warning, since this initial discussion, some other functions also raise DeprecationWarning's in code. -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.py

[issue28742] argparse.ArgumentDefaultsHelpFormatter sometimes provides inaccurate documentation of defaults, so they should be overrideable

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Hi Peter, this proposal would be easier to review as a GitHub Pull Request. -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue28

[issue26278] BaseTransport.close() does not trigger connection_lost()

2019-05-06 Thread anthony shaw
anthony shaw added the comment: This issue was never responded to, are you still having this issue? Which version of CPython are you using and can you please provide steps to reproduce the problem. -- nosy: +anthonypjshaw ___ Python tracker

[issue13582] IDLE and pythonw.exe stderr problem

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Revisiting this issue as it's still open. The original patch was for 3.3a0, there have been many changes to both IDLE and the Windows build since, including the recent IDLE entry point in the new Windows installer. Steve, Terry, please could you revi

[issue25597] unittest.mock does not wrap dunder methods (__getitem__ etc)

2019-05-06 Thread anthony shaw
anthony shaw added the comment: The assertions in the attached test still fail on master (3.8a3), so this still applies. Michael, are you able to look at this, the code hasn't changed since the original PEP417 implementation, which doesn't specify if this behaviour should be

[issue24939] Remove unicode_format.h from stringlib

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch pull_requests: +13050 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue24939> ___ ___ Py

[issue24939] Remove unicode_format.h from stringlib

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Eric, there have been further changes to Objects/stringlib/unicode_format.h since this original note, I've raised a PR with the intent of your note from 2015. There also hasn't been any change to the situation, unicode_format.h is onl

[issue24939] Remove unicode_format.h from stringlib

2019-05-06 Thread anthony shaw
anthony shaw added the comment: > The things that are in this file but are unrelated to unicodeobject.c are the support routines for implementing string.Formatter. I'm not sure which functions that relates to, if you could let me know I'd be happy to add th

[issue33971] os.mknod is subject to "umask"

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- assignee: docs@python -> Mariatta nosy: +Mariatta ___ Python tracker <https://bugs.python.org/issue33971> ___ ___ Python-bugs-lis

[issue33971] os.mknod is subject to "umask"

2019-05-06 Thread anthony shaw
anthony shaw added the comment: NB: This issue would be good for PyCon sprints -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue33

[issue25541] Wrong usage of sockaddr_un struct for abstract namespace unix sockets

2019-05-06 Thread anthony shaw
anthony shaw added the comment: hi, which version of Python were you using to do this? Please could you provide the full code snippet to reproduce the issue. The following example binds to the correct namespace from socket import * sock = socket(AF_UNIX, SOCK_STREAM) sock.bind(&qu

[issue32971] Docs on unittest.TestCase.assertRaises() should clarify context manager details

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- pull_requests: -9605 ___ Python tracker <https://bugs.python.org/issue32971> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32971] Docs on unittest.TestCase.assertRaises() should clarify context manager details

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue32971> ___ ___ Pyth

[issue34368] ftplib __init__ function can't handle 120 or 4xy reply when connect to the server

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- nosy: +giampaolo.rodola ___ Python tracker <https://bugs.python.org/issue34368> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24939] Remove unicode_format.h from stringlib

2019-05-06 Thread anthony shaw
anthony shaw added the comment: The code is mostly: FieldNameIterator * related functions FormatterIterator * related functions MarkupIterator * related functions There are a few other utility methods in there as well -- ___ Python tracker

[issue31968] exec(): method's default arguments from dict-inherited globals

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- pull_requests: +13053 ___ Python tracker <https://bugs.python.org/issue31968> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31968] exec(): method's default arguments from dict-inherited globals

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Added a PR for the documentation clarification. -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue31

[issue28775] Option to set startup directory in IDLE

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Hi Nofar are you still interested on working on this request? -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue28

[issue25251] Unknown MS Compiler version 1900

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Closing as 3rd party feature for setuptools -- nosy: +anthonypjshaw resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue27534] IDLE: Reduce number and time for user process imports

2019-05-06 Thread anthony shaw
anthony shaw added the comment: It would be great for this issue to be revisited, there has been some further interest from users. -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue27

[issue28367] Add more standard baud rate constants to "termios"

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- pull_requests: +13055 ___ Python tracker <https://bugs.python.org/issue28367> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28367] Add more standard baud rate constants to "termios"

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Converted the original patch as a PR GH-13142 this seems like a good idea and an easy change -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue28

[issue36821] Termios module largely untested

2019-05-06 Thread anthony shaw
New submission from anthony shaw : I noticed that the termios.c module is largely untested. There is some coverage via test_pty, test_ioctl and test_getpass, but there is nothing to cover regression and the behaviours in the module functions. Tests are required for: - termios.tcgetattr

[issue36821] Termios module largely untested

2019-05-06 Thread anthony shaw
anthony shaw added the comment: This could be a good issue for the PyCon sprints, otherwise I'm happy to implement it -- ___ Python tracker <https://bugs.python.org/is

[issue36819] Crash during encoding using UTF-16/32 and custom error handler

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Easily reproduced on master, thanks (lldb) run encode_crash.py Process 14743 launched: '/Users/anthonyshaw/repo/cpython/python.exe' (x86_64) Objects/unicodeobject.c:448: _PyUnicode_CheckConsistency: Assertion "((PyObject*)(op))->ob_type))

[issue36814] posix_spawn explicit file_actions=None throws error

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Verified on master Python 3.8.0a3+ (heads/bpo-28367:373c7aa098, May 6 2019, 17:34:39) [Clang 10.0.1 (clang-1001.0.46.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>>

[issue36814] posix_spawn explicit file_actions=None throws error

2019-05-06 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch pull_requests: +13057 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36814> ___ ___ Py

[issue36814] posix_spawn explicit file_actions=None throws error

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Raised a fix in GH-13144 -- stage: patch review -> ___ Python tracker <https://bugs.python.org/issue36814> ___ ___ Python-

[issue36814] posix_spawn explicit file_actions=None throws error

2019-05-06 Thread anthony shaw
anthony shaw added the comment: Issue is in parse_file_actions parse_file_actions(PyObject *file_actions, posix_spawn_file_actions_t *file_actionsp, PyObject *temp_buffer) { PyObject *seq; PyObject *file_action = NULL; PyObject *tag_obj

[issue36814] posix_spawn explicit file_actions=None throws error

2019-05-06 Thread anthony shaw
anthony shaw added the comment: After patch: Python 3.8.0a3+ (heads/31968-dirty:c664b342a4, May 6 2019, 18:06:21) [Clang 10.0.1 (clang-1001.0.46.4)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>>

[issue12188] PEP 7 (or guide) add C style policies and explanation

2019-05-08 Thread anthony shaw
anthony shaw added the comment: Hi, This discussion came to a stop, but it doesn't seem conclusive. PEP discussions are now in GitHub on https://github.com/python/peps/issues so I'm going to close this BPO issue. There is no additional section in PEP 7 for this level of detail

[issue24263] unittest cannot load module whose name starts with Unicode

2019-05-08 Thread anthony shaw
anthony shaw added the comment: thanks, will wait for a review from Serhiy, Rbcollins or ezio -- ___ Python tracker <https://bugs.python.org/issue24263> ___ ___

[issue36862] Add Visual Studio 2019 support to PCBuild/env.bat

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- keywords: +patch pull_requests: +13126 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36862> ___ ___ Py

[issue36862] Add Visual Studio 2019 support to PCBuild/env.bat

2019-05-08 Thread anthony shaw
New submission from anthony shaw : The PCBuild tool should support VS2019 but default to 2017 as per documentation. PR to follow. -- assignee: anthonypjshaw components: Build messages: 341963 nosy: anthonypjshaw priority: normal severity: normal status: open title: Add Visual Studio

[issue36862] Add Visual Studio 2019 support to PCBuild/env.bat

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- nosy: +steve.dower stage: patch review -> ___ Python tracker <https://bugs.python.org/issue36862> ___ ___ Python-bugs-list mai

[issue36551] Optimize list comprehensions with preallocate size and protect against overflow

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- assignee: -> anthonypjshaw nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue36551> ___ ___ Python-bugs-lis

[issue36552] Replace OverflowError with ValueError when calculating length of range objects > PY_SIZE_MAX

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- assignee: -> anthonypjshaw nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue36552> ___ ___ Python-bugs-lis

[issue36500] Add "regen-*" equivalent projects for Windows builds

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- assignee: -> anthonypjshaw nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue36500> ___ ___ Python-bugs-lis

[issue35668] Improve test coverage for idlelib

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue35668> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36551] Optimize list comprehensions with preallocate size and protect against overflow

2019-05-08 Thread anthony shaw
Change by anthony shaw : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue25541] Wrong usage of sockaddr_un struct for abstract namespace unix sockets

2019-05-09 Thread anthony shaw
anthony shaw added the comment: thanks, your code example zero-pads the socket address, and looking at the socketmodule.c code it does some padding under certain circumstances. https://github.com/python/cpython/blob/master/Modules/socketmodule.c#L1318-L1330 The Unix man page specify the same

[issue25541] Wrong usage of sockaddr_un struct for abstract namespace unix sockets

2019-05-09 Thread anthony shaw
Change by anthony shaw : -- versions: +Python 3.8 -Python 2.7, Python 3.4, Python 3.7 ___ Python tracker <https://bugs.python.org/issue25541> ___ ___ Python-bug

[issue25541] Wrong usage of sockaddr_un struct for abstract namespace unix sockets

2019-05-09 Thread anthony shaw
anthony shaw added the comment: The existing tests in place add the null-termination bytes in the test string: def testLinuxAbstractNamespace(self): address = b"\x00python-test-hello\x00\xff" with socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) as s1:

[issue36883] 在ctypes里调用C库返回c_char_p类型时的问题

2019-05-10 Thread anthony shaw
anthony shaw added the comment: Closing as duplicate of 36882 -- nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org/issue36883> ___ ___ Python-bug

[issue36883] 在ctypes里调用C库返回c_char_p类型时的问题

2019-05-10 Thread anthony shaw
Change by anthony shaw : -- stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue36883> ___ ___ Python-bugs-list

[issue36882] 在ctypes里调用C库返回c_char_p类型时的问题

2019-05-10 Thread anthony shaw
anthony shaw added the comment: "When the C library is called in ctypes to return the c_char_p type, the problem that only the string before \0 can be obtained when the string contains \\0" This function is specifically for null-terminated strings (\0), please could you be mor

[issue36880] Returning None from a callback with restype py_object decrements None's refcount too much

2019-05-10 Thread anthony shaw
anthony shaw added the comment: Thanks, I'll check this out -- assignee: -> anthonypjshaw nosy: +anthonypjshaw ___ Python tracker <https://bugs.python.org

[issue36880] Returning None from a callback with restype py_object decrements None's refcount too much

2019-05-10 Thread anthony shaw
anthony shaw added the comment: The documentation says: >> Note Make sure you keep references to CFUNCTYPE() objects as long as they are used from C code. ctypes doesn’t, and if you don’t, they may be garbage collected, crashing your program when a callback is made. Also, note that

[issue36880] Returning None from a callback with restype py_object decrements None's refcount too much

2019-05-10 Thread anthony shaw
anthony shaw added the comment: >From lldb (lldb) run ~/cpython/test_gc_ctypes.py Process 20059 launched: '/Users/anthonyshaw/CLionProjects/cpython/python.exe' (x86_64) Fatal Python error: deallocating None Current thread 0x0001005c85c0 (most recent call first):

[issue36880] Returning None from a callback with restype py_object decrements None's refcount too much

2019-05-10 Thread anthony shaw
anthony shaw added the comment: Full trace for reference: (lldb) bt all * thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT * frame #0: 0x7fff5984f2c6 libsystem_kernel.dylib`__pthread_kill + 10 frame #1: 0x7fff59904bf1 libsystem_pthread.dylib`pt

[issue36880] Returning None from a callback with restype py_object decrements None's refcount too much

2019-05-11 Thread anthony shaw
anthony shaw added the comment: In the stack it's calling none_dealloc() which should never happen. Assume this is being triggered by ctypes PyCFuncPtr_call. The stacktrace I'm getting comes after the double decref so it's not showing the root cause. Someone who knows ctypes

[issue36880] Returning None from a callback with restype py_object decrements None's refcount too much

2019-05-11 Thread anthony shaw
anthony shaw added the comment: Thanks Eryk that saved a lot of debugging. dgelessus - if you want to write a patch for CPython am happy to take you through this and get it over the line. Else: am Happy to write a test against the gc counter and a patch for this

[issue36880] Returning None from a callback with restype py_object decrements None's refcount too much

2019-05-13 Thread anthony shaw
anthony shaw added the comment: If you can write a test similar to the AnotherLeak.test_callback test case, and commit that first. It will show in the CI/CD log as failed and verify the issue (incase it comes up in PR review) Then add another commit with the patch itself and we should see

[issue33405] PYTHONCOERCECLOCALE no longer being respected

2018-05-01 Thread anthony shaw
New submission from anthony shaw : observing a behaviour on Python 3.7 b2 that doesn't match what's documented in PEP 538 PEP 538 states that the locale coercion behaviour can be disabled through the PYTHONCOERCECLOCALE environment variable. I would then expect the stdin encoding

<    1   2