Valerio added the comment:
I can pick up this bug.
--
nosy: +valerio.turturici
___
Python tracker
<http://bugs.python.org/issue8193>
___
___
Python-bugs-list m
Valerio added the comment:
I confirm that the bug still exists on trunk.
--
___
Python tracker
<http://bugs.python.org/issue8193>
___
___
Python-bugs-list mailin
Valerio added the comment:
This is my first patch, i apologize if i make some mistakes.
--
Added file: http://bugs.python.org/file16691/8193.patch
___
Python tracker
<http://bugs.python.org/issue8
Valerio added the comment:
Now i make patches for other versions of Python.
How i try if the patched test still work with the older zlib?
--
___
Python tracker
<http://bugs.python.org/issue8
Valerio added the comment:
Seems that from Python 2.6 to 3.2 the test work fine. With -1 still raises the
exception. By the way, the original problem of Arkadiusz was with Python 2.5.
--
___
Python tracker
<http://bugs.python.org/issue8
Valerio added the comment:
The original test, with 0, pass in all versions of Python, from 2.6 to 3.2.
--
___
Python tracker
<http://bugs.python.org/issue8
Valerio added the comment:
I try again and ValueError not raised. The test pass without problem, both
Python 2.6 and next.
--
___
Python tracker
<http://bugs.python.org/issue8
Valerio added the comment:
P.S: the value it's default, 0.
--
___
Python tracker
<http://bugs.python.org/issue8193>
___
___
Python-bugs-list mailing list
Valerio added the comment:
This was clear. Now i make a new patch and then upload it.
--
___
Python tracker
<http://bugs.python.org/issue8193>
___
___
Python-bug
Changes by Valerio :
Removed file: http://bugs.python.org/file16691/8193.patch
___
Python tracker
<http://bugs.python.org/issue8193>
___
___
Python-bugs-list mailin
Valerio added the comment:
Here's the new patch. It's ok?
--
Added file: http://bugs.python.org/file16707/8193.patch
___
Python tracker
<http://bugs.python.
Valerio added the comment:
@pitrou: because the op have the problem with 1.2.4 version of zlib. By the way
i had just always test against -1 in my first patch. Make i a new patch with a
simple correction with -1 in place of 0?
@david: i know, but i'm learning now the TDD, so excuse me
Changes by Valerio :
Removed file: http://bugs.python.org/file16707/8193.patch
___
Python tracker
<http://bugs.python.org/issue8193>
___
___
Python-bugs-list mailin
Valerio added the comment:
While i wait for what i have to do, i corrected the patch. But there is a
problem: the version of zlib '1.2.3.3' raise an error on "distutils.version"
module. The problem is caused by the regex expression in the
"distutils.version" mo
Changes by Valerio :
Removed file: http://bugs.python.org/file16711/8193.patch
___
Python tracker
<http://bugs.python.org/issue8193>
___
___
Python-bugs-list mailin
Valerio added the comment:
Ok, so here the patch.
--
Added file: http://bugs.python.org/file16718/8193.patch
___
Python tracker
<http://bugs.python.org/issue8
Valerio Turturici added the comment:
Thanks to you! This was my first patch, i'm very happy to contribute :)
--
___
Python tracker
<http://bugs.python.org/i
New submission from Valerio G :
I encountered one condition where calling get_type_hints causes infinite
recursion when dealing with forward declaration and cyclic types.
Here's an example:
from typing import Union, List, get_type_hints
ValueList = List['Value']
Value = Union
Change by Valerio G :
--
type: -> crash
___
Python tracker
<https://bugs.python.org/issue37806>
___
___
Python-bugs-list mailing list
Unsubscrib
19 matches
Mail list logo
