Change by Tal Einat :
--
pull_requests: +14625
pull_request: https://github.com/python/cpython/pull/14834
___
Python tracker
<https://bugs.python.org/issue34
Tal Einat added the comment:
New changeset 1ebee37dde5c2aabc8e2d2c7bbe2a69b293133bb by Tal Einat in branch
'master':
bpo-33610: validate non-negative integer inputs in IDLE's config (GH-14822)
https://github.com/python/cpython/commit/1ebee37dde5c2aabc8e2d2c7b
Tal Einat added the comment:
New changeset 7123ea009b0b004062d91f69859bddf422c34ab4 by Tal Einat in branch
'master':
bpo-17535: IDLE editor line numbers (GH-14030)
https://github.com/python/cpython/commit/7123ea009b0b004062d91f69859bdd
Change by Tal Einat :
--
pull_requests: +14692
pull_request: https://github.com/python/cpython/pull/14917
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
New changeset e9ec1663d8fa0b3829add14e784107482af8dacb by Tal Einat in branch
'3.7':
[3.7] bpo-17535: IDLE editor line numbers (GH-14030)
https://github.com/python/cpython/commit/e9ec1663d8fa0b3829add14e784107
Tal Einat added the comment:
PR Merged! This will be in 3.8.0 and 3.7.5. Thanks to everyone who worked on
this and took part in the discussion!
Special thanks to Saimadhav for preparing a patch and iterating on it several
times; I picked up the work from where he left off, and it was a
Tal Einat added the comment:
Since it's a text widget, it would be simple and rather intuitive to make it
scrollable. We could then make its size set according to the size of the
config dialog window, rather than the other way a
Tal Einat added the comment:
Thanks for trying this and giving such useful feedback, Kyle!
Interestingly, Terry just opened an issue about exactly what you mention
regarding the font configuration window; see issue #37628.
--
___
Python tracker
Tal Einat added the comment:
Correction: Terry commented on that issue (#37628) earlier today; Raymond
Hettinger originally reported it a about a week ago.
--
___
Python tracker
<https://bugs.python.org/issue17
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14726
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14958
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
See proposed fix in PR GH-14958.
--
___
Python tracker
<https://bugs.python.org/issue37628>
___
___
Python-bugs-list mailin
Change by Tal Einat :
--
pull_requests: +14727
pull_request: https://github.com/python/cpython/pull/14959
___
Python tracker
<https://bugs.python.org/issue17
Tal Einat added the comment:
> The current right margin is 1 pixel. Let's try making it 2.
See PR GH-14959. I added 2 pixels of horizontal padding to the line numbers
text widget, and it certainly does look much nicer. Thanks for the suggestio
Tal Einat added the comment:
Terry, thanks for reviewing, helping get this fully ready, and merging.
Kyle, thanks for the kind feedback, it's truly heart-warming!
--
resolution: -> fixed
stage: patch review -> resolved
status: ope
Tal Einat added the comment:
Unfortunately, my Mac is out of order, so I am unable to diagnose and fix this.
I hope to be able to do so again in a few weeks.
--
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
Karl, many thanks for bringing this up, making a PR and iterating on it with me!
--
nosy: +taleinat
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9
___
Pytho
Tal Einat added the comment:
I can't reproduce this on a Mac now with the recent 3.8.0b3 installer: After
removing the skipIf() decorators, the tests all pass as expected.
Ned, can you check with this installer? If it still fails for you, can you give
some details about your Mac, e.g
Tal Einat added the comment:
Hi Tal, could you please make your report clearer by giving more context? Right
now it is very hard to understand.
The following would be helpful:
* What are you trying to do that is failing? (perhaps extract a Zip archive?)
* Which libraries/classes/functions
Change by Tal Einat :
--
nosy: +Michael.Felt
___
Python tracker
<https://bugs.python.org/issue37733>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Perhaps we should use a separator to differentiate between things that run in
the shell and those that don't, e.g. as following:
Run Module
Run... Customized
Python Shell
-
Check Module
--
___
P
Tal Einat added the comment:
Ah, my bad, I mixed up "Check Module" with the proposed external checkers
feature.
Anyways, I'm +1 on this reordering, but have no opinion on the specifics.
--
___
Python tracker
<https://bugs.pyt
Change by Tal Einat :
--
pull_requests: +14845
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15103
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
I was even able to reproduce this on Windows, though not on my Mac. A sneaky
bug.
See PR GH-15103 with a fix.
--
___
Python tracker
<https://bugs.python.org/issue37
Tal Einat added the comment:
New changeset a2ea9448c677706d6318eaa71101f08df7604eb9 by Tal Einat in branch
'3.7':
[3.7] bpo-34621: backwards-compatible pickle UUID with is_safe=unknown
(GH-14834)
https://github.com/python/cpython/commit/a2ea9448c677706d6318eaa71101f0
Tal Einat added the comment:
Note that the original fix, in PR GH-9133, contained a bug: UUID objects with
`is_safe` set to `SafeUUID.unknown` would cause an exception if unpickled with
Python <3.7.
This was reported by Thomas Wiebe in a comment to a commit in that PR:
https://github.
Tal Einat added the comment:
On Windows 10, this reproduces consistently with 3.6 and 3.7.0, but not with
3.7.4, 3.8.0b3 and current master. So this definitely seems to be fixed.
--
nosy: +taleinat
resolution: -> fixed
stage: -> resolved
status: open -&g
Tal Einat added the comment:
I am able to reproduce this with Python 3.6.3 and 3.7.0, but not with 3.7.4,
3.8.0b3 or current master (to be 3.9).
This has been fixed since 3.7.3; see issue #34572.
--
nosy: +taleinat
resolution: not a bug -> fixed
stage: -> resolved
status: p
Tal Einat added the comment:
Tkinter calls Tcl_DeleteInterp when a Tk object is garbage collected, and it
registers a cleanup callback for each registered command, which according to
the Tcl docs should be called upon Tcl_DeleteInterp[1]. So this must either be
a bug in Tcl or something in
Tal Einat added the comment:
I'm closing this: It has had no followup in over 3 months, and seems to be a
simple misuse of the C API rather than a bug.
--
nosy: +taleinat
stage: -> resolved
status: pending -> closed
___
Python trac
Tal Einat added the comment:
I too find this surprising, especially given how thoroughly UUID validates
inputs of types other than "hex".
The documentation simply states that for hex input, hypens, curly braces and a
URN prefix are optional. In practice, though, it is much mo
Tal Einat added the comment:
The global completion list (i.e. when not completing a file name or object
attribute) is already full of all the built-ins, imported modules and
variables. So IMO we'd need a good reason to add yet more options into the
completions list.
Personally, I
Tal Einat added the comment:
To be clear, I'm currently -1 on this suggestion.
--
___
Python tracker
<https://bugs.python.org/issue37765>
___
___
Pytho
Tal Einat added the comment:
Regarding help(), there's actually a comment in IDLE's code by KBK that it
should be opened in a reader (this was before TextViewer was added). IMO
that's a much better approach for long help() outputs, and is simpl
New submission from Tal Einat :
Currently, IDLE just writes the entire help message into the shell.
If auto-squeezing is enabled, then long help messages are automatically
squeezed, following which the help text can be viewed in a text viewer or
expanded inline. This is still not great UX
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14878
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15140
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
See PR GH-15140.
--
___
Python tracker
<https://bugs.python.org/issue37768>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Raymond, I'm interested in your opinion on this.
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/is
Tal Einat added the comment:
I had no idea that this was desired... I had this working in a old version of
autocomplete back before 2010! I'm not sure whether I'll be able to find it
though.
I can't understand why Louie's PR was closed, it seemed to be going in the
ri
Tal Einat added the comment:
IDLE in general doesn't recognize and support control characters commonly used
in terminals. This is often a problem with running things that show a progress
bars, which usually print "\r" to return the cursor to the beginning of the
line and the
Tal Einat added the comment:
So, Jupyter notebook has special support for carriage-return ('\r') and
backspace ('\b') characters[1].
Do we want to consider adding similar support in IDLE?
[1]
https://github.com/jupyter/notebook/blob/e498de6775b3de57f5ff827e562c179b1789
Change by Tal Einat :
--
pull_requests: +14901
pull_request: https://github.com/python/cpython/pull/15169
___
Python tracker
<https://bugs.python.org/issue21
Tal Einat added the comment:
Raymond, your with may just come true!
I've just created PR GH-15169 with a new implementation of my own, complete
with tests. I have not yet thoroughly tested it though, and would like some
feedback
Tal Einat added the comment:
Many thanks for the review, Kyle!
--
___
Python tracker
<https://bugs.python.org/issue21261>
___
___
Python-bugs-list mailin
Tal Einat added the comment:
I'm happy to look into implementing this. Also perhaps auto-saved backups for
edited files.
Where would you suggest the files be kept? The user's .idlerc directory?
--
nosy: +taleinat
___
Python track
Tal Einat added the comment:
I propose closing this as "wontfix", since this goes strongly against how
completions currently work in IDLE (based on the namespace of the shell), and I
don't think we're considering changing that.
--
New submission from Tal Einat :
Currently, when running an IDLE shell with a sub-process, it will allow
completing attributes of objects not actually in the shell's namespace. For
example, typing "codecs." will bring up completions for the codecs module's
attributes, des
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14936
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15207
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
See fix in PR GH-15207.
--
___
Python tracker
<https://bugs.python.org/issue37821>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: +14939
pull_request: https://github.com/python/cpython/pull/15211
___
Python tracker
<https://bugs.python.org/issue23
Tal Einat added the comment:
See initial working implementation of handling \r and \b characters is the
shell, PR GH-15211.
--
nosy: +taleinat
___
Python tracker
<https://bugs.python.org/issue23
New submission from Tal Einat :
IDLE's shell doesn't currently handle \r and \b in any special way; they are
written the the Tk Text widget which displays them in strange, system-dependent
ways.
These are often used to show continuously updated progress, e.g. in text-based
pro
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14945
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15211
___
Python tracker
<https://bugs.python.org/issu
Tal Einat added the comment:
Ah, sorry for missing that, Terry. See new issue, #37827, for the proposed
change.
--
___
Python tracker
<https://bugs.python.org/issue23
Tal Einat added the comment:
See PR GH-15211 with a working implementation.
--
___
Python tracker
<https://bugs.python.org/issue37827>
___
___
Python-bugs-list m
Change by Tal Einat :
--
pull_requests: -14939
___
Python tracker
<https://bugs.python.org/issue23220>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
With PR GH-15211 (for issue #37827), which implements terminal-like handling of
the \r and \b control characters, the TensorFlow tutorial almost works as
intended in the IDLE shell; a minor change to Tensorflow is needed to make it
work as intended.
Tensorflow
Tal Einat added the comment:
See issue #37768 regarding opening of help(object) output in a separate window.
--
___
Python tracker
<https://bugs.python.org/issue35
Tal Einat added the comment:
Danish, see Martin's previous comment (msg314413):
"... the signature at [the 3.6 docs] should not show close_fds=True, because
that is not necessarily the default on Windows."
--
___
Python
Tal Einat added the comment:
Vlad, perhaps you could take a look at this?
Note that Tcl/Tk 8.6.9 has recently been released (Nov 16th, 2018), which
addresses several other issues pertaining to macOS Mojave. Can someone check
this on Mojave with Tk 8.6.9?
--
nosy: +vtudorache
Tal Einat added the comment:
Gregory, this issue was about the docs, not the doc-string (help()). Are you
sure it should be closed?
--
___
Python tracker
<https://bugs.python.org/issue31
Tal Einat added the comment:
Squeezer currently does take wrapping into account, i.e. it does take IDLE's
"soft" line wrapping into account when counting lines. Therefore the
auto-squeeze criterion of "at least X lines" does lead to auto-squeezing for
any mixture
Tal Einat added the comment:
As I mentioned when opening this issue: 'a'*200 (or 'a'*1).
--
___
Python tracker
<https://bugs.python.org/issue35208>
___
Tal Einat added the comment:
Note the lack of newline at the end; that triggers the problematic path in the
current calculation.
--
___
Python tracker
<https://bugs.python.org/issue35
Tal Einat added the comment:
> Vlad says in msg323040 "on 8.6.8 I didn't see issues" and in msg326778 "The
> issues appear with ... Tk 8.6.[:8]". Different 'issues'?
Nope, same issues: Vlad was saying that 8.6.x versions of Tcl/Tk *before* 8.6.8
Tal Einat added the comment:
We already have a warning about Tk versions on macOS, see
macosx.tkVersionWarning(). It is currently printed in new shell windows.It
would be straightforward to add warnings when using anything other than 8.5.18
or 8.6.8+. I suggest this approach.
As for
Tal Einat added the comment:
My mistake on the reproduction; try: print('a'*1+'\n'). It does not
trigger auto-squeezing, though this is an obvious case where it should be
triggered. (Manual squeezing also results in showing just
Tal Einat added the comment:
Terry, I'm not sure I follow your thinking, but it feels like over-thinking.
This is a simple bug with a simple fix.
Barring the current bug (which the attached PR fixes), the current logic counts
lines, taking soft wrapping into account. This was chos
Tal Einat added the comment:
> Part of my thinking with the simple auto-squeeze formula, besides just
> simplifying the code, it this. Raymond claimed that squeezing slows down
> printing. If measurably true, one way to avoid a slow down would be to use a
> simple heuristi
Change by Tal Einat :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
New changeset 44a79cc5b3d1fb0c03c99077aa26def85ec26c67 by Tal Einat in branch
'master':
bpo-35208: Fix IDLE Squeezer line counting (GH-10449)
https://github.com/python/cpython/commit/44a79cc5b3d1fb0c03c99077aa26de
Change by Tal Einat :
--
pull_requests: +10551
___
Python tracker
<https://bugs.python.org/issue33725>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +10548
___
Python tracker
<https://bugs.python.org/issue25234>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +10548, 10549
___
Python tracker
<https://bugs.python.org/issue25234>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +10551, 10552
___
Python tracker
<https://bugs.python.org/issue33725>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +10550
___
Python tracker
<https://bugs.python.org/issue35363>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch
'master':
bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213)
https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f626014
Tal Einat added the comment:
The conversion of Modules/_hashopenssh.c leaves just Python/sysmodule.c to be
converted from this batch.
There's an old patch here from 3.5 years ago that will likely need to be
heavily updated.
--
___
Python tr
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332588
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list m
Tal Einat added the comment:
The conversion of Modules/_hashopenssl.c leaves just Python/sysmodule.c to be
converted from this batch.
There's an old patch here from 3.5 years ago that will likely need to be
heavily updated.
--
___
Python tr
Tal Einat added the comment:
New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch
'master':
bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213)
https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f626014
Change by Tal Einat :
--
pull_requests: +10591
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Tal Einat :
--
pull_requests: +10591, 10592, 10593
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
pull_requests: +10591, 10592
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
See new PR GH-11328 with updated AC conversion of Python/sysmodule.c.
--
___
Python tracker
<https://bugs.python.org/issue20
Tal Einat added the comment:
New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch
'master':
bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213)
https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f626014
Tal Einat added the comment:
New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch
'master':
bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213)
https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f626014
Tal Einat added the comment:
New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch
'master':
bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213)
https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f626014
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332609
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list m
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332608
Removed message: https://bugs.python.org/msg332609
___
Python tracker
<https://bugs.python.org/issue20
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332594
Removed message: https://bugs.python.org/msg332608
___
Python tracker
<https://bugs.python.org/issue20
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332590
Removed message: https://bugs.python.org/msg332594
Removed message: https://bugs.python.org/msg332608
Removed message: https://bugs.python.org/msg332609
___
Python tracker
Tal Einat added the comment:
New changeset c6c7237272499b2c528acb5f62601421f329e92a by Tal Einat in branch
'master':
bpo-20182: AC convert remaining functions/methods in _hashopenssl.c (GH-9213)
https://github.com/python/cpython/commit/c6c7237272499b2c528acb5f626014
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332590
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list m
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332590
Removed message: https://bugs.python.org/msg332607
___
Python tracker
<https://bugs.python.org/issue20
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg332590
Removed message: https://bugs.python.org/msg332607
Removed message: https://bugs.python.org/msg332661
___
Python tracker
<https://bugs.python.org/issue20
Tal Einat added the comment:
Terry, I'm having trouble getting Tk to work on my Mac since the Mojave update,
so I'm not yet able to check this.
--
___
Python tracker
<https://bugs.python.o
Tal Einat added the comment:
New changeset ede0b6fae20290bf22b6ee1b9a1e1179d750f360 by Tal Einat in branch
'master':
bpo-20182: AC convert Python/sysmodule.c (GH-11328)
https://github.com/python/cpython/commit/ede0b6fae20290bf22b6ee1b9a1e11
Tal Einat added the comment:
Note that the problematic part of the Modules/_hashopenssl.c AC conversion was
reverted, as part of GH-11379.
--
___
Python tracker
<https://bugs.python.org/issue20
Tal Einat added the comment:
AFAICT, this issue can finally be closed!
--
___
Python tracker
<https://bugs.python.org/issue20182>
___
___
Python-bugs-list mailin
Tal Einat added the comment:
New changeset ede0b6fae20290bf22b6ee1b9a1e1179d750f360 by Tal Einat in branch
'master':
bpo-20182: AC convert Python/sysmodule.c (GH-11328)
https://github.com/python/cpython/commit/ede0b6fae20290bf22b6ee1b9a1e11
601 - 700 of 1452 matches
Mail list logo
