[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-09 Thread Tal Einat
Change by Tal Einat : -- versions: -Python 3.6 ___ Python tracker <https://bugs.python.org/issue19670> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19670] SimpleCookie Generates Non-RFC6265-Compliant Cookies

2020-06-09 Thread Tal Einat
Tal Einat added the comment: It seems that the docs haven't been updated regarding this, so I don't think this should be closed. On the contrary, A PR adding a clarification to the docs would be most welcome. -- ___ Python track

[issue40594] urljoin since 3.5 incorrectly filters out double slashes

2020-06-09 Thread Tal Einat
Tal Einat added the comment: According to section 3.3 of RFC 3986[1], and also RFC 2396[2] which preceded it, a path is made up of zero or more consecutive "/" + section pieces, and a section may be empty. In other words, paths may include consecutive slashes. Several StackOverfl

[issue40594] urljoin since 3.5 incorrectly filters out double slashes

2020-06-09 Thread Tal Einat
Tal Einat added the comment: Putting aside backwards compatibility, I would argue the opposite: Since consecutive slashes are valid, I suggest we would need to see that collapsing them into a single slash is the status quo, otherwise we should avoid such collapsing. Here's some evi

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: I agree that this should be improved. Terry, on the technical side, IDLE already has good tools for parsing the current code line/block and figuring out whether the cursor is in a string, a comment or parentheses. This should be possible to solve in a robust way

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: > OMG, request too large. I can't upload mp4 You can try to reduce the video's resolution and/or framerate in order to reduce its size. Usually screen captures are taken at high resolution and framerates by default, making the resulting video fil

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: Confirmed on latest master on macOS 10.15.5 with Tcl/Tk 8.6.10. -- ___ Python tracker <https://bugs.python.org/issue40511> ___ ___

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +20092 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20910 ___ Python tracker <https://bugs.python.org/issu

[issue40511] IDLE: properly handle '(' and ')' within calls

2020-06-16 Thread Tal Einat
Tal Einat added the comment: See PR GH-20910 with a fix. -- ___ Python tracker <https://bugs.python.org/issue40511> ___ ___ Python-bugs-list mailing list Unsub

[issue37706] IDLE: fix sidebar click-drag bug and macOS test failures

2020-06-28 Thread Tal Einat
Tal Einat added the comment: I had been running the GUI tests, apparently until the change Ned mentioned whereby they are only run on framework builds of Python. With Ned's help, I've finally managed to create a framework build on macOS where the GUI tests run properly. Indee

[issue37706] IDLE: fix sidebar click-drag bug and macOS test failures

2020-06-28 Thread Tal Einat
Tal Einat added the comment: While we're on the topic, it seems wise to have our macOS buildbot workers create proper framework builds and run the GUI tests, if possible. We should also try to get a macOS 10.15 ("Catalina") machine into our buildbot fleet. Perhaps there&#

[issue37765] IDLE: Include longer keywords in __main__ autocomplete list

2020-07-07 Thread Tal Einat
Tal Einat added the comment: Also, note that the keywords would only be included in the suggested completions when not in a string and when not completing an attribute. So, for example, such a change could not possibly affect the completion of dunder method names

[issue37765] IDLE: Include longer keywords in __main__ autocomplete list

2020-07-07 Thread Tal Einat
Tal Einat added the comment: Auto-completion is not just about saving keystrokes. For example, I assume that many Python beginners just read through the completion list to see what the options are. This inconsistency would be hard to grok. I think that including only some of the keywords in

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-17 Thread Tal Einat
Tal Einat added the comment: I just ran into this too on Ubuntu 20.04. I don't recommend changing /etc/ssl/openssl.cnf. Instead, make a local copy, for example at $HOME/cpython-dev-openssl.cnf, with the changes suggested by Vladyslav Bondar. Then run the tests with: OPENSSL_CONF=

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-17 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue41561> ___ ___ Python-bugs-list mailing list Unsub

[issue38815] test_ssl: test_min_max_version() fails on FreeBSD and Fedora

2020-09-17 Thread Tal Einat
Tal Einat added the comment: Ping? -- nosy: +taleinat status: pending -> open ___ Python tracker <https://bugs.python.org/issue38815> ___ ___ Python-bugs-lis

[issue40049] tarfile cannot extract from stdin

2020-09-18 Thread Tal Einat
Tal Einat added the comment: GNU tar (v1.30, Ubuntu 20.04) does indeed overwrite files with symlinks upon extracting, while both `ln -s` and `os.symlink` do not. Therefore I agree that the appropriate behavior would seem to be to overwrite this way, as in the attached PR. -- nosy

[issue41775] IDLE: change Shell window title

2020-09-19 Thread Tal Einat
Change by Tal Einat : -- nosy: -taleinat ___ Python tracker <https://bugs.python.org/issue41775> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40049] tarfile cannot extract from stdin

2020-09-19 Thread Tal Einat
Tal Einat added the comment: This is actually a duplicate of issue12800, which itself describe precisely the same issue as in issue10761, which was fixed but then the fix was lost in a bad merge. I'm closing this, as discussion should happen on the original issues. -- resol

[issue12800] 'tarfile.StreamError: seeking backwards is not allowed' when extract symlink

2020-09-19 Thread Tal Einat
Tal Einat added the comment: See also another duplicate of this issue, issue40049. -- nosy: +taleinat versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue12

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-19 Thread Tal Einat
Tal Einat added the comment: Likewise here on Ubuntu 20.04: (True, True, True, True) -1 -2 -- ___ Python tracker <https://bugs.python.org/issue41561> ___ ___

[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-09-19 Thread Tal Einat
Tal Einat added the comment: This is certainly a bug fix, but since it may break backwards-compatibility in delicate ways, I'm not going to backport it to earlier versions. Expect this to land in 3.10. -- ___ Python tracker &

[issue37827] IDLE: Have the shell mimic terminal handling of \r and \b control characters in outputs

2020-09-19 Thread Tal Einat
Tal Einat added the comment: As the creator of this issue, I'm reverting the name back to the original, since I did not propose to add a new "mode" to the IDLE shell. Such a proposal could be a separate issue. I'm unfortunately going to mark close this as "rejected&

[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-09-19 Thread Tal Einat
Tal Einat added the comment: New changeset 0c71a66b53f6ea262aa5a60784c8c625ae0bb98c by idomic in branch 'master': bpo-33689: Blank lines in .pth file cause a duplicate sys.path entry (GH-20679) https://github.com/python/cpython/commit/0c71a66b53f6ea262aa5a60784c8c6

[issue33689] Blank lines in .pth file cause a duplicate sys.path entry

2020-09-19 Thread Tal Einat
Tal Einat added the comment: Thanks for bringing this up again Malcolm, for the original Patch Ammar, and for the work on the PR Ido! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -P

[issue37849] IDLE: Completion window misplaced when shown above current line

2020-09-19 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior ___ Python tracker <https://bugs.python

[issue37827] IDLE: Have the shell mimic terminal handling of \r and \b control characters in outputs

2020-09-19 Thread Tal Einat
Tal Einat added the comment: I will highlight the fact that IDLE's shell currently allows no way of showing a progress indicator, beyond extremely simple bar that only fill up from left to right, without any indication of the rightmost limit, a percentage indicator, or a rotating pro

[issue28657] cmd.Cmd.get_help() implementation can't see do_*() methods added dynamically by setattr()

2020-09-19 Thread Tal Einat
Tal Einat added the comment: I agree with Raymond's reasoning on this. Following the discussion, I'm closing this as wontfix. Thanks to everyone involved for the detailed, clear and focused discussion. -- nosy: +taleinat resolution: -> wont fix stage: patch revie

[issue12178] csv writer doesn't escape escapechar

2020-09-19 Thread Tal Einat
Tal Einat added the comment: New changeset 5c0eed7375fdd791cc5e19ceabfab4170ad44062 by Berker Peksag in branch 'master': bpo-12178: Fix escaping of escapechar in csv.writer() (GH-13710) https://github.com/python/cpython/commit/5c0eed7375fdd791cc5e19ceabfab4

[issue12178] csv writer doesn't escape escapechar

2020-09-19 Thread Tal Einat
Tal Einat added the comment: After a great deal of delay, a fix for this has finally been merged, and will be available in Python 3.10. Thanks to everyone involved! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -P

[issue21261] Teach IDLE to Autocomplete dictionary keys

2020-09-20 Thread Tal Einat
Tal Einat added the comment: People still get confused between bytes and strings, even with Python 3, especially novice programmers who are a major target audience of IDLE. I simply thought it would be confusing if string dict keys did appear in the completion list, but bytes keys did not

[issue21261] Teach IDLE to Autocomplete dictionary keys

2020-09-20 Thread Tal Einat
Tal Einat added the comment: Also, please note that the PR allows using either type of quote when typing completions. -- ___ Python tracker <https://bugs.python.org/issue21

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-20 Thread Tal Einat
Tal Einat added the comment: No, adding that after the first line of test_min_max_version_mismatch() still results in the same error: ssl.SSLError: [SSL: UNSUPPORTED_PROTOCOL] unsupported protocol (_ssl.c:1122) -- ___ Python tracker <ht

[issue1207613] Idle Editor: Bottom Scroll Bar

2020-09-20 Thread Tal Einat
Tal Einat added the comment: We've run into a significant technical hurdle in trying to implement a horizontal scrollbar: The Tk text widget sets the horizontal scroll position only according to the currently visible lines! If the text was scrolled to the right, scrolling down to

[issue41561] test_ssl fails in Ubuntu 20.04: test_min_max_version_mismatch

2020-09-20 Thread Tal Einat
Tal Einat added the comment: Same. -- ___ Python tracker <https://bugs.python.org/issue41561> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29940] Add follow_wrapped=True option to help()

2020-09-25 Thread Tal Einat
Tal Einat added the comment: To clarify, to my understanding the issue here is that when using a class as a decorator, and copying the wrapped function's __doc__ to self.__doc__ in __init__, help() will pick up the wrapper class's __doc__ rather than the instance's __doc_

[issue29940] Add follow_wrapped=True option to help()

2020-09-25 Thread Tal Einat
Tal Einat added the comment: The issue was not that __doc__ was not copied, but that help() would use the class's __doc__ when called on an instance, even if that instance had its own __doc__. See the StackOverflow question for another example. You will not see this issue with the l

[issue41858] Fix incomplete line on optparse documentation

2020-09-26 Thread Tal Einat
Tal Einat added the comment: I agree with Terry that the current form is not incorrect, as well as with his suggestion to inline the commands for printing the usage info. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue41

[issue41851] tkinter: add font neg and equal methods

2020-09-26 Thread Tal Einat
Tal Einat added the comment: Why would negating the font size convert it from points to pixels?? It seems to be coming straight from Tk; is this documented anywhere? I'd greatly prefer that we use a properly named property instead, e.g. .pixel_size. -- nosy: +tal

[issue41851] tkinter: add font neg and equal methods

2020-09-26 Thread Tal Einat
Tal Einat added the comment: As for an equal() method, I think that adding equal() which is different than the existing __eq__() would be a source of confusion. I also think using it wouldn't add anything, and would be less clear, compared to font1.actual() == font2.actual().

[issue41858] Fix incomplete line on optparse documentation

2020-09-27 Thread Tal Einat
Tal Einat added the comment: Thanks for the report and the PR, Emmanuel! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41851] tkinter: add font equal methods

2020-09-28 Thread Tal Einat
Tal Einat added the comment: > > I also think using [.equal] wouldn't add anything > I disagree and will stand by this one! Please do note that the full quote was "I also think using it wouldn't add anything, and would be less clear, compared to font1.actual() =

[issue41851] tkinter: add font equal methods

2020-09-28 Thread Tal Einat
Tal Einat added the comment: P.P.S. Re-reading that piece of code for IDLE's font config dialog, that actually looks to be intentional and correct. -- ___ Python tracker <https://bugs.python.org/is

[issue40105] Updating zip comment doesn't truncate the zip file

2020-09-28 Thread Tal Einat
Tal Einat added the comment: New changeset ff9147d93b868f0e13b9fe14e2a76c2879f6787b by Jan Mazur in branch 'master': bpo-40105: ZipFile truncate in append mode with shorter comment (GH-19337) https://github.com/python/cpython/commit/ff9147d93b868f0e13b9fe14e2a76c2879f6787b -

[issue40105] Updating zip comment doesn't truncate the zip file

2020-09-28 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue40105> ___ ___ Python-bugs-list mailing list Unsub

[issue40105] Updating zip comment doesn't truncate the zip file

2020-09-28 Thread Tal Einat
Tal Einat added the comment: Thanks for the report and initial PR, Yudi! Thanks for the second PR, Jan! -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue41851] tkinter: add font equal methods

2020-09-28 Thread Tal Einat
Change by Tal Einat : -- assignee: -> docs@python components: +Documentation nosy: +docs@python ___ Python tracker <https://bugs.python.org/issue41851> ___ _

[issue41894] UnicodeDecodeError during load failure in non-UTF-8 locale

2020-10-02 Thread Tal Einat
Change by Tal Einat : -- versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue41894> ___ ___ Python-bugs-list mailin

[issue40833] Clarify docstring of Path.rename

2020-10-03 Thread Tal Einat
Tal Einat added the comment: New changeset f97e42ef4d97dee64f45ed65170a6e77c8e46fdf by Ram Rachum in branch 'master': bpo-40833: Clarify Path.rename doc-string regarding relative paths (GH-20554) https://github.com/python/cpython/commit/f97e42ef4d97dee64f45ed65170a6e

[issue41867] Include options for timespec in docstrings of isoformat

2020-10-03 Thread Tal Einat
Tal Einat added the comment: New changeset 52301312bb9de2299b0c42468fd1936d869e651c by Ram Rachum in branch 'master': bpo-41867: List options for timespec in docstrings of isoformat methods (GH-22418) https://github.com/python/cpython/commit/52301312bb9de2299b0c42468fd193

[issue40833] Clarify docstring of Path.rename

2020-10-03 Thread Tal Einat
Tal Einat added the comment: New changeset ef7b937b8fe94f4c59dfcbe7567c3ca76097a41d by Miss Skeleton (bot) in branch '3.9': [3.9] bpo-40833: Clarify Path.rename doc-string regarding relative paths (GH-20554) https://github.com/python/cpython/commit/ef7b937b8fe94f4c59dfcbe7567c3c

[issue40833] Clarify docstring of Path.rename

2020-10-03 Thread Tal Einat
Tal Einat added the comment: Thanks, Ram! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41867] Include options for timespec in docstrings of isoformat

2020-10-03 Thread Tal Einat
Tal Einat added the comment: New changeset 8ca08310a882b7db6469fe732465610b92f4665e by Miss Skeleton (bot) in branch '3.9': [3.9] bpo-41867: List options for timespec in docstrings of isoformat methods (GH-22418) https://github.com/python/cpyt

[issue41867] Include options for timespec in docstrings of isoformat

2020-10-03 Thread Tal Einat
Tal Einat added the comment: Thanks for this, Ram! -- assignee: -> docs@python components: +Documentation nosy: +docs@python resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 __

[issue21756] IDLE - ParenMatch fails to find closing paren of multi-line statements

2020-10-04 Thread Tal Einat
Tal Einat added the comment: As noted on the PR GH-20753, an incremental change to the current logic doesn't seem like a promising approach. It seems to me that this will require refactoring the code parsing logic to allow it to incrementally parse lines backwards and forwards in ord

[issue38490] statistics: add covariance, Pearson's correlation, and simple linear regression

2020-10-05 Thread Tal Einat
Tal Einat added the comment: Given the discussion here and the state of the attached PR, I intend to merge the PR in several weeks, unless someone has anything else to say. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue38

[issue34976] IDLE: Replace the search dialog with a search bar

2020-10-12 Thread Tal Einat
Tal Einat added the comment: The version in the PR is modeled after similar features in IDEs, not browsers. I mentioned browsers since they are very commonly used, and to the best of my knowledge all modern browsers use search bars. Therefore, as a UI element, search bars are now

[issue34976] IDLE: Replace the search dialog with a search bar

2020-10-12 Thread Tal Einat
Tal Einat added the comment: I should mention one *major* advantage of using a search/replace bar: Live highlighting of matches *as you type*. It really is a vastly better experience; if you haven't tried it yet, please do. -- ___ Python tr

[issue37903] IDLE Shell sidebar.

2020-10-13 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +21653 pull_request: https://github.com/python/cpython/pull/22682 ___ Python tracker <https://bugs.python.org/issue37

[issue30934] Document how to run coverage for repository idlelib files.

2020-10-14 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +21665 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/22694 ___ Python tracker <https://bugs.python.org/issu

[issue30934] Document how to run coverage for repository idlelib files.

2020-10-14 Thread Tal Einat
Tal Einat added the comment: See a cross-platform script in PR GH-22694. -- ___ Python tracker <https://bugs.python.org/issue30934> ___ ___ Python-bugs-list m

[issue24845] IDLE functional/integration testing

2020-10-14 Thread Tal Einat
Change by Tal Einat : -- nosy: +taleinat nosy_count: 4.0 -> 5.0 pull_requests: +21677 pull_request: https://github.com/python/cpython/pull/22682 ___ Python tracker <https://bugs.python.org/issu

[issue35525] Incorrect keyword name in NNTP.starttls() documentation

2020-10-16 Thread Tal Einat
Tal Einat added the comment: Indeed, this can be closed :) Thanks for the report Colin, thanks for the PR Harmandeep, and thanks for the reminder to close this Irit! -- resolution: -> fixed stage: patch review -> resolved status: open -&g

[issue40529] Auto Completions with case insensitive

2020-10-17 Thread Tal Einat
Tal Einat added the comment: Thanks for the suggestion and for the high quality PR, Madhusudhan! I'm not sure about this feature. It seems harmless enough, with the default being the existing case-sensitive completion. But it seems like a rather esoteric thing to want, so I'm not

[issue18857] urlencode of a None value uses the string 'None'

2020-10-17 Thread Tal Einat
Tal Einat added the comment: Thanks for the PRs, James! I've closed the PRs for now, to avoid having people spend time reviewing them while this issue is closed as "wontfix". That said, if further discussion changes that decision, the PRs could be reopened. --

[issue42065] Fix incorrectly formatted _codecs.charmap_decode error message

2020-10-17 Thread Tal Einat
New submission from Tal Einat : The error message for _codecs.charmap_decode uses a non-existent formatting placeholder "%lx", when a mapped value is a number outside the range of valid Unicode code points. This was reported by Max Bernstein (@tekknolagi) on GitHub P

[issue42065] Fix incorrectly formatted _codecs.charmap_decode error message

2020-10-17 Thread Tal Einat
Change by Tal Einat : -- components: +Library (Lib), Unicode nosy: +ezio.melotti, vstinner -tekknolagi type: -> behavior versions: +Python 3.10, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issu

[issue42065] Fix incorrectly formatted _codecs.charmap_decode error message

2020-10-17 Thread Tal Einat
Tal Einat added the comment: New changeset 3635388f52b42e5280229104747962117104c453 by Max Bernstein in branch 'master': bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message (GH-19940) https://github.com/python/cpython/commit/3635388f52b42e5280229104747962

[issue42065] Fix incorrectly formatted _codecs.charmap_decode error message

2020-10-17 Thread Tal Einat
Tal Einat added the comment: Thanks for the PR, Max! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40509] In argparse, allow REMAINDER(...) arguments in a mutually exclusive group

2020-10-17 Thread Tal Einat
Tal Einat added the comment: I suggest bringing this up for discussion on Python-Ideas. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue40

[issue40507] FileNotFound error raised by os.exec* doesn't contain filename

2020-10-17 Thread Tal Einat
Tal Einat added the comment: I agree that having the error message include the executable name could be useful. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue40

[issue40507] FileNotFound error raised by os.exec* doesn't contain filename

2020-10-17 Thread Tal Einat
Change by Tal Einat : -- type: -> enhancement versions: +Python 3.10 -Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issu

[issue42065] Fix incorrectly formatted _codecs.charmap_decode error message

2020-10-17 Thread Tal Einat
Tal Einat added the comment: New changeset 6a2aa4994e99ae8e43011a0290646fde4724a003 by Miss Skeleton (bot) in branch '3.9': bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message (GH-19940) https://github.com/python/cpython/commit/6a2aa4994e99ae8e43011a0290646f

[issue42065] Fix incorrectly formatted _codecs.charmap_decode error message

2020-10-17 Thread Tal Einat
Tal Einat added the comment: New changeset 400175ad91c1aa8abc6dfce108446e4210d0c157 by Miss Skeleton (bot) in branch '3.8': bpo-42065: Fix incorrectly formatted _codecs.charmap_decode error message (GH-19940) https://github.com/python/cpython/commit/400175ad91c1aa8abc6dfce108446e

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-17 Thread Tal Einat
Tal Einat added the comment: > I am not sure what is better: to fix it at high level, in main() for cProfile > and cProfile, or at low level, in methods runctx() and run() of > profile._Utils. Maybe both, to keep them decoupled and be sure of correct behavior in all cases? --

[issue40507] FileNotFound error raised by os.exec* doesn't contain filename

2020-10-18 Thread Tal Einat
Tal Einat added the comment: After further reading, especially the docs for OSError which describe the filename and filename2 attributes, I agree that setting .filename on the FileNotFoundError exception is the way to go. -- ___ Python tracker

[issue32498] urllib.parse.unquote raises incorrect errormessage when string parameter is bytes

2020-10-18 Thread Tal Einat
Tal Einat added the comment: Thanks for the reminder Irit! No, this should not be closed yet, as there is still the possibility of improving the exception in version 3.8. -- versions: +Python 3.8 ___ Python tracker <https://bugs.python.

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-18 Thread Tal Einat
Tal Einat added the comment: New changeset 3c0ac18504cfeed822439024339d5717f42bdd66 by Anthony Sottile in branch 'master': bpo-40492: Fix --outfile with relative path when the program changes it working dir (GH-19910) https://github.com/python/cpyt

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-18 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +21716 pull_request: https://github.com/python/cpython/pull/22753 ___ Python tracker <https://bugs.python.org/issue40

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-18 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +21717 pull_request: https://github.com/python/cpython/pull/22754 ___ Python tracker <https://bugs.python.org/issue40

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-18 Thread Tal Einat
Tal Einat added the comment: Many thanks for the report and the PR, Anthony! Serhiy, do you think it is worth also calling abspath in the profile._Utils as you mentioned, for cases where those may be called directly? -- ___ Python tracker <ht

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-18 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32498] urllib.parse.unquote raises incorrect errormessage when string parameter is bytes

2020-10-18 Thread Tal Einat
Tal Einat added the comment: New changeset 1a3f7c042a32fb813835243bd7f96e47c665bfdc by Irit Katriel in branch '3.8': [3.8] bpo-32498: Improve exception message on passing bytes to urllib.parse.unquote (GH-22746) https://github.com/python/cpyt

[issue32498] urllib.parse.unquote raises incorrect errormessage when string parameter is bytes

2020-10-18 Thread Tal Einat
Tal Einat added the comment: Thanks for the report and the PR, Stein! And thanks for the PR for 3.8, Irit! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-18 Thread Tal Einat
Tal Einat added the comment: New changeset 1c5a65723e623be32e246f58b8797a263f616295 by Anthony Sottile in branch '3.8': bpo-40492: Fix --outfile with relative path when the program changes it working dir (GH-19910) https://github.com/python/cpyt

[issue40492] -m cProfile -o f.pstats with a script that does chdir() writes to the changed directory and not `.`

2020-10-18 Thread Tal Einat
Tal Einat added the comment: New changeset 7c949020ef2520d7a7cbc978f0b34423e6c2a94c by Anthony Sottile in branch '3.9': bpo-40492: Fix --outfile with relative path when the program changes it working dir (GH-19910) https://github.com/python/cpyt

[issue40841] Provide mimetypes.sniff API as stdlib

2020-10-23 Thread Tal Einat
Tal Einat added the comment: > Dong-hee, I recommend that you turn this into a 3rd party package on PyPI > yourself. +1 -- ___ Python tracker <https://bugs.python.org/i

[issue34976] IDLE: Replace the search dialog with a search bar

2020-10-23 Thread Tal Einat
Tal Einat added the comment: > Why would having all 'a's on a page light up when I type 'a' be a plus? The auto-highlighting could be disabled for 1-2 character search queries, or delayed for a bit to allow typing to continue. I find auto-highlighting very useful when

[issue34976] IDLE: Replace the search dialog with a search bar

2020-10-23 Thread Tal Einat
Tal Einat added the comment: Thanks Mark, your feedback is greatly appreciated! -- ___ Python tracker <https://bugs.python.org/issue34976> ___ ___ Python-bug

[issue41972] bytes.find consistently hangs in a particular scenario

2020-10-28 Thread Tal Einat
Tal Einat added the comment: After spending quite a while setting up my dev machine for (hopefully) reliable benchmarking, I can say with a high level of certainty that the latest PR (GH-22904, commit fe9e9d9c1f1c5f98c797d19e2214d1413701f6de) runs stringbench.py significantly faster than

[issue41972] bytes.find consistently hangs in a particular scenario

2020-10-28 Thread Tal Einat
Tal Einat added the comment: I should also mention that I configured and compiled Python for each of the above-mentioned versions using the --enable-optimizations` flag. -- ___ Python tracker <https://bugs.python.org/issue41

[issue42239] IDLE: Restore or keep calltip when needed

2020-11-01 Thread Tal Einat
Tal Einat added the comment: We already have a "<>" virtual event which is triggered upon typing a closing parenthesis ')'. We could just have it always call "open_calltip()" rather than only doing so when o

[issue42239] IDLE: Restore or keep calltip when needed

2020-11-01 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +22014 pull_request: https://github.com/python/cpython/pull/23100 ___ Python tracker <https://bugs.python.org/issue42

[issue42239] IDLE: Restore or keep calltip when needed

2020-11-01 Thread Tal Einat
Tal Einat added the comment: We already have a "<>" virtual event which is triggered upon typing a closing parenthesis ')'. We could just have it always call "open_calltip()" rather than only doing so when o

[issue42239] IDLE: Restore or keep calltip when needed

2020-11-01 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg380188 ___ Python tracker <https://bugs.python.org/issue42239> ___ ___ Python-bugs-list m

[issue40452] Tkinter/IDLE: preserve clipboard on closure

2020-11-02 Thread Tal Einat
Tal Einat added the comment: Perhaps we could get a Tcl/Tk dev to help with this? -- ___ Python tracker <https://bugs.python.org/issue40452> ___ ___ Python-bug

[issue26053] regression in pdb output between 2.7 and 3.5

2020-11-05 Thread Tal Einat
Tal Einat added the comment: I'm also uneasy about the sys.argv mangling. It seem to me that it would be safer, and more explicit, to pass the desired arguments in the Restart exception instance. -- nosy: +taleinat ___ Python tracker &

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

2020-11-05 Thread Tal Einat
Tal Einat added the comment: Irit, I like the approach of your PR for an immediate fix, that we could consider backporting. In the long term, ISTM that we should refactor to store the breakpoints with only a single source of truth, and avoid the duplication between Breakpoint.bplist

[issue26053] regression in pdb output between 2.7 and 3.5

2020-11-05 Thread Tal Einat
Tal Einat added the comment: Since it's a different implementation approach, I'd prefer a separate PR. Whether we merge the existing one depends on whether we'd like to backport a fix for this to 3.9 and 3.8. -- ___ Python

[issue28850] Regression in Python 3: Subclassing PrettyPrinter.format doesn't work anymore

2020-11-23 Thread Tal Einat
Tal Einat added the comment: New changeset ff420f0e08a2443339da0df7ace95e14177bac53 by Irit Katriel in branch 'master': bpo-28850: Fix PrettyPrinter.format overrides ignored for contents of small containers (GH-22120) https://github.com/python/cpyt

<    1   2   3   4   5   6   7   8   9   10   >