[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-08-15 Thread Tal Einat
Change by Tal Einat : -- title: Squeezer - squeeze large output in IDLE -> Squeezer - squeeze large output in IDLE's shell ___ Python tracker <https://bugs.python.org/i

[issue34419] selectmodule.c does not compile on HP-UX due to bpo-31938/6dc57e2a20c

2018-08-17 Thread Tal Einat
Tal Einat added the comment: New changeset 0e6e7a1e52a53090e33ebef13f8f1fbe9bec2375 by Tal Einat (Michael Osipov) in branch 'master': bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (GH-8796) https://github.com/python/cpyt

[issue31938] Convert selectmodule.c to Argument Clinic

2018-08-17 Thread Tal Einat
Tal Einat added the comment: New changeset 0e6e7a1e52a53090e33ebef13f8f1fbe9bec2375 by Tal Einat (Michael Osipov) in branch 'master': bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (GH-8796) https://github.com/python/cpyt

[issue34419] selectmodule.c does not compile on HP-UX due to bpo-31938/6dc57e2a20c

2018-08-17 Thread Tal Einat
Tal Einat added the comment: Michael, thanks for catching this and supplying a PR! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue19050] [Windows] fflush called on pointer to potentially closed file

2018-08-17 Thread Tal Einat
Tal Einat added the comment: I agree this should probably be ignored for security-only branches. However, AFAIK 2.7 is still in bugfix status, not security-only. If there's interest, I'm happy to build with AMK's fix on 2.7 on Windows to see if it works, and if

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-22 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8331 ___ Python tracker <https://bugs.python.org/issue34454> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-23 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.8 -Python 3.5 ___ Python tracker <https://bugs.python.org/issue6700> ___ ___ Python-bugs-list mailing list Unsub

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-23 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 2.7 ___ Python tracker <https://bugs.python.org/issue6700> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-23 Thread Tal Einat
Tal Einat added the comment: New changeset 096329f0b2bf5e3f0a16363aa631d993ce078737 by Tal Einat (Paul Ganssle) in branch 'master': bpo-34454: fix .fromisoformat() methods crashing on inputs with surrogate code points (GH-8862) https://github.com/python/cpyt

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-23 Thread Tal Einat
Tal Einat added the comment: Thanks for the report and initial patch, Alexey! Thanks for the followup and final PR, Paul! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bug

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-24 Thread Tal Einat
Tal Einat added the comment: New changeset 91cb298f811961277fd4cc4a32211899d48bedcb by Tal Einat (Vladimir Matveev) in branch 'master': bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (GH-8864) https://github.com/python/cpyt

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-24 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8371 ___ Python tracker <https://bugs.python.org/issue6700> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-26 Thread Tal Einat
Tal Einat added the comment: New changeset 491740f116755e220135e596ec802ea3a0f65596 by Tal Einat in branch '2.7': [2.7] bpo-6700: Fix inspect.getsourcelines for module level frames/tracebacks (GH-8864) https://github.com/python/cpython/commit/491740f116755e220135e596ec802e

[issue6700] inspect.getsource() returns incorrect source lines at the module level

2018-08-26 Thread Tal Einat
Tal Einat added the comment: Thanks for reporting this, Gabriel! Thanks for the PR, Vladimir! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

[issue17102] tarfile extract can write files outside the destination path

2018-08-27 Thread Tal Einat
Tal Einat added the comment: I suggest marking this as a duplicate of #21109, which is more general and includes most of the relevant discussion and patches. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue17

[issue1044] tarfile insecure pathname extraction

2018-08-27 Thread Tal Einat
Tal Einat added the comment: I suggest marking this as a duplicate of #21109, which is more general and includes most of the relevant discussion and patches. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue1

[issue1044] tarfile insecure pathname extraction

2018-08-27 Thread Tal Einat
Change by Tal Einat : -- Removed message: https://bugs.python.org/msg324192 ___ Python tracker <https://bugs.python.org/issue1044> ___ ___ Python-bugs-list mailin

[issue21109] tarfile: Traversal attack vulnerability

2018-08-27 Thread Tal Einat
Tal Einat added the comment: Lars, a huge +1 from me for your suggested approach and patch. I'd like to work this into a review-ready PR. The patch is a great step forward but still a ways from being ready for a PR: It is missing tests entirely and there are still several important me

[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-08-28 Thread Tal Einat
Tal Einat added the comment: I've gone ahead and addressed all of the significant issues raised here: * Squeezer is no longer an extension * Expanding problematically large outputs prompts the user for confirmation * "copy" and "view" moved to a right-click context m

[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-08-30 Thread Tal Einat
Tal Einat added the comment: > 1. Yes. Always show. Fix delay at 80 until we decide on something better. Done. > 2. No. Max should be enough. Done. > I once printed over 500_000 short lines to see if scrolling remained > responsive. It did. I could have set min to 1_000_

[issue34548] IDLE: Make TextView use the configured theme colors

2018-08-30 Thread Tal Einat
Change by Tal Einat : -- assignee: taleinat components: IDLE nosy: taleinat, terry.reedy priority: low severity: normal status: open title: IDLE: Make TextView use the configured theme colors versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

[issue34548] IDLE: Make TextView use the configured theme colors

2018-08-30 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +8478 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34548> ___ ___ Python-

[issue30977] reduce uuid.UUID() memory footprint

2018-09-06 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +8536 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue30977> ___ ___ Python-

[issue30977] reduce uuid.UUID() memory footprint

2018-09-06 Thread Tal Einat
Tal Einat added the comment: See new PR which addresses pickle forward and backward compatibility. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue30

[issue31371] Remove deprecated tkinter.tix module in 3.7

2018-09-06 Thread Tal Einat
Tal Einat added the comment: We should decide on this. I agree with Serhiy that in accordance with PEP 4, as long as Tix still works, we should keep it. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue31

[issue30977] reduce uuid.UUID() memory footprint

2018-09-06 Thread Tal Einat
Tal Einat added the comment: New changeset 3e2b29dccc3ca9fbc418bfa312ad655782e250f2 by Tal Einat in branch 'master': bpo-30977: make uuid.UUID use __slots__ (GH-9078) https://github.com/python/cpython/commit/3e2b29dccc3ca9fbc418bfa312ad65

[issue30977] reduce uuid.UUID() memory footprint

2018-09-06 Thread Tal Einat
Tal Einat added the comment: Thanks for the suggestion and the original patch, Wouter! -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue32055] Reconsider comparison chaining for containment tests

2018-09-06 Thread Tal Einat
Tal Einat added the comment: Has this been discussed on python-dev? If so, what was the result? -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue32

[issue30977] reduce uuid.UUID() memory footprint

2018-09-07 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8560 ___ Python tracker <https://bugs.python.org/issue30977> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28307] Accelerate 'string' % (value, ...) by using formatted string literals

2018-09-07 Thread Tal Einat
Tal Einat added the comment: I'm +1 on this optimization. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue28307> ___ ___ Python-bugs-l

[issue34609] Idle Unitest

2018-09-07 Thread Tal Einat
Tal Einat added the comment: Testing similarly to Terry, this doesn't reproduce with a recent build of master branch (3.8) on Ubuntu 16.04. I'll be able to try a build of older versions with IDLE only in a few days. -- ___ Python track

[issue34621] uuid.UUID objects can't be unpickled in older Python versions (<3.7)

2018-09-10 Thread Tal Einat
New submission from Tal Einat : This affects only 3.7, where the new SafeUUID enum was introduced. This was fixed on the master branch (3.8) while implementing issue30977. Fixing this should simply require defining similar __getstate__ and __setstate__ methods as in 3.8

[issue22807] uuid.uuid1() should use uuid_generate_time_safe() if available

2018-09-10 Thread Tal Einat
Tal Einat added the comment: The fix for issue30977 did fix the unpickling in older versions. It was only applied to the master (i.e. 3.8) branch, though. I've created issue34621 to deal with this separately. -- ___ Python tracker &

[issue34621] uuid.UUID objects can't be unpickled in older Python versions (<3.7)

2018-09-10 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +8585 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34621> ___ ___ Python-

[issue30977] reduce uuid.UUID() memory footprint

2018-09-10 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8586 ___ Python tracker <https://bugs.python.org/issue30977> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30977] reduce uuid.UUID() memory footprint

2018-09-10 Thread Tal Einat
Tal Einat added the comment: New changeset 54752533b2ed1c898ffe5ec2e795c6910ee46a39 by Tal Einat in branch 'master': bpo-30977: rework code changes according to post-merge code review (GH-9106) https://github.com/python/cpython/commit/54752533b2ed1c898ffe5ec2e795c6

[issue34621] uuid.UUID objects can't be unpickled in older Python versions (<3.7)

2018-09-10 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34621] uuid.UUID objects can't be unpickled in older Python versions (<3.7)

2018-09-10 Thread Tal Einat
Tal Einat added the comment: New changeset d53f1cabe8837697df4acb70c9c6537461b5eeda by Tal Einat in branch '3.7': [3.7] bpo-34621: fix uuid.UUID (un)pickling compatbility with older Python versions (<3.7) (GH-9133) https://github.com/python/c

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

2018-09-11 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8607 ___ Python tracker <https://bugs.python.org/issue20180> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

2018-09-11 Thread Tal Einat
Tal Einat added the comment: Now just the collections module is left from this group. Raymond, what would you like done with it WRT AC conversion, if at all? -- ___ Python tracker <https://bugs.python.org/issue20

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-09-12 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8645 ___ Python tracker <https://bugs.python.org/issue20182> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20182] Derby #13: Convert 50 sites to Argument Clinic across 5 files

2018-09-12 Thread Tal Einat
Tal Einat added the comment: See new updated PR9213 for completing the _hashopenssl.c conversion. -- ___ Python tracker <https://bugs.python.org/issue20

[issue21109] tarfile: Traversal attack vulnerability

2018-09-16 Thread Tal Einat
Tal Einat added the comment: For one thing, the new diffs are still missing tests. Tests should include, at the least: 1. *Safely* testing SafeTarFile against examples of problematic tarballs. Perhaps from Jakub's collection of "sly" tarballs could be used, assuming those co

[issue21109] tarfile: Traversal attack vulnerability

2018-09-18 Thread Tal Einat
Tal Einat added the comment: I am not a lawyer, but to the best of my understanding, using such tarballs would be fine. Since Jakub's repo only provides code to generate archive files but doesn't include actual archive files, and the generation code is licensed via the MIT licen

[issue34736] Confusing base64.b64decode output

2018-09-19 Thread Tal Einat
Tal Einat added the comment: I welcome suggestions for improvement! We could either find a better error message covering all cases, or emit a more specific message when non-base64 characters have been skipped. Unfortunately, skipping non-base64 characters is a basic assumption of

[issue34736] Confusing base64.b64decode output

2018-09-19 Thread Tal Einat
Tal Einat added the comment: Perhaps something such as "number of base64 data characters cannot be 1 more than a multiple of 4"? -- ___ Python tracker <https://bugs.python.o

[issue34736] Confusing base64.b64decode output

2018-09-22 Thread Tal Einat
Change by Tal Einat : -- nosy: +ned.deily ___ Python tracker <https://bugs.python.org/issue34736> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34609] Idle Unitest

2018-09-22 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issue34609> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33083] math.factorial accepts non-integral Decimal instances

2018-09-22 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-09-22 Thread Tal Einat
Tal Einat added the comment: The PR is ready for another review. ISTM it should be good to go, after have addressing all of the significant issues brought up in the discussion here. -- ___ Python tracker <https://bugs.python.org/issue1529

[issue34369] kqueue.control() documentation and implementation mismatch

2018-09-22 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +8906 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34369> ___ ___ Python-

[issue34609] Importing the certain modules while debugging raises an exception

2018-09-22 Thread Tal Einat
Change by Tal Einat : -- title: Idle Unitest -> Importing the certain modules while debugging raises an exception ___ Python tracker <https://bugs.python.org/issu

[issue34609] Importing certain modules while debugging raises an exception

2018-09-22 Thread Tal Einat
Change by Tal Einat : -- title: Importing the certain modules while debugging raises an exception -> Importing certain modules while debugging raises an exception ___ Python tracker <https://bugs.python.org/issu

[issue34736] Confusing base64.b64decode output

2018-09-22 Thread Tal Einat
Tal Einat added the comment: > I think what I _really_ want as a user is for b64decode to reject strings > containing... Do you mean you'd like to have this behavior by default? One can already use validate=True to have invalid characters cause an exception. I too find it sur

[issue27117] turtledemo does not work with IDLE's new dark theme.

2018-09-22 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8908 ___ Python tracker <https://bugs.python.org/issue27117> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34548] IDLE: Make TextView use the configured theme colors

2018-09-23 Thread Tal Einat
Tal Einat added the comment: Thanks for the review, discussion and approval, Cheryl and Terry! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-09-25 Thread Tal Einat
Tal Einat added the comment: Working on getting this in now. Just in time, it seems. -- ___ Python tracker <https://bugs.python.org/issue1529353> ___ ___ Pytho

[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-09-25 Thread Tal Einat
Tal Einat added the comment: This seems like it would need a "What's New" entry. How does this work with IDLE re. new features being backported? -- ___ Python tracker <https://bugs.pytho

[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-09-25 Thread Tal Einat
Tal Einat added the comment: New changeset 604e7b9931f9e7881a2941816e538f5f15930db8 by Tal Einat in branch 'master': bpo-1529353: IDLE: squeeze large output in the shell (GH-7626) https://github.com/python/cpython/commit/604e7b9931f9e7881a2941816e538f

[issue34736] Confusing base64.b64decode output

2018-09-25 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +8965 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34736> ___ ___ Python-

[issue1529353] Squeezer - squeeze large output in IDLE's shell

2018-09-25 Thread Tal Einat
Tal Einat added the comment: ISTM that this issue can finally be closed! Followup on some remaining minor points brought up here, such as colors and squeezing of multiple output lines printed separately, could be done in separate issues or discussed on idle-dev

[issue21109] tarfile: Traversal attack vulnerability

2018-09-26 Thread Tal Einat
Tal Einat added the comment: shashank, you're making good progress on this! The tests should also put SafeTarFile through all of the tests for TarFile, considering that it is being described as a drop-in replacement. You should look through the existing tests for other modules whi

[issue31425] Expose AF_QIPCRTR in socket module

2018-09-26 Thread Tal Einat
Tal Einat added the comment: New changeset bb8165172ac2ef8c7092e8e82928cc7f5f310ab3 by Tal Einat (Bjorn Andersson) in branch 'master': bpo-31425: Expose AF_QIPCRTR in socket module (GH-3706) https://github.com/python/cpython/commit/bb8165172ac2ef8c7092e8e82928cc7f5f310ab3 -

[issue31425] Expose AF_QIPCRTR in socket module

2018-09-26 Thread Tal Einat
Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.7 ___ Python tracker <https://bugs.python.or

[issue31425] Expose AF_QIPCRTR in socket module

2018-09-26 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +8993 ___ Python tracker <https://bugs.python.org/issue31425> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31425] Expose AF_QIPCRTR in socket module

2018-09-26 Thread Tal Einat
Tal Einat added the comment: New changeset f55c64c632af438d0daa043acdd95a5e74f31441 by Tal Einat in branch 'master': bpo-31425: fix versionadded in docs and add attribution in NEWS (GH-9595) https://github.com/python/cpython/commit/f55c64c632af438d0daa043acdd95a

[issue34512] Document platform-specific strftime() behavior for non-ASCII format strings

2018-09-26 Thread Tal Einat
Change by Tal Einat : -- versions: +Python 2.7, Python 3.5 ___ Python tracker <https://bugs.python.org/issue34512> ___ ___ Python-bugs-list mailing list Unsub

[issue34736] Confusing base64.b64decode output

2018-09-27 Thread Tal Einat
Tal Einat added the comment: Thanks, Mark! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34369] kqueue.control() documentation and implementation mismatch

2018-09-28 Thread Tal Einat
Tal Einat added the comment: I agree Martin, I hadn't noticed that the docs don't otherwise mention the default behavior WRT timeout. I've added a description as per your suggestion to the PR. -- ___ Python tracker <https

[issue34313] IDLE crashes with Tk-related error on macOS with ActiveTcl 8.6

2018-10-01 Thread Tal Einat
Tal Einat added the comment: I couldn't reproduce this issue with any of the 3.7.1rc1 and 3.6.7rc1 installers from python.org on my macOS. This certainly seems like an issue with Tcl/Tk versions before 8.6.8. It is unfortunate that ActiveState have still not released ActiveTcl 8.6.8

[issue34313] IDLE crashes with Tk-related error on macOS with ActiveTcl 8.6

2018-10-01 Thread Tal Einat
Tal Einat added the comment: Vlad, you previously mentioned that with Tcl/Tk 8.6.8 you also didn't see this issue. Have you tried building Tcl/Tk 8.6.8 yourself? When I did so everything worked fine. -- ___ Python tracker &

[issue34864] In Idle, Mac tabs make bottom editor line with cursor location disappear

2018-10-03 Thread Tal Einat
Tal Einat added the comment: Confirmed on macOS High Sierra 10.13.6, with "Prefer tabs when opening documents" set to "Always". See attached screenshot with the macOS tabs; indeed the bottom bar is missing. -- Added file: https://bugs.python.org/fil

[issue21880] IDLE: Ability to run 3rd party code checkers

2018-10-04 Thread Tal Einat
Tal Einat added the comment: It's unfortunate that this has gone dormant for so long. Is anyone interested in picking this up? I'd be happy to provide guidance and feedback. -- nosy: +taleinat ___ Python tracker <https://bu

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2018-10-08 Thread Tal Einat
Tal Einat added the comment: Can someone clarify whether Modules/overlapped.c should be converted to use AC? -- ___ Python tracker <https://bugs.python.org/issue20

[issue21880] IDLE: Ability to run 3rd party code checkers

2018-10-09 Thread Tal Einat
Tal Einat added the comment: I'll get this up on a git branch so that we can continue hacking on it. -- ___ Python tracker <https://bugs.python.org/is

[issue21109] tarfile: Traversal attack vulnerability

2018-10-10 Thread Tal Einat
Tal Einat added the comment: > Having said that, I am refactoring the tests right now since the test file is > ~3000 lines and adding SafeTarFile tests for every TarFile test is cluttering > it. This must be done without adding much test code and with minimal changes to the exist

[issue21880] IDLE: Ability to run 3rd party code checkers

2018-10-10 Thread Tal Einat
Tal Einat added the comment: Update: I've nearly got an updated version ready and working based on the current master branch. I hope to have a PR up by tomorrow. -- ___ Python tracker <https://bugs.python.org/is

[issue21880] IDLE: Ability to run 3rd party code checkers

2018-10-11 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +9185 ___ Python tracker <https://bugs.python.org/issue21880> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21880] IDLE: Ability to run 3rd party code checkers

2018-10-11 Thread Tal Einat
Tal Einat added the comment: See PR9802. -- ___ Python tracker <https://bugs.python.org/issue21880> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27741] datetime.datetime.strptime functionality description incorrect

2018-10-12 Thread Tal Einat
Tal Einat added the comment: At least with Python 3.7.0, the equivalence is not complete: datetime.strptime() is better, since it retains both microseconds and timezone data. See examples below. >>> from datetime import datetime, timezone >>> import time >>

[issue34203] documentation: recommend Python 3 over 2 in faq

2018-10-12 Thread Tal Einat
Tal Einat added the comment: New changeset 4505f65ae7807f2420ed14d4f060e7cd5c4039d3 by Tal Einat (Gus Goulart) in branch 'master': bpo-34203: FAQ now recommends python 3.x over 2.x (GH-9796) https://github.com/python/cpython/commit/4505f65ae7807f2420ed14d4f060e7

[issue34203] documentation: recommend Python 3 over 2 in faq

2018-10-12 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +9198 ___ Python tracker <https://bugs.python.org/issue34203> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20304] Argument Clinic: char convertor should use default values of type bytes

2018-10-12 Thread Tal Einat
Tal Einat added the comment: This was fixed in PR GH-8039. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34976] IDLE: Replace the search dialog with a search bar

2018-10-13 Thread Tal Einat
New submission from Tal Einat : Search dialogs are clunky and arguably outdated. Most modern editors, IDEs and browsers use a search bar instead. I created a search bar for IDLE as an extension years ago, it can be found on PyPI as "SearchBar". I hadn't updated it in rece

[issue34976] IDLE: Replace the search dialog with a search bar

2018-10-13 Thread Tal Einat
Change by Tal Einat : -- keywords: +patch pull_requests: +9224 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue34976> ___ _

[issue34976] IDLE: Replace the search dialog with a search bar

2018-10-13 Thread Tal Einat
Tal Einat added the comment: See PR GH-9855 for a working implementation based on my old "SearchBar" extension. -- ___ Python tracker <https://bugs.python.o

[issue33656] IDLE: Turn on DPI awareness on Windows

2018-10-13 Thread Tal Einat
Tal Einat added the comment: Ping? Do we want to get this in for 3.7.1 and 3.6.7? -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue33

[issue6686] xml.sax.xmlreader.XMLReader.getProperty (xml.sax.handler.property_xml_string) returns bytes

2018-10-14 Thread Tal Einat
Tal Einat added the comment: See additional research and discussion in the comments of PR GH-9715. Simply changing this to return a string rather than bytes would break backwards compatibility. I certainly agree that this should have returned a string in the first place, especially since

[issue9453] pulldom.SAX2DOM Doesn't support processing instructions before the root element

2018-10-14 Thread Tal Einat
Tal Einat added the comment: Proposing removal of SAX2DOM doesn't seem unreasonable to me. However, considering it hasn't been removed so far, we'll need good reason to do so since that would break backwards compatibility. Jonathan, if the solution to this is simple, I sa

[issue34976] IDLE: Replace the search dialog with a search bar

2018-10-15 Thread Tal Einat
Tal Einat added the comment: Thanks for giving it a try, Cheryl, I'm glad you like it! -- ___ Python tracker <https://bugs.python.org/issue34976> ___ ___

[issue27869] test failures under Bash on Windows / WSL

2018-10-18 Thread Tal Einat
Tal Einat added the comment: As a side-effect, test_ssl hanging is causing builds configured with --enable-optimizations to hang. (Tested with both 3.6.6 and 3.7.0 on Ubuntu 18.04 in WSL on Win 10 Pro 64-bit) -- nosy: +taleinat ___ Python tracker

[issue27741] datetime.datetime.strptime functionality description incorrect

2018-10-18 Thread Tal Einat
Tal Einat added the comment: I agree with Gus, such new wording would be great. Gus, would you like to make a PR? I'd split the comparison into a second paragraph, and avoid the word "better", instead using something like "but datetime.strptime() also retains both micro

[issue31500] IDLE: Tiny font on HiDPI display

2018-10-21 Thread Tal Einat
Tal Einat added the comment: Just tested on a 13" Retina MacBook Pro (2560x1600), everything looks fine. -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/is

[issue29743] Closing transport during handshake process leaks open socket

2018-10-21 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +9367 ___ Python tracker <https://bugs.python.org/issue29743> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29843] errors raised by ctypes.Array for invalid _length_ attribute

2018-10-21 Thread Tal Einat
Tal Einat added the comment: Should this be back-ported to 3.7 and 3.6? 2.7? -- nosy: +taleinat ___ Python tracker <https://bugs.python.org/issue29843> ___ ___

[issue29843] errors raised by ctypes.Array for invalid _length_ attribute

2018-10-21 Thread Tal Einat
Change by Tal Einat : -- pull_requests: +9368 ___ Python tracker <https://bugs.python.org/issue29843> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-21 Thread Tal Einat
Tal Einat added the comment: This was backported since it was considered a bug, but you are right that it broke backwards compatibility, and perhaps shouldn't have been backported. Still, with 3.6.6 and 3.7.1 now released, that ship has sailed. We could perhaps revert this on the 2.7 b

[issue33899] Tokenize module does not mirror "end-of-input" is newline behavior

2018-10-21 Thread Tal Einat
Tal Einat added the comment: I'm sorry to have caused this mess, it was bad judgement on my part. Adding mention in What's is a good idea, Ned, I'll do that. -- ___ Python tracker <https://bugs.pyt

[issue29843] errors raised by ctypes.Array for invalid _length_ attribute

2018-10-22 Thread Tal Einat
Tal Einat added the comment: Thanks for all of your work on this Oren! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue29843] errors raised by ctypes.Array for invalid _length_ attribute

2018-10-22 Thread Tal Einat
Tal Einat added the comment: New changeset 2447773573e74819e163f8963ab107bc5db123e5 by Tal Einat in branch 'master': bpo-29843: raise AttributeError if given negative _length_ (GH-10029) https://github.com/python/cpython/commit/2447773573e74819e163f8963ab107

<    6   7   8   9   10   11   12   13   14   15   >