Tal Einat added the comment:
Indeed, the argument name in the code is "obj", and in 3 of those 4 functions
it is a normal (positional or keyword) argument, so the name is important.
--
assignee: eric.smith -> taleinat
nosy: +taleinat
_
Tal Einat added the comment:
I agree that it seems better to avoid menntioning venv in that sentence.
Specifically I suggest:
This won’t work for __main__.py files in the root directory of a .zip file
though. Hence, for consistency, minimal __main__.py without a __name__ check
are preferred
Tal Einat added the comment:
New changeset ef5376e69e72fa922d7f1b3df47b99d3576f9df1 by Zsolt Dollenstein in
branch 'main':
bpo-46290: Fix parameter names in dataclasses docs (GH-30450)
https://github.com/python/cpython/commit/ef5376e69e72fa922d7f1b3df47b99
Tal Einat added the comment:
Thanks for the report and the PR, Zsolt!
--
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Tal Einat added the comment:
Good to know Eric, will do!
--
___
Python tracker
<https://bugs.python.org/issue46290>
___
___
Python-bugs-list mailing list
Unsub
Tal Einat added the comment:
Thanks for the suggestion and the PR, Giacomo!
However, in my opinion, this is better suited to be something like a cookbook
recipe. The number of use cases for this will be low, and there would be
little advantage to having this in the stdlib rather than
Tal Einat added the comment:
New changeset b6aa38f1ca79600f2ab46ac114ff36461a19c4a3 by Erlend Egeberg
Aasland in branch 'main':
bpo-46261: Update `sqlite3.Cursor.lastrowid` docs (GH-30407)
https://github.com/python/cpython/commit/b6aa38f1ca79600f2ab46ac114ff36461a19c4a3
-
Change by Tal Einat :
--
nosy: +pmoody, taleinat
stage: -> patch review
status: pending -> open
versions: -Python 3.8
___
Python tracker
<https://bugs.python.org/i
Tal Einat added the comment:
New changeset 987fba102e909229dd2aa1a6115aa28d514c1818 by Miss Islington (bot)
in branch '3.10':
bpo-46261: Update `sqlite3.Cursor.lastrowid` docs (GH-30407)
https://github.com/python/cpython/commit/987fba102e909229dd2aa1a6115aa2
Tal Einat added the comment:
New changeset b29aa71090e4dd34900660ecca8bb62667440f41 by Miss Islington (bot)
in branch '3.9':
[3.9] bpo-46261: Update `sqlite3.Cursor.lastrowid` docs (GH-30407)
https://github.com/python/cpython/commit/b29aa71090e4dd34900660ecca8bb6
Tal Einat added the comment:
Thanks for this, Erlend!
--
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue46261>
___
___
Py
Change by Tal Einat :
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issue46261>
___
___
Python-bugs-list mailing list
Un
Tal Einat added the comment:
First, I think that it's good and useful to have full, well-maintained examples
of how to build extension modules in the docs.
Second, until distutils is removed, I think we should keep the documentation
for how to use it. Due to this, I don't think
Tal Einat added the comment:
Terry, for all intents and purposes you're the one in charge of IDLE now. I
suggest deciding whether to change all three bindings as in the current PR or
only the one for completions. Just le me know and if needed I'll mak
Tal Einat added the comment:
I'm closing this for now since nobody has followed up and to the best of my
understanding this wouldn't be an appropriate addition to the stdlib.
This can be re-opened in the future if needed, of course.
--
resolution: -> rejected
stage:
Change by Tal Einat :
--
versions: +Python 3.11, Python 3.9
___
Python tracker
<https://bugs.python.org/issue41857>
___
___
Python-bugs-list mailing list
Unsub
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg382482
___
Python tracker
<https://bugs.python.org/issue40529>
___
___
Python-bugs-list m
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg382481
___
Python tracker
<https://bugs.python.org/issue40529>
___
___
Python-bugs-list m
Tal Einat added the comment:
This should probably be brought up in the python-ideas mailing list, which is
much more active than the group on discuss.python.org.
--
___
Python tracker
<https://bugs.python.org/issue40
Tal Einat added the comment:
New changeset 9e87c0e03fa501fb90008547983ce4c1dcaaf90c by Felix Fontein in
branch 'main':
bpo-46080: fix argparse help generation exception in edge case (GH-30111)
https://github.com/python/cpython/commit/9e87c0e03fa501fb90008547983ce4c1dcaaf90c
-
Tal Einat added the comment:
New changeset 27df7566bc19699b967e0e30d7808637b90141f6 by Zane Bitter in branch
'main':
bpo-41857: mention timeout argument units in select.poll() and select.depoll()
doc-strings (GH-22406)
https://github.com/python/cpyt
Tal Einat added the comment:
Thanks for the report and the PR, Felix!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Tal Einat :
--
pull_requests: +28928
pull_request: https://github.com/python/cpython/pull/30741
___
Python tracker
<https://bugs.python.org/issue41
Change by Tal Einat :
--
pull_requests: +28929
pull_request: https://github.com/python/cpython/pull/30742
___
Python tracker
<https://bugs.python.org/issue41
Tal Einat added the comment:
New changeset f6e5972fa984c10d47694973db1c91c6486d654a by Tal Einat in branch
'3.10':
[3.10] bpo-41857: mention timeout argument units in select.poll() and
select.depoll() doc-strings (GH-22406)
https://github.com/python/cpyt
Tal Einat added the comment:
New changeset 656971e4953a70a6048170377888db5530eea0a6 by Tal Einat in branch
'3.9':
[3.9] bpo-41857: mention timeout argument units in select.poll() and
select.depoll() doc-strings (GH-22406)
https://github.com/python/cpyt
Tal Einat added the comment:
Thanks for this improvement, Zane!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Tal Einat :
--
pull_requests: +29025
pull_request: https://github.com/python/cpython/pull/28332
___
Python tracker
<https://bugs.python.org/issue45
Tal Einat added the comment:
Thanks for your work on this Nikita!
--
nosy: +taleinat
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Tal Einat:
Patch adding a 'Paste Code' item to the 'Edit' menu, as well as hotkeys.
Using 'Paste Code' instead of the normal paste will remove prompts ('>>>
' or '... ') from the code, and also remove empty lines if
New submission from Tal Einat:
The saving bug is a string/bytes issue, simply fixed by replaced line
366 in Lib\idlelib\IOBinding.py with:
chars = chars.replace(b"\n", self.eol_convention.encode('ASCII'))
--
nosy: +taleinat
__
Track
New submission from Tal Einat:
Patch run.py, adding a global 'interruptable' flag which is set only
when executing code. This avoids interrupting the main thread while it
is printing an exception, which would cause IDLE to freeze up.
Reworked patch from IDLE-Spoon.
--
compon
Tal Einat added the comment:
Your solution is better than my suggestion, but has two minor bugs:
1) eol_convention must be initialized somewhere. For instance, opening a
new editor window (Ctrl+N) and saving it fails because
self.eol_convention is not defined. I agree that is shouldn't
New submission from Tal Einat:
Add an __call__ magic method to Delegator so that it can delegate to
callables. This will raise the required exception if the delegate isn't
callable.
The built-in callable() method will now return True for any Delegator.
Before this patch it always returns
New submission from Tal Einat:
The Percolator class has been very hard to figure out, and has been a
source of confusion for users wanting to "hack" IDLE.
This patch makes Percolator a generally useful class which inherits from
Delegator. It also adds a new class, TkTextPercola
Tal Einat added the comment:
The change required for Squeezer and ShellLogger is the separation of
the Tk Text specific logic into a subclass, which makes Percolator a
generally useful class. Along with the simple patch to Delegator.py
which allows delegation to callables, this change allows one
Tal Einat added the comment:
I understand your argument, but am not convinced. I'll try to explain
how I see this and how I came to this view.
I wished to wrap a specific method (or function) instead of wrapping the
father object with a Delegator and implementing a single method. But I
n
New submission from Tal Einat:
This patch fixes the following bugs:
* Configured selection highlighting colors were ignored
* Updating highlighting in the config dialog would cause
non-Python files to be colored as if they were Python source
Additionally, adding and removing of
Tal Einat added the comment:
It seems we're looking at Delegators and Percolators from increasingly
different points of view. Let's back up a little.
I see a Delegator object as a transparent proxy to its "delegate". This
means that attribute access is automatically deleg
Tal Einat added the comment:
The first patch contained a bug - a window opened using the "New Window"
menu option would not be colorized.
This patch removes the assumption that EditorWindow.ResetColorizer will
be called by IOBinding code, by calling ResetColorizer during __init__
any
New submission from Tal Einat:
This (relatively speaking) simple patch allows the full doc-string of a
callable to be displayed in a textView window. Once a call-tip is being
displayed, hitting one of the keys which is bound to the
force-open-calltip virtual event (Control-backslash by default
Tal Einat added the comment:
:)
Minor note - shouldn't there be a question mark at the end of the message?
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.or
Tal Einat added the comment:
Update, as requested.
After the recent configDialog.py changes, very little changes to it are
required.
I've included a much updated version of tabbedPages.py in this patch.
Since posting the original patch, I've discovered and fixed a few bugs,
implem
Tal Einat added the comment:
Bah, sorry, included wrong version of tabbedPages.py in the previous patch.
(differences are very minor, just some code cleanup and one very minor bug)
Added file: http://bugs.python.org/file8653/IDLE_tabbedPages.071029.patch
Tal Einat added the comment:
I'm trying to keep this as simple as possible, because it seems we're
tending to over-complicate.
We're discussing two distinct issues:
1) Should Delegator delegate calls to callables
2) Should Percolator inherit from Delegator
Have I missed somethi
Tal Einat added the comment:
Updated patch as requested.
Most of the changes are cosmetic, except one minor bug (kw -> **kw). I
added a few comments and doc-strings as well.
Consider removing tabpage.py, which is no longer used...
Added file: http://bugs.python.org/file8671/IDLE_tabbedpa
New submission from Tal Einat:
The format_paragraph_event method was not returning "break", causing
unwanted side effects when called via a key binding.
--
components: IDLE
files: IDLE_FormatParagraph.071102.patch
messages: 57060
nosy: kbk, taleinat
severity: normal
status:
New submission from Tal Einat:
As brought up on the idle-dev mailing list, I have redesigned the key
config window. The new layout is two wide frames one above the other,
instead of two tall frames side-by-side. This allows the key-binding
entries to be completely visible in the listbox
Tal Einat added the comment:
Fixed in patch 1725576.
--
title: cannot change cursor color in IDLE -> cannot change cursor color in IDLE
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Tal Einat added the comment:
I'd just like to weigh in and say that this is a major issue for me at the
moment. Not being able to indiscriminately pickle/unpickle exceptions is making
my parallel-processing work very painful, because of problematic stdlib
exceptions.
I'm surp
Tal Einat added the comment:
The patch seems broken to me.
In cgi.parse_multipart(), the 'boundary' variable can be a string even though
it is concatenated to bytes. Its default value is a string, and a string can be
given via the pdict argument. There is no validity check
Tal Einat added the comment:
Yes, please submit the other additional tests in a separate issue.
The default value for boundary should surely be b"". A simple test should be
added where cgi.parse_multipart() uses the default boundary.
If valid_boundary() is used only for cgi.parse
Changes by Tal Einat :
--
nosy: +taleinat
___
Python tracker
<http://bugs.python.org/issue12590>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tal Einat added the comment:
Note that some discussion about this issue is taking place on the idle-dev
mailing list.
Bruce Sherwood found the line "root.bind('<>',
flist.close_all_callback)", which seems to be an unsuccessful attempt to
achieve the wanted behavio
Changes by Tal Einat <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file8641/IDLE_CallTips.071028.patch
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Tal Einat <[EMAIL PROTECTED]>:
Removed file:
http://bugs.python.org/file8960/IDLE_CallTips.071214.incremental.patch
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Tal Einat <[EMAIL PROTECTED]> added the comment:
After more testing, I discovered a bug which broke Goto Line. Attaching
a fixed patch.
Added file:
http://bugs.python.org/file10555/IDLE_standardize_dialogs.080609.patch
___
Python tracker <[EMAIL
Changes by Tal Einat <[EMAIL PROTECTED]>:
Removed file:
http://bugs.python.org/file10555/IDLE_standardize_dialogs.080609.patch
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Tal Einat <[EMAIL PROTECTED]>:
Added file:
http://bugs.python.org/file10556/IDLE_standardize_dialogs.080609.patch
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
New submission from Tal Einat <[EMAIL PROTECTED]>:
Attaching a patch for a straightforward extension config dialog, largely
based on configDialog.py.
This uses the multiple-tab-rows feature of the TabbedPageSet widget from
the tabbedPages module, as well as the included VerticalScrolle
Changes by Tal Einat <[EMAIL PROTECTED]>:
Removed file:
http://bugs.python.org/file10560/IDLE_configExtensionsDialog.080609.patch
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Tal Einat <[EMAIL PROTECTED]> added the comment:
I forgot to mention:
This patch also removes the "paragraph width" option from the "General"
tab in the normal IDLE config, since that configures a parameter of the
FormatParagraph extension, which can now be done in t
Tal Einat <[EMAIL PROTECTED]> added the comment:
What if this message was made part of the error message which is
displayed when the connection to the subprocess fails? This way only
users in situations where it is likely that the warning is relevant will
see it.
I suggest this sin
New submission from Tal Einat <[EMAIL PROTECTED]>:
Just minor code cleanup.
Only one instance of zip(count(), ...) in EditorWindow.py, where I also
changed 'file' to 'file_name' to avoid overriding the built-in 'file' class.
--
files: IDLE_Edit
Tal Einat added the comment:
Yes, I admit I haven't tested this very thoroughly. I'll give this some
more time this weekend and submit another patch.
As for 3.0, I'll have to see what you've changed, but I'll gladly work
up a patch b
Tal Einat added the comment:
Alrighty then!
Since I had also done some work on CallTips.py since the previous patch,
I've worked up a merged version, including stuff from the py3k version
and better tests.
Changes since the first patch:
* add support for callable instances (e.g. __c
Changes by Tal Einat:
Added file:
http://bugs.python.org/file8958/IDLE_CallTips.071214.incremental.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1350>
__
__
Tal Einat added the comment:
Now for CallTipWindow.py:
* split conditionals into two lines as requested
* changed the test (took me a while to understand what "controversy" you
were referring to...)
I couldn't find anything wrong with the first line. It is the
function/method
Changes by Tal Einat:
Added file:
http://bugs.python.org/file8960/IDLE_CallTips.071214.incremental.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1350>
__
__
Tal Einat added the comment:
(bah, sorry for the mess, use the patch files from the later hour)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1350>
__
___
Pyth
Changes by Tal Einat:
--
nosy: +taleinat
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1607>
__
___
Python-bugs-list mailing list
Unsubs
Changes by Tal Einat:
--
nosy: +taleinat
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1777398>
_
___
Python-bugs-list mailing list
Unsubs
Tal Einat added the comment:
I had a working version which also used inspect before I saw your 3.0
version, but they both use inspect similarly, very straightforward. I
seem to recall only one of the version used inspect to get the doc
string, but I don't remember which one...
Depending o
Tal Einat added the comment:
I say close it, but start a discussion on switching to Tcl/Tk8.5 on the
appropriate list(s).
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
New submission from Tal Einat:
Event handlers in ScriptBinding.py were not returning 'break', although
they should have been.
--
components: IDLE
files: IDLE_ScriptBinding.080208.patch
messages: 62196
nosy: kbk, taleinat
severity: minor
status: open
title: IDLE - make Scr
New submission from Tal Einat:
When IDLE is run with a subprocess, add a 'Restart Shell & Run Module'
item to the 'Run' menu in editor windows. Also add Alt-F5 as a hotkey
for this item.
This is what the 'Run Module' (F5) item used to do (when there was a
New submission from Tal Einat:
In many places in the code, tkMessageBox dialogs were being used
directly, with the master (parent) widget being set explicitly to the
EditorWindow's text widget. Only in some cases was the focus being set
to the text widget afterwards, although in most this i
Tal Einat added the comment:
(sorry to be joining in late, but I just happened upon this...)
Nashev, if you configured your IDLE's keys to fit a Russian keyboard
layout, then you could post your config-keys.cfg file (from your .idlerc
directory) on the internet for others to enjoy. (this i
Tal Einat added the comment:
Bah, the initial version contained a silly bug in
EditorWindow.goto_line_event. Please remove it, and use this version
instead.
Added file:
http://bugs.python.org/file9395/IDLE_standardize_dialogs.080209.patch
__
Tracker <[EM
Tal Einat added the comment:
Going through the code more thoroughly, found additional places where
the standardized dialogs should be used. Also fixed remaining places
where these dialogs are used but the parent widget was still being
explicitly set to be the text widget, which is now the
New submission from Tal Einat:
This patch makes the auto-completion of file names support possible
alternate separator characters (e.g. '/' in windows).
--
components: IDLE
files: IDLE_AutoComplete_path_separators.080211.patch
messages: 62263
nosy: kbk, taleinat
severity: mi
New submission from Tal Einat:
Improve the code in AutoCompleteWindow._complete_string to be more
efficient.
(this is to be followed up by a more extensive patch, which builds on
this change to support case-insensitive completion)
--
components: IDLE
files
Tal Einat added the comment:
Found two more instances in the code where a similar improvement can be
made. This (second) version of the patch is more consistent, please use
it instead of the initial version.
Added file:
http://bugs.python.org/file9403
Tal Einat added the comment:
First of all, installing Python on Windows creates a 'Edit with IDLE'
context-menu item whenever you right-click a .py file, which opens IDLE
without a subprocess. The reason for this is that there is still a
problem regarding having several instances of
Tal Einat added the comment:
Well, I admit, I haven't tested this enough. Specifically, there is a
bug in this patch (both versions); please delete it.
I accept your criticism of my latest patches, they truly are of inferior
quality. I deeply apologize for having taken up more of your
Tal Einat added the comment:
I agree that the interface should be kept as simple as possible, but
this is a meaningful and important addition, which will help clarify to
the users how to work with the subprocess. The point of this change is
avoid surprising the user, while also making the
Tal Einat added the comment:
After fixing the aforementioned bug and testing as thoroughly as I can,
here is a revised patch.
Added file:
http://bugs.python.org/file9426/IDLE_AutoComplete_complete_string_optimization.080214.patch
__
Tracker <[EMAIL PROTEC
Tal Einat added the comment:
Umm, that's me being silly and forgetting to remove some backwards
compatibility stuff.
Revised (simpler) version attached.
Added file:
http://bugs.python.org/file9439/IDLE_AutoComplete_path_separators.080216.patch
__
Tr
Tal Einat <[EMAIL PROTECTED]> added the comment:
I really, really wish we could get this in for Python2.6 - this issue is
a major drawback for beginners, for whom IDLE is mostly intended.
Perhaps not this specific patch; I am willing to work on cleaning up the
code and getting it tes
Tal Einat <[EMAIL PROTECTED]> added the comment:
Thanks for taking the time to review this patch, Guilherme. For the
record, on which OS+Python have you tested this?
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Tal Einat <[EMAIL PROTECTED]> added the comment:
uploaded a single comprehensive patch file
Added file:
http://bugs.python.org/file10140/IDLE_standardize_dialogs.080429.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Tal Einat <[EMAIL PROTECTED]> added the comment:
Will this be back-ported to 2.5.3? (please say yes...)
--
nosy: +taleinat
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Tal Einat <[EMAIL PROTECTED]> added the comment:
First of all, the multiprocessing module doesn't work fully in an
interactive shell.
>From the Python2.6 docs:
"Note Functionality within this package requires that the __main__
method be importable by the children. This is cov
Tal Einat <[EMAIL PROTECTED]> added the comment:
Attaching a new patch against a more recent revision (resolved minor
conflict).
Only 3 extremely minor changes from previous patch: fixed two more
places where the parent was being passed explicitly (no longer required)
and changed tw
Tal Einat added the comment:
Terry, many thanks for the clarifications!
> The intended behavior is to complete if at all possible.
I can see the point in that.
> What is odd to me is that you seem happy using the more numerous non-user
> IDLE imports when there is no Sh
Change by Tal Einat :
--
Removed message: https://bugs.python.org/msg349556
___
Python tracker
<https://bugs.python.org/issue37821>
___
___
Python-bugs-list m
Tal Einat added the comment:
Terry, many thanks for the clarifications!
> The intended behavior is to complete if at all possible.
I can see the point in that.
> What is odd to me is that you seem happy using the more numerous non-user
> IDLE imports when there is no Sh
New submission from Tal Einat :
When the current line is near the bottom of the shell window, the completions
list will be shown above it. However, instead of appearing directly above the
current line, it appears quite a bit higher, about one line too high. See
attached screenshot.
Seen
Change by Tal Einat :
Added file:
https://bugs.python.org/file48541/idle_completion_window_position.png
___
Python tracker
<https://bugs.python.org/issue37849>
___
___
Change by Tal Einat :
--
keywords: +patch
pull_requests: +14988
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15267
___
Python tracker
<https://bugs.python.org/issu
1 - 100 of 1452 matches
Mail list logo
