Steve Dower added the comment:
New changeset 3f398a77d37b5dfd51dabbc362d482a482fa885a by neonene in branch
'main':
bpo-45582: Fix test_embed failure during a PGO build on Windows (GH-30014)
https://github.com/python/cpython/commit/3f398a77d37b5dfd51dabbc362d482
Steve Dower added the comment:
I'm going to need a decent amount of time to learn all of these components,
because I never use this OS, Tox, nor virtualenv :) I'll try and get to it, but
don't hold your breath. Luckily, Modules/getpath.py is much easier to follow
and modi
Steve Dower added the comment:
We'd also need to update the launcher to launch the executable with its name,
which it currently doesn't do. I was looking at this recently for some other
reason.
--
___
Python tracker
<https://bu
New submission from Steve Dower :
The embeddable distro cannot import native modules.
This is because the '.' entry in the ._pth file is incorrect parsed by the new
getpath module (issue45582).
--
assignee: steve.dower
components: Interpreter Core
messages: 408300
nosy: lu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28273
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30048
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 971ece8e1738b1107dda692cc44c6d8ddce384cd by Steve Dower in branch
'main':
bpo-46048: Fix parsing of single character lines in getpath readlines()
(GH-30048)
https://github.com/python/cpython/commit/971ece8e1738b1107dda692cc44c6d
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Currently ._pth files are "enabled" for all platforms, but are only tested on
Windows.
Extend the tests in test_site to work on all platforms.
--
assignee: steve.dower
components: Interpreter Core
messages: 408304
nosy: steve.dower
priori
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28276
pull_request: https://github.com/python/cpython/pull/30051
___
Python tracker
<https://bugs.python.org/issue46
Steve Dower added the comment:
New changeset bfc59ed0a00106f5ba4a32a0c5b3dbe71d12665d by Steve Dower in branch
'main':
bpo-46049: Fixes ._pth support on non-Windows (GH-30051)
https://github.com/python/cpython/commit/bfc59ed0a00106f5ba4a32a0c5b3db
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
What's the contents of the pyvenv.cfg in these cases?
It looks like the first case is definitely wrong, because the base
executable should not be in "venv_a2" (that's sys.executable), but I
don't know where it
Steve Dower added the comment:
> $ cat venv_a3/pyvenv.cfg
> home = /home/ss/.pyenv/versions/3.11.0a3/bin
> $ venv_a3/bin/python -c "import sys,os.path; print(e :=
> sys._base_executable); print(os.path.exists(e))"
> /home/ss/.pyenv/versions/3.11.0a3/bin/python
>
Steve Dower added the comment:
I'm downgrading this from release blocker. If Vinay thinks there's a
venv-related release blocker here he's welcome to raise the priority again, but
I only see an intentional change to an internal value. Tools relying on
internal fields will ha
Steve Dower added the comment:
If you execute "python -m venv --without-pip ..." to create, then as a
workaround you can set the __PYVENV_LAUNCHER__ environment variable to the full
path to the venv's python.exe and run the normal python3.10.exe.
As Eryk mentioned, you
Steve Dower added the comment:
Also, if you see people discussing PEP 582, you might want to throw in a vote
of support. It is intended to provide the benefits of a venv without needing to
do tricks like we do for the current design, but it keeps being rejected for
"not being suffici
Steve Dower added the comment:
> Windows should have its own specific function.
Either that or mimic it properly. Having a single function that requires
different parameters based on OS is a very user-hostile design.
If someone wants to shepherd it through the process, I'd suppor
Steve Dower added the comment:
Is sys._base_executable correct without a venv? It should be the same as
sys.executable in that case.
venv calculates 'home' here: Lib/venv/__init__.py#L117
executable = sys._base_executable
dirname, exename = os.path.split(os.pa
Steve Dower added the comment:
> But the value as it's calculated now seems to give a file that doesn't exist
> - how can that be correct?
Because we never actually use the executable referenced by the 'home' path in a
pyvenv.cfg. It's only used as a start
Steve Dower added the comment:
> Because we never actually use the executable referenced by the 'home' path in
> a pyvenv.cfg.
This is actually not true on Windows or (I believe) some situations on macOS,
where we need to use a redirecting launcher to actually launch the b
Steve Dower added the comment:
> $ v311/bin/python -m venv 311-nested
> Error: [Errno 2] No such file or directory:
> '/private/tmp/bpo-46028/311-nested/bin/python'
I assume /private/tmp/bpo-46028/311-nested/bin/python3.11 exists though?
Probably that's the issue
Steve Dower added the comment:
Or possibly that error is coming from the attempt to copy it? And since
both executable and base_executable don't have the 3/3.x suffix, the
copy is failing because the "real" binary does have the suffix.
This could be corrected in getpath.py
Steve Dower added the comment:
Does the first venv's 'python' link to python3[.11]? If so, maybe
_base_executable should be based on real_executable's filename rather than
executable (that is, *after* resolving symlinks rather than before).
I don't *think* that will
Change by Steve Dower :
--
pull_requests: +28361
pull_request: https://github.com/python/cpython/pull/30143
___
Python tracker
<https://bugs.python.org/issue46
Steve Dower added the comment:
I posted a PR that shells out to the find_python script and captures its output
to use during VS builds.
Theoretically, this could save us from running it in build.bat, but I like
having the detection and messages up front rather than buried deep in the build
Steve Dower added the comment:
On Windows we automatically download a runtime if you don't have one, so this
isn't such a big deal. You *do* need an internet connection to do this, of
course, but that's the case for most of our external dependencies already.
Plus I don
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28362
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30144
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
This PR *might* be a fix, but I think it's only partial. It isn't going to work
if you've made a venv and copied "python3"->"python", for example.
It still might be best solved by writing base_executable into pyven
Steve Dower added the comment:
New changeset 6214caafbe66e34e84c1809abf0b7aab6791956b by neonene in branch
'main':
bpo-40915: Avoid compiler warnings by fixing mmapmodule conversion from
LARGE_INTEGER to Py_ssize_t (GH-30175)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset 6fc91daf730c60b08b4b32cdce28ff26505a0622 by Steve Dower in branch
'main':
bpo-46088: Automatically detect or install bootstrap Python runtime when
building from Visual Studio (GH-30143)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Are we going to have to rush security releases for this one? Or can it
wait (for me) until Monday?
--
___
Python tracker
<https://bugs.python.org/issue46
Steve Dower added the comment:
New changeset 0b582a4a1b24472a35ed7fc973728ac9d595f123 by neonene in branch
'main':
bpo-46123: Disable optimizations for _freeze_module.exe on MSVC for faster
building (GH-30181)
https://github.com/python/cpython/commit/0b582a4a1b24472a35ed7fc973728a
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
I've put up the builds for 1.1.1m (and double checked everything after
last time - it's definitely "m" :) ), so anyone can do the PR to change
Python itself. Otherwise I'll probably get time this week.
--
_
Steve Dower added the comment:
There are plenty of other ways to get a venv through a potentially unexpected
path (turns out I've been doing one for years), which is why I went with the
general warning rather than limiting it to specific behaviours that are subject
to change outside o
Steve Dower added the comment:
This normally happens because you've already installed the launcher "just for
me". You can't change that setting later.
Open Add/Remove Programs and uninstall the Python Launcher first. Then you
should be able to reinst
Steve Dower added the comment:
Yep, it's a bug and should be fixed.
I'm still not back coding yet, but I'll get to it once I am if nobody else gets
there first. This is going to affect getpath.py in the native implementation,
so it ought to be fixed there (and we need test
Steve Dower added the comment:
My VHDX mounted in a directory is affected by this, and actually broke a couple
of tools until I also mounted it as a drive. (Using a VHDX helps bypass a lot
of filesystem related perf impacts on Windows, so it's worth the occasional
broken tool.)
I su
Steve Dower added the comment:
If you have them, can you share your install logs (look in %TEMP% for files
starting with "Python"). If not, please share your install options.
By default, this works fine. You have to make some specific modifications to
the install options to do w
Steve Dower added the comment:
Good catch. We still support 8.1 for this release, so that flag will have to be
taken out (and hopefully people won't be impacted by long path names here).
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
I'm happy with PR 30362 now - any other comments before we merge?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset 9c5fa9c97c5c5336e60e4ae7a2e6e3f67acedfc7 by neonene in branch
'main':
bpo-46208: Fix normalization of relative paths in
_Py_normpath()/os.path.normpath (GH-30362)
https://github.com/python/cpython/commit/9c5fa9c97c5c5336e60e4ae7a2e6e3
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Taken from https://github.com/python/cpython/pull/30362#issuecomment-1006840632
For Windows, should there be tests for invalid UNC paths such as "//", "//..",
"//../..", "//../../..", "//server", "//serv
Steve Dower added the comment:
My replies to Eryk's comment copied above:
Yes, always more tests :)
The behaviour of normpath has always been weird and/or incorrect around invalid
UNC paths.
For example, on 3.10, normpath("//spam///eggs/..") --> "spam". Orig
Steve Dower added the comment:
Are we enabling the build option they mention on the release page? Or is
this only going to affect users who use the pragma?
We should obviously do the upgrade, but that will determine how
aggressively we ought to be messaging the issue
Steve Dower added the comment:
We should definitely upgrade, but we probably don't have to trigger a
fresh release of all branches for it, or make a big fuss about it being
a special fix. That's all I was trying to establish.
--
Steve Dower added the comment:
Only a newer WinSDK, which is not in any way a significant change to the
resulting build and so isn't part of the "spec" as it were.
But we'll remove the use of this flag once someone has the time to make a PR.
(Remember to add the
Steve Dower added the comment:
> Can you update the sources repo in the mean time?
Done
--
___
Python tracker
<https://bugs.python.org/issue45925>
___
___
Py
Steve Dower added the comment:
New changeset c9dc1f491e8edb0bc433cde73190a3015d226891 by Daniel in branch
'main':
bpo-46297: Fix interpreter crash on startup with multiple PythonPaths set in
registry (GH-30466)
https://github.com/python/cpyt
Steve Dower added the comment:
Thanks for the report and the PR!
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue46297>
___
_
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28676
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/30473
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset d81182b8ec3b1593daf241d44757a9fa68fd14cc by Steve Dower in branch
'main':
bpo-46217: Revert use of Windows constant that is newer than what we support
(GH-30473)
https://github.com/python/cpython/commit/d81182b8ec3b1593daf241d44757a9
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Without logs or the ability to reproduce it, there's not much we can do. I ran
the install and it put the variables in the right place, so it's not happening
all the time.
The install logs are usually detailed enough to see why decisions like this
Steve Dower added the comment:
Hi Tommy! Glad to have you join the discussion (I'm a huge fan of OBS Studio,
and if the license wasn't incompatible with my employer, I'd be actively
contributing :) )
Our challenge with the installer is the portability of Wix Toolset. I
Steve Dower added the comment:
Possibly related to Victor's change in issue46303?
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
PEP 514 is the way to find it on Windows (you should be able to look directly
for your supported version, rather than enumerating to search). As far as I
know, the best way to find it on macOS and Linux is to search PATH for
"python3.X".
Appreciat
Steve Dower added the comment:
> Microsoft provides stat and struct stat, but they prepend the names with an
> underscore.
They are also influenced by various compiler options to choose between
32-bit and 64-bit fields. This makes it impossible to use the standard
names as part of
Steve Dower added the comment:
One thing to be aware of is that Windows 11 has changed the rules around these
files, so here's my results with 3.10:
>>> for path in paths:
... print(os.path.abspath(path))
...
C:\CON
C:\PRN
C:\AUX
\\.\NUL
C:\COM1
C:\COM2
C:\COM3
C:\COM9
C:\
Steve Dower added the comment:
New changeset d4e64cd4b0ea431d4e371f9b0a25f6b75a069dc1 by neonene in branch
'main':
bpo-46362: Ensure ntpath.abspath() uses the Windows API correctly (GH-30571)
https://github.com/python/cpython/commit/d4e64cd4b0ea431d4e371f9b0a25f6
Steve Dower added the comment:
Thanks for the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 71c0b859ae16ee748cbb050a1f4de93c04e04f83 by neonene in branch
'main':
bpo-46362: Ensure abspath() tests pass through environment variables to
subprocess (GH-30595)
https://github.com/python/cpython/commit/71c0b859ae16ee748cbb050a1f4de9
Steve Dower added the comment:
New changeset c47c9e6589eb7a272cfe4d352eb87389eb20ec2f by bneuburg in branch
'main':
bpo-44934: Add optional feature AppendPath to Windows MSI installer (GH-27889)
https://github.com/python/cpython/commit/c47c9e6589eb7a272cfe4d352eb873
Steve Dower added the comment:
Thanks for the PR! This is a good contribution, that wasn't trivial to do. It
should be in Python 3.11 alpha 5, so please test it out and make sure it's
behaving as you expect.
--
resolution: -> fixed
stage: patch review -> resol
Steve Dower added the comment:
New changeset 7407fe4c25ba0308d49e3e88e4a107ef32251cdc by Steve Dower in branch
'main':
bpo-46028: Calculate base_executable by resolving symlinks in a venv (GH-30144)
https://github.com/python/cpython/commit/7407fe4c25ba0308d49e3e88e4a107
Steve Dower added the comment:
Merged my PR, but I want to leave this open in commit review for now - I'm not
sure it deals with all the issues here, and probably not everything from the
Discourse thread linked by Victor (though it might come close).
--
stage: patch review ->
Steve Dower added the comment:
The PR looks good. I assume you've started the CLA process, so once that clears
we'll be fine to merge.
--
versions: -Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.o
New submission from Steve Dower :
After applying this patch on Linux, test_freeze_simple_script
(test.test_tools.test_freeze.TestFreeze) fails.
diff --git a/Modules/Setup b/Modules/Setup
index d3647ecb99..c41bcac453 100644
--- a/Modules/Setup
+++ b/Modules/Setup
@@ -135,7 +135,7 @@ PYTHONPATH
Steve Dower added the comment:
I'm afraid not. The ._pth file is intended for embedding applications that have
a static set of search paths.
You may want to try adding a startup file (search for PYTHONSTARTUP) that
modifies sys.path directly. Or alternatively if you rename the ._pth fi
Steve Dower added the comment:
Need to make this happen, and it probably needs to be me (though I'm happy to
review a contribution).
We now handle ._pth files on all platforms as part of the Modules/getpath.py
changes (which I hinted to in my previous comment from 5 year
Steve Dower added the comment:
See
https://github.com/python/cpython/blob/b04dfbbe4bd7071d46c8688c2263726ea31d33cd/PC/layout/main.py#L256-L289
Basically, the .pyc files in the embeddable distro have been compiled with
optimize=2, which is the equivalent of -OO. So yes, docstrings (and
Steve Dower added the comment:
> the existing check in `do_help` didn't catch this case because
> https://docs.python.org/3/library/sys.html#sys.flags only reflects command
> line flags, rather than whether or not it was actually optimised.
Precisely. Your check is much more a
Steve Dower added the comment:
This configuration is intentional.
When cross-compiling, tools that are executed as part of the build need to be
built for the tool platform, not the target platform.
--
nosy: +steve.dower
resolution: -> not a bug
stage: patch review -> re
Steve Dower added the comment:
Windows ARM64 devices all support x86 and x64 emulation, so while it's less
than ideal performance-wise to use a non-native build for this step, it's
hardly fatal. That step doesn't rely on the underlying architecture, just the
current Python
Steve Dower added the comment:
I don't think we've changed anything here in years, so I'd be very
surprised if something new was in there.
More likely somebody PyInstaller'd some malware and the scanners picked
up a generic part of it as the signature. Reporting it
Steve Dower added the comment:
The installer doesn't support installing twice on the same machine, even to
different locations.
What you probably want to do is to install it normally, then copy all the files
onto the USB. You will need to "python -m pip install --force pip" i
Steve Dower added the comment:
New changeset 60705cff70576482fea31dcafbf8a37cbb751ea5 by Tom Sparrow in branch
'main':
bpo-46434: Handle missing docstrings in pdb help (GH-30705)
https://github.com/python/cpython/commit/60705cff70576482fea31dcafbf8a3
Steve Dower added the comment:
I think we can close it.
--
stage: -> resolved
status: pending -> closed
___
Python tracker
<https://bugs.python.org/i
Steve Dower added the comment:
Thanks for the contribution!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Exception occurred:
File "D:\a\1\s\Doc\tools\extensions\escape4chm.py", line 44, in fixup_keywords
with app.builder.open_file(outdir, outname + '.hhk', 'r') as f:
AttributeError: 'HTMLHelpBuilder' object has no attr
Change by Steve Dower :
--
keywords: +patch
pull_requests: +28953
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30768
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 57d1855682dbeb9233ef3a531f9535c6442e9992 by Steve Dower in branch
'main':
bpo-46463: Fixes escape4chm.py script used when building the CHM documentation
file (GH-30768)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Yeah, I pushed the machines up to 2022 the other day while tidying the configs.
Wouldn't have expected it to impact that issue though, it's fully within
OpenSSL, isn't it? (We also updated that recently...)
Also, as an FYI, if you use "wm
Steve Dower added the comment:
> Our challenge with the installer is the portability of Wix Toolset. I'm
> pretty sure our current version doesn't support ARM64, and they haven't
> released a newer version that does yet.
Turns out they've released some
Steve Dower added the comment:
Yeah, will just be the same files again but with "arm64" in place of
"win32"/"amd64".
I'm also going to stop uploading the old webinstall files with my change here,
though that shouldn't matter. The code we added to f
Change by Steve Dower :
--
pull_requests: +29066
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/30885
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
sys.getwindowsversion() is affected to Microsoft's minimal rebuilds of
OS components causing core DLLs to have older versions than the release,
and also to compatibility modes that may report earlier versions if API
behaviour is being emulated.
The bes
Steve Dower added the comment:
>> AFAIK, the Win32_OperatingSystem caption is always ASCII.
>
> I think I was wrong here. The "Caption" field is localized, so the wmic.exe
> OEM encoded output to a pipe isn't reliable.
Correct. And while "Windows" its
Steve Dower added the comment:
I think we need somewhere in the documentation to explain how the initial
import path is calculated, in terms useful for an end user (rather than what's
in getpath.py, which is for developers).
Right now, I'm not sure there's a good place fo
Steve Dower added the comment:
New changeset db77bcd6092f3c174ae855522411ab83854d65a8 by Kumar Aditya in
branch 'main':
bpo-45925: Update Windows installer to SQLite 3.37.2 (GH-30485)
https://github.com/python/cpython/commit/db77bcd6092f3c174ae855522411ab
Change by Steve Dower :
--
pull_requests: +29171
pull_request: https://github.com/python/cpython/pull/30991
___
Python tracker
<https://bugs.python.org/issue45
Steve Dower added the comment:
New changeset 45faf151c693b6f13f78926761caea6df7242024 by Steve Dower in branch
'main':
bpo-33125: Enables building traditional installer for Windows ARM64 (GH-30885)
https://github.com/python/cpython/commit/45faf151c693b6f13f78926761caea
New submission from Steve Dower :
We now have a traditional installer that runs on Windows ARM64 devices, but it
omits the py.exe launcher. This is because sys.winver is "3.11-arm64" and hence
the registry tag (see PEP 514) is not detected by the launcher.
Currently, the launc
Steve Dower added the comment:
The ARM64 installer will be part of the next 3.11 release, minus the py.exe
launcher (which needs a chunk of work in issue46566) and Tcl/Tk (which needs
upstream support for the platform) and hence IDLE.
I'm hesitant to make a final release without
New submission from Steve Dower :
Currently our ARM64 installs omit Tcl/Tk (and implicitly tkinter and IDLE)
because there appears to be no upstream support for building Tcl/Tk for ARM64.
Once the upstream support exists, or we have a good enough patch to apply to
our own copy of the sources
Steve Dower added the comment:
Tcl/Tk tracking issue is issue46567
--
___
Python tracker
<https://bugs.python.org/issue33125>
___
___
Python-bugs-list mailin
1 - 100 of 5794 matches
Mail list logo
