Change by Soumendra Ganguly :
--
pull_requests: +27900
pull_request: https://github.com/python/cpython/pull/29658
___
Python tracker
<https://bugs.python.org/issue41
Soumendra Ganguly added the comment:
This is actually good news. I had not tested the code on Solaris; this confirms
my suspicion that Linux is the only platform that "behaves differently". Sadly,
the current Lib/pty.py code depends on such "different behavior" to exit
Change by Soumendra Ganguly :
--
pull_requests: +22415
pull_request: https://github.com/python/cpython/pull/23533
___
Python tracker
<https://bugs.python.org/issue41
Soumendra Ganguly added the comment:
PR-23533 should fix the test_master_read() issue on Solaris. Actually, instead
of adding 'or PLATFORM == "SunOS"', I ended up removing the whole line and
replaced it with 'if platform.system() != "Linux"' beca
Change by Soumendra Ganguly :
--
pull_requests: +22418
pull_request: https://github.com/python/cpython/pull/23536
___
Python tracker
<https://bugs.python.org/issue41
Soumendra Ganguly added the comment:
Update: I closed PR 23533. PR 23536 is much better. It will help us detect
exact behavior on each platform, which is necessary for making pty.spawn()
successfully exit its copy loop.
--
___
Python tracker
Change by Soumendra Ganguly :
--
pull_requests: +22425
pull_request: https://github.com/python/cpython/pull/23546
___
Python tracker
<https://bugs.python.org/issue41
Change by Soumendra Ganguly :
--
pull_requests: +22550
pull_request: https://github.com/python/cpython/pull/23686
___
Python tracker
<https://bugs.python.org/issue41
Change by Soumendra Ganguly :
--
pull_requests: +22598
pull_request: https://github.com/python/cpython/pull/23740
___
Python tracker
<https://bugs.python.org/issue41
Soumendra Ganguly added the comment:
Thank you for the fix. That test was created by modifying an existing test
which already had that issue; it is documented in a comment by user nnorwitz in
the file. If your solution resolves the problem for all the tests in "class
PtyTest", th
New submission from Soumendra Ganguly :
This was tested using Python 3.7 after commenting out the sys.audit lines.
https://docs.python.org/3/library/pty.html presents us with an example usage of
pty.spawn. This example mimics script(1). However, the script(1) from
util-linux has fantastic
Change by Soumendra Ganguly :
--
pull_requests: +20896
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21752
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
Updated diff.
Changes _ekill()
--
Added file: https://bugs.python.org/file49376/pty.diff
___
Python tracker
<https://bugs.python.org/issue41
Change by Soumendra Ganguly :
--
title: Add window resizing support [ SIGWINCH ] to Lib/pty -> Adds window
resizing support to Lib/pty.py for proper output rendering
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
The following are two [ very old ] stackoverflow threads that are relevant.
https://stackoverflow.com/questions/6418678/resize-the-terminal-with-python
https://stackoverflow.com/questions/16941885/want-to-resize-terminal-windows-in-python-working-but-not
Change by Soumendra Ganguly :
--
title: Adds window resizing support to Lib/pty.py -> Adds window resizing
support to Lib/pty.py [ SIGWINCH ]
___
Python tracker
<https://bugs.python.org/issu
Change by Soumendra Ganguly :
--
title: Adds window resizing support to Lib/pty.py for proper output rendering
-> Adds window resizing support to Lib/pty.py
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
Hi! Can anyone please take a look at
https://bugs.python.org/issue41494 [
https://github.com/python/cpython/pull/21752 ]?
I think these are related. I wrote a new function called wspawn, which is like
spawn+the following differences.
1. It sets window
Soumendra Ganguly added the comment:
Hi! Can anyone please take a look at
https://bugs.python.org/issue41494 [
https://github.com/python/cpython/pull/21752 ]?
I think these are related. I wrote a new function called wspawn, which is like
spawn+the following differences.
1. It sets window
Soumendra Ganguly added the comment:
Possibly related issues:
https://bugs.python.org/issue29070
https://bugs.python.org/issue26228
Since wspawn does not depend on OSError, it might be a possible [ not
necessarily the only way ] of solving the above issues
Soumendra Ganguly added the comment:
Closing because registering SIGWINCH handler from within library function is
impractical.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Soumendra Ganguly :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue41494>
___
___
Pyth
New submission from Soumendra Ganguly :
The example in https://docs.python.org/3/library/pty.html that mimics script(1)
can be used to reproduce the problem: since window size is not set by
pty.spawn, output of "ls" becomes scattered and hard to visually parse if xterm
window
Change by Soumendra Ganguly :
--
title: Make pty.spawn set window size, make code more readable -> Make
pty.spawn set window size
___
Python tracker
<https://bugs.python.org/issu
Change by Soumendra Ganguly :
--
pull_requests: +20988
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21861
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
OS: Linux 4.19.0-9-amd64 Debian 10 GNU/Linux
--
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bug
Soumendra Ganguly added the comment:
Note that defining _login_pty() was not a cosmetic change; it is reused in
spawn().
--
___
Python tracker
<https://bugs.python.org/issue41
Soumendra Ganguly added the comment:
v0.2 moves _setwinsz block to parent after fork.
--
Added file: https://bugs.python.org/file49390/pty.diff
___
Python tracker
<https://bugs.python.org/issue41
Soumendra Ganguly added the comment:
Screenshot: output of "ls" before the patch is applied.
--
title: Make pty.spawn set window size -> Make pty.spawn set window size [ +
before, after screenshots ]
Added file: https://bugs.python.org/file493
Soumendra Ganguly added the comment:
Screenshot: output of "ls" after the patch is applied.
--
Added file: https://bugs.python.org/file49392/after.png
___
Python tracker
<https://bugs.python.o
Change by Soumendra Ganguly :
--
title: Make pty.spawn set window size [ + before, after screenshots ] -> Make
pty.spawn set window size [ patch + before, after screenshots ]
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
Adding the test program [ test.py ] as an attachment. It was taken from
https://docs.python.org/3/library/pty.html.
How to reproduce issue:
1. Notice that the xterm window in before.png is not too wide; this makes the
output of "ls" wrap
Soumendra Ganguly added the comment:
I am new to BPO. Just learned how to make someone nosy.
@twouters, I have attached all resources. This is ready for a review.
Thank you.
--
nosy: +twouters
___
Python tracker
<https://bugs.python.
Change by Soumendra Ganguly :
--
nosy: +mark.dickinson, meador.inge
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list mailin
Soumendra Ganguly added the comment:
Additional note: I am using the i3wm window manager. No desktop environment.
--
nosy: -mark.dickinson, meador.inge
___
Python tracker
<https://bugs.python.org/issue41
Change by Soumendra Ganguly :
--
title: Make pty.spawn set window size [ patch + before, after screenshots ] ->
[PATCH] Make pty.spawn set window size
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
v0.3 removes _login_pty() and defines _login_tty() instead; the latter is based
on login_tty(3) from glibc.
--
Added file: https://bugs.python.org/file49395/pty.diff
___
Python tracker
<https://bugs.python.
Soumendra Ganguly added the comment:
v0.4 puts try-except guards around imports so that existing code does not break.
--
Added file: https://bugs.python.org/file49396/pty.diff
___
Python tracker
<https://bugs.python.org/issue41
Soumendra Ganguly added the comment:
Further proposal: Rename my _login_tty to login_tty and make it available as a
part of the pty library. Note that usually login_tty accompanies openpty and
forkpty on a system; for example, see
https://www.man7.org/linux/man-pages/man3/login_tty.3.html
Soumendra Ganguly added the comment:
Further note: login_tty will also enable us to set slave termios from the
parent process in pty.spawn.
Due to the fact that reviewing patches can be overwhelming, v0.5 removes a lot
of stuff and instead simply performs window resize by calling ioctl
Soumendra Ganguly added the comment:
v0.5 had introduced minor mistakes + one hack [ was using master instead of
slave to set window size ]. v0.6 removes all such mistakes.
--
Added file: https://bugs.python.org/file49404/pty.diff
___
Python
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49386/pty.diff
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49392/after.png
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49396/pty.diff
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49402/pty.diff
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49390/pty.diff
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49391/before.png
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bug
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49393/test.py
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49395/pty.diff
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
--
title: pty.spawn hangs on FreeBSD 9.3, 10.x -> pty.spawn hangs on FreeBSD 9.3,
10.x, 12.1
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
All images, test programs, and old patches have been removed.
window resize test is now being performed using stty.
On linux:
stty -F rows x cols y
On BSDs:
stty -f rows x cols y
to change window size
Change by Soumendra Ganguly :
Added file: https://bugs.python.org/file49456/after.png
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Added file: https://bugs.python.org/file49455/before.png
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Removed file: https://bugs.python.org/file49457/script.py
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Added file: https://bugs.python.org/file49457/script.py
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
Change by Soumendra Ganguly :
Added file: https://bugs.python.org/file49458/script.py
___
Python tracker
<https://bugs.python.org/issue41541>
___
___
Python-bugs-list m
New submission from Soumendra Ganguly :
The current pty library has the following issues:
1. Does not set slave termios. Documented in the source.
2. Does not set initial slave window size. Documented in the source. Does not
handle SIGWINCH. See bpo-41494, bpo-41541. This is essential in
Soumendra Ganguly added the comment:
Reopening to indicate that this issue has not been resolved. However, this
thread should not be used anymore. Use this instead:
https://bugs.python.org/issue41818
--
status: closed -> open
___
Python trac
Soumendra Ganguly added the comment:
Makes sense. I will happily make a change of terminology in the pypty2
repository after the most desirable alternative is determined based on the
choice of the majority. I think 'mother/son' sounds cute while still retaining
the same initials
Change by Soumendra Ganguly :
--
pull_requests: +21879
pull_request: https://github.com/python/cpython/pull/22962
___
Python tracker
<https://bugs.python.org/issue26
Change by Soumendra Ganguly :
--
keywords: +patch
pull_requests: +21878
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22962
___
Python tracker
<https://bugs.python.org/issu
Soumendra Ganguly added the comment:
The reproducer was helpful. https://github.com/python/cpython/pull/23526 should
fix this issue.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Soumendra Ganguly :
--
pull_requests: +22408
pull_request: https://github.com/python/cpython/pull/23526
___
Python tracker
<https://bugs.python.org/issue41
63 matches
Mail list logo
