Shubha Ramani added the comment:
May I take resolve this issue and submit a patch ?
--
nosy: +shubha_bloodhound
___
Python tracker
<http://bugs.python.org/issue31
New submission from Shubha Ramani:
PyPy had a longstanding issue :
ZipFile.extractall is very slow compared to CPython 2.6
https://bitbucket.org/pypy/pypy/issues/905/zipfileextractall-is-very-slow-compared-to
which has been fixed in the PyPy code base. The changes were entirely in
zipfile.py
Changes by Shubha Ramani :
--
title: Propagate zipfile.py pypy issue #905 patch to CPython -> Propagate
zipfile.py pypy issue #905 patch to CPython 2.7
___
Python tracker
<http://bugs.python.org/issu
New submission from Shubha Ramani:
PyPy had a longstanding issue :
ZipFile.extractall is very slow compared to CPython 2.6
https://bitbucket.org/pypy/pypy/issues/905/zipfileextractall-is-very-slow-compared-to
which has been fixed in the PyPy code base. The changes were entirely in
zipfile.py
Shubha Ramani added the comment:
Please assign this bug to me. I will submit a patch
--
___
Python tracker
<http://bugs.python.org/issue30468>
___
___
Python-bug
Shubha Ramani added the comment:
serhiy sure I will attach proof of the performance bottle-neck on 2.7 and 3.7
before I submit a patch. Please assign this bug to me.
--
___
Python tracker
<http://bugs.python.org/issue30
Shubha Ramani added the comment:
Please assign this bug to me.
--
___
Python tracker
<http://bugs.python.org/issue30467>
___
___
Python-bugs-list mailin
Shubha Ramani added the comment:
Serhiy yes what you said makes sense. Thanks for clarifying. Updates
(benchmarking results) shortly...stay tuned.
--
___
Python tracker
<http://bugs.python.org/issue30
New submission from Shubha Ramani:
It is wasteful to generate the CRC Table every time, via _crctable =
list(map(_gen_crc, range(256))). Better to have a pre-computed table.
I will submit the patch which incorporates this feature along with
micro-benchmark results. Related issue:
http
Shubha Ramani added the comment:
It looks like _GenerateCRCTable() is already implemented here:
https://svn.python.org/projects/python/trunk/Lib/zipfile.py
The question is, why isn't it implemented here ?
https://github.com/python/cpython/blob/master/Lib/zipfi
Shubha Ramani added the comment:
This is not needed after all jkloth explained. Please feel free to close.
--
___
Python tracker
<http://bugs.python.org/issue30
Shubha Ramani added the comment:
Upon comparing the PyPy changes from attached diff to the latest cpython3
github, I don't find a need for improvement. Looks like cpython3 zipfile.py has
the same changes and the read() method in class
ZipExtFile(io.BufferedIOBase) is vastly improved com
12 matches
Mail list logo