Senthil Kumaran added the comment:
I have added a PR to remove ascii newlines and tabs from URL input. It is as
per the WHATWG spec.
However, I still like to research more and find out if this isn't introducing
behavior that will break existing systems. It should also be aligne
Senthil Kumaran added the comment:
New changeset 9ca20fdc4c27e31832adbd6d393a87e7d8953e3c by Miss Islington (bot)
in branch '3.8':
bpo-43534: Fix the turtle module working with multiple root windows GH-25594
https://github.com/python/cpython/commit/9ca20fdc4c27e31832adbd6d393a87
Senthil Kumaran added the comment:
New changeset b47f05157bd05c5825c26389af5be3064a2c1313 by Miss Islington (bot)
in branch '3.9':
bpo-43534: Fix the turtle module working with multiple root windows GH-25593
https://github.com/python/cpython/commit/b47f05157bd05c5825c26389af5be3
Senthil Kumaran added the comment:
Closing this age old bug in favor of fixing it as part of issue23498.
--
resolution: -> wont fix
___
Python tracker
<https://bugs.python.org/iss
Change by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<https://bugs.python.org/issue23498>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Senthil Kumaran :
--
stage: needs patch -> resolved
status: languishing -> closed
___
Python tracker
<https://bugs.python.org/issue3609>
___
___
Senthil Kumaran added the comment:
This bug was reported in 2.5 and we don't have a test case attached in this
report. Given many changes and age of the bug, I am closing this.
A specific report against the latest code will help us to fix this bug.
--
stage: -> resolve
Senthil Kumaran added the comment:
Please open a new issue. It has better chances of being fixed quickly.
On Mon, Apr 26, 2021 at 10:02 PM junpengruan wrote:
>
> junpengruan <632077...@qq.com> added the comment:
>
> Hi
> I think there is another bug when initial_re
Change by Senthil Kumaran :
--
title: cgi handling of POSTed files is broken -> cgi handling of POSTed files
is broken in Windows
versions: +Python 3.10 -Python 3.2, Python 3.3
___
Python tracker
<https://bugs.python.org/iss
Change by Senthil Kumaran :
--
pull_requests: +24343
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/25652
___
Python tracker
<https://bugs.python.org/iss
Change by Senthil Kumaran :
--
nosy: +orsenthil
nosy_count: 5.0 -> 6.0
pull_requests: +24406
pull_request: https://github.com/python/cpython/pull/25716
___
Python tracker
<https://bugs.python.org/issu
Change by Senthil Kumaran :
--
nosy: +orsenthil
nosy_count: 3.0 -> 4.0
pull_requests: +24407
pull_request: https://github.com/python/cpython/pull/25716
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
New changeset 76cd81d60310d65d01f9d7b48a8985d8ab89c8b4 by Senthil Kumaran in
branch 'master':
bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and
tabs. (GH-25595)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
New changeset 491fde0161d5e527eeff8586dd3972d7d3a631a7 by Miss Islington (bot)
in branch '3.9':
[3.9] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline
and tabs. (GH-25595) (GH-25725)
https://github.com/python/cpyt
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue43972>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Hi Stephen,
Could you give a brief demo of using curl to see the problematic behavior.
I have testing with a version python and saw that without content length, the
curl was behaving properly.
```
$mkdir foo
$#add index.html to directory foo
$python -m
Change by Senthil Kumaran :
--
pull_requests: +24537
pull_request: https://github.com/python/cpython/pull/25853
___
Python tracker
<https://bugs.python.org/issue43
Senthil Kumaran added the comment:
Based on Greg's review comment, I have pushed the fix for 3.9, and 3.8
- [3.9] https://github.com/python/cpython/pull/25853
- [3.8] https://github.com/python/cpython/pull/25726
There is no need to hold off releases for these alone. If we get it m
Senthil Kumaran added the comment:
New changeset 8a595744e696a0fb92dccc5d4e45da41571270a1 by Senthil Kumaran in
branch '3.9':
[3.9] bpo-43882 Remove the newline, and tab early. From query and fragments.
(#25853)
https://github.com/python/cpyt
Change by Senthil Kumaran :
--
pull_requests: +24589
pull_request: https://github.com/python/cpython/pull/25921
___
Python tracker
<https://bugs.python.org/issue43
Senthil Kumaran added the comment:
New changeset 24f1d1a8a2c4aa58a606b4b6d5fa4305a3b91705 by Miss Islington (bot)
in branch '3.10':
bpo-43882 Remove the newline, and tab early. From query and fragments.
(GH-25936)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
Hi Stephen,
With the example, I couldn't reproduce the problem with curl 7.65.3
That said, I do recognize that this change is a positive improvement, but I
cannot see this a bug-fix (and for client misbehavior, which I couldn't verify).
To take
Senthil Kumaran added the comment:
I am also hesitant to fix something that is not broken. So, please share the
broken behavior that could be verified, and this will give us greater
confidence to commit this patch.
--
___
Python tracker
<ht
Senthil Kumaran added the comment:
Hi Stephen,
Thanks for the response and the details. I was able to verify the bug!
I don't know exactly what I was doing previously, but I agree with you that
this is a bug and will be fixed with your patch. :)
Thanks,
Se
Change by Senthil Kumaran :
--
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/issue43972>
___
___
Python-bugs-list mailin
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Senthil Kumaran added the comment:
This was fixed in
https://github.com/python/cpython/commit/16dbbae2981c96c7c9b1ae81e1708d54b08c10ac
Since Python 3.4
And tests do not raise any ResourceWarning now.
```
$ ../../python -Vs
Python 3.11.0a0
$ ../../python -m unittest test_getpass.py -v
Senthil Kumaran added the comment:
The _GLOBAL_DEFAULT_TIMEOUT usage is an established pattern with socket module.
https://github.com/python/cpython/blob/main/Lib/socket.py#L805
This is not a bug and we don't have a good reproducible step mentioned in the
report.
--
resol
Senthil Kumaran added the comment:
This has been fixed here - https://github.com/python/cpython/pull/2755/files
Python docs demonstrate the usage of ftplib using ftp.debian.org.
I think, it is perfectly reasonable and welcome thing to do so.
https://docs.python.org/3/library/ftplib.html
Change by Senthil Kumaran :
--
pull_requests: +24624
pull_request: https://github.com/python/cpython/pull/25968
___
Python tracker
<https://bugs.python.org/issue30
Senthil Kumaran added the comment:
urllib.request.FancyURLopener has been deprecated since 3.3
https://docs.python.org/3/library/urllib.request.html#urllib.request.FancyURLopener
This bug wont be fixed. The other higher level methods (urlopen) could used for
basic authentication with
Senthil Kumaran added the comment:
This is still a problem behaviour as of May 2021.
./configure --prefix=/home/senthil/foobar
make libainstall
failed with
/usr/bin/install: cannot create regular file
'/home/senthil/foobar/bin/python3.11-config': No such file or dire
Senthil Kumaran added the comment:
issue25696 was related, and it fixed bininstall issue.
--
___
Python tracker
<https://bugs.python.org/issue16866>
___
___
Senthil Kumaran added the comment:
Hello All,
I think, the current striping of ASCII newline and tab is a _reasonable_
solution given it was a security issue.
It also follows the guidelines of "WHATWG" (Specifically Point 3)
> 2. If input contains any ASCII tab or newlin
Senthil Kumaran added the comment:
Ned wrote:
> Senthil, I am not sure which previous message you are referring to but.
I meant, the messages from other developers who raised that change broke
certain test cases.
Ned, but I got little concerned, if we planned to revert the change.
&g
Senthil Kumaran added the comment:
Looks like the BINDIR dependency was added here -
https://github.com/python/cpython/commit/49fd7fa4431da299196d74087df4a04f99f9c46f#diff-1f0a8db227d22005511b0d90f5339b97db345917b863954b3b3ccb9ec308767cR833
but we didn't add the directory creation depen
Change by Senthil Kumaran :
--
pull_requests: +24632
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/25980
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
Fixed in 3.11 here -
https://github.com/python/cpython/commit/80d250d68cf3bb511fd862169c681b28028499c2
--
___
Python tracker
<https://bugs.python.org/issue16
Senthil Kumaran added the comment:
In 3.10 -
https://github.com/python/cpython/commit/a2c72d52dddefbfbaa0745b0af54330fad03b29e
3.9 -
https://github.com/python/cpython/commit/a25c46bd7dd47a2f95b32d17ee2f66de214892c6
--
resolution: -> fixed
stage: patch review -> resolved
Senthil Kumaran added the comment:
Does anyone know what the return value 768 signify here?
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue23
Senthil Kumaran added the comment:
New changeset 6fc6f4366d02412e3424d2a6da43a28d8f479d7b by Miss Islington (bot)
in branch '3.10':
bpo-23750: Document os-system, subprocess. Patch by Martin Panter. (GH-26016)
(GH-26040)
https://github.com/python/cpyt
Change by Senthil Kumaran :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue23750>
___
___
Pyth
Senthil Kumaran added the comment:
New changeset 390bfe044531a813722919933116ed37fe321861 by Miss Islington (bot)
in branch '3.9':
bpo-23750: Document os-system, subprocess. Patch by Martin Panter. (GH-26016)
(GH-26041)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
New changeset 3e44e9af9ea4c5e82912a01f256d4abcae96f32b by Miss Islington (bot)
in branch '3.10':
bpo-44089: Allow subclassing of ``csv.Error`` (GH-26008) (GH-26066)
https://github.com/python/cpython/commit/3e44e9af9ea4c5e82912a01f256d4a
Change by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Senthil Kumaran added the comment:
This was also merged in 3.11
https://github.com/python/cpython/commit/2b458c1dba4058c808fde25226bb2d91c5a909ca
--
___
Python tracker
<https://bugs.python.org/issue44
Senthil Kumaran added the comment:
Julien, we could remove them from docs.python.org instead of pointing to
archive.org.
Users will be able to find more recent examples in the internet.
--
nosy: +orsenthil
___
Python tracker
<ht
Change by Senthil Kumaran :
--
pull_requests: +24871
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/26267
___
Python tracker
<https://bugs.python.org/issu
Change by Senthil Kumaran :
--
pull_requests: +24872
pull_request: https://github.com/python/cpython/pull/26268
___
Python tracker
<https://bugs.python.org/issue43
Change by Senthil Kumaran :
--
pull_requests: +24881
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/26275
___
Python tracker
<https://bugs.python.org/issu
Change by Senthil Kumaran :
--
pull_requests: +24882
pull_request: https://github.com/python/cpython/pull/26276
___
Python tracker
<https://bugs.python.org/issue43
Change by Senthil Kumaran :
--
pull_requests: +24883
pull_request: https://github.com/python/cpython/pull/26277
___
Python tracker
<https://bugs.python.org/issue43
Senthil Kumaran added the comment:
New changeset f14015adf52014c2345522fe32d43f15f001c986 by Senthil Kumaran in
branch '3.10':
[3.10] bpo-43882 - Mention urllib.parse changes in Whats new section. (GH-26275)
https://github.com/python/cpython/commit/f14015adf52014c2345522fe32d43f
Senthil Kumaran added the comment:
New changeset 0593ae84af9e0e8332644e7ed13d7fd8306c4e1a by Senthil Kumaran in
branch '3.9':
[3.9] bpo-43882 - Mention urllib.parse changes in Whats new section. (GH-26276)
https://github.com/python/cpython/commit/0593ae84af9e0e8332644e7ed13d7f
Senthil Kumaran added the comment:
There is a report about this change might have caused behaviour change for '.'
in sys.path between 3.10.0a7 and 3.10.0b1
https://mail.python.org/archives/list/python-...@python.org/thread/DE3MDGB2JGOJ3X4NWEGJS26BK6PJUPKW/
--
nosy:
Change by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue44348>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Yes, this was related to the Linux OOM Killer. The agent went down
shortly after this. Either multiple parallel jobs might have led to OOM
or something else. I will see if logs provide more information
Senthil Kumaran added the comment:
> Maybe you should give more memory to your worker, or you should spawn less
> jobs in parallel
It was related to high number of jobs in that particular agent and result in
OOM Kill from the Linux kernel - https://pastebin.com/559H4ksa
The machi
Change by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue44359>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Yes, closing this.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Senthil Kumaran :
--
keywords: +patch
nosy: +orsenthil
nosy_count: 3.0 -> 4.0
pull_requests: +26153
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27664
___
Python tracker
<https://bugs.python.org/i
Senthil Kumaran added the comment:
New changeset ebecffdb6d5fffa4249f9a813f1fc1915926feb5 by Senthil Kumaran in
branch 'main':
bpo-44830 - Remove the broken Broken Mozilla devguide link. (GH-27664)
https://github.com/python/cpython/commit/ebecffdb6d5fffa4249f9a813f1fc1
Change by Senthil Kumaran :
--
pull_requests: +26155
pull_request: https://github.com/python/cpython/pull/27666
___
Python tracker
<https://bugs.python.org/issue44
Senthil Kumaran added the comment:
New changeset 6a6bcf16370beff2e0d1a034661654d5c335b5ee by Miss Islington (bot)
in branch '3.9':
bpo-44830 - Remove the broken Broken Mozilla devguide link. (GH-27664)
(GH-27665)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
@Jack, if you review this backport -
https://github.com/python/cpython/pull/27666 , I can merge this PR.
--
___
Python tracker
<https://bugs.python.org/issue44
New submission from Senthil Kumaran :
I verified that ncurses-devel is installed.
./configure is able to verify ncurses
checking curses.h usability... yes
checking curses.h presence... yes
checking for curses.h... yes
checking ncurses.h usability... yes
checking ncurses.h presence... yes
Senthil Kumaran added the comment:
Here is the output of make with relevant lines.
CC='gcc -pthread' LDSHARED='gcc -pthread -shared' OPT='-DNDEBUG -g -fwrapv
-O3 -Wall' _TCLTK_INCLUDES='' _TCLTK_LIBS='' ./python -E ./setup.p
Senthil Kumaran added the comment:
A change like this will be required since these funcs were introduced only
recently and nurses shipped with centos was older.
% git diff
diff --git a/Modules/_cursesmodule.c b/Modules/_cursesmodule.c
index 61aaf85522..6fb6c490e6 100644
--- a/Modules
Change by Senthil Kumaran :
--
keywords: +patch
pull_requests: +26680
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/28260
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
I have created a pull request - https://github.com/python/cpython/pull/28260
Please review this.
--
assignee: -> orsenthil
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.pyth
Senthil Kumaran added the comment:
New changeset 794430700defb913512f871b701a888aa730de81 by Senthil Kumaran in
branch 'main':
bpo-45067 - Verify the version of ncurses for extended color support feature
usage. (GH-28260)
https://github.com/python/cpyt
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.9
___
Python tracker
<https://bugs.python.or
Senthil Kumaran added the comment:
New changeset c379bc5ec9012cf66424ef3d80612cf13ec51006 by Jochem Schulenklopper
in branch 'main':
bpo-40321: Support HTTP response status code 308 in urllib.request (#19588)
https://github.com/python/cpython/commit/c379bc5ec9012cf66424ef3d80612c
Senthil Kumaran added the comment:
+1 to these modules removal.
One concern I have is when users follow internet examples and look out for
these modules or examples.
What is the best way to show them the modern usage?
- Should Python docs show some example snippet of the most common usage
Senthil Kumaran added the comment:
> Timeout value should not be reset after client receives a data(bytes),
> because it can easily be abused to achieve DOS.
Interesting. I looked the server example.
Does clients like curl have something like th
Senthil Kumaran added the comment:
Hi Muhammad,
I haven't gotten to this. urllib doesn't maintain a client state during
multiple request / response.
The code is available here
https://github.com/python/cpython/tree/main/
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue38686>
___
___
Python-bugs-list mai
Change by Senthil Kumaran :
--
versions: +Python 3.8 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue38686>
___
___
Python-bugs-list mailin
Senthil Kumaran added the comment:
New changeset 14a89c47983f2fb9e7fdf33c769e622eefd3a14a by Senthil Kumaran
(PypeBros) in branch 'master':
bpo-38686: fix HTTP Digest handling in request.py (#17045)
https://github.com/python/cpython/commit/14a89c47983f2fb9e7fdf33c769e62
Change by Senthil Kumaran :
--
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue38686>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Senthil Kumaran :
--
versions: +Python 3.9 -Python 2.7, Python 3.7
___
Python tracker
<https://bugs.python.org/issue38686>
___
___
Python-bugs-list m
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<https://bugs.python
Senthil Kumaran added the comment:
New changeset f82e59ac4020a64c262a925230a8eb190b652e87 by Senthil Kumaran in
branch '2.7':
[2.7] bpo-27973 - Fix for urllib.urlretrieve() failing on second ftp transfer
(#1040)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
New changeset f82e59ac4020a64c262a925230a8eb190b652e87 by Senthil Kumaran in
branch '2.7':
[2.7] bpo-27973 - Fix for urllib.urlretrieve() failing on second ftp transfer
(#1040)
https://github.com/python/cpyt
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue27973>
___
___
Change by Senthil Kumaran :
--
pull_requests: +17207
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/17774
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
Thanks for the note, Pablo.
I am going to check if this patch https://github.com/python/cpython/pull/17774
will solve the Windows buildbot issues.
--
stage: patch review -> resolved
___
Python tracker
<
Senthil Kumaran added the comment:
Hi Pablo, Is there a way for us to test
https://github.com/python/cpython/pull/17774 on a Windows Builder which
displayed the post-commit failure?
The CI custom-builders seem to be broken for a different reason:
https://buildbot.python.org/all/#/builders
Senthil Kumaran added the comment:
Thanks for the suggestion, David. I have updated the PR 17774 to use
temp_support instead of NamedTemporaryFile. Please review this.
--
___
Python tracker
<https://bugs.python.org/issue27
Senthil Kumaran added the comment:
Sorry, I have updated it now: https://github.com/python/cpython/pull/17774
(I had pushed to a different branch earlier and it didn't reflect in my PR)
--
___
Python tracker
<https://bugs.python.org/is
Change by Senthil Kumaran :
--
nosy: -Joony898i
title: SEO Services Development & PHP development -> Redirect is not working
correctly in urllib2
___
Python tracker
<https://bugs.python.org/
Senthil Kumaran added the comment:
New changeset 5bba60290b4ac8c95ac46cfdaba5deee37be1fab by Senthil Kumaran in
branch '2.7':
bpo-27973 - Use test.support.temp_dir instead of NamedTemporaryFile for the
(#17774)
https://github.com/python/cpyt
Change by Senthil Kumaran :
--
pull_requests: +17245
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/17819
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
@James - Originally the issue was considered a revert and the versions were set
for the merge, but I certainly recognize the problem when parsing can fail for
simple URLs like `localhost:8000` which is very common.
Another developer had raised the concerns
Change by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue17005>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Hi Ido, there was a change requested by a core-dev, Zachary , on your PR.
> Please have a look at PEP 257 for docstring formatting guidelines.
https://github.com/python/cpython/pull/16458/files#r353422155
Please let us know if that is addres
Senthil Kumaran added the comment:
Hi Lukaz / Ned:
I will like to revert the backports done in 3.8 and 3.7.
Preferably in 3.8.2 and 3.7.7, so that this undesirable behavior exists only
for a single release.
I have set this is a release blocker to catch your attention.
--
nosy
Senthil Kumaran added the comment:
Welcome to work on the patch, Amir.
* We shouldn't be encoding anything.
* Create reject for Unicode control characters and reject the request if the
request contains any control character. Write tests for this.
It will similar to one of the exa
Change by Senthil Kumaran :
--
keywords: +patch
pull_requests: +17902
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/18525
___
Python tracker
<https://bugs.python.org/issu
Change by Senthil Kumaran :
--
pull_requests: +17903
pull_request: https://github.com/python/cpython/pull/18526
___
Python tracker
<https://bugs.python.org/issue27
901 - 1000 of 2044 matches
Mail list logo
