Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11736>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Fixed it in relevant branches. I had to add condition around the test to verify
that platform was win because this is unique to windows only. Thanks.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Just for the explaination (as the report already closed), getheaders of
HTTPMessage object is available by subclassing all the way from rfc822.py
module. If you trace it through the debugger, you will come to know
Senthil Kumaran added the comment:
We need not base changes to html/parser.py on html5 spec, but rather make
changes based on the requirements on parsers which may rely on this library.
Like the tolerant mode was brought in issue1486713 for some practical reasons
and it was seen useful tor
Senthil Kumaran added the comment:
> So is the issue7311-3.diff patch fine?
Just that it allows unquoted attrs for unicode too.
My previous suggestion was not to allow unquoted attribute values, but as the
change is already made in 2.7 and discussion pointed out a portion in 4.1 spec
wh
Senthil Kumaran added the comment:
With the patch there is a new exception with specific msg being raised in
certain cases, so this may only pertain to 3.3
--
assignee: -> orsenthil
nosy: +orsenthil
versions: -Python 3.2
___
Python tracker
&l
Senthil Kumaran added the comment:
It should be noted that the bug surfaced in 2.7 and above due to changes made
as part of Issue8280.
--
assignee: -> orsenthil
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
This is fixed in all the codelines. Thanks for the patch, Santoso.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Fixed in all the codelines. Thanks for the patch, Santoso.
--
assignee: -> orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11710>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
It is better to close this issue as it was a Server Error. Standard just says
that when there two headers with different values, combine them comma separated
as urllib2 does. Making special case exception for 'Content-Length' header
when the se
Senthil Kumaran added the comment:
Fixed this in all codelines. Thanks Santoso.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
What would be a 'meaning' __str__ or __unicode__ of urlparse.urlparse and how
would it be useful to you?
I would think that people would except a tuple, list or a ParsedResult for such
a call.
I cannot understand the rational behind the expect
Senthil Kumaran added the comment:
Tomasz,
I think, you misunderstood the purpose of urlparse library. urlparse is for
parsing the URL and into its components. The url could be a mailto:, svn+ssh or
http,https. The requirement for parsing comes when you are designing systems
which take up
Changes by Senthil Kumaran :
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue4608>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
I have made the changes in 3.3,3.2,3.1 and 2.7 codeline. The behavior is
aligned with the 2.5 (and earlier) behaviors. I cannot change this 2.6 because
this is not a security issue to be back-ported. (rather it was misinterpreted
problem and resulted in
Senthil Kumaran added the comment:
Updated the NEWS entry.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11236>
___
___
Python-
Senthil Kumaran added the comment:
Scott- which platform did you observe this? I can't reproduce this on the 2.7
code on Linux.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
I had tried/tested against 3.x branch and did not find the problem. Later
realized that it was only again 2.7. Pushed in the changes and the tests. I
shall the tests only in 3.x codeline.
--
___
Python tracker
Senthil Kumaran added the comment:
Éric, ParseResult is a class which provides tuple for urlparse/unparse. People
should hardly (/never) use ParseResult directly. The original poster's concern
was to get something like geturl() from this class which was not suitable and
it shou
Senthil Kumaran added the comment:
Sijin, please go ahead and submit a patch. No one is working on this at the
moment.
--
nosy: +markm
___
Python tracker
<http://bugs.python.org/issue9
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11943>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I had wrapped skipUnless decorator for the wrong test (test_extractall
instead of test_extractall_symlinks) in the 3.x code. Corrected it
and waiting for next bb reports.
Thank you.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
buildbots are green again.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10761>
___
___
Python-
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10946>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Hello Bernhard,
I tried to a POST of JPEG file, through urllib2 (which internally uses httplib)
and goes through the code that you pointed out and I don't face any problem. I
am able to POST binaries using httplib.
I am also surpris
Senthil Kumaran added the comment:
Added the flush_headers method and the test function. this issue can be closed
now. Thanks, Andrew Schaaf.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I could reproduce the BadStatusLine exception using Vinay's server_test.py. I
see that the exception is triggered by logging package when it is trying to
http.client's getresponse() before it is ready. The previous commit
25298224cb25 was on h
Senthil Kumaran added the comment:
On Tue, May 10, 2011 at 09:12:58AM +, Vinay Sajip wrote:
> Either omitting the end_headers() call was always an error but
> previously undetected, or the requirement to always call
> end_headers() is new and this should be documented. I'm no
Senthil Kumaran added the comment:
On Tue, May 10, 2011 at 02:06:48PM +, Vinay Sajip wrote:
> @Senthil - are you planning to make the documentation change, or should I?
I shall do it, Vinay.
Thanks!
--
___
Python tracker
&l
Senthil Kumaran added the comment:
Hi Vinay,
Normally, when one uses send_response() call, it is most often followed with
(multiple) send_header() calls and I updated the documentation keeping that in
mind.
Just calling of send_response() without any send_header and end_headers was an
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
The bug was about sending Binary "data" via httplib. In the example you
wrote, you are sending a unicode "url" and experiencing a failure for
certain examples.
In the 2.7, the urls should be str type, we don't have function to
deal wi
Senthil Kumaran added the comment:
I looked at your message and the patch, seems okay for the case of testing if
the symlink is broken and performing the next steps. I shall commit it soon.
--
assignee: -> orsenthil
nosy: +orsenthil
___
Pyt
Senthil Kumaran added the comment:
Committed the fix. Thank you, Scott.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11197>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
neologix, that is right. Importing uuid before importing the other modules does
not result in Seg Fault. Till the libc fix is available in Operating systems
and as a result in CPython, this is probably the only way to go for.
--
nosy: +orsenthil
Senthil Kumaran added the comment:
hello wrobell , I see that issue3754 has patches for more recent line of code
and issue 1597850 is related too. Would you like to test the patches in there?
If successful, this feature can be pushed further (and considered) for
inclusion.
--
nosy
Senthil Kumaran added the comment:
Code compatibility wise there is not much difference between Python3.2
and Python3.3. So you can do it for Python3.2 (in a bitbucket cpython
branch) and it is found stable, there are good chances that it will be
can be made in Python3.3 and future. I don&#
Senthil Kumaran added the comment:
Hi Ezio, the connection can be closed via the finally call as you do in the
patch. There are times when request object is re-used, but before the
connection is made. It may also help to understand how the code in the
packaging was invoking it.
If you run
Senthil Kumaran added the comment:
Fixed in r86514 (py3k) and r86515 (release31-maint).
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue9991>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Fixed in r86520 (py3k) and r86522 (release31-maint).
unquote happens at the first level inside Request class, _parse method.
Shall port to py2.7.
--
nosy: -BreamoreBoy
resolution: -> fixed
stage: patch review -> committed/re
Senthil Kumaran added the comment:
r86523(py3k) and r86524(release31-maint)
--
___
Python tracker
<http://bugs.python.org/issue9991>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
back-ported to release27-maint in r86554.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I have doubts on the validity of this bug itself.
- First is, query and fragment are usually for the file being served from the
webserver, not on the directories. If there are characters such as '?' and '#'
in the directory names, which
Senthil Kumaran added the comment:
Fixed in r86580 (py3k), r86581 and r86582.
--
components: +Library (Lib)
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
BaseHTTPServer documentation explains that "Usually, this module isn’t used
directly, but is used as a basis for building functioning Web servers". Methods
are usually subclassed with desirable behaviors customized.
If you are using SocketServ
Senthil Kumaran added the comment:
What should it do? OP expected that it print the redirected url. I don't think
that's helpful by setting max_redirections to 0, when it can be achieved in
other ways.
Also, max_redirections is not exposed (as a parameter or arg) or a documented,
Senthil Kumaran added the comment:
On Sat, Nov 20, 2010 at 07:09:58PM +, Jeremy Thurgood wrote:
> There are two separate things here: the URL and the filesystem path.
> The bug is that the fragment and query parameters are stripped in
> translate_path(), but are *not* stri
Senthil Kumaran added the comment:
Fixed this revision 86640.
- Even though this is an internal optimization,I don't think back-porting is a
good idea, because it changes the behavior of certain methods like send_header
and end_headers
- Added the Documentation and other test scenario
Senthil Kumaran added the comment:
On Sun, Nov 21, 2010 at 12:12:08PM +, Jeremy Thurgood wrote:
> I see your point now, but I don't agree with it completely. It seems
> reasonable to allow query parameters to specify things like sort
> order for a directory listing or have
Senthil Kumaran added the comment:
On Sun, Nov 21, 2010 at 03:15:06PM +, R. David Murray wrote:
> Senthil, I didn't clearly express my concern about
> send_response_only. It doesn't look to me like, with buffering in
> place, that it *should* write directly, it looks to
Senthil Kumaran added the comment:
Fixed it in r86676 (py3k), r86677 ( release31-maint) and
r86678(release27-maint).
Wes: I fixed it at the much higher level in the urlparse itself, so that the
fixed url is sent to the httplib.
In issue2464, John had pointed out that according to STD 66
Changes by Senthil Kumaran :
--
assignee: facundobatista -> orsenthil
nosy: -BreamoreBoy
___
Python tracker
<http://bugs.python.org/issue1675455>
___
___
Py
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10483>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I think, it is better that distutils.command.register and
distutils.command.upload use CRLF as the line terminator for header
values.
It just helps in many cases, we can safely side by this case, but not
relying LR or CR only may not be always possible
Senthil Kumaran added the comment:
On Thu, Nov 25, 2010 at 05:44:21AM +, Dafydd Crosby wrote:
> I created a patch that adds those two wishlist items. Given that
> mouse support and the use of curses.flash() are missing from the
> demo programs, I think it's a bit
Senthil Kumaran added the comment:
The transparent gzip Content-Encoding support should be done at the
http.client level code.
Before adding this feature, a question needs to be sorted out.
If we support the transparent gzip and wrap the file pointer to a
GzipFile filepointer, should reset
Senthil Kumaran added the comment:
Patch for py3k.
--
stage: unit test needed -> patch review
Added file: http://bugs.python.org/file19811/issue1508475.diff
___
Python tracker
<http://bugs.python.org/issue1
Senthil Kumaran added the comment:
Boštjan, it is fixed. The change will reflect when the docs get served
from the updated version.
Also, Georg will take care of merging it to other branches.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
If you want to quickly solve this, do like this:
import urllib
import tarfile
tarfile.open(urllib.urlretrieve('http://plugins.supybot-fr.tk/GoodFrench.tar')[0],
mode='r:') # Works
The problem is tarfile is expecting a "file-objec
Senthil Kumaran added the comment:
Committed in r86750. Thank you!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.2
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10441>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10442>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
assignee: jhylton -> orsenthil
___
Python tracker
<http://bugs.python.org/issue3243>
___
___
Python-bugs-list mailing list
Un
Senthil Kumaran added the comment:
No problems when I downloaded and installed on Windows XP.
I scanned using the Symantec EndPoint protection and no threats found.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10
Senthil Kumaran added the comment:
On Sun, Nov 28, 2010 at 05:48:20AM +, Éric Araujo wrote:
> I’m not committing directly because I’d like feedback: Is the
> wording okay for the beginning of the tutorial?
It seems fine and useful. Please go ahead.
--
nosy: +ors
Senthil Kumaran added the comment:
xuanji, the issue you stumbled upon was just fixed by Raymond for the report
Issue10565.
--
___
Python tracker
<http://bugs.python.org/issue3
Senthil Kumaran added the comment:
Fixed in r86861. Xavier, I noticed that pdb.py itself was not calling the
proper method. Added the tests to the patch. Thanks.
BTW, please provide patches against py3k as that is development version.
--
assignee: -> orsenthil
nosy: +orsent
Senthil Kumaran added the comment:
r86862 - release31-maint and r86863 - release27-maint.
--
status: open -> closed
versions: +Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Ouch. My mistake. Had not realize then, that code that actually broke things
was merged in 2.6.x and it had to be fixed too. :(
--
___
Python tracker
<http://bugs.python.org/issue9
Senthil Kumaran added the comment:
Xuanji, a wording which does convey the approximate meaning is fine. I think,
the Exception error messages will help the people based on the Context.
- Lets have the ValueError raised from the urllib/request.py. Changing it to
isinstance(data
Senthil Kumaran added the comment:
Give a try to this minor variation of the patch with tests added and let me
know your review comments.
--
Added file: http://bugs.python.org/file19890/Issue3243-4.patch
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
On Wed, Dec 01, 2010 at 10:06:25AM +, Antoine Pitrou wrote:
> +try:
> + self.sock.sendall(data)
>
> Indentation problem here.
I could notice it now. Shall fix it.
>
> +if i
Senthil Kumaran added the comment:
On Wed, Dec 01, 2010 at 02:56:56PM +, Xuanji Li wrote:
> orsenthil: Hi, i don't quite understand why iter() needs to be
> called explicitly on data? As I understand it, if data is an
> iterable then you can use a for loop on it directly.
>
On Wed, Dec 01, 2010 at 05:08:26PM +, Antoine Pitrou wrote:
> Antoine Pitrou added the comment:
> > if not request.has_header('Content-length'):
> > if (not hasattr(data, '__read__') and
>
> What is __read__ supposed to be?
I don't think is required. The previous 2.x version patch was d
Senthil Kumaran added the comment:
On Thu, Dec 02, 2010 at 02:19:10AM +, Senthil Kumaran wrote:
> On Wed, Dec 01, 2010 at 10:06:25AM +, Antoine Pitrou wrote:
> > +try:
> > + self.sock.sendall(data)
> >
> > Indentation problem here.
>
Senthil Kumaran added the comment:
Updated patch after correcting the mistake (bytes vs str) in the previous one.
--
Added file: http://bugs.python.org/file19900/Issue3243-6.patch
___
Python tracker
<http://bugs.python.org/issue3
On Thu, Dec 02, 2010 at 03:08:55AM +, Xuanji Li wrote:
>
> req = Request("http://example.com/";, "")
That should be:
> req = Request("http://example.com/";, b"")
I updated some of those in the latest updated patch.
___
Python-bugs-list mailing li
Senthil Kumaran added the comment:
On Thu, Dec 02, 2010 at 03:16:53AM +, Xuanji Li wrote:
> And my version too...
>
+if hasattr(data, '__len__') and not len(data):
+request.add_unredirected_header('Content-length', '0&#
Senthil Kumaran added the comment:
On Thu, Dec 02, 2010 at 03:20:05AM +, Xuanji Li wrote:
> Actually I don't think you can go around changing test_urllib2.py,
> they are after all regression tests... and surely some users will
> send "" as data.
>
Think
Senthil Kumaran added the comment:
Glaring at my mistakes.
> There was wrong examples in the test_urllib2 which I just corrected.
There were..
> Expect for the difference in (it = iter(data) - Which I am seeking
Except for ...
--
___
Senthil Kumaran added the comment:
On Mon, Nov 29, 2010 at 05:51:35PM +, Antoine Pitrou wrote:
> However, urllib.request.urlopen() works fine in this case, so
> perhaps this advocates for deprecating the old stuff? Senthil?
Yes. It should be deprecated.. I created a branch for
Senthil Kumaran added the comment:
On Fri, Dec 03, 2010 at 10:33:50PM +, Fred L. Drake, Jr. wrote:
> Though msg104261 suggests this change be documented in NEWS.txt, it
> doesn't appear to have made it.
Better late than never. I just added the NEWS in r87014 (py3k)
,r87015(rele
Senthil Kumaran added the comment:
I think, the file-like object behavior can be brought back. No need to handling
gzipped file object in the patch, if the earlier behavior was not handling it.
There is a separate issue to keep track of handling gzip encoded content in
httplib. I shall try
Senthil Kumaran added the comment:
Instead of tossing around the GzipDecoding code from one method to another
(which would in turn change the return value from those methods), I thought is
appropriate to do a change in parse_response itself, so that it verifies that
it is a http response
Senthil Kumaran added the comment:
This issue is not applicable to release31-maint.
--
resolution: -> fixed
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
py3k fixed in r87128
--
___
Python tracker
<http://bugs.python.org/issue8194>
___
___
Python-bugs-list mailing list
Unsub
Senthil Kumaran added the comment:
Can you point me to your code and error traceback that was observed and some
details about server which gave 301/302 Redirect as what was the hostname and
where did it redirect to?
I don't see the code changes that you provided in the patch in the l
Senthil Kumaran added the comment:
On Sat, Nov 13, 2010 at 01:17:47PM +, Antoine Pitrou wrote:
> There are still sporadic failures such as:
I have made a small change for this in r87260.
--
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Zsolt,
The change in the urllib2 was at a place where tuple of all local ips
were required.
In test_urllib2, which testcase failed?
Also, can you make this change and see if this helps in your case.
- localaddr = socket.gethostbyname
Senthil Kumaran added the comment:
+localaddr = socket.gethostbyname_ex(socket.gethostname())[2][0]
May not be a generic solution, because in another system the other ip
could be first in the list. Because the failure was in the test_file,
which was basically exercising file
Senthil Kumaran added the comment:
I just read the whole discussion and it seems that code was in place so that
client can tolerant of a BAD HTTP 0.9 Server response.
http://www.w3.org/Protocols/HTTP/OldServers.html
Given that issue10711 talks about removing HTTP/0.9 support (+1 to that
Senthil Kumaran added the comment:
+1 removing HTTP 0.9, and falling back to HTTP 1.0 behavior where ever it was
HTTP 0.9. Removing support for response without status (which was acceptable by
0.9) is fine. I reviewed the patch too and it seems good to go
Senthil Kumaran added the comment:
Well, ignore my comment on order of ip addresses. It definitely does not matter
in this case for test_urllib2.
However, readability does matter again as per my previous explanation, since
http://localhost/ was being exercised in the test_file
Senthil Kumaran added the comment:
On Thu, Dec 16, 2010 at 01:18:30PM +, Antoine Pitrou wrote:
> Well, removing 0.9 support doesn't make this obsolete, does it?
It does. Doesn't it? Because I saw in your patch that you fall back on
HTTP 1.0 behaviour when the server does
Senthil Kumaran added the comment:
On Thu, Dec 16, 2010 at 02:02:10PM +, Antoine Pitrou wrote:
> I don't think you understood the issue here. Calling readline() without
> a maximum length means the process memory potentially explodes, if the
> server sends gigabytes of data wi
601 - 700 of 2044 matches
Mail list logo
