Senthil Kumaran added the comment:
Fixed in revision 85837.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
- Otherwise, it is not possible to distinguish between netloc and path
- components, and would the indistinguishable component would be classified
- as the path as in a relative URL.
+ If the netloc does not start with '//', the mod
Senthil Kumaran added the comment:
Not sure, why changed the resolution. It is an invalid bug report. You could
have resolved it by a little research or by asking around.
--
resolution: fixed -> invalid
___
Python tracker
<http://bugs.pyth
New submission from Senthil Kumaran :
/py3k/Modules/readline.c: In function flex_complete:
/py3k/Modules/readline.c:877: error: on_completion undeclared (first use in
this function)
--
assignee: orsenthil
messages: 120376
nosy: orsenthil
priority: normal
severity: normal
status: open
Senthil Kumaran added the comment:
The problem was in py3k, due to a minor overlook in r85680.
Fixed in r86153.
--
components: +Build
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.2
_
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10205>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue6269>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Fixed the wordings in r86296(py3k), r86297(release31-maint) and
r86298(release27-maint).
David, for the examples you mentioned, the first one's parsing logic follows
the explanation that is written. It is correct.
For the second example, the port valu
Senthil Kumaran added the comment:
Fixed in r86310. print was used in some examples following its mention, so a
simple introduction to it was okay. It is introduced properly further down in
the tutorial.
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> com
Senthil Kumaran added the comment:
Fixed in r86348 for py3k and r86349 for release27-maint.
In release31-maint, I see that there are missing features, like support for
xml_declaration and default_namespace, which are however available in
release27-maint. This is not a desirable scenario and
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10318>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
jrodman2, in the socketserver TCPServer code you will find that
shutdown_request does a socket.SHUT_WR before calling close_request.
If the application or code in your description used shutdown_request, instead
of close_request would you still require the
Senthil Kumaran added the comment:
Hallvard, if it going be a rather huge diff, you may make it available at
http://bugs.python.org/review, so that it is easy for review.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10
Senthil Kumaran added the comment:
conn.close() was done in the finally method in r86228 by brian.curtin.
The other change in your patch in very minor space addition after comma. We can
leave it to place along with some other code change.
--
nosy: +brian.curtin, orsenthil
resolution
Senthil Kumaran added the comment:
At first, I was worried if this simplification would cause any harm to
readability of the algorithm. Fortunately, it didn't.
Committed in r86357.
--
nosy: +orsenthil
resolution: -> fixed
stage: commit review -> committed/rejected
s
Senthil Kumaran added the comment:
On Tue, Nov 09, 2010 at 07:15:57PM +, Jean-Paul Calderone wrote:
> >>> cProfile.run("import time; time.sleep(1)")
> 4 function calls in 1.012 CPU seconds
>
> It is not the case that the profiled code uses >1 CP
Senthil Kumaran added the comment:
On Fri, Nov 12, 2010 at 12:35:49AM +, Łukasz Langa wrote:
> This is unfortunately a backwards compatibility concern. Originally
> it wasn't made so that set() converts to string or accepts only
> strings and when the developers realized th
Senthil Kumaran added the comment:
Thanks for the explanation, Éric. That helps.
- Backported QName tests in r86447 to release31-maint.
As for the logic of the fix, it follows like this:
If True and False:
#Doesn't go here
elif True:
# Goes here
vs
if True:
# Goes here
if
Senthil Kumaran added the comment:
On Sat, Nov 13, 2010 at 01:20:45AM +, Łukasz Langa wrote:
> You think wrong. Try it.
Okay, I get it. Coercing would be a bad idea in RawConfigParser
because there are cases where get method can have raw=True and
coercing would break those behaviors.
Senthil Kumaran added the comment:
This is an invalid bug report at the moment. In fact, aged.
The redirection depends upon max_redirections and max_repeats together. Setting
it to 0 explicitly (inside the code) is not a good use case under any condition.
--
nosy: -BreamoreBoy
Senthil Kumaran added the comment:
Fixed in r86450 (py3k). Will be back porting shortly.
--
resolution: -> fixed
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/
Changes by Senthil Kumaran :
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue10116>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
r86461 (release31-maint)
r86462 (release27-maint)
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
That's sad. The fix is very simple. We shall have it before 3.2 alpha4 or beta1.
--
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
John, I was trying to find out what does rfc say on "Client Ignoring the 30X
REDIRECT headers". There is no point made on Client's trying to ignore it,
instead it said that it should follow the Redirect and must not endlessly loop.
Setting ma
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10425>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Revisiting this issue.
- Cookie: should contain name=value pairs
- Set-Cookie: header can contain a single word like 'secure'
The current design is along the same lines only.
In the original comment, the request had asked to document the behavior
Senthil Kumaran added the comment:
Did you attach the correct files? You mention about two programs in the
description, but you have attached only one file 'deadlock.py'.
Also, it does not fail on Python 2.7.1. Please try it on the latest
codeline from release27-maint too.
-
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue10399>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
It is 'attributes' instead of term 'members'. The term 'method' when it denotes
methods can be left as such.
--
assignee: d...@python -> orsenthil
nosy: +orsenthil
___
Python
Changes by Senthil Kumaran :
--
stage: -> needs patch
type: -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
On Tue, Nov 16, 2010 at 11:32:03AM +, Adam Bielański wrote:
> just accept ex:nil as well as nil and not try to analyze namespaces at all.
But even that seems specific to Java/ Apache Extension.
If it is, then it might go in as part of issue8
Changes by Senthil Kumaran :
--
assignee: -> bquinlan
nosy: +bquinlan
stage: -> patch review
versions: -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Senthil Kumaran :
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Fixed in revision 88631
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
On Sat, Feb 26, 2011 at 12:11:10AM +, Antoine Pitrou wrote:
> if err.errno != errno.EACCESS:
> AttributeError: 'module' object has no attribute 'EACCESS'
That was one 'S' too many. Should be errno.EACCES
Looks
Senthil Kumaran added the comment:
Done in r88634.
--
___
Python tracker
<http://bugs.python.org/issue10228>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I fail to see the bug here. Python's getpass.py is mimicing the
behavior of getp
On Tue, Feb 22, 2011 at 08:48:20AM +, wesley chun wrote:
>
> The fix is to add the end char '$' to the regex to get all 4 working:
Better would be a regex for white-space '\s' which would achieve the
same purpose plus it would satisfy the other requirement for using it
with search and can do
Senthil Kumaran added the comment:
Thinking about the regex pattern again. The example given is not really wrong.
It does what it claims to match, that is '' and
'u...@example.com' and reject ' kind of string.
Also, this is not an example of validating an email ad
Senthil Kumaran added the comment:
Guy, if the issue you describe in relevant to py3.x or 2.7, can you open a new
issue?
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue5
Changes by Senthil Kumaran :
--
resolution: -> invalid
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue11301>
___
___
Pyth
On Thu, Feb 24, 2011 at 03:07:10PM +, R. David Murray wrote:
> Creating a test for this may not be practical :(
Then should we just go ahead with this change as it seems reasonable
one.
-elif e.errno == errno.EACCES:
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11375>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
I am not able to understand what you mean by 'endpoint'.
Actually, when using tunnels people understand that they often 'tunnel through'
the proxy server and here is an example code from the tests which is going to
use the se
Senthil Kumaran added the comment:
splituser is an internal API. It has never been exposed through Docs anytime
and there are good reasons for that too. We never want internal helper
functions (even tough they don't startwith _) be exposed through docs as it may
clutter the API Document
Only for relatively uncommon concepts like "Moving Average" and
some other cases used in collections module hyperlink to a general
article helps.
Set theory is a commonly understood concept and link to wikipedia
article may not be required. It can be left to the user to find out
more, if they want
Senthil Kumaran added the comment:
Sandro, I don't think is a required. Those functions serve the purpose
of making the module code modular. They are helper functions for the
module and are not really useful outside of it, when used standalone.
Think about , splituser, splitpath, splitpor
Senthil Kumaran added the comment:
What kind of url is 'javascript:123' and how do you (/ we) say that python2.6
behavior was correct?
--
assignee: -> orsenthil
keywords: +patch
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Okay, fixed in all relevant branches.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Yes, please ensure that server is returning a proper HTTP response. Test it
against browser or curl and see if they work. If they work, then it needs to be
investigated as why 'http.client' is not working.
--
assignee: -> orsenthil
nos
Senthil Kumaran added the comment:
Santoso, Quick review comments:
1. The patch looks good.
2. I would use a temporary 'throw-away' variable instead of _, but don't bother
to change it, before committing I shall take care.
3. Important - Did you find any regression with the
New submission from Senthil Kumaran :
Here is the make log and a patch to ignore looking for subversion keyword and
assume some defaults (same is done in 2.6 + higher).
--
components: Installation
files: make-error.log
messages: 131216
nosy: loewis, orsenthil
priority: normal
severity
Changes by Senthil Kumaran :
--
keywords: +patch
Added file: http://bugs.python.org/file21260/ignore_subversion_keywords.diff
___
Python tracker
<http://bugs.python.org/issue11
Senthil Kumaran added the comment:
go ahead. please submit a patch.
--
assignee: -> orsenthil
nosy: +orsenthil
type: performance -> behavior
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Yes, go ahead with the patch.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11563>
___
___
Python-bug
New submission from Senthil Kumaran :
When pushed a change to 2.5 branch, I got an error, which I think has
to do with buildbot not available for 2.5 codeline.
It asked me to notify the tracker and here it is.
remote: state = method(*args, **kw)
remote: File "/data/buildbot/m
Senthil Kumaran added the comment:
Fixed in all the relevant code lines.
--
assignee: -> orsenthil
priority: release blocker ->
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python
Senthil Kumaran added the comment:
Fixed in 3.3 and 3.2.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
On Thu, Mar 17, 2011 at 05:15:09PM +, Skip Montanaro wrote:
> Should you be pushing anything to 2.5?
I think, there is a security release planned in 2011.
Also, see issue11442 which was the specific case for pushing to
Senthil Kumaran added the comment:
On Thu, Mar 17, 2011 at 05:16:43PM +, Skip Montanaro wrote:
> See Issue 11439.
Yes, that is relevant and applies probably to code in default and
other branches.
Just in case, this corner case in 2.5 does not overlooked (because it
does not happen in ot
Senthil Kumaran added the comment:
issue11442 is a security issue and I pushed to 2.5 for fixing that and
encountered this problem with buildbot. I think, we may/may not fix
this (buildbot issue) depending upon when the 2.5 release may be
planned
Changes by Senthil Kumaran :
--
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue11581>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10486>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue8450>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10860>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue8704>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
On Thu, Mar 17, 2011 at 06:30:51PM +, Jeff McNeil wrote:
> I went down the same path as AbstractHTTPHandler and added a Connection:
> close header.
This is fine for the moment, tough I wish that the TODO pending in
urllib.request with H
Senthil Kumaran added the comment:
Why should we have this file served on the web itself? Cannot it be on server
outside of www ( or any directory which is getting served). I would vote for
this.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
David, from you message I understand that Martin is planning to
release 2.5 via svn. If that is the case, whatever was pushed for
security fix to hg can remain as such and so that those can be
exported to svn.
The bugs related to buildbot and svn keyword
Senthil Kumaran added the comment:
Significant patch. Thanks. I looked at the review too. For the
Context Manager part, don't club it along with this one. We need to
test this thoroughly, after this is in shape, that can be addressed.
--
___
P
Senthil Kumaran added the comment:
Changing the description is a minor update. The term 'URL access module' seems
fine.
--
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
Since the reporter did not get back with more details (testing against curl or
a HEAD output to eliminate server issues), I am closing this issue.
--
resolution: -> invalid
status: pending -> closed
___
Senthil Kumaran added the comment:
Buildbots pass the tests again.
--
priority: release blocker ->
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue9740>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue3566>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Victor - Issue9740 and Issue3566 talks about the need to have persistent
connection. 3.3 would be a good target to have this feature in.
Shall add the NEWS entry.
Nadeen Wadwa - Thanks for your patch. I committed the fix as part of another
bug (Issue3566
Changes by Senthil Kumaran :
--
Removed message: http://bugs.python.org/msg131456
___
Python tracker
<http://bugs.python.org/issue11563>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Victor - Issue9740 and Issue3566 talks about the need to have persistent
connection. 3.3 would be a good target to have this feature in.
Shall add the NEWS entry.
Nadeem Vawda - Thanks for your patch. I committed the fix as part of another
bug (Issue3566
Senthil Kumaran added the comment:
I saw the partial fix suggested by the patch, but for some reason I
did not see ResourceWarning being shutup. Let's look at this again.
The warnings are all from the (old) ftp portion of the code..
--
___
P
Senthil Kumaran added the comment:
Ezio Melotti wrote:
> This is just nitpicking, but serving XHTML as text/html is wrong.
While, I thought this statement is correct and expected the Internet
media-type should be something else (application/xhtml+xml), but as
per w3c, it is not wrong
Senthil Kumaran added the comment:
Thanks again.
Agree to use of returning the block size to the returnhook callable.
But this is going be a deviation from the existing behavior which was
present to inform the user at regular intervals and did not bother to
provide any 'progressive
Senthil Kumaran added the comment:
Antoine Pitrou wrote:
> Can you clarify the issue?
URLopener which is an old class from the merge of urllib and urllib2
and it can be slowly and safely removed. If we go this line, then I
assume it has to have a DeprecationWarning before we remove it. Sho
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue4492>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
How about the patch attached in the issue11579
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11
Senthil Kumaran added the comment:
No, it is not waiting for you, in fact it is waiting for me to commit
the portion which you have already contributed with some additional
code (DeprecationWarning).
But this bug does not end up here as there are other primitives which
may need cleanup and
Senthil Kumaran added the comment:
Yes, interesting that Content-Length is returned as a comma separated value of
ints.
Normally, this behavior is observed for other headers which can have multiple
values and urllib appends the subsequent values of the header for e.g.
Content-Type header
Senthil Kumaran added the comment:
Yes, this is good enough for a non-standard behavior.
However, I would be curious to know what curl did. Did it do something
on based on the value or sequence in which it was obtained or just
over-wrote it.
--
title: urlib{,2} returns a pair of
Senthil Kumaran added the comment:
Agree to removing of termios.ISIG so that we get a KeyBoardInterrupt exception
raised when CNTL-C is pressed. Looking at discussion more carefully, it does
not present any security risk.
Should this be fixed in 3.3 only with NEWS detailing the change in
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue11466>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
>> HTTPRedirectHandler behaviour can be changed
>> to only allow redirects to HTTP, HTTPS and FTP by checking the scheme
>> of the location URL (this seems to be a common practise in browsers)
This would be the way to go.
-
Senthil Kumaran added the comment:
>> why doesn't it have a "review" link?
Perhaps, as it is not against the 'default'?
Let's try my hg sandbox link which has a fix committed. Let's see if it gives
the review link.
--
hgrepos: +7
_
Changes by Senthil Kumaran :
Added file: http://bugs.python.org/file21374/c6a4d267fe88.diff
___
Python tracker
<http://bugs.python.org/issue11662>
___
___
Python-bug
Changes by Senthil Kumaran :
Added file: http://bugs.python.org/file21376/3c07ea6a176a.diff
___
Python tracker
<http://bugs.python.org/issue11662>
___
___
Python-bug
Senthil Kumaran added the comment:
Here is a more complete patch with tests. Please review this. Yes, it is
against the default branch (3.x codeline). We can backport this behavior to 2.x
codeline.
I have raised an URLError exception when the direct to invalid_schemes is
detected.
Also
Senthil Kumaran added the comment:
On Thu, Mar 24, 2011 at 05:32:42PM +, Guido van Rossum wrote:
> I still don't think we should raise URLError on the bad redirect; we
> should treat it the same as a missing URI/Location header, and it
> will raise HTTPError.
Agreed.
Changes by Senthil Kumaran :
Added file: http://bugs.python.org/file21388/ff71c4416cde.diff
___
Python tracker
<http://bugs.python.org/issue11662>
___
___
Python-bug
Senthil Kumaran added the comment:
+1 to removing of the spurious egg-info files. For the folks who are not aware
of the multitude 'packaging terms', egg-info files are the first step towards
the path leading to more confusion.
So cleaning up would be definitely better in th
+1 to the counter argument that "Unexpected Skips should not be marked as
failures".
Also, I like the following proposal of giving better messages on skips
useful.
On Sat, Mar 26, 2011 at 07:53:34AM +, Ezio Melotti wrote:
> It's also possible to provide better skip messages, e.g.:
> -test_wi
Senthil Kumaran added the comment:
I wonder if this is CentOS and RHEL specific. Unable to reproduce this on
Ubuntu.
--
nosy: +dmalcolm, orsenthil
___
Python tracker
<http://bugs.python.org/issue10
501 - 600 of 2044 matches
Mail list logo