[issue10192] 'from urllib.parse import *' does not import urlencode function

2010-10-25 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in revision 85837. -- assignee: -> orsenthil nosy: +orsenthil resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue10226] urlparse example is wrong

2010-10-29 Thread Senthil Kumaran
Senthil Kumaran added the comment: - Otherwise, it is not possible to distinguish between netloc and path - components, and would the indistinguishable component would be classified - as the path as in a relative URL. + If the netloc does not start with '//', the mod

[issue8555] tkinter doesn't see _tkinter

2010-10-31 Thread Senthil Kumaran
Senthil Kumaran added the comment: Not sure, why changed the resolution. It is an invalid bug report. You could have resolved it by a little research or by asking around. -- resolution: fixed -> invalid ___ Python tracker <http://bugs.pyth

[issue10307] compile error in readline.c

2010-11-03 Thread Senthil Kumaran
New submission from Senthil Kumaran : /py3k/Modules/readline.c: In function flex_complete: /py3k/Modules/readline.c:877: error: on_completion undeclared (first use in this function) -- assignee: orsenthil messages: 120376 nosy: orsenthil priority: normal severity: normal status: open

[issue10307] compile error in readline.c

2010-11-03 Thread Senthil Kumaran
Senthil Kumaran added the comment: The problem was in py3k, due to a minor overlook in r85680. Fixed in r86153. -- components: +Build resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.2 _

[issue10205] Can't have two tags with the same QName

2010-11-05 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue10205> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6269] threading documentation makes no mention of the GIL

2010-11-05 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue6269> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10226] urlparse example is wrong

2010-11-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed the wordings in r86296(py3k), r86297(release31-maint) and r86298(release27-maint). David, for the examples you mentioned, the first one's parsing logic follows the explanation that is written. It is correct. For the second example, the port valu

[issue10303] small inconsistency in tutorial

2010-11-07 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r86310. print was used in some examples following its mention, so a simple introduction to it was okay. It is introduced properly further down in the tutorial. -- nosy: +orsenthil resolution: -> fixed stage: needs patch -> com

[issue10205] Can't have two tags with the same QName

2010-11-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r86348 for py3k and r86349 for release27-maint. In release31-maint, I see that there are missing features, like support for xml_declaration and default_namespace, which are however available in release27-maint. This is not a desirable scenario and

[issue10318] "make altinstall" installs many files with incorrect shebangs

2010-11-08 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue10318> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10319] SocketServer.TCPServer truncates responses on close (in some situations)

2010-11-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: jrodman2, in the socketserver TCPServer code you will find that shutdown_request does a socket.SHUT_WR before calling close_request. If the application or code in your description used shutdown_request, instead of close_request would you still require the

[issue10359] ISO C cleanup

2010-11-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hallvard, if it going be a rather huge diff, you may make it available at http://bugs.python.org/review, so that it is easy for review. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue10

[issue10245] Fix resource warnings in test_telnetlib

2010-11-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: conn.close() was done in the finally method in r86228 by brian.curtin. The other change in your patch in very minor space addition after comma. We can leave it to place along with some other code change. -- nosy: +brian.curtin, orsenthil resolution

[issue10324] Modules/binascii.c: simplify expressions

2010-11-09 Thread Senthil Kumaran
Senthil Kumaran added the comment: At first, I was worried if this simplification would cause any harm to readability of the algorithm. Fortunately, it didn't. Committed in r86357. -- nosy: +orsenthil resolution: -> fixed stage: commit review -> committed/rejected s

[issue10377] cProfile incorrectly labels its output

2010-11-12 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Tue, Nov 09, 2010 at 07:15:57PM +, Jean-Paul Calderone wrote: > >>> cProfile.run("import time; time.sleep(1)") > 4 function calls in 1.012 CPU seconds > > It is not the case that the profiled code uses >1 CP

[issue10387] ConfigParser's getboolean method is broken

2010-11-12 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Fri, Nov 12, 2010 at 12:35:49AM +, Łukasz Langa wrote: > This is unfortunately a backwards compatibility concern. Originally > it wasn't made so that set() converts to string or accepts only > strings and when the developers realized th

[issue10205] Can't have two tags with the same QName

2010-11-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks for the explanation, Éric. That helps. - Backported QName tests in r86447 to release31-maint. As for the logic of the fix, it follows like this: If True and False: #Doesn't go here elif True: # Goes here vs if True: # Goes here if

[issue10387] ConfigParser's getboolean method is broken

2010-11-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Sat, Nov 13, 2010 at 01:20:45AM +, Łukasz Langa wrote: > You think wrong. Try it. Okay, I get it. Coercing would be a bad idea in RawConfigParser because there are cases where get method can have raw=True and coercing would break those behaviors.

[issue1520831] urrlib2 max_redirections=0 disables redirects

2010-11-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: This is an invalid bug report at the moment. In fact, aged. The redirection depends upon max_redirections and max_repeats together. Setting it to 0 explicitly (inside the code) is not a good use case under any condition. -- nosy: -BreamoreBoy

[issue5111] httplib: wrong Host header when connecting to IPv6 litteral URL

2010-11-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in r86450 (py3k). Will be back porting shortly. -- resolution: -> fixed stage: -> committed/rejected ___ Python tracker <http://bugs.python.org/

[issue10116] Sporadic failures in test_urllibnet

2010-11-13 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- status: pending -> closed ___ Python tracker <http://bugs.python.org/issue10116> ___ ___ Python-bugs-list mailing list Unsubscri

[issue5111] httplib: wrong Host header when connecting to IPv6 litteral URL

2010-11-13 Thread Senthil Kumaran
Senthil Kumaran added the comment: r86461 (release31-maint) r86462 (release27-maint) -- status: open -> closed ___ Python tracker <http://bugs.python.org/iss

[issue9991] xmlrpc client ssl check faulty

2010-11-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: That's sad. The fix is very simple. We shall have it before 3.2 alpha4 or beta1. -- ___ Python tracker <http://bugs.python.org/i

[issue1520831] urrlib2 max_redirections=0 disables redirects

2010-11-15 Thread Senthil Kumaran
Senthil Kumaran added the comment: John, I was trying to find out what does rfc say on "Client Ignoring the 30X REDIRECT headers". There is no point made on Client's trying to ignore it, instead it said that it should follow the Redirect and must not endlessly loop. Setting ma

[issue10425] xmlrpclib support for None isn't compliant with XMLRPC

2010-11-15 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue10425> ___ ___ Python-bugs-list mai

[issue1028088] Cookies without values are silently ignored (by design?)

2010-11-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Revisiting this issue. - Cookie: should contain name=value pairs - Set-Cookie: header can contain a single word like 'secure' The current design is along the same lines only. In the original comment, the request had asked to document the behavior

[issue10394] subprocess Popen deadlock

2010-11-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Did you attach the correct files? You mention about two programs in the description, but you have attached only one file 'deadlock.py'. Also, it does not fail on Python 2.7.1. Please try it on the latest codeline from release27-maint too. -

[issue10399] AST Optimization: inlining of function calls

2010-11-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue10399> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10403] Use "member" consistently

2010-11-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: It is 'attributes' instead of term 'members'. The term 'method' when it denotes methods can be left as such. -- assignee: d...@python -> orsenthil nosy: +orsenthil ___ Python

[issue10403] Use "member" consistently

2010-11-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- stage: -> needs patch type: -> behavior versions: +Python 2.7, Python 3.1, Python 3.2 ___ Python tracker <http://bugs.python.org/i

[issue10425] xmlrpclib support for None isn't compliant with XMLRPC

2010-11-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Tue, Nov 16, 2010 at 11:32:03AM +, Adam Bielański wrote: > just accept ex:nil as well as nil and not try to analyze namespaces at all. But even that seems specific to Java/ Apache Extension. If it is, then it might go in as part of issue8

[issue10432] concurrent.futures.as_completed() spins waiting for futures to complete

2010-11-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> bquinlan nosy: +bquinlan stage: -> patch review versions: -Python 3.3 ___ Python tracker <http://bugs.python.org/i

[issue10425] xmlrpclib support for None isn't compliant with XMLRPC

2010-11-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> duplicate stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue10228] Refleak run of test_dbm fails when several dbm modules are available

2011-02-25 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in revision 88631 -- nosy: +orsenthil resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue10784] os.getpriority() and os.setpriority()

2011-02-25 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Sat, Feb 26, 2011 at 12:11:10AM +, Antoine Pitrou wrote: > if err.errno != errno.EACCESS: > AttributeError: 'module' object has no attribute 'EACCESS' That was one 'S' too many. Should be errno.EACCES Looks

[issue10228] Refleak run of test_dbm fails when several dbm modules are available

2011-02-25 Thread Senthil Kumaran
Senthil Kumaran added the comment: Done in r88634. -- ___ Python tracker <http://bugs.python.org/issue10228> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

2011-02-26 Thread Senthil Kumaran
Senthil Kumaran added the comment: I fail to see the bug here. Python's getpass.py is mimicing the behavior of getp

Re: [issue11283] incorrect pattern in the re module docs for conditional regex

2011-02-27 Thread Senthil Kumaran
On Tue, Feb 22, 2011 at 08:48:20AM +, wesley chun wrote: > > The fix is to add the end char '$' to the regex to get all 4 working: Better would be a regex for white-space '\s' which would achieve the same purpose plus it would satisfy the other requirement for using it with search and can do

[issue11283] incorrect pattern in the re module docs for conditional regex

2011-02-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thinking about the regex pattern again. The example given is not really wrong. It does what it claims to match, that is '' and 'u...@example.com' and reject ' kind of string. Also, this is not an example of validating an email ad

[issue5542] Socket is closed prematurely in httplib, if server sends response before request body has been sent

2011-02-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Guy, if the issue you describe in relevant to py3.x or 2.7, can you open a new issue? -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue5

[issue11301] cookielib.LWPCookieJar.save() doesn't save cookies

2011-02-28 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- resolution: -> invalid stage: -> committed/rejected ___ Python tracker <http://bugs.python.org/issue11301> ___ ___ Pyth

Re: [issue11306] mailbox should test for errno.EROFS

2011-02-28 Thread Senthil Kumaran
On Thu, Feb 24, 2011 at 03:07:10PM +, R. David Murray wrote: > Creating a test for this may not be practical :( Then should we just go ahead with this change as it seems reasonable one. -elif e.errno == errno.EACCES:

[issue11375] urllib2 over SOCKS doesn't use proxy for DNS

2011-03-02 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11375> ___ ___ Python-bugs-list mai

[issue11448] docs for HTTPConnection.set_tunnel are ambiguous

2011-03-08 Thread Senthil Kumaran
Senthil Kumaran added the comment: I am not able to understand what you mean by 'endpoint'. Actually, when using tunnels people understand that they often 'tunnel through' the proxy server and here is an example code from the tests which is going to use the se

[issue11009] urllib.splituser is not documented

2011-03-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: splituser is an internal API. It has never been exposed through Docs anytime and there are good reasons for that too. We never want internal helper functions (even tough they don't startwith _) be exposed through docs as it may clutter the API Document

Re: [issue11465] Set documentation: Link to wikipedia

2011-03-11 Thread Senthil Kumaran
Only for relatively uncommon concepts like "Moving Average" and some other cases used in collections module hyperlink to a general article helps. Set theory is a commonly understood concept and link to wikipedia article may not be required. It can be left to the user to find out more, if they want

[issue11009] urllib.splituser is not documented

2011-03-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: Sandro, I don't think is a required. Those functions serve the purpose of making the module code modular. They are helper functions for the module and are not really useful outside of it, when used standalone. Think about , splituser, splitpath, splitpor

[issue11467] urlparse.urlsplit() regression for paths consisting of digits

2011-03-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: What kind of url is 'javascript:123' and how do you (/ we) say that python2.6 behavior was correct? -- assignee: -> orsenthil keywords: +patch ___ Python tracker <http://bugs.pytho

[issue11283] incorrect pattern in the re module docs for conditional regex

2011-03-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: Okay, fixed in all relevant branches. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue11463] IncompleteRead: IncompleteRead(168 bytes read)

2011-03-11 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, please ensure that server is returning a proper HTTP response. Test it against browser or curl and see if they work. If they work, then it needs to be investigated as why 'http.client' is not working. -- assignee: -> orsenthil nos

[issue11467] urlparse.urlsplit() regression for paths consisting of digits

2011-03-14 Thread Senthil Kumaran
Senthil Kumaran added the comment: Santoso, Quick review comments: 1. The patch looks good. 2. I would use a temporary 'throw-away' variable instead of _, but don't bother to change it, before committing I shall take care. 3. Important - Did you find any regression with the

[issue11579] python 2.5 does not build from hg - looks for subversion keywords

2011-03-16 Thread Senthil Kumaran
New submission from Senthil Kumaran : Here is the make log and a patch to ignore looking for subversion keyword and assume some defaults (same is done in 2.6 + higher). -- components: Installation files: make-error.log messages: 131216 nosy: loewis, orsenthil priority: normal severity

[issue11579] python 2.5 does not build from hg - looks for subversion keywords

2011-03-16 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- keywords: +patch Added file: http://bugs.python.org/file21260/ignore_subversion_keywords.diff ___ Python tracker <http://bugs.python.org/issue11

[issue11567] http.server error message format

2011-03-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: go ahead. please submit a patch. -- assignee: -> orsenthil nosy: +orsenthil type: performance -> behavior versions: +Python 3.3 ___ Python tracker <http://bugs.python.org/i

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-16 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, go ahead with the patch. -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11563> ___ ___ Python-bug

[issue11581] buildbot error when pushing to 2.5 branch?

2011-03-17 Thread Senthil Kumaran
New submission from Senthil Kumaran : When pushed a change to 2.5 branch, I got an error, which I think has to do with buildbot not available for 2.5 codeline. It asked me to notify the tracker and here it is. remote: state = method(*args, **kw) remote: File "/data/buildbot/m

[issue11442] list_directory() in SimpleHTTPServer.py should add charset=... to Content-type header

2011-03-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in all the relevant code lines. -- assignee: -> orsenthil priority: release blocker -> resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python

[issue11567] http.server error message format

2011-03-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: Fixed in 3.3 and 3.2. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue11581] buildbot error when pushing to 2.5 branch?

2011-03-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Thu, Mar 17, 2011 at 05:15:09PM +, Skip Montanaro wrote: > Should you be pushing anything to 2.5? I think, there is a security release planned in 2011. Also, see issue11442 which was the specific case for pushing to

[issue11579] python 2.5 does not build from hg - looks for subversion keywords

2011-03-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Thu, Mar 17, 2011 at 05:16:43PM +, Skip Montanaro wrote: > See Issue 11439. Yes, that is relevant and applies probably to code in default and other branches. Just in case, this corner case in 2.5 does not overlooked (because it does not happen in ot

[issue11581] buildbot error when pushing to 2.5 branch?

2011-03-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: issue11442 is a security issue and I pushed to 2.5 for fixing that and encountered this problem with buildbot. I think, we may/may not fix this (buildbot issue) depending upon when the 2.5 release may be planned

[issue11581] buildbot error when pushing to 2.5 branch?

2011-03-17 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +loewis ___ Python tracker <http://bugs.python.org/issue11581> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10486] http.server doesn't set all CGI environment variables

2011-03-17 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <http://bugs.python.org/issue10486> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8450] httplib: false BadStatusLine() raised

2011-03-17 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <http://bugs.python.org/issue8450> ___ ___ Python-bugs-list mailing list Unsubscri

[issue10860] Handle empty port after port delimiter in httplib

2011-03-17 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <http://bugs.python.org/issue10860> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8704] cgitb sends a bogus HTTP header if the app crashes before finishing headers

2011-03-17 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue8704> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-17 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Thu, Mar 17, 2011 at 06:30:51PM +, Jeff McNeil wrote: > I went down the same path as AbstractHTTPHandler and added a Connection: > close header. This is fine for the moment, tough I wish that the TODO pending in urllib.request with H

[issue11575] addresses.txt file leaks into search engines

2011-03-18 Thread Senthil Kumaran
Senthil Kumaran added the comment: Why should we have this file served on the web itself? Cannot it be on server outside of www ( or any directory which is getting served). I would vote for this. -- nosy: +orsenthil ___ Python tracker <h

[issue11581] buildbot error when pushing to 2.5 branch?

2011-03-18 Thread Senthil Kumaran
Senthil Kumaran added the comment: David, from you message I understand that Martin is planning to release 2.5 via svn. If that is the case, whatever was pushed for security fix to hg can remain as such and so that those can be exported to svn. The bugs related to buildbot and svn keyword

[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-18 Thread Senthil Kumaran
Senthil Kumaran added the comment: Significant patch. Thanks. I looked at the review too. For the Context Manager part, don't club it along with this one. We need to test this thoroughly, after this is in shape, that can be addressed. -- ___ P

[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-18 Thread Senthil Kumaran
Senthil Kumaran added the comment: Changing the description is a minor update. The term 'URL access module' seems fine. -- ___ Python tracker <http://bugs.python.o

[issue11463] IncompleteRead: IncompleteRead(168 bytes read)

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Since the reporter did not get back with more details (testing against curl or a HEAD output to eliminate server issues), I am closing this issue. -- resolution: -> invalid status: pending -> closed ___

[issue11609] urllib-related buildbot failures

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Buildbots pass the tests again. -- priority: release blocker -> resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue9740] Support for HTTP 1.1 persistent connections throughout the standard library

2011-03-19 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <http://bugs.python.org/issue9740> ___ ___ Python-bugs-list mailing list Unsubscri

[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

2011-03-19 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil ___ Python tracker <http://bugs.python.org/issue3566> ___ ___ Python-bugs-list mailing list Unsubscri

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Victor - Issue9740 and Issue3566 talks about the need to have persistent connection. 3.3 would be a good target to have this feature in. Shall add the NEWS entry. Nadeen Wadwa - Thanks for your patch. I committed the fix as part of another bug (Issue3566

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- Removed message: http://bugs.python.org/msg131456 ___ Python tracker <http://bugs.python.org/issue11563> ___ ___ Python-bugs-list m

[issue11563] test_urllibnet is triggering a ResourceWarning

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Victor - Issue9740 and Issue3566 talks about the need to have persistent connection. 3.3 would be a good target to have this feature in. Shall add the NEWS entry. Nadeem Vawda - Thanks for your patch. I committed the fix as part of another bug (Issue3566

[issue10883] urllib: socket is not closed explicitly

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: I saw the partial fix suggested by the patch, but for some reason I did not see ResourceWarning being shutup. Let's look at this again. The warnings are all from the (old) ftp portion of the code.. -- ___ P

[issue11567] http.server error message format

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Ezio Melotti wrote: > This is just nitpicking, but serving XHTML as text/html is wrong. While, I thought this statement is correct and expected the Internet media-type should be something else (application/xhtml+xml), but as per w3c, it is not wrong

[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-19 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks again. Agree to use of returning the block size to the returnhook callable. But this is going be a deviation from the existing behavior which was present to inform the user at regular intervals and did not bother to provide any 'progressive

[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-20 Thread Senthil Kumaran
Senthil Kumaran added the comment: Antoine Pitrou wrote: > Can you clarify the issue? URLopener which is an old class from the merge of urllib and urllib2 and it can be slowly and safely removed. If we go this line, then I assume it has to have a DeprecationWarning before we remove it. Sho

[issue4492] httplib code thinks it closes connection, but does not

2011-03-20 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue4492> ___ ___ Python-bugs-list mai

[issue11421] Subversion keywords missing on 2.5 checkout

2011-03-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: How about the patch attached in the issue11579 -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11

[issue10050] urllib.request still has old 2.x urllib primitives

2011-03-21 Thread Senthil Kumaran
Senthil Kumaran added the comment: No, it is not waiting for you, in fact it is waiting for me to commit the portion which you have already contributed with some additional code (DeprecationWarning). But this bug does not end up here as there are other primitives which may need cleanup and

[issue11652] urlib{, 2} returns a pair of integers as the content-length value

2011-03-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, interesting that Content-Length is returned as a comma separated value of ints. Normally, this behavior is observed for other headers which can have multiple values and urllib appends the subsequent values of the header for e.g. Content-Type header

[issue11652] urlib{, 2} returns a pair of integers as the content-length value

2011-03-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Yes, this is good enough for a non-standard behavior. However, I would be curious to know what curl did. Did it do something on based on the value or sequence in which it was obtained or just over-wrote it. -- title: urlib{,2} returns a pair of

[issue11236] getpass.getpass does not respond to ctrl-c or ctrl-z

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: Agree to removing of termios.ISIG so that we get a KeyBoardInterrupt exception raised when CNTL-C is pressed. Looking at discussion more carefully, it does not present any security risk. Should this be fixed in 3.3 only with NEWS detailing the change in

[issue11466] getpass.getpass doesn't close tty file

2011-03-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : -- assignee: -> orsenthil nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue11466> ___ ___ Python-bugs-list mai

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: >> HTTPRedirectHandler behaviour can be changed >> to only allow redirects to HTTP, HTTPS and FTP by checking the scheme >> of the location URL (this seems to be a common practise in browsers) This would be the way to go. -

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: >> why doesn't it have a "review" link? Perhaps, as it is not against the 'default'? Let's try my hg sandbox link which has a fix committed. Let's see if it gives the review link. -- hgrepos: +7 _

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : Added file: http://bugs.python.org/file21374/c6a4d267fe88.diff ___ Python tracker <http://bugs.python.org/issue11662> ___ ___ Python-bug

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : Added file: http://bugs.python.org/file21376/3c07ea6a176a.diff ___ Python tracker <http://bugs.python.org/issue11662> ___ ___ Python-bug

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: Here is a more complete patch with tests. Please review this. Yes, it is against the default branch (3.x codeline). We can backport this behavior to 2.x codeline. I have raised an URLError exception when the direct to invalid_schemes is detected. Also

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Senthil Kumaran added the comment: On Thu, Mar 24, 2011 at 05:32:42PM +, Guido van Rossum wrote: > I still don't think we should raise URLError on the bad redirect; we > should treat it the same as a missing URI/Location header, and it > will raise HTTPError. Agreed.

[issue11662] Redirect vulnerability in urllib/urllib2

2011-03-24 Thread Senthil Kumaran
Changes by Senthil Kumaran : Added file: http://bugs.python.org/file21388/ff71c4416cde.diff ___ Python tracker <http://bugs.python.org/issue11662> ___ ___ Python-bug

[issue10645] Remove egg-info files in stdlib

2011-03-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: +1 to removing of the spurious egg-info files. For the folks who are not aware of the multitude 'packaging terms', egg-info files are the first step towards the path leading to more confusion. So cleaning up would be definitely better in th

Re: [issue10966] eliminate use of ImportError implicitly representing SkipTest

2011-03-30 Thread Senthil Kumaran
+1 to the counter argument that "Unexpected Skips should not be marked as failures". Also, I like the following proposal of giving better messages on skips useful. On Sat, Mar 26, 2011 at 07:53:34AM +, Ezio Melotti wrote: > It's also possible to provide better skip messages, e.g.: > -test_wi

[issue10632] multiprocessing generates a fatal error

2011-03-30 Thread Senthil Kumaran
Senthil Kumaran added the comment: I wonder if this is CentOS and RHEL specific. Unable to reproduce this on Ubuntu. -- nosy: +dmalcolm, orsenthil ___ Python tracker <http://bugs.python.org/issue10

<    1   2   3   4   5   6   7   8   9   10   >