Senthil Kumaran added the comment:
@martin, the patch looks good to me. Please go ahead and commit this.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue29
New submission from Senthil Kumaran:
In the attached patch, I updated the copyright year to 2017 at places it was
mentioned until 2016.
There was a suggestion that we remove the copyright line of Python Software
Foundation from module headers since the code is already covered 1) by top
level
Changes by Senthil Kumaran :
--
nosy: +lemburg
___
Python tracker
<http://bugs.python.org/issue29555>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thank you for the patch, Dave.
Following the language style of rest of the docs, check_same_thread, should be
explained in a passive voice.
Also, mentioning the version requirement at this place, does not seem suitable
to me. When we provide this feature
Senthil Kumaran added the comment:
Thanks for the patch, Nathan.
--
nosy: +orsenthil
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
We should be able to simplify this further based on the comments in the review
for the first patch.
Please find my patch issue27113-rev2.patch attached.
--
Added file: http://bugs.python.org/file43053/issue27113-rev2.patch
Senthil Kumaran added the comment:
Thanks for the review. Made it both singular in the updated patch.
* As for why the default value was chosen to be to True, I think, the reason is
pysqlite, from sqlite3 module was derived, did not support this option when it
was introduced. I still do not
Senthil Kumaran added the comment:
Dave, your patch looks good to me.
Did you see the comment from Trevor on your first patch?
>> According to the sqlite docs (http://www.sqlite.org/threadsafe.html), the
default mode is 'serialized', which does the necessary locking for th
Senthil Kumaran added the comment:
Thanks Angad and Anatoly for the patches discussions.
Thank you Berker for review.
Made the changes in all active versions of python. Let this issue reset in
peace.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -&g
Senthil Kumaran added the comment:
Thanks for the explanation, Dave. Completely agree with those points. Let's go
ahead with the latest patch.
--
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
Thanks for your contribution. It's now documented.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Senthil Kumaran added the comment:
Thanks for the patch, Jelle Zijlstra.
We don't have warnings in Doc/faq/programming.rst now, and this issue was
specific to fix the doctests for it. I find it complete. Closing this issue.
--
nosy: +orsenthil
resolution: -> fix
Senthil Kumaran added the comment:
Thanks for your contribution, Jelle.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Addressed the problem with the previous commit.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Unfortunately no. 3.4 is only in security fixes mode and this doesn't qualify
as a security fix. Usually the bug fixes and feature additions are incentives
for developers to upgrade their python cod
Senthil Kumaran added the comment:
Hi Adam,
Thanks for the patch. I reviewed it. It's a good change. As you mentioned in
the comments, making both HTML and Text formatter behave consistently and skip,
underscores, callables, _callables will be a good idea. Please include change.
Als
Senthil Kumaran added the comment:
Марк, it's documented now. Thank you for the patch.
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Senthil Kumaran added the comment:
Evelyn,
Thanks for digging in.
The code for time2netscape has been in the current form since it was originally
introduced in 2004. If this is a bug, then it has been present since the
introduction of the module. If anyone is using this module, they are
Senthil Kumaran added the comment:
Here is the patch that fixes this issue. Patch includes unittests and NEWS
entry.
--
assignee: -> orsenthil
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file43659/issue27466
Senthil Kumaran added the comment:
Fixed the redundant import as pointed by Evelyn on IRC.
--
Added file: http://bugs.python.org/file43666/issue27466-v2.patch
___
Python tracker
<http://bugs.python.org/issue27
Senthil Kumaran added the comment:
This is fixed in all versions of python. Thanks for the review.
--
resolution: -> fixed
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python.or
New submission from Senthil Kumaran:
PULL_REQUEST_TEMPLATE will discourage pull requests in github repo and will
instead point to python hg repo and dev guide. This will be removed after the
hg to git migration is complete.
--
assignee: orsenthil
messages: 270124
nosy: orsenthil
Senthil Kumaran added the comment:
Context: https://mail.python.org/pipermail/core-workflow/2016-July/000616.html
https://github.com/python/cpython/pull/41
--
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue27
Senthil Kumaran added the comment:
Here is the patch.
--
keywords: +patch
Added file: http://bugs.python.org/file43677/issue2476.patch
___
Python tracker
<http://bugs.python.org/issue27
Senthil Kumaran added the comment:
Thanks. Addressed the review comments. Committing this.
--
Added file: http://bugs.python.org/file43679/issue27476-v2.patch
___
Python tracker
<http://bugs.python.org/issue27
Senthil Kumaran added the comment:
Please use stackoverflow.com or python-tu...@python.org for assistance. This
site is for developers of python.
--
nosy: +orsenthil
resolution: -> rejected
stage: -> resolved
status: open -> closed
_
Senthil Kumaran added the comment:
I am unsure of the change too. I am willing to close this report as .port
attribute is already documented.
--
resolution: -> not a bug
stage: needs patch -> resolved
status: pending -> closed
___
Pytho
Senthil Kumaran added the comment:
I think that we use encourage everyone to use the higher level functions like
urlparse() or urlsplit() and then get the .port from the named tuple result.
Two things to do.
1. Update that Note the documentation which states a false statement that those
Senthil Kumaran added the comment:
Thanks for this patch. The CVE number assigned to python - CVE-2016-1000110.
There is redundancy in /Doc/library/urllib.request.rst change where the same
paragraph is repeated twice. See if you can have it at a single location as a
`Note` and reference it
Senthil Kumaran added the comment:
The patch looks good to me. I am checking this in.
--
___
Python tracker
<http://bugs.python.org/issue27568>
___
___
Python-bug
Senthil Kumaran added the comment:
For 3.3, 3.4 it seems reasonable to backport changes from issue26804 and then
apply this patch. I will do this today.
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
This is also committed in 2.7 branch in ba915d561667.
This is committed in all active versions(2.7, 3.5, 3.6) and also versions which
receive security updates (3.3 and 3.4).
This issue is resolved. Thank you for the patch, Rémi.
(In msg271688, I pondered
Changes by Senthil Kumaran :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue27466>
___
___
Python-bugs-list mailing list
Un
Senthil Kumaran added the comment:
Hi Hans-Peter,
In 3.3 (95b09ccc8a3e) and 3.4 (3c19023c9fec) the change completely removes any
variant of http_proxy if REQUEST_METHOD is set. The only way to have http
based proxy in cgi environment by using ProxyHandler method. This is solution
introduced
Senthil Kumaran added the comment:
(Assigning this to Martin)
I really like this patch, and I support that we land this before the feature
freeze of 3.6.
As along as the API interface to users is simple, the changes internal to
_send_output should not be a concern. Yeah, I agree that
Senthil Kumaran added the comment:
Thank you and great work everyone involved with this change. Regards.
--
___
Python tracker
<http://bugs.python.org/issue12
Senthil Kumaran added the comment:
Thanks for the bug report, Reuben. I verified that this is indeed a bug and
should be fixed in all versions. Thanks for the patch too, would you like to
enhance it with tests? GeneralTests in test_telnetlib.py support timeout and
you could that exercise
Senthil Kumaran added the comment:
@gps: looks like it is. For changeset: 78129:de229dde486b for Issue #14635
--
___
Python tracker
<http://bugs.python.org/issue17
Serhiy: The patch LGTM.
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
Senthil Kumaran added the comment:
The doc change looks good to me. I am adding Terry and Ezio to see if they have
any comments on wordings in the doc. If not, I can commit this change. I think
that this is helpful.
--
nosy: +ezio.melotti, orsenthil, terry.reedy
Senthil Kumaran added the comment:
Chris: The patch is for the docs. the test code I believe, is for
reference. It would be to run it on different OS and verify the
documentation matches the behavior.I am okay with more than one person
verifying this and I shall do on OS'es I
Applying this patch - I tried this hypothetical test.
$ ./python.exe -m timeit -s "import urllib.parse; x='a%20' * 10"
"urllib.parse.unquote(x)"
10 loops, best of 3: 205 msec per loop
Without the patch, the above test will run for minutes!
This creates a significant difference for extremely
Senthil Kumaran added the comment:
I wrongly minutes. Here is actual data of execution speeds. There is
magnitude of difference (almost 130x faster). Measured on macbook pro
with 2 cores and 4 Gig mem.
Before Patch:
$ ./python.exe -m timeit -s "import urllib.parse; x='a%20
Senthil Kumaran added the comment:
let me check that.
--
___
Python tracker
<http://bugs.python.org/issue979407>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
> Serhiy Storchaka added the comment:
>>
>> + append = res.append
>>
>> And then use 'append'?
>
> This speed up unquote_to_bytes by 15%.
Thanks for the response. In fact, writing the whole _hextobyte
verbatim would
Senthil Kumaran added the comment:
I am noticing this one late. Sorry for that.
I agree that this is docs issue and I would like to fix it in this way.
Give the doc example as:
>>> urlparse('www.cwi.nl/%7Eguido/Python.html')
ParseResult(scheme='', netloc=
Senthil Kumaran added the comment:
I have fixed the docs issue. Thanks for the report and following up.
--
assignee: -> orsenthil
keywords: -buildbot
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
type:
Senthil Kumaran added the comment:
Yes, feature complete of 1.1 will be a start. :(
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17
New submission from Senthil Kumaran:
I think an explicit HTTP put request example in the docs may help. Previously,
I thought the POST example was enough as PUT is very similar, but given the
folks are looking for it, an example of how to do a PUT request using httplib
may be helpful.
Here
Senthil Kumaran added the comment:
Ezio. yes in 3.3 onwards it should be done in urllib.request. I was having 2.7
docs in my mind, but I ended up writing for latest with the intention to
backport. I have updated the patch to include both ways, while backporting to
2.7 and 3.2, plan to include
Senthil Kumaran added the comment:
I thought this was fixed (recently). Shall look again. Having the tests is the
only hard part here.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17
Senthil Kumaran added the comment:
David & Karl -
I had been thinking on this. My understanding of the RFC implies that "server"
should reject when the headers contain the whitespace and I had a little
concern if the client library should feel free to cleanup a wrongly set
hea
Senthil Kumaran added the comment:
Looks like curl is sending the headers without removing spaces.
Check Raw here link here. (The link would probably be online a week)
http://requestb.in/1kfodmj1?inspect
$ curl --header "X-MyHeader: 123" http://requestb.in/1kfodmj1
ok
$ curl --h
Senthil Kumaran added the comment:
Oh wow. Thank you very much Karl for the care. I am having the same
inclination are you too, but determining a definite answer is really
helpful before going ahead into making the change.
--
___
Python tracker
Senthil Kumaran added the comment:
The curl example also suggest to think about "pragamatic de-facto"
stuff. Will removing the spaces cause any breakage? I can say for
sure. But if someone can think of it, it would be good for at lea
Senthil Kumaran added the comment:
Karl,
Ack. The patch looks good. I shall go about with testing + committing this..
--
___
Python tracker
<http://bugs.python.org/issue12
Senthil Kumaran added the comment:
Ronald:
Sorry for the delay in response. I was referring to this:
https://github.com/capistrano/capistrano/issues/250#issuecomment-8055991
" Mountain Lion no longer includes OpenSSL as it uses a different SSL
implementation. So, you need to have RVM in
Senthil Kumaran added the comment:
Karl - thanks for your telnet debugging session output. Helped realized the
problem better. So I had been thinking that sending message is okay. But had
not realized that same variable name was used and was causing problem.
I have gone ahead with the fix for
Senthil Kumaran added the comment:
There is a test failure. which leads me to believe that "Error message" may
probably be relied upon by some applications.
FAIL: test_header_length (test.test_httpservers.BaseHTTPRequestHandl
Senthil Kumaran added the comment:
Karl, I am getting back to this. Thanks for your review comments on the patch.
1. Agree with your explanation on HTTP PUT. I shall modify the comment.
2. I think, it is okay to remove the HTTP PUT server example. I wrote it for
test purposes and I think, it
Senthil Kumaran added the comment:
Thanks for the review, Karl. Made the doc changes in all codelines.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Serhiy - Is there any technical issue that is holding up this patch? (I dont
see any). If nothing is holding up and you are busy, I shall go ahead with
committing this one. /cc flox
--
___
Python tracker
<h
Senthil Kumaran added the comment:
I am okay with closing this. If Diego gets back with more info or specifics of
error, we can deal with it.
--
assignee: -> orsenthil
resolution: -> wont fix
stage: -> committed/rejected
status: pending
Senthil Kumaran added the comment:
Karl - I reviewed the patch and like it. Here are some comments.
At first, I did not see the need for both "message" and "explain" in the API
both having almost similar purposes. But given that "explain" is already used
by se
Senthil Kumaran added the comment:
Reviewed the patch - the logic looks okay to me - namely verifying that the
changeset the merged with the next +0.1, 3.x branch or default.
I tested.
2.7 -> push -> success.
3.1 -> push -> fail -> merge to 3.2 -> fail -> merge to defau
Senthil Kumaran added the comment:
I have added explain argument in 3.4, committed changeset 82669:59292f366b53
I think the short message no trailing line assertion should be taken by next.
Either a new issue it if already open or create one just for the purpose.
Thanks Karl for the patch
Senthil Kumaran added the comment:
The last commit 59292f366b53 was for fixing issue12921 and not this. Wrongly
linked.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue1
Senthil Kumaran added the comment:
Sorry for taking long time to respond. full_url has been in the shape it is for
many versions, changing it in backwards incompatible way be do more harm than
good.
- I would be really interested to know why the present form of full_url
presented any
New submission from Senthil Kumaran:
issue10711 Removed the HTTP 0.9 support in 3.2 and deprecated strict and
related params in 3.2. It is time to remove those in 3.4.
--
assignee: orsenthil
messages: 184458
nosy: orsenthil, pitrou
priority: normal
severity: normal
status: open
title
Senthil Kumaran added the comment:
Tested this patch and all tests pass.
--
keywords: +patch
Added file: http://bugs.python.org/file29443/17460.patch
___
Python tracker
<http://bugs.python.org/issue17
Senthil Kumaran added the comment:
I don't know what is the best way to raise an Exception when we are deprecating
an argument.
1. The options are type checking on timeout parameter and then raising an
error. This does not look good to me.
2. Making the rest of the arguments as keyword
Senthil Kumaran added the comment:
Serhiy - Had a chat with Thomas Wouters and realized that just removing the
strict is a best way to go. We have been issuing Deprecation warning for 2
releases now and it should have given enough time for folks to make the changes
Changes by Senthil Kumaran :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17460>
___
___
Python-bugs-list
Senthil Kumaran added the comment:
Sorry, I went ahead with committing it. But let's continue the discussion.
Leaving the parameter when we have said it will be deprecated may be a bad
practice. It has remained unused for 2 versions now when the deprecation
warning was added.
The opt
Senthil Kumaran added the comment:
And getcode is documented all 3.x documentation now.
URLOpener (and by inheritance) raise DeprecationWarning since 3.3. I believe,
when class becomes deprecated and removed, their methods go away too? For the
URLOpener, I would like that to happen as it will
Senthil Kumaran added the comment:
URLOpener (and by inheritance *FancyURLOpener*)
--
___
Python tracker
<http://bugs.python.org/issue12707>
___
___
Python-bug
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue12707>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Thanks Daniel. I will commit it.
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
I think, this issue should have been closed. Or at least be closed now.
1. urlretrieve - change was done.
2. Re: msg172874 - DeprecationWarnings on URLopener have been in place since
3.3. Also in the documentation in the Legacy Interface section, it is
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17472>
___
___
Python-bugs-list mai
Changes by Senthil Kumaran :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10050>
___
___
Python-bugs-list
New submission from Senthil Kumaran:
Number of methods of Request class were deprecated in 3.3 #10050
This issue to to track their removal in 3.4.
--
assignee: orsenthil
messages: 184565
nosy: orsenthil
priority: normal
severity: normal
status: open
title: Remove the deprecated methods
Senthil Kumaran added the comment:
This commit by Ezio in the tests is related (1bcddc0a3765)
--
___
Python tracker
<http://bugs.python.org/issue12707>
___
___
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17483>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Daniel - I could not really get the need for this check.
+>>> msg = str(err)
+>>> str(err.code) in msg and err.msg in msg
The other one was really useful and probably covered the reasonstr.
Thanks for the patch.
--
res
Senthil Kumaran added the comment:
Daniel,
Agree to your point. Sorry that i did not run the coverage before.
I would prefer to do the check this way for readability of the test code and
get to 100% coverage.
>>> expected_errmsg = 'HTTP Error %s: %s'
Senthil Kumaran added the comment:
Avoiding the static test is actually a good idea for Exception "messages", as
there is no guarantee for those to be consistent across revs. But this one is
slightly different in HTTPError str represent and we better be consistent in
this. I dont se
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue5550>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Serhiy - the bad thing IMO would be 'enforcing a new feature in order to save
people from using deprecated feature'.
I am not against the addition of keyword only args for HTTPConnection in 3.4. A
concrete need should be ascertained. Should we ask
Senthil Kumaran added the comment:
Karl - a patch is welcome. BTW, I wanted to search for an already existing and
I think open issue with a patch ( probably written by me) somewhere. We have to
see what's the diff of that issue with new one. I will share that issue in this
id. But yeah,
Senthil Kumaran added the comment:
Making these changes in 2.7
+# Google Chrome/Chromium browsers
+for browser in ("google-chrome", "chrome", "chromium", "chromium-browser"):
+if _iscommand(browser):
+register(browser, No
Senthil Kumaran added the comment:
Are you behind some kind of a proxy? This is seen when you are running the
tests and your interent connection is via proxy (and that is handling this
invalid URL test)
--
nosy: +orsenthil
status: open -> pend
Senthil Kumaran added the comment:
Case insensitive lookup will be more fool-proof than capitalized look up.
I would in favor of going with case insensitive look up than the capitalized
look up one. Because the headers could be added in multiple ways and we cannot
be assured that they are all
Senthil Kumaran added the comment:
RDM's comment:
If that test is run by default, we could change it to only run with -uall.
Then normal users wouldn't see it.
This is a good idea, only to reduce the occurrence of this test_run. Logically,
this may not help at all. I am kind of
Senthil Kumaran added the comment:
Do you have the sample server URL or test script?
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17
Senthil Kumaran added the comment:
I think, this requires triaging in terms of is the feature request still
applicable. Except 100 is sent by httplib and the support for this was added
few years ago, much later then this bug was originally raised.
--
assignee: -> orsent
Senthil Kumaran added the comment:
LGTM - please make the changes in all versions of python.
( I had the same patch pending locally and was waiting for my push->merge cycle
time)
--
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Here is an approach to solve this. I think, going this way is safe. I shall
append with the tests and docs.
--
Added file: http://bugs.python.org/file29610/17483-v1-notests-nodocs.patch
___
Python tracker
<h
Senthil Kumaran added the comment:
Here is the final patch (17483.patch) for this support. I am including Ezio &
David for their review comments before I check this in. Thanks!
--
nosy: +ezio.melotti, r.david.murray
Added file: http://bugs.python.org/file29644/17483.p
1801 - 1900 of 2044 matches
Mail list logo
