Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7044>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
In the Issue7044, the reporter has identified the root cause and
possible fix too.
"
In Python 2.6.3 on Mac OS 10.6.1, there is a bug in
lib/python2.6/urllib.py, line 1367. The variable hostIP is used before
it's defined. You can fix it by addi
Senthil Kumaran added the comment:
I am inclined to reject this issue and close it as:
1) Digest Authentication does with urllib2
2) This is specific with some domain, which does not give enough details
to reproduce it.
3) The report is way old (2005).
If there are any new issues with Digest
Senthil Kumaran added the comment:
On Sun, Oct 04, 2009 at 05:39:26PM +, Preston Landers wrote:
> I'm curious what happened with this issue. It says closed+accepted but
> it doesn't appear to be checked in.
If you see the report, the last message indicates that it is chec
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue1673007>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
I have attached a docs patch against the trunk.
Please provide your review comments. If its okay, I can commit it and
have the information (urllib2.rst) for the Python 3k too.
--
assignee: georg.brandl -> orsenthil
keywords: +patch
nosy: +orsent
Senthil Kumaran added the comment:
Thanks for the comments.
Fixed and committed the changes trunk - 75478.
and merged into
release26-maint - 75479.
py3k - r75476
release31-maint - r75477
--
resolution: accepted -> fixed
status: open ->
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7159>
___
___
Python-bugs-list mai
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue5625>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
getproxies is urllib one of the many helper functions that is not
documented in the Documentation files.
I am not sure of a good resolution for this (leave it as such/Document
it/ make it private). I shall look into the test coverage,usage of the
function and
Senthil Kumaran added the comment:
drukker: I verified your patch. Looks fine for changes made to the
subprocess call.
You mentioned: I've also unified the Unix and Windows portions in
run_cgi. Both now use subprocess."
I don't see it in the patch. Was it that you assum
Senthil Kumaran added the comment:
Committed revision 76208 in trunk. Shall look at the output of windows
buildbots and merge the changes to other codelines.
--
___
Python tracker
<http://bugs.python.org/issue1
Senthil Kumaran added the comment:
Committed revision 76209 - release26-maint
Committed revision 76210 - py3k
Committed revision 76211 - release31-maint
Thanks Derk for the patch.
--
resolution: -> fixed
status: open -> closed
___
Python t
Senthil Kumaran added the comment:
Thanks for the notification. Seems I over looked it. Fixed it with the
changes in 76212 (trunk) and 76213 (release26-maint). py3k did not have
this issue.
--
___
Python tracker
<http://bugs.python.org/issue1
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue4683>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
This issue is Invalid. I am sorry that it had be open for so long
without any explanation.
The order in which the handlers are tried does not depend upon the way
http_error_auth_reqed method is coded, but rather on the handler_order.
In urllib2, we have
Senthil Kumaran added the comment:
Interesting issue. RFC 2617 supports the claim. In RFC 2617, section
3.2.2 The Authorization Request Header, we see that nonce-count is
maintained for each particular nonce value and it can used by the server
to verify the replays.
"""
The
Senthil Kumaran added the comment:
Fixed in r76288 (trunk), r76289 (release26-maint), r76290 (py3k) and
r76291(release31-maint). The issue is fixed. I am keeping it open to
remind of the pending tests (HTTPAuthDigest and nonce value check testcase).
--
resolution: accepted -> fi
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue7291>
___
__
Changes by Senthil Kumaran :
--
nosy: +pveloz
___
Python tracker
<http://bugs.python.org/issue7183>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
This bug is not reproducible in trunk, py3k and is not reproducible in
py26 releases too. I tried to hunt down if any changes in the code-line
from py2.5 to py2.6 had effect on the behavior mention (BadStatusLine) ,
but don't see any.
I am closing th
New submission from Senthil Kumaran :
2.x code:
import urllib2
opener = urllib2.build_opener(urllib2.HTTPHandler(debuglevel=1))
2to3 on this would result in:
import urllib.request, urllib.error, urllib.parse
opener = urllib.request.build_opener(urllib2.HTTPHandler(debuglevel=1))
which is
Changes by Senthil Kumaran :
--
components: +2to3 (2.x to 3.0 conversion tool)
___
Python tracker
<http://bugs.python.org/issue7375>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
tjreedy: The reporter's suggestion seems fine. Prepending a 0 does not
seem to be a good idea.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Terry: Oh, sorry. Now I get what you meant by "Prepend O to output
line". That is, Output line from the fib, as part of the patch. The
changes need to be done at 3 places. Section 3.2, twice in S
Senthil Kumaran added the comment:
Yes, I noticed the issue and found the patch to be good as well.
Unfortunate it was pending for a long time.
Fixed and Committed revision 76464 (trunk).
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: ->
Senthil Kumaran added the comment:
merged to 26-maint in revision 76468 and shall merge in py3k too.
--
___
Python tracker
<http://bugs.python.org/issue1488
Senthil Kumaran added the comment:
fixed r76469 (py3k) and r76470(release31-maint). Closing the issue.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue1
Senthil Kumaran added the comment:
HTTP Proxy Authentication works on Windows and has been verified. Under
the situation of failure, we do not enough details. Closing this bug as
out-of-date as the reporter informed it worked on py2.5 and problem was
with py2.4.
--
assignee
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue6452>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
The timeout propagation fixed with Issue5102.
--
resolution: -> duplicate
___
Python tracker
<http://bugs.python.org/iss
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7118>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
urllib and urllib2, by definition, returns a file-like object which
provides a variety of facilities, most common one being a reading the
object to get the content.
What you are asking for is, to read the content, verify if it matches
the Content-Length
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue5596>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
weak method idea seems interesting. I have not used it anytime yet, and
in this case,it seems okay.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7
Senthil Kumaran added the comment:
On Fri, Dec 11, 2009 at 09:40:40AM +, Kristján Valur Jónsson wrote:
> Is there any chance of getting a weakmethod class into the weakref
> module?
This is a separate feature request on weakref module. It may opened
and discussion carried out
Senthil Kumaran added the comment:
This is working as designed.
--
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Fixed and Committed revision 76908 in the trunk.
--
keywords: -needs review
resolution: accepted -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Fixed through reversions r76908, r76909, r76910, r76911
Thanks for the patch, Tatsuhiro Tsujikawa.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I reviewed the patches attached.
- The patch to add Context Manager support for fileinput.py seems good.
It has docs too.
This discussion did not conclude on the need for Context Manager for
StringIO. With py3k having it, it should be good for py2.7 to
Senthil Kumaran added the comment:
Having a HEAD request for urllib2 might be a good idea. I shall use this
patch to add the functionality.
But, having a history support in the urllib2 module is not a good idea
IMO. It is best left to the clients which might use urllib2
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7540>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Here is a discussion and explanation from the submitter on what is meant
by history of requests.
http://mail.python.org/pipermail/python-dev/2007-March/072069.html
--
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
Thanks for the note, Manuel. Fixed it in revision 77013.
--
___
Python tracker
<http://bugs.python.org/issue7291>
___
___
Pytho
Changes by Senthil Kumaran :
--
assignee: georg.brandl -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7570>
___
___
Python-
Senthil Kumaran added the comment:
Fixed it in r77018 and merges.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Hi Ezio, let us not close the issue. Waiting for David Beazley's patch
is okay or even looking at specific modules pointed out from the point
of str vs bytes interfaces and if any docs can be improved, we can
improve them. If we determine there is none,
Senthil Kumaran added the comment:
I am attaching an updated patch for caching the 301 redirects.
As per RFC 2616:
10.3.2 301 Moved Permanently
...
...references returned by the server, where possible. This response
is cacheable unless indicated otherwise.
So, I have included an
Senthil Kumaran added the comment:
Thanks for the patch, Ned. Fixed in the trunk revision 77058.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Merged the fixes in r77059, r77060 and r77061
I fixed the thishost function to return all ips in py3k.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I dont see the failure on trunk either.
Is it either specific to windows or existed back when the bug was raised?
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue3
Changes by Senthil Kumaran :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue6452>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
> Antoine Pitrou added the Comment:
>
> I have trouble understanding what the patch does. I would expect it to
> cache the ->
Senthil Kumaran added the comment:
Here is the corrected patch for caching the 301 redirections.
* It caches only the redirection not the response.
* It retains cacheable=True kwarg for http_error_301 method. ( I feel, it
should be useful)
* Have made the cached dict as private.
I have
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file15677/urllib2-301-redirection.diff
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Senthil Kumaran added the comment:
Antoine: I got your point. Yes, I was missing the purpose of the redirection
itself and the patch was wrong.
If the 301 is to be cached, the cache map should be maintained at the higher
level in order for the further requests to refer to.
I have created a
Senthil Kumaran added the comment:
Thanks for the comments.
Shall come with the tests.
Yes,it currently does not handle chained redirects via cache. I dont know RFC's
stance on it. RFC does not say anything about 301 chained redirects and there
are tricker issues of caching anything
Senthil Kumaran added the comment:
Attaching a non-malformed patch. I had incomplete tests in previous ones and I
removed it by-hand before submitting for review. Something went wrong, I see.
Okay, I get the points you are making. Specifically a request specific object
and then maintaining a
Changes by Senthil Kumaran :
Removed file:
http://bugs.python.org/file15745/urllib2-301-redirection-proper.diff
___
Python tracker
<http://bugs.python.org/issue1755
Changes by Senthil Kumaran :
Removed file:
http://bugs.python.org/file15722/urllib2-301-redirection-CORRECTED.diff
___
Python tracker
<http://bugs.python.org/issue1755
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file8117/liburllib2.patch
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Python-bug
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file8116/test_urllib2-cache.patch
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Pytho
Changes by Senthil Kumaran :
Removed file: http://bugs.python.org/file8115/urllib2-301-cache.patch
___
Python tracker
<http://bugs.python.org/issue1755841>
___
___
Pytho
Senthil Kumaran added the comment:
Fixed in revision 77367
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Yes, I indeed, I quickly moved to patch it up in the trunk and did a svn submit
-m "..." I had your big patch for tests in the trunk. I have reverted it for
now and shall fix this one only.
--
___
Pyth
Senthil Kumaran added the comment:
Fixed in revision 77411 for trunk. Will merge it to other branches.
--
versions: +Python 2.6, Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue7
Changes by Senthil Kumaran :
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue7648>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
merged it in other branches: r77413,r77414,r77415.
This fixes the errors in test_trivial tests. Verified on windows.
--
assignee: -> orsenthil
status: open -> closed
___
Python tracker
<http://bugs.p
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue7665>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Just a Note: test_file in py26 had problems with multiple ips in this scenario
(execute test.test_urllib2 from different drive in windows), but not in the
py3k version. I need to verify it py26-maint/trunk
Senthil Kumaran added the comment:
FWIW, it should also be noted that RFC asserts square brackets to be
valid characters in the hostname portion only and that too when it is
a IPv6 url.
In the example given, at the query portion, it should be quoted (or
percent-encoded
Senthil Kumaran added the comment:
On Mon, May 17, 2010 at 01:38:57PM +, Florent Xicluna wrote:
> Committed in r81265 for 2.7.
Thanks. That was interesting. Without resorting to any drastic changes like
use of regex, interesting speed-up seems to have been achieved by
using rsplit and
Changes by Senthil Kumaran :
--
assignee: orsenthil -> flox
resolution: -> fixed
stage: patch review -> committed/rejected
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
HTTP Ref says that Server can send any encoding, if client does not
specify Accept-Encoding header. But if 'identity' is one of the
encoding that server recognizes (?), then it should send it as
identity, which indicates untransformed content.
I a
Senthil Kumaran added the comment:
Fixed it in revision 81279 and other branches.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue8
Changes by Senthil Kumaran :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue8744>
___
___
Python-bugs-list
Senthil Kumaran added the comment:
The functionality provided by urllib.request._urlopener can be accomplished in
a more natural way using build_opener. Historically, _urlopener was there for
urllib and build_opener style came in urllib2.
So, I think, this can be safely be removed from the
Senthil Kumaran added the comment:
Actually, I see certain use-cases of _urlopener in py3k. Most visible one being
urllib.request.urlretrieve and also URLOpener.open which is different from
build_opener way of doing things.
- But still, public exposure of overriding globals to can be removed
Senthil Kumaran added the comment:
Removed in r81283 and r81284.
With respect to the technical details of exposing this functionality for
_urlretrieve and URLOpener.
- users can still do it.
- There is a better way, if the other global _opener be served for the same
purpose, so that
Senthil Kumaran added the comment:
Ashley Sands wrote:
> Is this the right approach?
Follow the process mentioned here:
http://www.python.org/dev/faq/
And create a patch against Docs/library/importlib.rst with the
reference to PEP 3147 included. That is it. Look for other places
where
Senthil Kumaran added the comment:
Here is the proper link:
http://www.cs.princeton.edu/research/techreps/TR-554-97
Fixed those references in the code too.
--
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
Senthil Kumaran added the comment:
This is a platform specific bug. It is happening only on windows.
BTW, makelink should not have been called for this file, because it
is not a link or symlink, but a regular file.
--
nosy: +orsenthil
___
Python
Senthil Kumaran added the comment:
tarek: Issue2987 has the details on changes made for ipv6 urlparse.
Those can't be backported as it's a feature. I would rather like to see whats
breaking in distutils2.
The url which resulted in this bug in distribute:
"http://www.famf
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
stage: unit test needed -> needs patch
___
Python tracker
<http://bugs.python.org/issue1368368>
___
__
Senthil Kumaran added the comment:
Is the behavior you posted observable on trunk?
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Okay, I see you have mentioned 2.6.5 in the Title.
I will try the following to reproduce this.
1) Try a Basis Auth which is working.
2) Pass an Invalid username/password and see the behavior.
--
___
Python tracker
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> accepted
___
Python tracker
<http://bugs.python.org/issue8801>
___
__
Senthil Kumaran added the comment:
I am just reopening this, as per dcj's comment.
--
resolution: fixed -> accepted
status: closed -> open
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
urllib2 is currently catching the socket.error exceptions and presenting the
reason as custom URLError exception. To address this issue, the module should
catch the httplib raised exceptions also and present it.
--
assignee: -> orsenthil
n
Senthil Kumaran added the comment:
please ask help at python-h...@python.org or comp.lang.python
--
nosy: +orsenthil
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
This is fixed in r81636, r81637, r81638, r81637.
Just like the Digest Authentication, the urllib2 will try for 5 times before
failing for any authentication failure ( It won't lead to recursion).
I had a thought that Basic Authentication need not be re
Senthil Kumaran added the comment:
Agree to your concern that doseq parameter is not properly explained.
Fixed in r81645, r81646, r81647 and r81648.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -&g
Senthil Kumaran added the comment:
The point of retry is for auth failure, which can happen due to any reason. It
is not just for a wrong password.
I was thinking just doing a single verification and failing, but did find some
resources (not just browsers) which adopt this approach of retry
Senthil Kumaran added the comment:
There was a fix made in issue8797, which adopts a retry approach before failing
for wrong password. This is present for Basic Auth and Digest Auth, so the
problem wont be faced. Jurjen, do you have any comments before I mark this as
Invalid. I see you have
Senthil Kumaran added the comment:
Okay, so there is another negative vote 5 retries in the basic auth.
But yeah, this bug can be marked duplicate.
--
___
Python tracker
<http://bugs.python.org/issue8
Senthil Kumaran added the comment:
Duplicate of issue8797
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Agree to single retry for Basic Auth. We are just dealing with
BasicAuthentication here, so that's why we did not have in the
HTTPPasswdManager. But, let me consider that viewpoint too.
--
status: closed -&
Senthil Kumaran added the comment:
Fixed in r81687, r81688, r81689 and r81690.
Yes, I see that before the original change was made any chuncked encoding went
through _read_chunked which close the resp before returning. So, here for HEAD,
the resp is closed thus fixing the problem mentioned
Senthil Kumaran added the comment:
I saw the earlier tests was closing it explicitly. Removed that and added a
test which verifies the closed resp obj. Thanks.
--
___
Python tracker
<http://bugs.python.org/issue6
Senthil Kumaran added the comment:
The reason the the password is prompted is because, on 401 authentication
failure, there is a retry logic by default. When the authentication is retried,
it is prompted for username:password using getpass. When using GUI modules it
is desired to override
1601 - 1700 of 2044 matches
Mail list logo
