Senthil Kumaran added the comment:
It should be noted that latest OSX Mountain Lion has caused problems for other
language libraries too (specifically ruby, which I use at work). Ease the
support of correct openssl in OSX may help a long way in all versions of python.
--
nosy
Senthil Kumaran added the comment:
The patch looks good to me. This change is helpful and definitely an
improvement over the existing text. Please go ahead with committing it, Terry.
Thanks.
--
___
Python tracker
<http://bugs.python.org/issue17
Senthil Kumaran added the comment:
I have a slight fear that this patch could be considered as a feature addition
in 2.7 urllib.py, I would like to quell that and ensure that behaviour
expectation is consistent when using urllib or urllib2 and latest
urllib/request.py modules.
Also, tests
Senthil Kumaran added the comment:
Thanks for the patches, Vajrasky and Karl. Fixed in currently active (3.4,3.3
and 2.7) versions of python.
--
assignee: -> orsenthil
resolution: -> fixed
stage: test needed -> committed/rejected
status: open -> closed
versions:
Senthil Kumaran added the comment:
I had removed them in all. Something must have gone wrong if still present or I
did a mistake.
changeset: 85594:678e3c0d2d99
parent: 85591:c116b658aede
parent: 85593:14ba90816930
user:Senthil Kumaran
date:Sat Sep 07 11:30:04 2013
Senthil Kumaran added the comment:
Thanks for making these changes (and correcting some of my mistakes), RDM.
They are much better now.
On Sat, Sep 14, 2013 at 10:38 AM, R. David Murray wrote:
>
> R. David Murray added the comment:
>
> You are right, there was a further typo in
Senthil Kumaran added the comment:
Found the patch suitable and had addressed Berker Pesag's review comments too.
Thanks for contributing, Malte Swart and thanks for submitting the contributor
agreement too.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review ->
Senthil Kumaran added the comment:
The patch looks good, but I have doubt in the claim that, this new behavior is
actually a right thing to do.
RDM wrote:
Now, that said, it seems to me that while it is not (apparently) RFC compliant,
query strings do have a natural way to support null
Senthil Kumaran added the comment:
> Georg Brandl added the comment:
>
> I would propose a leading underscore for these methods; they should make it
> clear to the user that the parameter is meant to be "private".
+1 to this proposal.
This style is present with randrange,
Senthil Kumaran added the comment:
Tim Peters added the comment:
> ..., _fast=slow, ...
>
> in an argument list means we endure the slow lookup (of `slow`) only
> once, when the function is first defined. When the function is
> _called_, that binding is available via
Senthil Kumaran added the comment:
Attaching a patch after changing int=int to _int = int and improving the
docstring. Please review the changes to the docstring and see if it will be
helpful.
--
status: closed -> pending
Added file: http://bugs.python.org/file31788/14927.d
Senthil Kumaran added the comment:
Thanks for catching the mistake at _randbelow. Updated patch to fix that and
removed the explanation in the docstring. Not sure if _randbelow should changed
(fully) or not at all. Leaving the change only with _int.
Will wait for Raymond's r
Senthil Kumaran added the comment:
Georg: Thanks for spotting. I feel bad for the mistake. I shall correct it.
--
___
Python tracker
<http://bugs.python.org/issue18
Senthil Kumaran added the comment:
Fixed now. Ascertained myself by doing hg diff -r tip^ -U 10 on local commits
before pushing. :-)
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Hello Dmi,
> I having a snippet to fix that, should I open a new issue for patch?
Please open a new issue.
Thanks!
--
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Thanks for the this change, Jason. Docs could be updated to reflect this change
(using ..versionchanged: directive). Thank you!
--
___
Python tracker
<http://bugs.python.org/issue18
Senthil Kumaran added the comment:
Hi Joshua, I did not setup a php server to test the html form that you
uploaded. We cannot test this in browsers because HTML does not have None as
values, it is simple empty strings and that is correct.
I think that the cost of making this change is higher
Senthil Kumaran added the comment:
I have provided my comments in the review tool. Please check them out.
--
___
Python tracker
<http://bugs.python.org/issue19
Senthil Kumaran added the comment:
FieldStorage("foo", "bar") is invalid because the first argument is supposed to
be file-like object and second one headers. Here we are sending invalid
headers. By
default, if the headers is none, the content-type is urlencoded.
Th
Senthil Kumaran added the comment:
Hi Raymond, Ezio provided some comments on improvements to the patch. Do you
mind if Ezio or I take over task of improvement. Not cause problems != no need
to improve.
TIA.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Hi Guido,
Agree with both your points.
Attaching a patch that fixes this issue.
1. Raises TypeError exception when header is not a Mapping or
email.message.Message type.
2. Asserts for fp.read and fp.readline() to assert that fp, the first argument
to
Changes by Senthil Kumaran :
--
versions: +Python 3.3, Python 3.4 -Python 2.6
___
Python tracker
<http://bugs.python.org/issue19097>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Addressing storchaka's review comments. Here is the updated patch.
--
Added file: http://bugs.python.org/file32021/19092-v2.diff
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
The patch is good. I think, it is better to include this information in
documentation too. Please let me know if this suitable, I shall go ahead
committing this. (With credits to Vajrasky Kok)
--
assignee: -> orsenthil
nosy: +orsenthil
versi
Senthil Kumaran added the comment:
Sounds good.I shall update patch (.rstify the security warning). Thank you!
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19350>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Patch committed in these versions. Thank you!
2.7 -5fda64d39540
3.3 - 06b9a9e75a6c
3.4 - 060d9b2e4d5e
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type:
Changes by Senthil Kumaran :
--
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue19350>
___
___
Python-bugs-list m
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19383>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Attached patch adds the index entry.
--
keywords: +patch
nosy: +orsenthil
Added file: http://bugs.python.org/file35703/20091.patch
___
Python tracker
<http://bugs.python.org/issue20
Senthil Kumaran added the comment:
Fixed in all active branches.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 2.7
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Thanks for the review, Mark. Addressed that and committed the changes in
changeset 606a18938476 (3.4)
changeset b4130b2f7748 (3.5)
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +P
New submission from Senthil Kumaran:
issue15588 brought the topic that quopri has ancient methods like encodestring,
decodestring, which a user might expect that will send a string, but instead
has to send bytes.
This needs to be cleaned up.
a) function name should be accurate and represent
Senthil Kumaran added the comment:
The patch was good and captured what was required. I made some minor
modifications and committed it in 3.4 and 3.5
Thanks for the patch, Vajrasky Kok.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch ->
Senthil Kumaran added the comment:
Thanks for the report. Point 2 is definitely a bug (and an overlook by me), I
will fix it.
I think, the url[:2] == '//' check was present for ftp case which supported
file:// protocol. I can't see a clear requirement to change here.
Th
Senthil Kumaran added the comment:
I have addressed the mistake where req.host is self.get_names() was done
instead of req.host in self.get_names() in the first commit as it was an
obvious problem.
I will come up with patch/solution addressing the other behavior mentioned in
this report
Senthil Kumaran added the comment:
This bug has been open for a while and I had lost sight of it. Upon prompted
recently, I dug bit
into history and could think of a good solution.
A brief history.
1. The bug "maximum recursion depth exceeded" when doing Basic Authentication
was
Senthil Kumaran added the comment:
I have backed out my changes. The buildbot failures were new as I could not
reproduce them in my local test on Mac. I will run the buildbot suite on branch
and fix it before committing.
--
___
Python tracker
Senthil Kumaran added the comment:
@Serhiy, yeah, I think the patch attached to issue22165 will fix one of the
buildbot failures. For this issue. there was another one with Broken PIPE which
may need a different fix.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Attached patch looks good to me. If an unittest can be provided for this
situation in test_httpservers.py it will be comprehensive and will be good to
go.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
Looks like we hit with an encoding issue, which is due to way os.fsdecode() and
os.listdir() decode the filenames.
>>> support.TESTFN_UNDECODABLE
b'@test_99678_tmp\xe7w\xf0'
>>> dir_list = os.listdir(self.tempdir)
>>>
Changes by Senthil Kumaran :
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
This is fixed in all active versions (2.7.8+, 3.4.2? and 3.5). Thanks all!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
Interesting. I had not noticed these with my run on Mac and neither did
Buildbots report. Looks like explicit closing of wfile do_GET method can be
cause of tis problem.
--
___
Python tracker
<h
Senthil Kumaran added the comment:
It was reproducible on my local machine too. Those errors were present and
somehow escaped me. Thanks for raising this.
Fixed these and tested in my local machine and test_urllib2_localnet was
successful.
--
assignee: -> orsenthil
resolut
Senthil Kumaran added the comment:
With the final review comment addressed, this could go in. Since you have
commit rights, please feel free to commit it. (else, please assign this to me
and I will commit and follow up with the buildbots
Changes by Senthil Kumaran :
--
assignee: -> alex
___
Python tracker
<http://bugs.python.org/issue22366>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
The localhost breaking on your linux system might be due to improper /etc/hosts
or is localhost pointing to an ipv6 address?
That said, I think it is okay to rely on 127.0.0.1 as host for running pydoc
server. I am unsure why the initial check was done only
Senthil Kumaran added the comment:
sys.platform is darwin since OS X 10.5. I am not sure when it's value was
'mac', So effectively the host was localhost on mac systems.
Directly setting the host value to localhost on all platforms may be right
thing to do. Here is a p
Senthil Kumaran added the comment:
2.7 was not affected and it was binding to localhost properly.
Since it is security related issue, I have fixed it in 3.3 as well.
Fix is now present in 3.4 and 3.5
--
resolution: -> fixed
stage: patch review -> resolved
status: open -&g
Senthil Kumaran added the comment:
Reviewed the patch. Looks good to go.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22420>
___
___
Pytho
Senthil Kumaran added the comment:
The patch looks good. Yeah, wsgiref server will see the benefiting of rejecting
long url with 414.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Thanks, fixed in all versions applicable for security release.
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Senthil Kumaran :
--
versions: +Python 2.7, Python 3.3, Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue22419>
___
___
Python-bug
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue22417>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I addressed Berker Peksag's review comments on Jame's patch, tested the local
building of docs, verified the content and looks.
Committed this in 2.7, 3.4 and 3.5.
Thank you all!
--
assignee: docs@python -> orsenthil
resolution: -
Senthil Kumaran added the comment:
Committed this in 3.5. (Since this is adding an new argument, it should not be
backported to 3.4).
Thank you!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: -Python 3.4
_
New submission from Senthil Kumaran:
While working on issue22366, I found a tricky bit of code in:
https://hg.python.org/cpython/file/ca0aa0d89273/Lib/http/client.py#l1295
https://hg.python.org/cpython/rev/1a945fb875bf/
The statement is
if not self._context.check_hostname and self
Senthil Kumaran added the comment:
Except for the minor comments made by Antoine in the review, the patch looks
good to go.
--
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
My worry is not about the timing. I can add it immediately, but are we
convinced on having a new argument (API Change) for 3.4.2 ?
--
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Patch looks good. Will need similar addition in urllib2 and inclusion of tests.
--
nosy: +orsenthil
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue22
Senthil Kumaran added the comment:
Well, the result with loading using json will be same. but without sending
Accept */*. The content-type returned is text/javascript; charset=UTF-8 and
with sending of Accept */* the content-type is set to application/json;
charset=UTF-8 (which is more
Senthil Kumaran added the comment:
I addressed Antoine's comments with the patch and committed it. Thank you!
--
assignee: -> orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.pyth
Senthil Kumaran added the comment:
First thing (and the easiest is), if you find inconsistent casing in
http/server.py itself, then make it consistent in your patch against cpython
default branch (from hg.python.org). Make it Content-Length and Content-Type in
your patch.
Next part is while
Senthil Kumaran added the comment:
I suspect that you have your interpreters confused. (For e.g, I see 3.4 run
against the trunk and the error messages are leading me to believe that 2.7
version in run on 3 code).
Or your local copy is not in right shape.
I tested it on 3.4 and cpython
Senthil Kumaran added the comment:
The buildbots are not showing this error too. I suggest you reset your local
copy with the pristine one from remote, do a make distclean; ./configure; make
and then run the tests.
--
assignee: -> orsenthil
resolution: -> works for me
New submission from Senthil Kumaran:
Reported by John Jeffers on docs mailing list.
https://docs.python.org/3.4/download.html (3.4.2rc1)
Return Error 404 (Your other pages are fine)!
--
messages: 227493
nosy: larry, orsenthil
priority: normal
severity: normal
status: open
title: 3.4
Senthil Kumaran added the comment:
Yes, urllib2 does not have any support for NTML based authentication. And it
is a long pending feature request too.
For 2.7, the best way to handle this might be, instead of crashing on
WWW-Authenticate: Negotiate, which is a valid response from IIS (1). It
Senthil Kumaran added the comment:
Sorry that I did not get involved earlier.
It is difficult to prove any problem with the current behavior and it is
rightly closed. The issue which was originally raised seems to me a cosmetic
one, which won't get exhibited as well.
Here is simple
Senthil Kumaran added the comment:
@Martin. Agree that this should have been backported. I have done that.
Thank you!
--
___
Python tracker
<http://bugs.python.org/issue12
Senthil Kumaran added the comment:
If you could point to RFC which states the list of characters which can be used
as valid query string separators, we can include that list. (Of course in 3.5)
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
And those examples were only in test.
Use of latin-1 to have a literal text for round trip is ok. The patch looks
good to me.
--
___
Python tracker
<http://bugs.python.org/issue20
Senthil Kumaran added the comment:
This is fixed in all active branches (2.7,3,3 and 3.4). I have addressed all
review comments. Thanks.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
The last tracker message msg207926 is applicable to issue #19097 and not here.
Sorry for the confusion.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue19
Senthil Kumaran added the comment:
Fixed in:
New changeset a3e49868cfd0 by Senthil Kumaran in branch '3.3':
Issue #19092 - Raise a correct exception when cgi.FieldStorage is given an
http://hg.python.org/cpython/rev/a3e49868cfd0
New changeset 1638360eea41 by Senthil Kumaran in branc
Senthil Kumaran added the comment:
Addressed this in all active branches (2.7, 3.3 and 3.4). Thanks!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
I think, it is simply okay to mention about ResourceWarning being displayed. I
spent something thinking and going into mechanics of how it is displayed may be
an overkill for that line in unittest.rst. I'll make the change and if you see
any fu
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
This is duplicate of Issue1143
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Senthil Kumaran added the comment:
Not actually a bug. The documentation is correct.
Do, random.randint(0,1) a couple of times and you see 1 appearing.
If still not convinced, look into the random.py see that randint(a, b)
actually does a return self.randrange(a, b+1)
--
nosy
Senthil Kumaran added the comment:
It is very difficult to debug with the information you have provided.
The webbrowser.py has indeed undergone some changes, but they are
positive changes and should not break any working behaviour.
For your problem, you might want to mention.
1) Your OS.
2
Senthil Kumaran added the comment:
Fixed that in revision 75166. Even in release26-maint got to chnage it
from env.unset(k) to self.env.unset(k).
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
___
Python tracker
Senthil Kumaran added the comment:
This needs to be changed in python2.6 branch as well. I was hesitant as
barry was making the build. After the branch opens, I shall make the
changes in that and close the issue.
--
nosy: +barry
___
Python tracker
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue7043>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Fixed and Committed revision 75253.
Will just wait for windows buildbot to test it before closing.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Committed revision 75254 for release26-maint.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
This bug is bit a tricky case.
Harshad: You might try the "work-around" suggested by Antoine. But that
is just a work-around. not a fix. Add an entry to gconf-editor like any
other. ( google).
The actual bug seems to be with gnome-open which is
Senthil Kumaran added the comment:
AdamN, did you specifically come across a scenario which broke due to
this change? I can understand your concern, in general. The
'non-breaking' existing tests is the one of confidence factor we have in
introducing t
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue6894>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Senthil Kumaran :
>>> help(struct) mentions the functions which use fmt characters.
The builtin help does not mention the fmt characters and their meaning.
One should go online if he has to refer them.
--
keywords: easy
messages: 93709
nosy: orsenthil
prio
Changes by Senthil Kumaran :
--
assignee: -> georg.brandl
components: +Documentation
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Fixed in trunk and Committed revision 75333.
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
merged into py3k revision 75334
merged into release-26maint revision 75335.
--
___
Python tracker
<http://bugs.python.org/issue6
Senthil Kumaran added the comment:
merged in release31-maint in revision 75336
Closing the issue.
--
status: open -> closed
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
> Hope this is the right place to report website issues.
Not actually,
http://wiki.python.org/moin/PythonWebsiteCreatingNewTickets
to report a bug or to suggest an enhancement for the python.org
website, please send an e-mail message to
.
If you
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7109>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Can you mention the python --version in which you encountered this issue?
And piece of code which loops indefinitely?
The propagation of timeout to redirects has been fixed with Issue5102.
--
assignee: -> orsenthil
nosy: +orsent
Senthil Kumaran added the comment:
Windows buildbots pass for this test. Closing the issue.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
1501 - 1600 of 2044 matches
Mail list logo
