Senthil Kumaran added the comment:
On Sun, Jan 29, 2012 at 10:30:45PM +, Antoine Pitrou wrote:
>
> Well, if you are a security expert you can volunteer to maintain a
> trusted certificates' file in the Python repository :) I think
> nobody else amongst us is qualified.
Senthil Kumaran added the comment:
I think, I was using wrong terminology, by 'sending' I meant, 'using' the
ca_file in the client to verify Server's certificates.
--
___
Python tracker
<http:
Senthil Kumaran added the comment:
I am sorry. I see that with context object in 3.x, verification is being done.
The CA certs can be pointed to using load_verify_locations.
As the author had in this patc tothe pass on addition ca_certs and ca_reqs to
wrap_socket in ssl from httplib2. I
Senthil Kumaran added the comment:
On Wed, Feb 08, 2012 at 03:42:16AM +, Eli Bendersky wrote:
> Any objections?
None. The explanation sounds reasonable.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
I have stumbled upon a wrong impression as well by reading the docs, but
usually in the code, I tend to catch the specific Exceptions, like timeout
instead or URLError when it is known. I saw some libraries following similar
pattern too. But that could be
Senthil Kumaran added the comment:
Thanks for patches. This is fixed.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Senthil Kumaran added the comment:
Added suggested changes to the documentation. Thanks.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Stephen - urlencode is responsible for producing the
application/x-www-form-urlencoded format, usually used in the FORMs in the web.
As per the spec, the Space characters are replaced by `+'. -
http://www.w3.org/TR/html4/interact/forms.html#h-17.1
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14001>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14072>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
A couple of points to help summarize and to help come to a conclusion.
In the initial message, Stephen pointed out, "it would be desirable to merely
encode spaces using percent encoding".
It seems to me that only in cases where a custom handlin
Senthil Kumaran added the comment:
If I recollect correctly, redirecting a POST request with POST data is not a
recommended thing to do and could be a security hazard. That's why RFC
prohibits it too. It is intentional that urllib2 is not redirecting carrying
along the POST data. Coul
Senthil Kumaran added the comment:
Oh Sorry. I shall fix this by this weekend.
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Here is a section which talks about 3xx redirection
http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
10.3 Redirection 3xx
This class of status code indicates that further action needs to be taken by
the user agent in order to fulfill the request
Senthil Kumaran added the comment:
It's an interesting issue. Thanks for the report and patch, Xavier. I am
setting patch to needing review.
--
keywords: +needs review -patch
nosy: +orsenthil
versions: +Python 2.7, Python 3.3
___
Python tr
Senthil Kumaran added the comment:
Hi Jay & Éric,
I understand your points and providing an extra argument seems like an idea
that could be useful to circumvent , what you see as a problem.
The RFC section states that -
"The action required MAY be carried out by the user agen
Senthil Kumaran added the comment:
On Mon, Mar 05, 2012 at 11:15:38AM +, Éric Araujo wrote:
> Ah, so there is a way to achieve it! If Jay is satisfied by this,
> we could add an example of using that in the urllib howto, with the
> appropriate warnings. That would have much less
Senthil Kumaran added the comment:
I am closing this issue as I feel that the requirement may not be addressed by
a change. If there is patch for HowTo, we can tackle that in another issue.
Thank you for contribution.
--
resolution: -> invalid
status: open ->
Senthil Kumaran added the comment:
Couple of points:
1. On your last example, which webserver treats 'L' as part of port number? I
can't of anything.
2. Can you write a "real application" which is listening to beyond 65535? Which
platform would it be?
Current way
Senthil Kumaran added the comment:
I reviewed the patch, built the docs and found it good.
Fixed it in 3d877dee1bde and aaf45928899c
Thanks!
--
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
versions: -Python 2.7
___
Python t
New submission from Senthil Kumaran :
Opening the this bug following this discussion -
http://mail.python.org/pipermail/docs/2012-March/007829.html
library/re.html
\S
When the LOCALE and UNICODE flags are not specified, matches any non-whitespace
character; this is equivalent to the set
Senthil Kumaran added the comment:
This clarification is specific to Python 2.7.
For Python3, the use of LOCALE flag is explicitly discouraged and
confusing references to it's meaning is not present in the docs.
--
___
Python tracker
Senthil Kumaran added the comment:
Just a minor comment on the patch - It should be %r instead of %s.
-raise TypeError('must be str, not %s' % type(s))
+raise TypeError('must be str, not %r' % type(s))
If there is any test for this, it could b
Senthil Kumaran added the comment:
One at the time - urlretrieve is re-written. Now should add deprecation
warnings to things methods to be deprecated / removed.
--
___
Python tracker
<http://bugs.python.org/issue10
Senthil Kumaran added the comment:
Thanks for the patch, Jeff McNeil. I pushed the patches to 3.2 and 3.3 docs.
Since it is a documentation change (an explaination rather), I did not update
the NEWS.
Thanks again!
--
___
Python tracker
<h
Senthil Kumaran added the comment:
Yes, it is simply a matter of adding warnings.warn in proper classes
and methods. I have started on that, Jeff. No problem. I just wanted
the changes to be two separate commits. Thanks!
--
___
Python tracker
Senthil Kumaran added the comment:
Here is patch which adds DeprecationWarning to URLOpener and (it's subclasses
FancyURLopener) as well as some other Request methods.
The idea would be, in the next release we remove this old URLOpener and it's
subclasses and remove (or make _pr
Senthil Kumaran added the comment:
My concern was with the method get_full_url. I have seen it being
useful in more than one place and it's not just the accessor. Others
are just the accessors and those can be safely removed. When
get_full_url gives the correct url, taking into consider
Senthil Kumaran added the comment:
It should be noted that diff in git supported format is recommended in the
devguide -
http://docs.python.org/devguide/committing.html#minimal-configuration
If it breaks the rietveld integration, then we should not be advising it.
--
nosy
Senthil Kumaran added the comment:
Éric - not really. nonlocal is from python3.x onwards only.
--
___
Python tracker
<http://bugs.python.org/issue14217>
___
___
Yeah, the other option is to fix the tracker-reitveld integration.
(Which I assumed was harder because diff did not give hg info required
for it)
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archi
Senthil Kumaran added the comment:
Closing this based on - msg155387. The upstream bug is "unfortunately" closed
as OLD. We can reopen if this stumble upon this again.
--
resolution: -> invalid
stage: needs patch -> committed/rejected
status
Senthil Kumaran added the comment:
I have rewritten some parts of the documentation, explaining the use of charset
parameter with Content-Type header. Used the suggestions from the previous
patch's review comments too. I see that other parts of the documentation can
be improved furth
Senthil Kumaran added the comment:
To note in the tracker, the original 2.6 code was changed in Issue 2254 and the
relevant changeset is c6c4398293bd
I find, Glenn's suggestion a possibly okay solution for PATH_INFO problem,
keeping in tact the security issue the the previous change
Senthil Kumaran added the comment:
Actually no. I revert back my previous statement. Meddling with splitpath
breaks all the tests.
--
___
Python tracker
<http://bugs.python.org/issue10
Senthil Kumaran added the comment:
I treated this as a regression from 2.6. A cgi url with
/cgi-bin/hello.py/hello/world would have PATH_INFO as '/hello/world'
I saw some apache specs saying that it should be 'hello/world', but I relied on
python2.6's behavior with h
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10487>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
superseder: -> Make CGIHTTPServer capable of redirects (and status other than
200)
___
Python tracker
<http://bugs.python.org/issu
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue10485>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Instead of what's new, I think, linking the benchmarks in the docs could be
helpful so that library users can find it they want to. I think, we have
similar performance benchmark links at other places too.
--
nosy: +orse
Senthil Kumaran added the comment:
It's funny, Antoine had raised an issue too. Should see why is this
sporadic failures..
--
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
That's not an error, but in fact a correct statement. Please test it in the
interpreter.
--
nosy: +orsenthil
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
type
Senthil Kumaran added the comment:
On Tue, Apr 03, 2012 at 08:37:35AM +, Ezio Melotti wrote:
>
> Ezio Melotti added the comment:
>
> + hg import --no-commit < mywork.patch
>
> Is the '<' correct here?
No!. It should just be hg import --no-commit mywo
Senthil Kumaran added the comment:
Well, I would like to correct this further and add clarification based on the
current implementation (_sre.c)
The definition of LOCALE Space is this -
#define SRE_LOC_IS_SPACE(ch) (!((ch) & ~255) ? isspace((ch)) : 0)
And the definition of NON_S
Senthil Kumaran added the comment:
Hi David,
I am sorry, I did not notice your second comment in this bug and later when you
closed this, noticed the bug report.
Yes, the default=None but actually pointing to a sentinel value is an odd duck
and I believe the explanation in docs were
Senthil Kumaran added the comment:
I had to carefully review a lot of changes for this. In addition, I did setup a
apache and tested the behaviors too.
Few notes -
- The test for _url_collapse_path_split is not directly helpful, especially
for PATH_INFO. I removed my previous changes I
Senthil Kumaran added the comment:
Hi Antoine,
I saw that check_warnings was commonly used ( and perhaps I had used to earlier
without any problems) and overlooked assertWarns. But I think, it is good to
remove support.check_warnings dependency here and just use assertWarnings. Let
me see
Senthil Kumaran added the comment:
Hello Glenn,
Your suggestions were valid. I have made those changes in the code. Thanks! I
think, we can close this bug now and move over to others.
Thanks,
Senthil
--
status: open -> closed
___
Python trac
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14560>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
I am trying to this test this to determine the fault.
--
assignee: -> orsenthil
nosy: +orsenthil
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
In that case, transparent decompression should not be available. (
Request header should not be sent and response wont be compressed).
--
___
Python tracker
<http://bugs.python.org/issue1508
Senthil Kumaran added the comment:
I tested setting cookies with ":" in the cookie name in both firefox and
google-chrome. They both seem to allow and store the cookie with ":" in them.
Firefox sent a request header like this:
Set-Cookie test:value=solution:is:he
Senthil Kumaran added the comment:
Hi Barry,
I stumbled upon this bug when trying to compile Python2.6 from source on Ubuntu
11.10. If this bug report or the related one issue11715 is a problem due to
Ubuntu changes, I think, it is good inform in the download or news page. People
try
Senthil Kumaran added the comment:
Thanks for this engagement and pull requests, Steve.
Thanks for reviews Karthikeyan.
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue36
Senthil Kumaran added the comment:
Hi Victor and Karthikeyan,
Both your analysis are correct.
- This is a legacy interface, present purely for satisfying the old code, when
urlretrieve was advertised as the first/easy to way to use urllib and download
something.
- At this moment, I think
Senthil Kumaran added the comment:
Suggesting the use of context and deprecating `cafile=None, capath=None,
cadefault=False` sounds like a good idea.
--
___
Python tracker
<https://bugs.python.org/issue37
Senthil Kumaran added the comment:
New changeset cbb16459934eaf29c7c7d362939cd05550b2f21f by Senthil Kumaran
(Sanyam Khurana) in branch 'master':
bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (#10639)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
New changeset 5d9ae8b9df8371dd65514e0d60b561fd37056986 by Senthil Kumaran (Miss
Islington (bot)) in branch '3.6':
bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639)
(#11477)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
New changeset 02e33d9567aa4bd612f9f08053acbfd5e68480d0 by Senthil Kumaran
(Sanyam Khurana) in branch '2.7':
[2.7] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff
(#11482)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
New changeset c5dc60ea858b8ccf78e8d26db81c307a8f9b2314 by Senthil Kumaran
(Pablo Galindo) in branch 'master':
bpo-24746: Fix doctest failures when running the testsuite with -R (#11501)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
Hi All,
It was my mistake to merge this in into 3.6, I didn't realize 3.6 was in bugfix
mode now. Also I went by the versions (previously) set in this bpo issue.
For the regression caused in refleaks, I think, Pablo's patch will fix it, and
I am
Change by Senthil Kumaran :
--
pull_requests: +11058
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Senthil Kumaran :
--
pull_requests: +11058, 11059
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsub
Change by Senthil Kumaran :
--
pull_requests: +11058, 11059, 11060
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailin
Change by Senthil Kumaran :
--
pull_requests: +11067
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Senthil Kumaran :
--
pull_requests: +11067, 11068, 11069, 11070
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailin
Change by Senthil Kumaran :
--
pull_requests: +11067, 11068
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsub
Change by Senthil Kumaran :
--
pull_requests: +11067, 11068, 11070
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailin
Change by Senthil Kumaran :
--
versions: +Python 2.7
___
Python tracker
<https://bugs.python.org/issue24746>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
New changeset 0167c08163f44f4a033497102244bbb6150f606b by Senthil Kumaran in
branch '2.7':
bpo-24746: Fix doctest failures when running the testsuite with -R (#11501)
(#11512)
https://github.com/python/cpyt
Senthil Kumaran added the comment:
All changes related to this issue are done.
Thanks for your contribution and engagement everyone!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Senthil Kumaran added the comment:
The .github directory needs to stay and is being used for other purposes (like
providing contributing guidelines
(https://github.com/blog/1184-contributing-guidelines)).
The old pull request template has already been deleted:
https://github.com/python
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
New changeset c3c7ef088583cc12bd218138036d1edb6de9c63f by Senthil Kumaran
(csabella) in branch 'master':
bpo-29917: DOC: Remove link from PyMethodDef (#890)
https://github.com/python/cpython/commit/c3c7ef088583cc12bd218138036d1edb6de9c63f
-
Changes by Senthil Kumaran :
--
stage: needs patch -> backport needed
___
Python tracker
<http://bugs.python.org/issue29917>
___
___
Python-bugs-list mai
Changes by Senthil Kumaran :
--
pull_requests: +797
___
Python tracker
<http://bugs.python.org/issue29917>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
pull_requests: +798
___
Python tracker
<http://bugs.python.org/issue29917>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
pull_requests: +799
___
Python tracker
<http://bugs.python.org/issue29917>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
New changeset da6ad2f780d187fbfdea330d1037766ae7bdb778 by Senthil Kumaran in
branch '3.6':
bpo-29917: DOC: Remove link from PyMethodDef (#890) (#894)
https://github.com/python/cpython/commit/da6ad2f780d187fbfdea330d103776
Senthil Kumaran added the comment:
New changeset d1dbbaab01354f01faa696aff1280db3b349e354 by Senthil Kumaran in
branch '3.5':
bpo-29917: DOC: Remove link from PyMethodDef (#890) (#895)
https://github.com/python/cpython/commit/d1dbbaab01354f01faa696aff1280d
Senthil Kumaran added the comment:
New changeset 3ceca68741f8a2d3a4436b6d54eae76aa5bcc4c5 by Senthil Kumaran in
branch '2.7':
bpo-29917: DOC: Remove link from PyMethodDef (#890) (#896)
https://github.com/python/cpython/commit/3ceca68741f8a2d3a4436b6d54eae7
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
New changeset 64c887ab3a400cf91bde4f0c5ef69eacc88bc5e1 by Senthil Kumaran
(csabella) in branch 'master':
bpo-26947: DOC: clarify wording on hashable in glossary (#948)
https://github.com/python/cpython/commit/64c887ab3a400cf91bde4f0c5ef69e
Changes by Senthil Kumaran :
--
pull_requests: +1139
___
Python tracker
<http://bugs.python.org/issue26947>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
pull_requests: +1140
___
Python tracker
<http://bugs.python.org/issue26947>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
New changeset 51fc7e3d6a29de7b3142e51f8caf4d31f7ac72a0 by Senthil Kumaran in
branch '3.5':
bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#958)
https://github.com/python/cpython/commit/51fc7e3d6a29de7b3142e51f8caf4d
Senthil Kumaran added the comment:
New changeset a71a3ad54d14483cfaebd8e0fb96c97c798d9e32 by Senthil Kumaran in
branch '3.6':
bpo-26947: DOC: clarify wording on hashable in glossary (#948) (#957)
https://github.com/python/cpython/commit/a71a3ad54d14483cfaebd8e0fb96c9
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
I reviewed in the pull request. I agree that the wording was slightly better
than the original.
--
___
Python tracker
<http://bugs.python.org/issue26
Senthil Kumaran added the comment:
I have to admit, I did not see some of the negative votes in this ticket before
merging the patch. If your is opposition is strong, please comment and suggest
a better improvement over the patch. thank you
New submission from Senthil Kumaran:
urllib.parse has the following information in this module.
```
# A classification of schemes ('' means apply by default)
uses_relative = ['ftp', 'http', 'gopher', 'nntp', 'imap
Senthil Kumaran added the comment:
https://github.com/python/cpython/pull/984 proposes a change. I'll need some
reviews on this changed text.
Note: I am aware that there is an issue (long pending), which suggests deal
away with these schemes at the top. If we get to that immediately, I
Senthil Kumaran added the comment:
Thanks for working on this.
row_factory seems to be another parameter that can be set in the Cursor object.
https://github.com/python/cpython/blob/master/Modules/_sqlite/cursor.c#L65
This can addressed in a different issue/ pr.
--
nosy: +orsenthil
Senthil Kumaran added the comment:
New changeset 02e12138000da834f23719521a011fa93763384d by Senthil Kumaran
(csabella) in branch 'master':
bpo-29725: DOC: add text for arraysize in sqlite3.Cursor (#947)
https://github.com/python/cpython/commit/02e12138000da834f23719521a011f
Changes by Senthil Kumaran :
--
pull_requests: +1157
___
Python tracker
<http://bugs.python.org/issue29725>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
pull_requests: +1158
___
Python tracker
<http://bugs.python.org/issue29725>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
New changeset cb1e002c07622e027e80a3843d27a623d1617430 by Senthil Kumaran in
branch '3.6':
bpo-29725: DOC: add text for arraysize in sqlite3.Cursor (#947) (#985)
https://github.com/python/cpython/commit/cb1e002c07622e027e80a3843d27a6
Senthil Kumaran added the comment:
New changeset 0f9ceaf322cc9358373167115fd4c21ab2d9ad50 by Senthil Kumaran in
branch '3.5':
bpo-29725: DOC: add text for arraysize in sqlite3.Cursor (#947) (#986)
https://github.com/python/cpython/commit/0f9ceaf322cc9358373167115fd4c2
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
type: enhancement -> behavior
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Looking forward to this.
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issu
1101 - 1200 of 2044 matches
Mail list logo