[issue23183] timeit CLI best of 3: undocumented output format

Changes by Robert Collins : -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue23183> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23183] timeit CLI best of 3: undocumented output format

Robert Collins added the comment: Here is a patch with some prose - feedback appreciated! -- keywords: +patch Added file: http://bugs.python.org/file38531/issue-23183-1.patch ___ Python tracker <http://bugs.python.org/issue23

[issue23183] timeit CLI best of 3: undocumented output format

Changes by Robert Collins : -- stage: -> patch review ___ Python tracker <http://bugs.python.org/issue23183> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue23552] Have timeit warn about runs that are not independent of each other

Robert Collins added the comment: I think for PyPI its actually important here - the JIT'd state of the code is essentially global state being mutated - you can't assess how fast the code is without first warming up the JIT, and if it warms up half way through your fastest run, yo

[issue6422] timeit called from within Python should allow autoranging

Changes by Robert Collins : -- nosy: +rbcollins stage: needs patch -> patch review ___ Python tracker <http://bugs.python.org/issue6422> ___ ___ Python-bugs-lis

[issue23552] Have timeit warn about runs that are not independent of each other

Robert Collins added the comment: Reviewed on rietvald. -- stage: -> patch review ___ Python tracker <http://bugs.python.org/issue23552> ___ ___ Python-

[issue6422] timeit called from within Python should allow autoranging

Robert Collins added the comment: I'm confused by the feedback on the patch. It adds a single new function, doesn't alter the public interface for any existing functions, and seems fit for purpose. Could someone help me understand how its

[issue23693] timeit accuracy could be better

New submission from Robert Collins: In #6422 Haypo suggested making the timeit reports much better. This is a new ticket just for that. See https://bitbucket.org/haypo/misc/src/tip/python/benchmark.py and http://bugs.python.org/issue6422?@ok_message=issue%206422%20nosy%2C%20nosy_count%2C

[issue6422] timeit called from within Python should allow autoranging

Robert Collins added the comment: Filed #23693 for the accuracy thing. -- ___ Python tracker <http://bugs.python.org/issue6422> ___ ___ Python-bugs-list mailin

[issue19495] context manager for measuring duration of blocks of code

Changes by Robert Collins : -- nosy: +rbcollins title: Enhancement for timeit: measure time to run blocks of code using 'with' -> context manager for measuring duration of blocks of code ___ Python tracker <http://bugs.pytho

[issue23683] allow timeit to run expensive reset code per repeats

Robert Collins added the comment: bah, nevermind - I failed to get that setup is called once per loop regardless - I might consider this a doc issue, or perhaps I was just fuzzy brained. -- resolution: -> not a bug status: open -> closed ___

[issue22903] unittest creates non-picklable errors

Robert Collins added the comment: LGTM please commit. -- ___ Python tracker <http://bugs.python.org/issue22903> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23809] RFE: emit a warning when a module in a traceback shadows a stdlib module

Robert Collins added the comment: Why limit this to just stdlib shadowing? A local module can shadow a top level module-or-package across the board. If we don't limit it to stdlib names, it becomes a lot easier to implement. -- ___ Python tr

[issue23809] RFE: emit a warning when a module in a traceback shadows a stdlib module

Robert Collins added the comment: Implementation wise: this is not part of the generic rendering-of-tracebacks; I'd like to make the traceback new stuff be tastefully extensible - I'd be inclined to do this with a per-frame-callback on render (so we don't pay overhead on unren

[issue23839] Clear caches after every test

Robert Collins added the comment: I'd like to see a definite profile of a bloated stdlib test process before we assume we know the issue - the usual leak I see in test code is used test objects, and I'm not sure we've ported the usual fix for that into unittest yet (we shou

[issue23839] Clear caches after every test

Robert Collins added the comment: +1 on moving to the summary classes rather than actual tracebacks in unittest. (Or perhaps even just serialised tracebacks like we do in testtools). -- ___ Python tracker <http://bugs.python.org/issue23

[issue23882] unittest discovery and namespaced packages

Robert Collins added the comment: Hi. I'd be happy enough to use pkgutil helpers if they (like walkdirs) allowed trimming the output: part of the definition of discovery is that one can control it, to stop it importing or processing part of the tree that one doesn't want processed.

[issue23882] unittest discovery doesn't detect namespace packages when given no parameters

Robert Collins added the comment: Ok, so here's whats happening: the default behaviour is to do discovery of '.', which bypasses the namespace support code. Running with tests as the first parameter works because it doesn't require the directory being directly sca

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

Robert Collins added the comment: Thanks, I shall look at this Monday. -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue24054> ___ ___ Pytho

[issue22619] Possible implementation of negative limit for traceback functions

Robert Collins added the comment: Nice, looks pretty elegant to me. I have nothing to add to the prior reviewers comments. -- ___ Python tracker <http://bugs.python.org/issue22

[issue17908] Unittest runner needs an option to call gc.collect() after each test

Robert Collins added the comment: I'm going to disagree with michael and antoine here. The *internals* should be clean and pluggable for sure, but this is actually a pretty common thing to try, so there's no reason to force it to only be done by external plugins. Right now the w

[issue23882] unittest discovery doesn't detect namespace packages when given no parameters

Robert Collins added the comment: Ah the user model? I think the following: If I run 'python -m unittest' in a directory, then I expect to run all of the tests contained within that directory tree, and no others. Does that defin

[issue9858] Python and C implementations of io are out of sync

Robert Collins added the comment: I think ignoring weakref is wrong: it means the two implementations are different. -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue9

[issue28086] test.test_getargs2.TupleSubclass test failure

New submission from Robert Collins: The test.test_getargs2.TupleSubclass test is failing in master. I suspect its a fastcall fallout. -- messages: 275879 nosy: rbcollins, serhiy.storchaka priority: normal severity: normal stage: needs patch status: open title: test.test_getargs2

[issue27213] Rework CALL_FUNCTION* opcodes

Robert Collins added the comment: See http://bugs.python.org/issue28086 - this introduced a regression in the test suite. -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue27

[issue24412] setUpClass equivalent for addCleanup

Robert Collins added the comment: So, thank you for the patch. However - there's no need for a metaclass here, and its actively harmful to comprehending the code. As I suggested earlier, please decouple the cleanups implementation and then consume it from the two places that it will be n

[issue24412] setUpClass equivalent for addCleanup

Robert Collins added the comment: Btw some things to be aware of in addressing this: - we will need tests that catchable exceptions raised from a setUpModule or setUpClass cause cleanups already registered to run - if (and I'd need to check this) setUpModule or setUpClass can nest - I

[issue25573] FrameSummary repr() does not support previously working uses of repr in traceback module

Robert Collins added the comment: So I think its fine to have a __len__ reporting 4. tuple(..) works via the iter() call, but thats really just a thunk to keep existing code working, and so __len__ for the same reason makes sense. On the documentation issue, yes, updating the docs is

[issue28087] macOS 12 poll syscall returns prematurely

Changes by Robert Collins : -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue28087> ___ ___ Python-bugs-list mai

[issue28087] macOS 12 poll syscall returns prematurely

Robert Collins added the comment: @Ned - any objection to my committing this at this point? -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue28

[issue21254] PropertyMock refuses to raise AttributeErrror as a side effect

Robert Collins added the comment: We're poking at this at the kiwipycon sprints -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue21254> ___ ___

[issue21254] PropertyMock refuses to raise AttributeErrror as a side effect

Robert Collins added the comment: I could imagine doing some complex things to let you get at the AttributeError in this case but *not* when a different descriptor was added to type(a_mock), but I think it would confusing overall. This might be worth a doc tweak to cover it? -- stage

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Robert Collins added the comment: It is a bugfix, but we should document when it started working using the version added segment IMO. I think addding this to 3.6 now would be ok. -- nosy: +rbcollins ___ Python tracker <http://bugs.python.

[issue26240] Docstring of the subprocess module should be cleaned up

Changes by Robert Collins : -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue26240> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20140] UnicodeDecodeError in ntpath.py when home dir contains non-ascii signs

Robert Collins added the comment: Given two (or more) parameters where one is unicode and one is not, upcasting will occur multiples times in path.join on windows: - '\\' is str and will cast up safely in all codecs - the other str (or bytes) parameter will be up

[issue27946] issues in elementtree and elsewhere due to PyDict_GetItem

Robert Collins added the comment: Please add the reproducer as a test case (in test_dict.py I think) - even though it needs elementree to trigger it is a dict bug :). I also wonder if there are similar cases lying under other C collections like list, tuple and set. E.g. list.find() calls obj

[issue16288] TextTestResult uses TestCase.__str__() which isn't customisable (vs id() or shortDescription())

Robert Collins added the comment: @Chris - I don't like the idea of making new classes on the fly like that, it seems more likely to provoke bugs (as type(case) != SomeSpecificClass) anymore after that, vs just not relying on __str__ directly. Going back to Michael's proposa

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

Robert Collins added the comment: I find details like this extremely useful in the main docs, so please do add there. -- ___ Python tracker <http://bugs.python.org/issue25

[issue15393] JSONDecoder.raw_decode breaks on leading whitespace

Robert Collins added the comment: I think the patch should either be rejected, or also handle trailing spaces: if we're taking the RFC definition of whitespace not being structural then we should also eat trailing space, which will change the check for extra data in decode to just che

[issue6087] distutils.sysconfig.get_python_lib gives surprising result when used with a Python build

Robert Collins added the comment: Ok, so we need to figure out whether the tests are wrong, or the 'fix' is wrong. -- ___ Python tracker <http://bugs.python.

[issue22431] Change format of test runner output

Robert Collins added the comment: +1 to changing the UI for 3.7 - just noting that if you're machine processing the output, the TUI isn't an appropriate channel. -- ___ Python tracker <http://bugs.python.o

[issue17188] Document 'from None' in raise statement doc.

Changes by Robert Collins : -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue17188> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    1   2   3   4   5   6